Bug 2327 fix to verify ipaddress in sol003_02 testsuite

[osm/tests.git] / robot-systest / resources / basic_01-crud_operations_on_vim_targets_data.py

diff --git a/robot-systest/resources/basic_01-crud_operations_on_vim_targets_data.py b/robot-systest/resources/basic_01-crud_operations_on_vim_targets_data.py
index 1e35e78..2e3f95b 100644 (file)
--- a/robot-systest/resources/basic_01-crud_operations_on_vim_targets_data.py
+++ b/robot-systest/resources/basic_01-crud_operations_on_vim_targets_data.py
@@ -11,60 +11,36 @@
 #   limitations under the License.
 
 import os
-from pathlib import Path
 import yaml
+from get_clouds_yaml_info import get_values_from_cloud, get_vim_values
 
 
+# Variables to be used by the testsuite
+VIM_ACCOUNT_TYPE = ""
+VIM_NAME_PREFIX = ""
+VIM_USER = ""
+VIM_PASSWORD = ""
+VIM_AUTH_URL = ""
+VIM_TENANT = ""
+VIM_CONFIG = ""
+
 # VIM configuration
 cloud_type = os.environ.get("CLOUD_TYPE", "openstack")
 if cloud_type == "openstack":
     # Openstack VIM
-    vim_account_type = "openstack"
-    vim_name_prefix = "basic01"
+    VIM_ACCOUNT_TYPE = "openstack"
+    VIM_NAME_PREFIX = "basic01"
     # Get credentias from Openstack Clouds file
-    os_cloud = os.environ.get("OS_CLOUD")
-    clouds_file_paths = [
-        "./clouds.yaml",
-        str(Path.home()) + "/.config/openstack/clouds.yaml",
-        "/etc/openstack/clouds.yaml",
-    ]
-    for path in clouds_file_paths:
-        clouds_file_path = Path(path)
-        if clouds_file_path.exists():
-            break
-    if not clouds_file_path.exists():
-        raise Exception("Openstack clouds file not found")
-    with clouds_file_path.open() as clouds_file:
-        clouds = yaml.safe_load(clouds_file)
-        if os_cloud not in clouds["clouds"]:
-            raise Exception("Openstack cloud '" + os_cloud + "' not found")
-        cloud = clouds["clouds"][os_cloud]
-        if "username" not in cloud["auth"]:
-            raise Exception("Username not found in Openstack cloud '" + os_cloud + "'")
-        vim_user = cloud["auth"]["username"]
-        if "password" not in cloud["auth"]:
-            raise Exception("Password not found in Openstack cloud '" + os_cloud + "'")
-        vim_password = cloud["auth"]["password"]
-        if "auth_url" not in cloud["auth"]:
-            raise Exception("Auth url not found in Openstack cloud '" + os_cloud + "'")
-        vim_auth_url = cloud["auth"]["auth_url"]
-        if "project_name" not in cloud["auth"]:
-            raise Exception(
-                "Project name not found in Openstack cloud '" + os_cloud + "'"
-            )
-        vim_tenant = cloud["auth"]["project_name"]
-        vim_user_domain_name = (
-            cloud["auth"]["user_domain_name"]
-            if "user_domain_name" in cloud["auth"]
-            else None
-        )
-        vim_project_domain_name = (
-            cloud["auth"]["project_domain_name"]
-            if "project_domain_name" in cloud["auth"]
-            else None
-        )
-        vim_insecure = True if "verify" in cloud and not cloud["verify"] else None
-
+    cloud, os_cloud = get_values_from_cloud()
+    (
+        VIM_USER,
+        VIM_PASSWORD,
+        VIM_AUTH_URL,
+        VIM_TENANT,
+        vim_user_domain_name,
+        vim_project_domain_name,
+        vim_insecure,
+    ) = get_vim_values(cloud, os_cloud)
     # Extra config
     vim_config_dict = {}
     vim_config_dict["vim_network_name"] = os.environ.get("VIM_MGMT_NET")
@@ -74,7 +50,7 @@ if cloud_type == "openstack":
         vim_config_dict["user_domain_name"] = vim_user_domain_name
     if vim_insecure:
         vim_config_dict["insecure"] = True
-    vim_config = "'{}'".format(
+    VIM_CONFIG = "'{}'".format(
         yaml.safe_dump(vim_config_dict, default_flow_style=True, width=10000).rstrip(
             "\r\n"
         )
@@ -82,12 +58,12 @@ if cloud_type == "openstack":
 
 elif cloud_type == "azure":
     # Azure VIM
-    vim_account_type = "azure"
-    vim_name_prefix = "basic01"
-    vim_auth_url = "http://www.azure.com"
-    vim_user = os.environ.get("AZURE_CLIENT_ID")
-    vim_password = os.environ.get("AZURE_SECRET")
-    vim_tenant = os.environ.get("AZURE_TENANT")
+    VIM_ACCOUNT_TYPE = "azure"
+    VIM_NAME_PREFIX = "basic01"
+    VIM_AUTH_URL = "http://www.azure.com"
+    VIM_USER = os.environ.get("AZURE_CLIENT_ID")
+    VIM_PASSWORD = os.environ.get("AZURE_SECRET")
+    VIM_TENANT = os.environ.get("AZURE_TENANT")
 
     # Extra config
     vim_config_dict = {}
@@ -101,7 +77,7 @@ elif cloud_type == "azure":
         vim_config_dict["vnet_name"] = os.environ.get("VNET_NAME")
     if "AZURE_FLAVORS_PATTERN" in os.environ:
         vim_config_dict["flavors_pattern"] = os.environ.get("AZURE_FLAVORS_PATTERN")
-    vim_config = "'{}'".format(
+    VIM_CONFIG = "'{}'".format(
         yaml.safe_dump(vim_config_dict, default_flow_style=True, width=10000).rstrip(
             "\r\n"
         )