Bug 2327 fix to verify ipaddress in sol003_02 testsuite

[osm/tests.git] / devops-stages / stage-test.sh

diff --git a/devops-stages/stage-test.sh b/devops-stages/stage-test.sh
index 00c8981..4be5aaa 100755 (executable)
--- a/devops-stages/stage-test.sh
+++ b/devops-stages/stage-test.sh
@@ -12,8 +12,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-# python3 -m rflint testsuites
-
 check_tabs () {
     folder="$1"
     tabs="y"
@@ -57,6 +55,19 @@ check_crlf_terminators () {
     exit 1
 }
 
+check_spaces_eol () {
+    folder="$1"
+    spaces_eol="y"
+    ! grep -ri " $" ${folder} && spaces_eol=""
+    [ -n "${spaces_eol}" ] && \
+    echo "Some files in ${folder} have spaces at the end of some lines" && \
+    echo "Use this command to change it:" && \
+    echo "   sed -i 's/ *$//g' <FILENAME>" && \
+    exit 1
+}
+
+echo "Checking syntax of Robot tests"
+
 echo "Checking tabs in robot files. No tabs should be present"
 check_tabs robot-systest/testsuite
 check_tabs robot-systest/lib
@@ -77,6 +88,18 @@ check_crlf_terminators robot-systest/testsuite
 check_crlf_terminators robot-systest/lib
 echo "No presence of CRLF terminators in robot files. Correct!"
 
-echo "SUCCESS"
-exit 0
+echo "Checking spaces at the end of lines in robot files. No spaces at EOL should be found"
+check_spaces_eol robot-systest/testsuite
+check_spaces_eol robot-systest/lib
+echo "No presence of spaces at EOL in robot files. Correct!"
+
+# Other policies to be added here:
+# - Blank lines used to separate main sections (Settings, Variables, Test Cases, Keywords)
+# - Blank lines used to separate parts of eah section:
+#   - Variables: max 1 blank line to separate each one
+#   - Settings: 1 blank line to separate each kind of setting (all LIbrary together, all Resource together, etc.)
+#   - Test cases: 2 blank lines between test cases, max 1 blank line inside Test case, no blank line after Test Case Keyword
+
+echo "Launching tox"
+TOX_PARALLEL_NO_SPINNER=1 tox --parallel=auto