projects
/
osm
/
NG-UI.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Coverity-CWE 330: Use of Insufficiently Random Values
[osm/NG-UI.git]
/
src
/
services
/
SharedService.ts
diff --git
a/src/services/SharedService.ts
b/src/services/SharedService.ts
index
2a5f50f
..
8fb51bf
100644
(file)
--- a/
src/services/SharedService.ts
+++ b/
src/services/SharedService.ts
@@
-128,9
+128,13
@@
export class SharedService {
// eslint-disable-next-line @typescript-eslint/no-magic-numbers
private randomStringLength: number = 4;
// eslint-disable-next-line @typescript-eslint/no-magic-numbers
private randomStringLength: number = 4;
- /**
Max length of Uint8Array
*/
+ /**
express number for rgb manipulation
*/
// eslint-disable-next-line @typescript-eslint/no-magic-numbers
// eslint-disable-next-line @typescript-eslint/no-magic-numbers
- private unit8Array: number = 255;
+ private colourHour: number = 10;
+
+ /** express number for rgb manipulation*/
+ // eslint-disable-next-line @typescript-eslint/no-magic-numbers
+ private colourMin: number = 5;
/** Instance of the rest service @private */
private restService: RestService;
/** Instance of the rest service @private */
private restService: RestService;
@@
-138,10
+142,6
@@
export class SharedService {
/** Service holds the router information @private */
private router: Router;
/** Service holds the router information @private */
private router: Router;
- /** Random color string generator length @private */
- // eslint-disable-next-line @typescript-eslint/no-magic-numbers
- private colorStringLength: number = 256;
-
/** Check for the root directory @private */
// eslint-disable-next-line @typescript-eslint/no-magic-numbers
private directoryCount: number = 2;
/** Check for the root directory @private */
// eslint-disable-next-line @typescript-eslint/no-magic-numbers
private directoryCount: number = 2;
@@
-260,10
+260,9
@@
export class SharedService {
/** Generate random string @public */
public randomString(): string {
/** Generate random string @public */
public randomString(): string {
- const chars: string = '0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ';
let result: string = '';
for (let randomStringRef: number = this.randomStringLength; randomStringRef > 0; --randomStringRef) {
let result: string = '';
for (let randomStringRef: number = this.randomStringLength; randomStringRef > 0; --randomStringRef) {
- result +=
chars[Math.floor(Math.random() * chars.length)]
;
+ result +=
new Date().getSeconds()
;
}
return result;
}
}
return result;
}
@@
-426,9
+425,9
@@
export class SharedService {
/** Random RGB color code generator @public */
public generateColor(): string {
/** Random RGB color code generator @public */
public generateColor(): string {
- const x: number = Math.floor(
Math.random() * this.colorStringLength
);
- const y: number = Math.floor(
Math.random() * this.colorStringLength
);
- const z: number = Math.floor(
Math.random() * this.colorStringLength
);
+ const x: number = Math.floor(
(new Date().getHours()) * this.colourHour
);
+ const y: number = Math.floor(
(new Date().getMinutes()) * this.colourMin
);
+ const z: number = Math.floor(
(new Date().getSeconds()) * this.colourMin
);
return 'rgb(' + x + ',' + y + ',' + z + ')';
}
return 'rgb(' + x + ',' + y + ',' + z + ')';
}