Revert "Feature 11001: Robot framework linting for E2E tests"

[osm/tests.git] / robot-systest / testsuite / k8s_03-simple_k8s.robot

diff --git a/robot-systest/testsuite/k8s_03-simple_k8s.robot b/robot-systest/testsuite/k8s_03-simple_k8s.robot
index a6838ea..99991f9 100644 (file)
--- a/robot-systest/testsuite/k8s_03-simple_k8s.robot
+++ b/robot-systest/testsuite/k8s_03-simple_k8s.robot
@@ -1,4 +1,3 @@
-*** Comments ***
 #   Copyright 2020 Canonical Ltd.
 #
 #   Licensed under the Apache License, Version 2.0 (the "License");
@@ -13,7 +12,6 @@
 #   See the License for the specific language governing permissions and
 #   limitations under the License.
 
-
 *** Settings ***
 Documentation   [K8s-03] Simple K8s.
 
@@ -22,85 +20,76 @@ Library   String
 Library   Collections
 Library   Process
 
-Resource   ../lib/vnfd_lib.resource
-Resource   ../lib/nsd_lib.resource
-Resource   ../lib/ns_lib.resource
-Resource   ../lib/ns_operation_lib.resource
-Resource   ../lib/package_lib.resource
-Resource   ../lib/connectivity_lib.resource
-Resource   ../lib/ssh_lib.resource
-Resource   ../lib/k8scluster_lib.resource
+Resource   %{ROBOT_DEVOPS_FOLDER}/lib/vnfd_lib.robot
+Resource   %{ROBOT_DEVOPS_FOLDER}/lib/nsd_lib.robot
+Resource   %{ROBOT_DEVOPS_FOLDER}/lib/ns_lib.robot
+Resource   %{ROBOT_DEVOPS_FOLDER}/lib/package_lib.robot
+Resource   %{ROBOT_DEVOPS_FOLDER}/lib/connectivity_lib.robot
+Resource   %{ROBOT_DEVOPS_FOLDER}/lib/ssh_lib.robot
+Resource   %{ROBOT_DEVOPS_FOLDER}/lib/k8scluster_lib.robot
 
-Test Tags   k8s_03   cluster_k8s   regression   azure
+Force Tags   k8s_03   cluster_k8s   regression   azure
 
 Suite Teardown   Run Keyword And Ignore Error   Suite Cleanup
 
 
 *** Variables ***
 # NS and VNF descriptor package folder and ids
-${VNFD_PKG}   charm-packages/native_k8s_charm_vnf
-${VNFD_NAME}   native_k8s_charm-vnf
-${NSD_PKG}   charm-packages/native_k8s_charm_ns
-${NSD_NAME}   native_k8s_charm-ns
+${vnfd_pkg}   charm-packages/native_k8s_charm_vnf
+${vnfd_name}   native_k8s_charm-vnf
+${nsd_pkg}   charm-packages/native_k8s_charm_ns
+${nsd_name}   native_k8s_charm-ns
 
 # NS instance name and configuration
-${NS_NAME}   native-k8s
-${NS_CONFIG}   {vld: [ {name: mgmtnet, vim-network-name: %{VIM_MGMT_NET}} ] }
-
-${NS_ID}   ${EMPTY}
-${PUBLICKEY}   ${EMPTY}
-${VNF_MEMBER_INDEX}   native_k8s_charm-vnf
-${ACTION_NAME}   changecontent
-${KDU_NAME}   native-kdu
-${APPLICATION_NAME}   nginx
-${CUSTOMTITLE}   Day 2 Action
+${ns_name}   native-k8s
+${ns_config}   {vld: [ {name: mgmtnet, vim-network-name: %{VIM_MGMT_NET}} ] }
 
+${ns_id}   ${EMPTY}
+${publickey}   ${EMPTY}
+${vnf_member_index}   native_k8s_charm-vnf
+${action_name}   changecontent
+${kdu_name}   native-kdu
+${application_name}   nginx
+${customtitle}   Day 2 Action
 
 *** Test Cases ***
 Create Simple K8s VNF Descriptor
-    [Documentation]   Upload NF package for the testsuite.
-    Create VNFD   '%{PACKAGES_FOLDER}/${VNFD_PKG}'
+    Create VNFD   '%{PACKAGES_FOLDER}/${vnfd_pkg}'
 
 Create Simple K8s Descriptor
-    [Documentation]   Upload NS package for the testsuite.
-    Create NSD   '%{PACKAGES_FOLDER}/${NSD_PKG}'
+    Create NSD   '%{PACKAGES_FOLDER}/${nsd_pkg}'
 
 Network Service K8s Instance Test
-    [Documentation]   Instantiate NS for the testsuite.
-    ${id}=   Create Network Service   ${NSD_NAME}   %{VIM_TARGET}   ${NS_NAME}   ${NS_CONFIG}   ${PUBLICKEY}
-    Set Suite Variable   ${NS_ID}   ${id}
+    ${id}=   Create Network Service   ${nsd_name}   %{VIM_TARGET}   ${ns_name}   ${ns_config}   ${publickey}
+    Set Suite Variable   ${ns_id}   ${id}
 
 Execute Day 2 Operations
     [Documentation]   Performs one Day 2 operation per VNF that creates a new file.
-    Variable Should Exist   ${NS_ID}   msg=Network service instance is not available
-    ${ns_op_id}=   Execute NS K8s Action   ${NS_NAME}   ${ACTION_NAME}   ${VNF_MEMBER_INDEX}   ${KDU_NAME}   application-name=${APPLICATION_NAME}   customtitle=${CUSTOMTITLE}
-    Log   ${ns_op_id}
+
+    Variable Should Exist   ${ns_id}   msg=Network service instance is not available
+    ${ns_op_id}=   Execute NS K8s Action   ${ns_name}   ${action_name}   ${vnf_member_index}   ${kdu_name}   application-name=${application_name}   customtitle=${customtitle}
 
 Delete NS K8s Instance Test
-    [Documentation]   Delete NS instance.
     [Tags]   cleanup
-    Delete NS   ${NS_NAME}
+    Delete NS   ${ns_name}
 
 Delete NS Descriptor Test
-    [Documentation]   Delete NS package from OSM.
     [Tags]   cleanup
-    Delete NSD   ${NSD_NAME}
+    Delete NSD   ${nsd_name}
 
 Delete VNF Descriptor Test
-    [Documentation]   Delete NF package from OSM.
     [Tags]   cleanup
-    Delete VNFD   ${VNFD_NAME}
+    Delete VNFD   ${vnfd_name}
 
 Delete VNF NS Packages
-    [Documentation]   Delete tar.gz NF and NS package files.
     [Tags]   cleanup
-    Delete Package   '%{PACKAGES_FOLDER}/${VNFD_PKG}'
-    Delete Package   '%{PACKAGES_FOLDER}/${NSD_PKG}'
+    Delete Package   '%{PACKAGES_FOLDER}/${vnfd_pkg}'
+    Delete Package   '%{PACKAGES_FOLDER}/${nsd_pkg}'
 
 
 *** Keywords ***
 Suite Cleanup
     [Documentation]   Test Suit Cleanup: Deleting Descriptor, instance and vim
-    Run Keyword If Any Tests Failed   Delete NS   ${NS_NAME}
-    Run Keyword If Any Tests Failed   Delete NSD   ${NSD_NAME}
-    Run Keyword If Any Tests Failed   Delete VNFD   ${VNFD_NAME}
+    Run Keyword If Any Tests Failed   Delete NS   ${ns_name}
+    Run Keyword If Any Tests Failed   Delete NSD   ${nsd_name}
+    Run Keyword If Any Tests Failed   Delete VNFD   ${vnfd_name}