Feature 11001: Robot framework linting for E2E tests

[osm/tests.git] / robot-systest / testsuite / epa_03-crud_operations_on_sdnc.robot

diff --git a/robot-systest/testsuite/epa_03-crud_operations_on_sdnc.robot b/robot-systest/testsuite/epa_03-crud_operations_on_sdnc.robot
index 48c9e90..1312328 100644 (file)
--- a/robot-systest/testsuite/epa_03-crud_operations_on_sdnc.robot
+++ b/robot-systest/testsuite/epa_03-crud_operations_on_sdnc.robot
@@ -1,3 +1,4 @@
+*** Comments ***
 #   Licensed under the Apache License, Version 2.0 (the "License");
 #   you may not use this file except in compliance with the License.
 #   You may obtain a copy of the License at
@@ -10,45 +11,44 @@
 #   See the License for the specific language governing permissions and
 #   limitations under the License.
 
+
 *** Settings ***
 Documentation   [EPA-03] CRUD operations on SDNC accounts.
 
-Resource   %{ROBOT_DEVOPS_FOLDER}/lib/sdnc_lib.robot
+Resource   ../lib/prometheus_lib.resource
+Resource   ../lib/sdnc_lib.resource
 
-Variables   %{ROBOT_DEVOPS_FOLDER}/resources/epa_03-crud_operations_on_sdnc_data.py
+Variables   ../resources/epa_03-crud_operations_on_sdnc_data.py
 
-Force Tags   epa_03   cluster_epa   daily   regression
+Test Tags   epa_03   cluster_epa   daily   regression
 
 Suite Setup   Run Keyword And Ignore Error   Suite Preparation
 Suite Teardown   Run Keyword And Ignore Error   Delete Basic SDNC
 
 
 *** Variables ***
-${sdnc_enabled_max_wait_time}   1min
-${sdnc_enabled_pol_time}   10
+${SDNC_ENABLED_MAX_WAIT_TIME}   1min
+${SDNC_ENABLED_POL_TIME}   10
 
 
 *** Test Cases ***
 Create Basic SDNC
-
+    [Documentation]   Register SDN controller in OSM.
     ${created_sdnc_id}=   Create SDNC   ${sdnc_name}   ${sdnc_user}   ${sdnc_password}   ${sdnc_url}   ${sdnc_type}
-    Set Suite Variable   ${sdnc_id}   ${created_sdnc_id}
-    Wait Until Keyword Succeeds   ${sdnc_enabled_max_wait_time}   ${sdnc_enabled_pol_time}   Check for SDNC   ${sdnc_id}
-
+    Set Suite Variable   ${SDNC_ID}   ${created_sdnc_id}
+    Wait Until Keyword Succeeds   ${SDNC_ENABLED_MAX_WAIT_TIME}   ${SDNC_ENABLED_POL_TIME}   Check For SDNC   ${SDNC_ID}
 
 Check SDNC Status Is Healthy
-
-    Check for SDNC Status   ${sdnc_id}   ${prometheus_host}   ${prometheus_port}   ${prometheus_user}   ${prometheus_password}
-
+    [Documentation]   Check in Prometheus that the SDN controller is in healthy state.
+    Check For SDNC Status   ${SDNC_ID}   ${PROMETHEUS_HOST}   ${PROMETHEUS_PORT}   ${PROMETHEUS_USER}   ${PROMETHEUS_PASSWORD}
 
 Delete Basic SDNC
+    [Documentation]   Delete SDN controller from OSM.
     [Tags]   cleanup
-
     Delete SDNC   ${sdnc_name}
 
 
 *** Keywords ***
 Suite Preparation
-    [Documentation]   Test Suite Preparation: Setting Prometheus Testsuite Variables
-
+    [Documentation]   Test Suite Preparation: Setting Prometheus Testsuite Variables.
     Set Testsuite Prometheus Variables