Code Cleanup and adding unit tests

[osm/common.git] / osm_common / tests / test_fsmongo.py

diff --git a/osm_common/tests/test_fsmongo.py b/osm_common/tests/test_fsmongo.py
index 01a8ef2..7e1e47c 100644 (file)
--- a/osm_common/tests/test_fsmongo.py
+++ b/osm_common/tests/test_fsmongo.py
@@ -44,7 +44,7 @@ def invalid_path():
 
 @pytest.fixture(scope="function", params=[True, False])
 def fs_mongo(request, monkeypatch):
 
 @pytest.fixture(scope="function", params=[True, False])
 def fs_mongo(request, monkeypatch):

-    def mock_mongoclient_constructor(a, b, c):
+    def mock_mongoclient_constructor(a, b):

         pass
 
     def mock_mongoclient_getitem(a, b):
         pass
 
     def mock_mongoclient_getitem(a, b):


@@ -57,9 +57,7 @@ def fs_mongo(request, monkeypatch):
     monkeypatch.setattr(MongoClient, "__getitem__", mock_mongoclient_getitem)
     monkeypatch.setattr(GridFSBucket, "__init__", mock_gridfs_constructor)
     fs = FsMongo(lock=request.param)
     monkeypatch.setattr(MongoClient, "__getitem__", mock_mongoclient_getitem)
     monkeypatch.setattr(GridFSBucket, "__init__", mock_gridfs_constructor)
     fs = FsMongo(lock=request.param)

-    fs.fs_connect(
-        {"path": valid_path(), "host": "mongo", "port": 27017, "collection": "files"}
-    )
+    fs.fs_connect({"path": valid_path(), "uri": "mongo:27017", "collection": "files"})

     return fs
 
 
     return fs
 
 


@@ -140,17 +138,6 @@ def test_get_params(fs_mongo, monkeypatch):
             "fs_mongo",
             valid_path(),
         ),
             "fs_mongo",
             valid_path(),
         ),

-        (
-            {
-                "logger_name": "fs_mongo",
-                "path": valid_path(),
-                "host": "mongo",
-                "port": 27017,
-                "collection": "files",
-            },
-            "fs_mongo",
-            valid_path(),
-        ),

         (
             {
                 "logger_name": "fs_mongo",
         (
             {
                 "logger_name": "fs_mongo",


@@ -161,47 +148,16 @@ def test_get_params(fs_mongo, monkeypatch):
             "fs_mongo",
             valid_path(),
         ),
             "fs_mongo",
             valid_path(),
         ),

-        (
-            {
-                "logger_name": "fs_mongo",
-                "path": valid_path()[:-1],
-                "host": "mongo",
-                "port": 27017,
-                "collection": "files",
-            },
-            "fs_mongo",
-            valid_path(),
-        ),

         (
             {"path": valid_path(), "uri": "mongo:27017", "collection": "files"},
             "fs",
             valid_path(),
         ),
         (
             {"path": valid_path(), "uri": "mongo:27017", "collection": "files"},
             "fs",
             valid_path(),
         ),

-        (
-            {
-                "path": valid_path(),
-                "host": "mongo",
-                "port": 27017,
-                "collection": "files",
-            },
-            "fs",
-            valid_path(),
-        ),

         (
             {"path": valid_path()[:-1], "uri": "mongo:27017", "collection": "files"},
             "fs",
             valid_path(),
         ),
         (
             {"path": valid_path()[:-1], "uri": "mongo:27017", "collection": "files"},
             "fs",
             valid_path(),
         ),

-        (
-            {
-                "path": valid_path()[:-1],
-                "host": "mongo",
-                "port": 27017,
-                "collection": "files",
-            },
-            "fs",
-            valid_path(),
-        ),

     ],
 )
 def test_fs_connect_with_valid_config(config, exp_logger, exp_path):
     ],
 )
 def test_fs_connect_with_valid_config(config, exp_logger, exp_path):


@@ -225,16 +181,6 @@ def test_fs_connect_with_valid_config(config, exp_logger, exp_path):
             },
             fs_connect_exception_message(invalid_path()),
         ),
             },
             fs_connect_exception_message(invalid_path()),
         ),

-        (
-            {
-                "logger_name": "fs_mongo",
-                "path": invalid_path(),
-                "host": "mongo",
-                "port": 27017,
-                "collection": "files",
-            },
-            fs_connect_exception_message(invalid_path()),
-        ),

         (
             {
                 "logger_name": "fs_mongo",
         (
             {
                 "logger_name": "fs_mongo",


@@ -244,44 +190,16 @@ def test_fs_connect_with_valid_config(config, exp_logger, exp_path):
             },
             fs_connect_exception_message(invalid_path()[:-1]),
         ),
             },
             fs_connect_exception_message(invalid_path()[:-1]),
         ),

-        (
-            {
-                "logger_name": "fs_mongo",
-                "path": invalid_path()[:-1],
-                "host": "mongo",
-                "port": 27017,
-                "collection": "files",
-            },
-            fs_connect_exception_message(invalid_path()[:-1]),
-        ),

         (
             {"path": invalid_path(), "uri": "mongo:27017", "collection": "files"},
             fs_connect_exception_message(invalid_path()),
         ),
         (
             {"path": invalid_path(), "uri": "mongo:27017", "collection": "files"},
             fs_connect_exception_message(invalid_path()),
         ),

-        (
-            {
-                "path": invalid_path(),
-                "host": "mongo",
-                "port": 27017,
-                "collection": "files",
-            },
-            fs_connect_exception_message(invalid_path()),
-        ),

         (
             {"path": invalid_path()[:-1], "uri": "mongo:27017", "collection": "files"},
             fs_connect_exception_message(invalid_path()[:-1]),
         ),
         (
         (
             {"path": invalid_path()[:-1], "uri": "mongo:27017", "collection": "files"},
             fs_connect_exception_message(invalid_path()[:-1]),
         ),
         (

-            {
-                "path": invalid_path()[:-1],
-                "host": "mongo",
-                "port": 27017,
-                "collection": "files",
-            },
-            fs_connect_exception_message(invalid_path()[:-1]),
-        ),
-        (
-            {"path": "/", "host": "mongo", "port": 27017, "collection": "files"},
+            {"path": "/", "uri": "mongo:27017", "collection": "files"},

             generic_fs_exception_message(
                 "Invalid configuration param at '[storage]': path '/' is not writable"
             ),
             generic_fs_exception_message(
                 "Invalid configuration param at '[storage]': path '/' is not writable"
             ),


@@ -302,50 +220,14 @@ def test_fs_connect_with_invalid_path(config, exp_exception_message):
             {"logger_name": "fs_mongo", "uri": "mongo:27017", "collection": "files"},
             'Missing parameter "path"',
         ),
             {"logger_name": "fs_mongo", "uri": "mongo:27017", "collection": "files"},
             'Missing parameter "path"',
         ),

-        (
-            {
-                "logger_name": "fs_mongo",
-                "host": "mongo",
-                "port": 27017,
-                "collection": "files",
-            },
-            'Missing parameter "path"',
-        ),

         (
             {"logger_name": "fs_mongo", "path": valid_path(), "collection": "files"},
         (
             {"logger_name": "fs_mongo", "path": valid_path(), "collection": "files"},

-            'Missing parameters: "uri" or "host" + "port"',
-        ),
-        (
-            {
-                "logger_name": "fs_mongo",
-                "path": valid_path(),
-                "port": 27017,
-                "collection": "files",
-            },
-            'Missing parameters: "uri" or "host" + "port"',
-        ),
-        (
-            {
-                "logger_name": "fs_mongo",
-                "path": valid_path(),
-                "host": "mongo",
-                "collection": "files",
-            },
-            'Missing parameters: "uri" or "host" + "port"',
+            'Missing parameters: "uri"',

         ),
         (
             {"logger_name": "fs_mongo", "path": valid_path(), "uri": "mongo:27017"},
             'Missing parameter "collection"',
         ),
         ),
         (
             {"logger_name": "fs_mongo", "path": valid_path(), "uri": "mongo:27017"},
             'Missing parameter "collection"',
         ),

-        (
-            {
-                "logger_name": "fs_mongo",
-                "path": valid_path(),
-                "host": "mongo",
-                "port": 27017,
-            },
-            'Missing parameter "collection"',
-        ),

     ],
 )
 def test_fs_connect_with_missing_parameters(config, exp_exception_message):
     ],
 )
 def test_fs_connect_with_missing_parameters(config, exp_exception_message):


@@ -367,22 +249,12 @@ def test_fs_connect_with_missing_parameters(config, exp_exception_message):
             },
             "MongoClient crashed",
         ),
             },
             "MongoClient crashed",
         ),

-        (
-            {
-                "logger_name": "fs_mongo",
-                "path": valid_path(),
-                "host": "mongo",
-                "port": 27017,
-                "collection": "files",
-            },
-            "MongoClient crashed",
-        ),

     ],
 )
 def test_fs_connect_with_invalid_mongoclient(
     config, exp_exception_message, monkeypatch
 ):
     ],
 )
 def test_fs_connect_with_invalid_mongoclient(
     config, exp_exception_message, monkeypatch
 ):

-    def generate_exception(a, b, c=None):
+    def generate_exception(a, b=None):

         raise Exception(exp_exception_message)
 
     monkeypatch.setattr(MongoClient, "__init__", generate_exception)
         raise Exception(exp_exception_message)
 
     monkeypatch.setattr(MongoClient, "__init__", generate_exception)


@@ -405,22 +277,12 @@ def test_fs_connect_with_invalid_mongoclient(
             },
             "Collection unavailable",
         ),
             },
             "Collection unavailable",
         ),

-        (
-            {
-                "logger_name": "fs_mongo",
-                "path": valid_path(),
-                "host": "mongo",
-                "port": 27017,
-                "collection": "files",
-            },
-            "Collection unavailable",
-        ),

     ],
 )
 def test_fs_connect_with_invalid_mongo_collection(
     config, exp_exception_message, monkeypatch
 ):
     ],
 )
 def test_fs_connect_with_invalid_mongo_collection(
     config, exp_exception_message, monkeypatch
 ):

-    def mock_mongoclient_constructor(a, b, c=None):
+    def mock_mongoclient_constructor(a, b=None):

         pass
 
     def generate_exception(a, b):
         pass
 
     def generate_exception(a, b):


@@ -447,22 +309,12 @@ def test_fs_connect_with_invalid_mongo_collection(
             },
             "GridFsBucket crashed",
         ),
             },
             "GridFsBucket crashed",
         ),

-        (
-            {
-                "logger_name": "fs_mongo",
-                "path": valid_path(),
-                "host": "mongo",
-                "port": 27017,
-                "collection": "files",
-            },
-            "GridFsBucket crashed",
-        ),

     ],
 )
 def test_fs_connect_with_invalid_gridfsbucket(
     config, exp_exception_message, monkeypatch
 ):
     ],
 )
 def test_fs_connect_with_invalid_gridfsbucket(
     config, exp_exception_message, monkeypatch
 ):

-    def mock_mongoclient_constructor(a, b, c=None):
+    def mock_mongoclient_constructor(a, b=None):

         pass
 
     def mock_mongoclient_getitem(a, b):
         pass
 
     def mock_mongoclient_getitem(a, b):