From e17cd946aed699b5feca83d37591d04f129a8f52 Mon Sep 17 00:00:00 2001 From: elumalai Date: Fri, 28 Apr 2023 18:04:24 +0530 Subject: [PATCH] Coverity CWE 688: Function Call With Incorrect Variable or Reference as Argument Added fix for CWE 688 Typo in Identifier Change-Id: I53b5142451b809be638d73626265531057722169 Signed-off-by: elumalai --- .../tests/test_vimconn_openstack.py | 2 +- .../osm_rovim_openstack/vimconn_openstack.py | 2 +- ...8_Typo_in_Identifier-1b9c906a74d24d2b.yaml | 20 +++++++++++++++++++ 3 files changed, 22 insertions(+), 2 deletions(-) create mode 100644 releasenotes/notes/Coverity_CWE_688_Typo_in_Identifier-1b9c906a74d24d2b.yaml diff --git a/RO-VIM-openstack/osm_rovim_openstack/tests/test_vimconn_openstack.py b/RO-VIM-openstack/osm_rovim_openstack/tests/test_vimconn_openstack.py index d4359cd9..118251b7 100644 --- a/RO-VIM-openstack/osm_rovim_openstack/tests/test_vimconn_openstack.py +++ b/RO-VIM-openstack/osm_rovim_openstack/tests/test_vimconn_openstack.py @@ -379,7 +379,7 @@ class TestNewVmInstance(unittest.TestCase): net, port_dict, created_items = {}, {}, {} expected_result = new_port expected_net = { - "mac_adress": mac_address, + "mac_address": mac_address, "vim_id": port_id, } expected_created_items = {f"port:{port_id}": True} diff --git a/RO-VIM-openstack/osm_rovim_openstack/vimconn_openstack.py b/RO-VIM-openstack/osm_rovim_openstack/vimconn_openstack.py index e4ee15b8..6d167c69 100644 --- a/RO-VIM-openstack/osm_rovim_openstack/vimconn_openstack.py +++ b/RO-VIM-openstack/osm_rovim_openstack/vimconn_openstack.py @@ -1964,7 +1964,7 @@ class vimconnector(vimconn.VimConnector): """ new_port = self.neutron.create_port({"port": port_dict}) created_items["port:" + str(new_port["port"]["id"])] = True - net["mac_adress"] = new_port["port"]["mac_address"] + net["mac_address"] = new_port["port"]["mac_address"] net["vim_id"] = new_port["port"]["id"] return new_port diff --git a/releasenotes/notes/Coverity_CWE_688_Typo_in_Identifier-1b9c906a74d24d2b.yaml b/releasenotes/notes/Coverity_CWE_688_Typo_in_Identifier-1b9c906a74d24d2b.yaml new file mode 100644 index 00000000..52185ec8 --- /dev/null +++ b/releasenotes/notes/Coverity_CWE_688_Typo_in_Identifier-1b9c906a74d24d2b.yaml @@ -0,0 +1,20 @@ +####################################################################################### +# Copyright ETSI Contributors and Others. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or +# implied. +# See the License for the specific language governing permissions and +# limitations under the License. +####################################################################################### +--- +security: + - | + Coverity fix for CWE 688: Function Call With Incorrect Variable or Reference as Argument -- 2.17.1