db_vnfd_content = yaml.load(db_vnfds_text, Loader=yaml.Loader)[0]
db_nsd_content = yaml.load(db_nsds_text, Loader=yaml.Loader)[0]
test_pid = db_vnfd_content["_admin"]["projects_read"][0]
-fake_session = {"username": test_name, "project_id": (test_pid,), "method": None,
- "admin": True, "force": False, "public": False, "allow_show_user_project_role": True}
+fake_session = {
+ "username": test_name,
+ "project_id": (test_pid,),
+ "method": None,
+ "admin": True,
+ "force": False,
+ "public": False,
+ "allow_show_user_project_role": True,
+}
def norm(str):
"""Normalize string for checking"""
- return ' '.join(str.strip().split()).lower()
+ return " ".join(str.strip().split()).lower()
def compare_desc(tc, d1, d2, k):
class Test_VnfdTopic(TestCase):
-
@classmethod
def setUpClass(cls):
cls.test_name = "test-vnfd-topic"
did = db_vnfd_content["_id"]
self.fs.get_params.return_value = {}
self.fs.file_exists.return_value = False
- self.fs.file_open.side_effect = lambda path, mode: open("/tmp/" + str(uuid4()), "a+b")
+ self.fs.file_open.side_effect = lambda path, mode: open(
+ "/tmp/" + str(uuid4()), "a+b"
+ )
test_vnfd = deepcopy(db_vnfd_content)
del test_vnfd["_id"]
del test_vnfd["_admin"]
- with self.subTest(i=1, t='Normal Creation'):
+ with self.subTest(i=1, t="Normal Creation"):
self.db.create.return_value = did
rollback = []
did2, oid = self.topic.new(rollback, fake_session, {})
self.assertEqual(db_args[0], self.topic.topic, "Wrong DB topic")
self.assertEqual(did2, did, "Wrong DB VNFD id")
self.assertIsNotNone(db_args[1]["_admin"]["created"], "Wrong creation time")
- self.assertEqual(db_args[1]["_admin"]["modified"], db_args[1]["_admin"]["created"],
- "Wrong modification time")
- self.assertEqual(db_args[1]["_admin"]["projects_read"], [test_pid], "Wrong read-only project list")
- self.assertEqual(db_args[1]["_admin"]["projects_write"], [test_pid], "Wrong read-write project list")
+ self.assertEqual(
+ db_args[1]["_admin"]["modified"],
+ db_args[1]["_admin"]["created"],
+ "Wrong modification time",
+ )
+ self.assertEqual(
+ db_args[1]["_admin"]["projects_read"],
+ [test_pid],
+ "Wrong read-only project list",
+ )
+ self.assertEqual(
+ db_args[1]["_admin"]["projects_write"],
+ [test_pid],
+ "Wrong read-write project list",
+ )
tmp1 = test_vnfd["vdu"][0]["cloud-init-file"]
- tmp2 = test_vnfd["df"][
- 0
- ]["lcm-operations-configuration"]["operate-vnf-op-config"]["day1-2"][
- 0
- ]["execution-environment-list"][
- 0
- ]["juju"]
+ tmp2 = test_vnfd["df"][0]["lcm-operations-configuration"][
+ "operate-vnf-op-config"
+ ]["day1-2"][0]["execution-environment-list"][0]["juju"]
del test_vnfd["vdu"][0]["cloud-init-file"]
- del test_vnfd["df"][
- 0
- ]["lcm-operations-configuration"]["operate-vnf-op-config"]["day1-2"][
- 0
- ]["execution-environment-list"][
- 0
- ]["juju"]
+ del test_vnfd["df"][0]["lcm-operations-configuration"][
+ "operate-vnf-op-config"
+ ]["day1-2"][0]["execution-environment-list"][0]["juju"]
try:
- self.db.get_one.side_effect = [{"_id": did, "_admin": deepcopy(db_vnfd_content["_admin"])}, None]
- self.topic.upload_content(fake_session, did, test_vnfd, {}, {"Content-Type": []})
+ self.db.get_one.side_effect = [
+ {"_id": did, "_admin": deepcopy(db_vnfd_content["_admin"])},
+ None,
+ ]
+ self.topic.upload_content(
+ fake_session, did, test_vnfd, {}, {"Content-Type": []}
+ )
msg_args = self.msg.write.call_args[0]
test_vnfd["_id"] = did
- self.assertEqual(msg_args[0], self.topic.topic_msg, "Wrong message topic")
+ self.assertEqual(
+ msg_args[0], self.topic.topic_msg, "Wrong message topic"
+ )
self.assertEqual(msg_args[1], "edited", "Wrong message action")
self.assertEqual(msg_args[2], test_vnfd, "Wrong message content")
db_args = self.db.get_one.mock_calls[0][1]
admin = db_args[2]["_admin"]
db_admin = deepcopy(db_vnfd_content["_admin"])
self.assertEqual(admin["type"], "vnfd", "Wrong descriptor type")
- self.assertEqual(admin["created"], db_admin["created"], "Wrong creation time")
- self.assertGreater(admin["modified"], db_admin["created"], "Wrong modification time")
- self.assertEqual(admin["projects_read"], db_admin["projects_read"], "Wrong read-only project list")
- self.assertEqual(admin["projects_write"], db_admin["projects_write"], "Wrong read-write project list")
- self.assertEqual(admin["onboardingState"], "ONBOARDED", "Wrong onboarding state")
- self.assertEqual(admin["operationalState"], "ENABLED", "Wrong operational state")
+ self.assertEqual(
+ admin["created"], db_admin["created"], "Wrong creation time"
+ )
+ self.assertGreater(
+ admin["modified"], db_admin["created"], "Wrong modification time"
+ )
+ self.assertEqual(
+ admin["projects_read"],
+ db_admin["projects_read"],
+ "Wrong read-only project list",
+ )
+ self.assertEqual(
+ admin["projects_write"],
+ db_admin["projects_write"],
+ "Wrong read-write project list",
+ )
+ self.assertEqual(
+ admin["onboardingState"], "ONBOARDED", "Wrong onboarding state"
+ )
+ self.assertEqual(
+ admin["operationalState"], "ENABLED", "Wrong operational state"
+ )
self.assertEqual(admin["usageState"], "NOT_IN_USE", "Wrong usage state")
storage = admin["storage"]
self.assertEqual(storage["folder"], did, "Wrong storage folder")
- self.assertEqual(storage["descriptor"], "package", "Wrong storage descriptor")
+ self.assertEqual(
+ storage["descriptor"], "package", "Wrong storage descriptor"
+ )
compare_desc(self, test_vnfd, db_args[2], "VNFD")
finally:
test_vnfd["vdu"][0]["cloud-init-file"] = tmp1
- test_vnfd["df"][
- 0
- ]["lcm-operations-configuration"]["operate-vnf-op-config"]["day1-2"][
- 0
- ]["execution-environment-list"][
- 0
- ]["juju"] = tmp2
- self.db.get_one.side_effect = lambda table, filter, fail_on_empty=None, fail_on_more=None: \
- {"_id": did, "_admin": deepcopy(db_vnfd_content["_admin"])}
- with self.subTest(i=2, t='Check Pyangbind Validation: additional properties'):
+ test_vnfd["df"][0]["lcm-operations-configuration"][
+ "operate-vnf-op-config"
+ ]["day1-2"][0]["execution-environment-list"][0]["juju"] = tmp2
+ self.db.get_one.side_effect = (
+ lambda table, filter, fail_on_empty=None, fail_on_more=None: {
+ "_id": did,
+ "_admin": deepcopy(db_vnfd_content["_admin"]),
+ }
+ )
+ with self.subTest(i=2, t="Check Pyangbind Validation: additional properties"):
test_vnfd["extra-property"] = 0
try:
- with self.assertRaises(EngineException, msg="Accepted VNFD with an additional property") as e:
- self.topic.upload_content(fake_session, did, test_vnfd, {}, {"Content-Type": []})
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("Error in pyangbind validation: {} ({})"
- .format("json object contained a key that did not exist", "extra-property")),
- norm(str(e.exception)), "Wrong exception text")
+ with self.assertRaises(
+ EngineException, msg="Accepted VNFD with an additional property"
+ ) as e:
+ self.topic.upload_content(
+ fake_session, did, test_vnfd, {}, {"Content-Type": []}
+ )
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "Error in pyangbind validation: {} ({})".format(
+ "json object contained a key that did not exist",
+ "extra-property",
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
finally:
del test_vnfd["extra-property"]
- with self.subTest(i=3, t='Check Pyangbind Validation: property types'):
+ with self.subTest(i=3, t="Check Pyangbind Validation: property types"):
tmp = test_vnfd["product-name"]
test_vnfd["product-name"] = {"key": 0}
try:
- with self.assertRaises(EngineException, msg="Accepted VNFD with a wrongly typed property") as e:
- self.topic.upload_content(fake_session, did, test_vnfd, {}, {"Content-Type": []})
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("Error in pyangbind validation: {} ({})"
- .format("json object contained a key that did not exist", "key")),
- norm(str(e.exception)), "Wrong exception text")
+ with self.assertRaises(
+ EngineException, msg="Accepted VNFD with a wrongly typed property"
+ ) as e:
+ self.topic.upload_content(
+ fake_session, did, test_vnfd, {}, {"Content-Type": []}
+ )
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "Error in pyangbind validation: {} ({})".format(
+ "json object contained a key that did not exist", "key"
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
finally:
test_vnfd["product-name"] = tmp
- with self.subTest(i=4, t='Check Input Validation: cloud-init'):
- with self.assertRaises(EngineException, msg="Accepted non-existent cloud_init file") as e:
- self.topic.upload_content(fake_session, did, test_vnfd, {}, {"Content-Type": []})
- self.assertEqual(e.exception.http_code, HTTPStatus.BAD_REQUEST, "Wrong HTTP status code")
- self.assertIn(norm("{} defined in vnf[id={}]:vdu[id={}] but not present in package"
- .format("cloud-init", test_vnfd["id"], test_vnfd["vdu"][0]["id"])),
- norm(str(e.exception)), "Wrong exception text")
- with self.subTest(i=5, t='Check Input Validation: day1-2 configuration[juju]'):
+ with self.subTest(i=4, t="Check Input Validation: cloud-init"):
+ with self.assertRaises(
+ EngineException, msg="Accepted non-existent cloud_init file"
+ ) as e:
+ self.topic.upload_content(
+ fake_session, did, test_vnfd, {}, {"Content-Type": []}
+ )
+ self.assertEqual(
+ e.exception.http_code, HTTPStatus.BAD_REQUEST, "Wrong HTTP status code"
+ )
+ self.assertIn(
+ norm(
+ "{} defined in vnf[id={}]:vdu[id={}] but not present in package".format(
+ "cloud-init", test_vnfd["id"], test_vnfd["vdu"][0]["id"]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+ with self.subTest(i=5, t="Check Input Validation: day1-2 configuration[juju]"):
del test_vnfd["vdu"][0]["cloud-init-file"]
- with self.assertRaises(EngineException, msg="Accepted non-existent charm in VNF configuration") as e:
- self.topic.upload_content(fake_session, did, test_vnfd, {}, {"Content-Type": []})
+ with self.assertRaises(
+ EngineException, msg="Accepted non-existent charm in VNF configuration"
+ ) as e:
+ self.topic.upload_content(
+ fake_session, did, test_vnfd, {}, {"Content-Type": []}
+ )
print(str(e.exception))
- self.assertEqual(e.exception.http_code, HTTPStatus.BAD_REQUEST, "Wrong HTTP status code")
- self.assertIn(norm("{} defined in vnf[id={}] but not present in package".format("charm", test_vnfd["id"])),
- norm(str(e.exception)), "Wrong exception text")
- del test_vnfd["df"][
- 0
- ]["lcm-operations-configuration"]["operate-vnf-op-config"]["day1-2"][
- 0
- ]["execution-environment-list"][
- 0
- ]["juju"]
- with self.subTest(i=6, t='Check Input Validation: mgmt-cp'):
+ self.assertEqual(
+ e.exception.http_code, HTTPStatus.BAD_REQUEST, "Wrong HTTP status code"
+ )
+ self.assertIn(
+ norm(
+ "{} defined in vnf[id={}] but not present in package".format(
+ "charm", test_vnfd["id"]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+ del test_vnfd["df"][0]["lcm-operations-configuration"][
+ "operate-vnf-op-config"
+ ]["day1-2"][0]["execution-environment-list"][0]["juju"]
+ with self.subTest(i=6, t="Check Input Validation: mgmt-cp"):
tmp = test_vnfd["mgmt-cp"]
del test_vnfd["mgmt-cp"]
try:
- with self.assertRaises(EngineException, msg="Accepted VNFD without management interface") as e:
- self.topic.upload_content(fake_session, did, test_vnfd, {}, {"Content-Type": []})
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("'{}' is a mandatory field and it is not defined".format("mgmt-cp")),
- norm(str(e.exception)), "Wrong exception text")
+ with self.assertRaises(
+ EngineException, msg="Accepted VNFD without management interface"
+ ) as e:
+ self.topic.upload_content(
+ fake_session, did, test_vnfd, {}, {"Content-Type": []}
+ )
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "'{}' is a mandatory field and it is not defined".format(
+ "mgmt-cp"
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
finally:
test_vnfd["mgmt-cp"] = tmp
- with self.subTest(i=7, t='Check Input Validation: mgmt-cp connection point'):
+ with self.subTest(i=7, t="Check Input Validation: mgmt-cp connection point"):
tmp = test_vnfd["mgmt-cp"]
test_vnfd["mgmt-cp"] = "wrong-cp"
try:
- with self.assertRaises(EngineException, msg="Accepted wrong mgmt-cp connection point") as e:
- self.topic.upload_content(fake_session, did, test_vnfd, {}, {"Content-Type": []})
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("mgmt-cp='{}' must match an existing ext-cpd".format(test_vnfd["mgmt-cp"])),
- norm(str(e.exception)), "Wrong exception text")
+ with self.assertRaises(
+ EngineException, msg="Accepted wrong mgmt-cp connection point"
+ ) as e:
+ self.topic.upload_content(
+ fake_session, did, test_vnfd, {}, {"Content-Type": []}
+ )
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "mgmt-cp='{}' must match an existing ext-cpd".format(
+ test_vnfd["mgmt-cp"]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
finally:
test_vnfd["mgmt-cp"] = tmp
- with self.subTest(i=8, t='Check Input Validation: vdu int-cpd'):
+ with self.subTest(i=8, t="Check Input Validation: vdu int-cpd"):
ext_cpd = test_vnfd["ext-cpd"][1]
tmp = ext_cpd["int-cpd"]["cpd"]
ext_cpd["int-cpd"]["cpd"] = "wrong-cpd"
try:
- with self.assertRaises(EngineException, msg="Accepted wrong ext-cpd internal connection point") as e:
- self.topic.upload_content(fake_session, did, test_vnfd, {}, {"Content-Type": []})
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("ext-cpd[id='{}']:int-cpd must match an existing vdu int-cpd".format(ext_cpd["id"])),
- norm(str(e.exception)), "Wrong exception text")
+ with self.assertRaises(
+ EngineException,
+ msg="Accepted wrong ext-cpd internal connection point",
+ ) as e:
+ self.topic.upload_content(
+ fake_session, did, test_vnfd, {}, {"Content-Type": []}
+ )
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "ext-cpd[id='{}']:int-cpd must match an existing vdu int-cpd".format(
+ ext_cpd["id"]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
finally:
ext_cpd["int-cpd"]["cpd"] = tmp
- with self.subTest(i=9, t='Check Input Validation: Duplicated VLD'):
- test_vnfd['int-virtual-link-desc'].insert(0, {'id': 'internal'})
+ with self.subTest(i=9, t="Check Input Validation: Duplicated VLD"):
+ test_vnfd["int-virtual-link-desc"].insert(0, {"id": "internal"})
try:
- with self.assertRaises(EngineException, msg="Accepted duplicated VLD name") as e:
- self.topic.upload_content(fake_session, did, test_vnfd, {}, {"Content-Type": []})
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
+ with self.assertRaises(
+ EngineException, msg="Accepted duplicated VLD name"
+ ) as e:
+ self.topic.upload_content(
+ fake_session, did, test_vnfd, {}, {"Content-Type": []}
+ )
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
self.assertIn(
- norm("identifier id '{}' is not unique".format(test_vnfd['int-virtual-link-desc'][0]["id"])),
- norm(str(e.exception)), "Wrong exception text")
+ norm(
+ "identifier id '{}' is not unique".format(
+ test_vnfd["int-virtual-link-desc"][0]["id"]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
finally:
- del test_vnfd['int-virtual-link-desc'][0]
- with self.subTest(i=10, t='Check Input Validation: vdu int-virtual-link-desc'):
- vdu = test_vnfd['vdu'][0]
- int_cpd = vdu['int-cpd'][1]
- tmp = int_cpd['int-virtual-link-desc']
- int_cpd['int-virtual-link-desc'] = 'non-existing-int-virtual-link-desc'
+ del test_vnfd["int-virtual-link-desc"][0]
+ with self.subTest(i=10, t="Check Input Validation: vdu int-virtual-link-desc"):
+ vdu = test_vnfd["vdu"][0]
+ int_cpd = vdu["int-cpd"][1]
+ tmp = int_cpd["int-virtual-link-desc"]
+ int_cpd["int-virtual-link-desc"] = "non-existing-int-virtual-link-desc"
try:
- with self.assertRaises(EngineException, msg="Accepted int-virtual-link-desc") as e:
- self.topic.upload_content(fake_session, did, test_vnfd, {}, {"Content-Type": []})
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("vdu[id='{}']:int-cpd[id='{}']:int-virtual-link-desc='{}' must match an existing "
- "int-virtual-link-desc".format(vdu["id"], int_cpd["id"],
- int_cpd['int-virtual-link-desc'])),
- norm(str(e.exception)), "Wrong exception text")
+ with self.assertRaises(
+ EngineException, msg="Accepted int-virtual-link-desc"
+ ) as e:
+ self.topic.upload_content(
+ fake_session, did, test_vnfd, {}, {"Content-Type": []}
+ )
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "vdu[id='{}']:int-cpd[id='{}']:int-virtual-link-desc='{}' must match an existing "
+ "int-virtual-link-desc".format(
+ vdu["id"], int_cpd["id"], int_cpd["int-virtual-link-desc"]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
finally:
- int_cpd['int-virtual-link-desc'] = tmp
- with self.subTest(i=11, t='Check Input Validation: virtual-link-profile)'):
- fake_ivld_profile = {'id': 'fake-profile-ref', 'flavour': 'fake-flavour'}
- df = test_vnfd['df'][0]
- df['virtual-link-profile'] = [fake_ivld_profile]
+ int_cpd["int-virtual-link-desc"] = tmp
+ with self.subTest(i=11, t="Check Input Validation: virtual-link-profile)"):
+ fake_ivld_profile = {"id": "fake-profile-ref", "flavour": "fake-flavour"}
+ df = test_vnfd["df"][0]
+ df["virtual-link-profile"] = [fake_ivld_profile]
try:
- with self.assertRaises(EngineException, msg="Accepted non-existent Profile Ref") as e:
- self.topic.upload_content(fake_session, did, test_vnfd, {}, {"Content-Type": []})
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("df[id='{}']:virtual-link-profile='{}' must match an existing "
- "int-virtual-link-desc".format(df["id"], fake_ivld_profile["id"])),
- norm(str(e.exception)), "Wrong exception text")
+ with self.assertRaises(
+ EngineException, msg="Accepted non-existent Profile Ref"
+ ) as e:
+ self.topic.upload_content(
+ fake_session, did, test_vnfd, {}, {"Content-Type": []}
+ )
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "df[id='{}']:virtual-link-profile='{}' must match an existing "
+ "int-virtual-link-desc".format(
+ df["id"], fake_ivld_profile["id"]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
finally:
- del df['virtual-link-profile']
- with self.subTest(i=12, t='Check Input Validation: scaling-criteria monitoring-param-ref'):
- vdu = test_vnfd['vdu'][1]
- affected_df = test_vnfd['df'][0]
- sa = affected_df['scaling-aspect'][0]
- sp = sa['scaling-policy'][0]
- sc = sp['scaling-criteria'][0]
- tmp = vdu.pop('monitoring-parameter')
+ del df["virtual-link-profile"]
+ with self.subTest(
+ i=12, t="Check Input Validation: scaling-criteria monitoring-param-ref"
+ ):
+ vdu = test_vnfd["vdu"][1]
+ affected_df = test_vnfd["df"][0]
+ sa = affected_df["scaling-aspect"][0]
+ sp = sa["scaling-policy"][0]
+ sc = sp["scaling-criteria"][0]
+ tmp = vdu.pop("monitoring-parameter")
try:
- with self.assertRaises(EngineException, msg="Accepted non-existent Scaling Group Policy Criteria") as e:
- self.topic.upload_content(fake_session, did, test_vnfd, {}, {"Content-Type": []})
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("df[id='{}']:scaling-aspect[id='{}']:scaling-policy"
- "[name='{}']:scaling-criteria[name='{}']: "
- "vnf-monitoring-param-ref='{}' not defined in any monitoring-param"
- .format(affected_df["id"], sa["id"], sp["name"],
- sc["name"], sc["vnf-monitoring-param-ref"])),
- norm(str(e.exception)), "Wrong exception text")
+ with self.assertRaises(
+ EngineException,
+ msg="Accepted non-existent Scaling Group Policy Criteria",
+ ) as e:
+ self.topic.upload_content(
+ fake_session, did, test_vnfd, {}, {"Content-Type": []}
+ )
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "df[id='{}']:scaling-aspect[id='{}']:scaling-policy"
+ "[name='{}']:scaling-criteria[name='{}']: "
+ "vnf-monitoring-param-ref='{}' not defined in any monitoring-param".format(
+ affected_df["id"],
+ sa["id"],
+ sp["name"],
+ sc["name"],
+ sc["vnf-monitoring-param-ref"],
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
finally:
- vdu['monitoring-parameter'] = tmp
- with self.subTest(i=13, t='Check Input Validation: scaling-aspect vnf-configuration'):
- df = test_vnfd['df'][0]
- tmp = test_vnfd["df"][0]["lcm-operations-configuration"]["operate-vnf-op-config"]["day1-2"].pop()
+ vdu["monitoring-parameter"] = tmp
+ with self.subTest(
+ i=13, t="Check Input Validation: scaling-aspect vnf-configuration"
+ ):
+ df = test_vnfd["df"][0]
+ tmp = test_vnfd["df"][0]["lcm-operations-configuration"][
+ "operate-vnf-op-config"
+ ]["day1-2"].pop()
try:
- with self.assertRaises(EngineException, msg="Accepted non-existent Scaling Group VDU ID Reference") \
- as e:
- self.topic.upload_content(fake_session, did, test_vnfd, {}, {"Content-Type": []})
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("'day1-2 configuration' not defined in the descriptor but it is referenced "
- "by df[id='{}']:scaling-aspect[id='{}']:scaling-config-action"
- .format(df["id"], df['scaling-aspect'][0]["id"])),
- norm(str(e.exception)), "Wrong exception text")
+ with self.assertRaises(
+ EngineException,
+ msg="Accepted non-existent Scaling Group VDU ID Reference",
+ ) as e:
+ self.topic.upload_content(
+ fake_session, did, test_vnfd, {}, {"Content-Type": []}
+ )
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "'day1-2 configuration' not defined in the descriptor but it is referenced "
+ "by df[id='{}']:scaling-aspect[id='{}']:scaling-config-action".format(
+ df["id"], df["scaling-aspect"][0]["id"]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
finally:
- test_vnfd["df"][0]["lcm-operations-configuration"]["operate-vnf-op-config"]["day1-2"].append(tmp)
- with self.subTest(i=14, t='Check Input Validation: scaling-config-action'):
- df = test_vnfd['df'][0]
- tmp = test_vnfd["df"][0].get(
- "lcm-operations-configuration"
- ).get(
- "operate-vnf-op-config"
- )["day1-2"][0]['config-primitive']
- test_vnfd["df"][0].get(
- "lcm-operations-configuration"
- ).get(
+ test_vnfd["df"][0]["lcm-operations-configuration"][
+ "operate-vnf-op-config"
+ ]["day1-2"].append(tmp)
+ with self.subTest(i=14, t="Check Input Validation: scaling-config-action"):
+ df = test_vnfd["df"][0]
+ tmp = (
+ test_vnfd["df"][0]
+ .get("lcm-operations-configuration")
+ .get("operate-vnf-op-config")["day1-2"][0]["config-primitive"]
+ )
+ test_vnfd["df"][0].get("lcm-operations-configuration").get(
"operate-vnf-op-config"
- )["day1-2"][0]['config-primitive'] = [{'name': 'wrong-primitive'}]
+ )["day1-2"][0]["config-primitive"] = [{"name": "wrong-primitive"}]
try:
- with self.assertRaises(EngineException,
- msg="Accepted non-existent Scaling Group VDU ID Reference") as e:
- self.topic.upload_content(fake_session, did, test_vnfd, {}, {"Content-Type": []})
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("df[id='{}']:scaling-aspect[id='{}']:scaling-config-action:vnf-"
- "config-primitive-name-ref='{}' does not match any "
- "day1-2 configuration:config-primitive:name"
- .format(df["id"], df['scaling-aspect'][0]["id"],
- sa['scaling-config-action'][0]['vnf-config-primitive-name-ref'])),
- norm(str(e.exception)), "Wrong exception text")
+ with self.assertRaises(
+ EngineException,
+ msg="Accepted non-existent Scaling Group VDU ID Reference",
+ ) as e:
+ self.topic.upload_content(
+ fake_session, did, test_vnfd, {}, {"Content-Type": []}
+ )
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "df[id='{}']:scaling-aspect[id='{}']:scaling-config-action:vnf-"
+ "config-primitive-name-ref='{}' does not match any "
+ "day1-2 configuration:config-primitive:name".format(
+ df["id"],
+ df["scaling-aspect"][0]["id"],
+ sa["scaling-config-action"][0][
+ "vnf-config-primitive-name-ref"
+ ],
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
finally:
- test_vnfd["df"][0].get(
- "lcm-operations-configuration"
- ).get(
+ test_vnfd["df"][0].get("lcm-operations-configuration").get(
"operate-vnf-op-config"
- )["day1-2"][0]['config-primitive'] = tmp
- with self.subTest(i=15, t='Check Input Validation: everything right'):
+ )["day1-2"][0]["config-primitive"] = tmp
+ with self.subTest(i=15, t="Check Input Validation: everything right"):
test_vnfd["id"] = "fake-vnfd-id"
- test_vnfd["df"][0].get(
- "lcm-operations-configuration"
- ).get(
+ test_vnfd["df"][0].get("lcm-operations-configuration").get(
"operate-vnf-op-config"
)["day1-2"][0]["id"] = "fake-vnfd-id"
- self.db.get_one.side_effect = [{"_id": did, "_admin": deepcopy(db_vnfd_content["_admin"])}, None]
- rc = self.topic.upload_content(fake_session, did, test_vnfd, {}, {"Content-Type": []})
+ self.db.get_one.side_effect = [
+ {"_id": did, "_admin": deepcopy(db_vnfd_content["_admin"])},
+ None,
+ ]
+ rc = self.topic.upload_content(
+ fake_session, did, test_vnfd, {}, {"Content-Type": []}
+ )
self.assertTrue(rc, "Input Validation: Unexpected failure")
return
did = vnfd_content["_id"]
self.fs.file_exists.return_value = True
self.fs.dir_ls.return_value = True
- with self.subTest(i=1, t='Normal Edition'):
+ with self.subTest(i=1, t="Normal Edition"):
now = time()
self.db.get_one.side_effect = [deepcopy(vnfd_content), None]
- data = {
- "product-name": "new-vnfd-name"
- }
+ data = {"product-name": "new-vnfd-name"}
self.topic.edit(fake_session, did, data)
db_args = self.db.replace.call_args[0]
msg_args = self.msg.write.call_args[0]
self.assertEqual(msg_args[2], data, "Wrong message content")
self.assertEqual(db_args[0], self.topic.topic, "Wrong DB topic")
self.assertEqual(db_args[1], did, "Wrong DB ID")
- self.assertEqual(db_args[2]["_admin"]["created"], vnfd_content["_admin"]["created"],
- "Wrong creation time")
- self.assertGreater(db_args[2]["_admin"]["modified"], now,
- "Wrong modification time")
- self.assertEqual(db_args[2]["_admin"]["projects_read"], vnfd_content["_admin"]["projects_read"],
- "Wrong read-only project list")
- self.assertEqual(db_args[2]["_admin"]["projects_write"], vnfd_content["_admin"]["projects_write"],
- "Wrong read-write project list")
- self.assertEqual(db_args[2]["product-name"], data["product-name"], "Wrong VNFD Name")
- with self.subTest(i=2, t='Conflict on Edit'):
+ self.assertEqual(
+ db_args[2]["_admin"]["created"],
+ vnfd_content["_admin"]["created"],
+ "Wrong creation time",
+ )
+ self.assertGreater(
+ db_args[2]["_admin"]["modified"], now, "Wrong modification time"
+ )
+ self.assertEqual(
+ db_args[2]["_admin"]["projects_read"],
+ vnfd_content["_admin"]["projects_read"],
+ "Wrong read-only project list",
+ )
+ self.assertEqual(
+ db_args[2]["_admin"]["projects_write"],
+ vnfd_content["_admin"]["projects_write"],
+ "Wrong read-write project list",
+ )
+ self.assertEqual(
+ db_args[2]["product-name"], data["product-name"], "Wrong VNFD Name"
+ )
+ with self.subTest(i=2, t="Conflict on Edit"):
data = {"id": "hackfest3charmed-vnf", "product-name": "new-vnfd-name"}
- self.db.get_one.side_effect = [deepcopy(vnfd_content), {"_id": str(uuid4()), "id": data["id"]}]
- with self.assertRaises(EngineException, msg="Accepted existing VNFD ID") as e:
+ self.db.get_one.side_effect = [
+ deepcopy(vnfd_content),
+ {"_id": str(uuid4()), "id": data["id"]},
+ ]
+ with self.assertRaises(
+ EngineException, msg="Accepted existing VNFD ID"
+ ) as e:
self.topic.edit(fake_session, did, data)
- self.assertEqual(e.exception.http_code, HTTPStatus.CONFLICT, "Wrong HTTP status code")
- self.assertIn(norm("{} with id '{}' already exists for this project".format("vnfd", data["id"])),
- norm(str(e.exception)), "Wrong exception text")
- with self.subTest(i=3, t='Check Envelope'):
+ self.assertEqual(
+ e.exception.http_code, HTTPStatus.CONFLICT, "Wrong HTTP status code"
+ )
+ self.assertIn(
+ norm(
+ "{} with id '{}' already exists for this project".format(
+ "vnfd", data["id"]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+ with self.subTest(i=3, t="Check Envelope"):
data = {"vnfd": [{"id": "new-vnfd-id-1", "product-name": "new-vnfd-name"}]}
- with self.assertRaises(EngineException, msg="Accepted VNFD with wrong envelope") as e:
+ with self.assertRaises(
+ EngineException, msg="Accepted VNFD with wrong envelope"
+ ) as e:
self.topic.edit(fake_session, did, data, content=vnfd_content)
- self.assertEqual(e.exception.http_code, HTTPStatus.BAD_REQUEST, "Wrong HTTP status code")
- self.assertIn("'vnfd' must be dict", norm(str(e.exception)), "Wrong exception text")
+ self.assertEqual(
+ e.exception.http_code, HTTPStatus.BAD_REQUEST, "Wrong HTTP status code"
+ )
+ self.assertIn(
+ "'vnfd' must be dict", norm(str(e.exception)), "Wrong exception text"
+ )
return
def test_delete_vnfd(self):
did = db_vnfd_content["_id"]
self.db.get_one.return_value = db_vnfd_content
p_id = db_vnfd_content["_admin"]["projects_read"][0]
- with self.subTest(i=1, t='Normal Deletion'):
+ with self.subTest(i=1, t="Normal Deletion"):
self.db.get_list.return_value = []
self.db.del_one.return_value = {"deleted": 1}
self.topic.delete(fake_session, did)
self.assertEqual(msg_args[2], {"_id": did}, "Wrong message content")
self.assertEqual(db_args[0], self.topic.topic, "Wrong DB topic")
self.assertEqual(db_args[1]["_id"], did, "Wrong DB ID")
- self.assertEqual(db_args[1]["_admin.projects_write.cont"], [p_id, 'ANY'], "Wrong DB filter")
+ self.assertEqual(
+ db_args[1]["_admin.projects_write.cont"],
+ [p_id, "ANY"],
+ "Wrong DB filter",
+ )
db_g1_args = self.db.get_one.call_args[0]
self.assertEqual(db_g1_args[0], self.topic.topic, "Wrong DB topic")
self.assertEqual(db_g1_args[1]["_id"], did, "Wrong DB VNFD ID")
self.assertEqual(db_gl_calls[0][0][0], "vnfrs", "Wrong DB topic")
# self.assertEqual(db_gl_calls[0][0][1]["vnfd-id"], did, "Wrong DB VNFD ID") # Filter changed after call
self.assertEqual(db_gl_calls[1][0][0], "nsds", "Wrong DB topic")
- self.assertEqual(db_gl_calls[1][0][1]["vnfd-id"], db_vnfd_content["id"],
- "Wrong DB NSD vnfd-id")
+ self.assertEqual(
+ db_gl_calls[1][0][1]["vnfd-id"],
+ db_vnfd_content["id"],
+ "Wrong DB NSD vnfd-id",
+ )
self.db.set_one.assert_not_called()
fs_del_calls = self.fs.file_delete.call_args_list
self.assertEqual(fs_del_calls[0][0][0], did, "Wrong FS file id")
- self.assertEqual(fs_del_calls[1][0][0], did + '_', "Wrong FS folder id")
- with self.subTest(i=2, t='Conflict on Delete - VNFD in use by VNFR'):
+ self.assertEqual(fs_del_calls[1][0][0], did + "_", "Wrong FS folder id")
+ with self.subTest(i=2, t="Conflict on Delete - VNFD in use by VNFR"):
self.db.get_list.return_value = [{"_id": str(uuid4()), "name": "fake-vnfr"}]
- with self.assertRaises(EngineException, msg="Accepted VNFD in use by VNFR") as e:
+ with self.assertRaises(
+ EngineException, msg="Accepted VNFD in use by VNFR"
+ ) as e:
self.topic.delete(fake_session, did)
- self.assertEqual(e.exception.http_code, HTTPStatus.CONFLICT, "Wrong HTTP status code")
- self.assertIn("there is at least one vnf instance using this descriptor", norm(str(e.exception)),
- "Wrong exception text")
- with self.subTest(i=3, t='Conflict on Delete - VNFD in use by NSD'):
- self.db.get_list.side_effect = [[], [{"_id": str(uuid4()), "name": "fake-nsd"}]]
- with self.assertRaises(EngineException, msg="Accepted VNFD in use by NSD") as e:
+ self.assertEqual(
+ e.exception.http_code, HTTPStatus.CONFLICT, "Wrong HTTP status code"
+ )
+ self.assertIn(
+ "there is at least one vnf instance using this descriptor",
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+ with self.subTest(i=3, t="Conflict on Delete - VNFD in use by NSD"):
+ self.db.get_list.side_effect = [
+ [],
+ [{"_id": str(uuid4()), "name": "fake-nsd"}],
+ ]
+ with self.assertRaises(
+ EngineException, msg="Accepted VNFD in use by NSD"
+ ) as e:
self.topic.delete(fake_session, did)
- self.assertEqual(e.exception.http_code, HTTPStatus.CONFLICT, "Wrong HTTP status code")
- self.assertIn("there is at least one ns package referencing this descriptor", norm(str(e.exception)),
- "Wrong exception text")
- with self.subTest(i=4, t='Non-existent VNFD'):
+ self.assertEqual(
+ e.exception.http_code, HTTPStatus.CONFLICT, "Wrong HTTP status code"
+ )
+ self.assertIn(
+ "there is at least one ns package referencing this descriptor",
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+ with self.subTest(i=4, t="Non-existent VNFD"):
excp_msg = "Not found any {} with filter='{}'".format("VNFD", {"_id": did})
self.db.get_one.side_effect = DbException(excp_msg, HTTPStatus.NOT_FOUND)
- with self.assertRaises(DbException, msg="Accepted non-existent VNFD ID") as e:
+ with self.assertRaises(
+ DbException, msg="Accepted non-existent VNFD ID"
+ ) as e:
self.topic.delete(fake_session, did)
- self.assertEqual(e.exception.http_code, HTTPStatus.NOT_FOUND, "Wrong HTTP status code")
- self.assertIn(norm(excp_msg), norm(str(e.exception)), "Wrong exception text")
- with self.subTest(i=5, t='No delete because referenced by other project'):
+ self.assertEqual(
+ e.exception.http_code, HTTPStatus.NOT_FOUND, "Wrong HTTP status code"
+ )
+ self.assertIn(
+ norm(excp_msg), norm(str(e.exception)), "Wrong exception text"
+ )
+ with self.subTest(i=5, t="No delete because referenced by other project"):
db_vnfd_content["_admin"]["projects_read"].append("other_project")
self.db.get_one = Mock(return_value=db_vnfd_content)
self.db.get_list = Mock(return_value=[])
db_s1_args = self.db.set_one.call_args
self.assertEqual(db_s1_args[0][0], self.topic.topic, "Wrong DB topic")
self.assertEqual(db_s1_args[0][1]["_id"], did, "Wrong DB ID")
- self.assertIn(p_id, db_s1_args[0][1]["_admin.projects_write.cont"], "Wrong DB filter")
- self.assertIsNone(db_s1_args[1]["update_dict"], "Wrong DB update dictionary")
- self.assertEqual(db_s1_args[1]["pull_list"],
- {"_admin.projects_read": (p_id,), "_admin.projects_write": (p_id,)},
- "Wrong DB pull_list dictionary")
+ self.assertIn(
+ p_id, db_s1_args[0][1]["_admin.projects_write.cont"], "Wrong DB filter"
+ )
+ self.assertIsNone(
+ db_s1_args[1]["update_dict"], "Wrong DB update dictionary"
+ )
+ self.assertEqual(
+ db_s1_args[1]["pull_list"],
+ {"_admin.projects_read": (p_id,), "_admin.projects_write": (p_id,)},
+ "Wrong DB pull_list dictionary",
+ )
self.fs.file_delete.assert_not_called()
return
indata = deepcopy(db_vnfd_content)
self.topic.validate_mgmt_interface_connection_point(indata)
- def test_validate_mgmt_interface_connection_point_when_missing_connection_point(self):
+ def test_validate_mgmt_interface_connection_point_when_missing_connection_point(
+ self,
+ ):
indata = deepcopy(db_vnfd_content)
- indata['ext-cpd'] = []
+ indata["ext-cpd"] = []
with self.assertRaises(EngineException) as e:
self.topic.validate_mgmt_interface_connection_point(indata)
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("mgmt-cp='{}' must match an existing ext-cpd"
- .format(indata["mgmt-cp"])),
- norm(str(e.exception)), "Wrong exception text")
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "mgmt-cp='{}' must match an existing ext-cpd".format(indata["mgmt-cp"])
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
def test_validate_mgmt_interface_connection_point_when_missing_mgmt_cp(self):
indata = deepcopy(db_vnfd_content)
- indata.pop('mgmt-cp')
+ indata.pop("mgmt-cp")
with self.assertRaises(EngineException) as e:
self.topic.validate_mgmt_interface_connection_point(indata)
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("'mgmt-cp' is a mandatory field and it is not defined"),
- norm(str(e.exception)), "Wrong exception text")
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm("'mgmt-cp' is a mandatory field and it is not defined"),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
def test_validate_vdu_internal_connection_points_on_valid_descriptor(self):
indata = db_vnfd_content
- vdu = indata['vdu'][0]
+ vdu = indata["vdu"][0]
self.topic.validate_vdu_internal_connection_points(vdu)
def test_validate_external_connection_points_on_valid_descriptor(self):
indata = db_vnfd_content
self.topic.validate_external_connection_points(indata)
- def test_validate_external_connection_points_when_missing_internal_connection_point(self):
+ def test_validate_external_connection_points_when_missing_internal_connection_point(
+ self,
+ ):
indata = deepcopy(db_vnfd_content)
- vdu = indata['vdu'][0]
- vdu.pop('int-cpd')
+ vdu = indata["vdu"][0]
+ vdu.pop("int-cpd")
affected_ext_cpd = indata["ext-cpd"][0]
with self.assertRaises(EngineException) as e:
self.topic.validate_external_connection_points(indata)
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("ext-cpd[id='{}']:int-cpd must match an existing vdu int-cpd"
- .format(affected_ext_cpd["id"])),
- norm(str(e.exception)), "Wrong exception text")
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "ext-cpd[id='{}']:int-cpd must match an existing vdu int-cpd".format(
+ affected_ext_cpd["id"]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
- def test_validate_vdu_internal_connection_points_on_duplicated_internal_connection_point(self):
+ def test_validate_vdu_internal_connection_points_on_duplicated_internal_connection_point(
+ self,
+ ):
indata = deepcopy(db_vnfd_content)
- vdu = indata['vdu'][0]
- duplicated_cpd = {'id': 'vnf-mgmt', 'order': 3,
- 'virtual-network-interface-requirement': [{'name': 'duplicated'}]}
- vdu['int-cpd'].insert(0, duplicated_cpd)
+ vdu = indata["vdu"][0]
+ duplicated_cpd = {
+ "id": "vnf-mgmt",
+ "order": 3,
+ "virtual-network-interface-requirement": [{"name": "duplicated"}],
+ }
+ vdu["int-cpd"].insert(0, duplicated_cpd)
with self.assertRaises(EngineException) as e:
self.topic.validate_vdu_internal_connection_points(vdu)
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("vdu[id='{}']:int-cpd[id='{}'] is already used by other int-cpd"
- .format(vdu["id"], duplicated_cpd["id"])),
- norm(str(e.exception)), "Wrong exception text")
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "vdu[id='{}']:int-cpd[id='{}'] is already used by other int-cpd".format(
+ vdu["id"], duplicated_cpd["id"]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
- def test_validate_external_connection_points_on_duplicated_external_connection_point(self):
+ def test_validate_external_connection_points_on_duplicated_external_connection_point(
+ self,
+ ):
indata = deepcopy(db_vnfd_content)
- duplicated_cpd = {'id': 'vnf-mgmt-ext', 'int-cpd': {'vdu-id': 'dataVM', 'cpd': 'vnf-data'}}
- indata['ext-cpd'].insert(0, duplicated_cpd)
+ duplicated_cpd = {
+ "id": "vnf-mgmt-ext",
+ "int-cpd": {"vdu-id": "dataVM", "cpd": "vnf-data"},
+ }
+ indata["ext-cpd"].insert(0, duplicated_cpd)
with self.assertRaises(EngineException) as e:
self.topic.validate_external_connection_points(indata)
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("ext-cpd[id='{}'] is already used by other ext-cpd"
- .format(duplicated_cpd["id"])),
- norm(str(e.exception)), "Wrong exception text")
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "ext-cpd[id='{}'] is already used by other ext-cpd".format(
+ duplicated_cpd["id"]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
def test_validate_internal_virtual_links_on_valid_descriptor(self):
indata = db_vnfd_content
def test_validate_internal_virtual_links_on_duplicated_ivld(self):
indata = deepcopy(db_vnfd_content)
- duplicated_vld = {'id': 'internal'}
- indata['int-virtual-link-desc'].insert(0, duplicated_vld)
+ duplicated_vld = {"id": "internal"}
+ indata["int-virtual-link-desc"].insert(0, duplicated_vld)
with self.assertRaises(EngineException) as e:
self.topic.validate_internal_virtual_links(indata)
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("Duplicated VLD id in int-virtual-link-desc[id={}]"
- .format(duplicated_vld["id"])),
- norm(str(e.exception)), "Wrong exception text")
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "Duplicated VLD id in int-virtual-link-desc[id={}]".format(
+ duplicated_vld["id"]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
- def test_validate_internal_virtual_links_when_missing_ivld_on_connection_point(self):
+ def test_validate_internal_virtual_links_when_missing_ivld_on_connection_point(
+ self,
+ ):
indata = deepcopy(db_vnfd_content)
- vdu = indata['vdu'][0]
- affected_int_cpd = vdu['int-cpd'][0]
- affected_int_cpd['int-virtual-link-desc'] = 'non-existing-int-virtual-link-desc'
+ vdu = indata["vdu"][0]
+ affected_int_cpd = vdu["int-cpd"][0]
+ affected_int_cpd["int-virtual-link-desc"] = "non-existing-int-virtual-link-desc"
with self.assertRaises(EngineException) as e:
self.topic.validate_internal_virtual_links(indata)
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("vdu[id='{}']:int-cpd[id='{}']:int-virtual-link-desc='{}' must match an existing "
- "int-virtual-link-desc".format(vdu["id"], affected_int_cpd["id"],
- affected_int_cpd['int-virtual-link-desc'])),
- norm(str(e.exception)), "Wrong exception text")
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "vdu[id='{}']:int-cpd[id='{}']:int-virtual-link-desc='{}' must match an existing "
+ "int-virtual-link-desc".format(
+ vdu["id"],
+ affected_int_cpd["id"],
+ affected_int_cpd["int-virtual-link-desc"],
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
def test_validate_internal_virtual_links_when_missing_ivld_on_profile(self):
indata = deepcopy(db_vnfd_content)
- affected_ivld_profile = {'id': 'non-existing-int-virtual-link-desc'}
- df = indata['df'][0]
- df['virtual-link-profile'] = [affected_ivld_profile]
+ affected_ivld_profile = {"id": "non-existing-int-virtual-link-desc"}
+ df = indata["df"][0]
+ df["virtual-link-profile"] = [affected_ivld_profile]
with self.assertRaises(EngineException) as e:
self.topic.validate_internal_virtual_links(indata)
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("df[id='{}']:virtual-link-profile='{}' must match an existing "
- "int-virtual-link-desc".format(df["id"], affected_ivld_profile["id"])),
- norm(str(e.exception)), "Wrong exception text")
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "df[id='{}']:virtual-link-profile='{}' must match an existing "
+ "int-virtual-link-desc".format(df["id"], affected_ivld_profile["id"])
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
def test_validate_monitoring_params_on_valid_descriptor(self):
indata = db_vnfd_content
def test_validate_monitoring_params_on_duplicated_ivld_monitoring_param(self):
indata = deepcopy(db_vnfd_content)
- duplicated_mp = {'id': 'cpu', 'name': 'cpu', 'performance_metric': 'cpu'}
- affected_ivld = indata['int-virtual-link-desc'][0]
- affected_ivld['monitoring-parameters'] = [duplicated_mp, duplicated_mp]
+ duplicated_mp = {"id": "cpu", "name": "cpu", "performance_metric": "cpu"}
+ affected_ivld = indata["int-virtual-link-desc"][0]
+ affected_ivld["monitoring-parameters"] = [duplicated_mp, duplicated_mp]
with self.assertRaises(EngineException) as e:
self.topic.validate_monitoring_params(indata)
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("Duplicated monitoring-parameter id in "
- "int-virtual-link-desc[id='{}']:monitoring-parameters[id='{}']"
- .format(affected_ivld["id"], duplicated_mp["id"])),
- norm(str(e.exception)), "Wrong exception text")
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "Duplicated monitoring-parameter id in "
+ "int-virtual-link-desc[id='{}']:monitoring-parameters[id='{}']".format(
+ affected_ivld["id"], duplicated_mp["id"]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
def test_validate_monitoring_params_on_duplicated_vdu_monitoring_param(self):
indata = deepcopy(db_vnfd_content)
- duplicated_mp = {'id': 'dataVM_cpu_util', 'name': 'dataVM_cpu_util', 'performance_metric': 'cpu'}
- affected_vdu = indata['vdu'][1]
- affected_vdu['monitoring-parameter'].insert(0, duplicated_mp)
+ duplicated_mp = {
+ "id": "dataVM_cpu_util",
+ "name": "dataVM_cpu_util",
+ "performance_metric": "cpu",
+ }
+ affected_vdu = indata["vdu"][1]
+ affected_vdu["monitoring-parameter"].insert(0, duplicated_mp)
with self.assertRaises(EngineException) as e:
self.topic.validate_monitoring_params(indata)
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("Duplicated monitoring-parameter id in "
- "vdu[id='{}']:monitoring-parameter[id='{}']"
- .format(affected_vdu["id"], duplicated_mp["id"])),
- norm(str(e.exception)), "Wrong exception text")
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "Duplicated monitoring-parameter id in "
+ "vdu[id='{}']:monitoring-parameter[id='{}']".format(
+ affected_vdu["id"], duplicated_mp["id"]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
def test_validate_monitoring_params_on_duplicated_df_monitoring_param(self):
indata = deepcopy(db_vnfd_content)
- duplicated_mp = {'id': 'memory', 'name': 'memory', 'performance_metric': 'memory'}
- affected_df = indata['df'][0]
- affected_df['monitoring-parameter'] = [duplicated_mp, duplicated_mp]
+ duplicated_mp = {
+ "id": "memory",
+ "name": "memory",
+ "performance_metric": "memory",
+ }
+ affected_df = indata["df"][0]
+ affected_df["monitoring-parameter"] = [duplicated_mp, duplicated_mp]
with self.assertRaises(EngineException) as e:
self.topic.validate_monitoring_params(indata)
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("Duplicated monitoring-parameter id in "
- "df[id='{}']:monitoring-parameter[id='{}']"
- .format(affected_df["id"], duplicated_mp["id"])),
- norm(str(e.exception)), "Wrong exception text")
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "Duplicated monitoring-parameter id in "
+ "df[id='{}']:monitoring-parameter[id='{}']".format(
+ affected_df["id"], duplicated_mp["id"]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
def test_validate_scaling_group_descriptor_on_valid_descriptor(self):
indata = db_vnfd_content
def test_validate_scaling_group_descriptor_when_missing_monitoring_param(self):
indata = deepcopy(db_vnfd_content)
- vdu = indata['vdu'][1]
- affected_df = indata['df'][0]
- affected_sa = affected_df['scaling-aspect'][0]
- affected_sp = affected_sa['scaling-policy'][0]
- affected_sc = affected_sp['scaling-criteria'][0]
- vdu.pop('monitoring-parameter')
+ vdu = indata["vdu"][1]
+ affected_df = indata["df"][0]
+ affected_sa = affected_df["scaling-aspect"][0]
+ affected_sp = affected_sa["scaling-policy"][0]
+ affected_sc = affected_sp["scaling-criteria"][0]
+ vdu.pop("monitoring-parameter")
with self.assertRaises(EngineException) as e:
self.topic.validate_scaling_group_descriptor(indata)
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("df[id='{}']:scaling-aspect[id='{}']:scaling-policy"
- "[name='{}']:scaling-criteria[name='{}']: "
- "vnf-monitoring-param-ref='{}' not defined in any monitoring-param"
- .format(affected_df["id"], affected_sa["id"], affected_sp["name"], affected_sc["name"],
- affected_sc["vnf-monitoring-param-ref"])),
- norm(str(e.exception)), "Wrong exception text")
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "df[id='{}']:scaling-aspect[id='{}']:scaling-policy"
+ "[name='{}']:scaling-criteria[name='{}']: "
+ "vnf-monitoring-param-ref='{}' not defined in any monitoring-param".format(
+ affected_df["id"],
+ affected_sa["id"],
+ affected_sp["name"],
+ affected_sc["name"],
+ affected_sc["vnf-monitoring-param-ref"],
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
def test_validate_scaling_group_descriptor_when_missing_vnf_configuration(self):
indata = deepcopy(db_vnfd_content)
- df = indata['df'][0]
- affected_sa = df['scaling-aspect'][0]
- indata["df"][0]["lcm-operations-configuration"]["operate-vnf-op-config"]["day1-2"].pop()
+ df = indata["df"][0]
+ affected_sa = df["scaling-aspect"][0]
+ indata["df"][0]["lcm-operations-configuration"]["operate-vnf-op-config"][
+ "day1-2"
+ ].pop()
with self.assertRaises(EngineException) as e:
self.topic.validate_scaling_group_descriptor(indata)
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("'day1-2 configuration' not defined in the descriptor but it is referenced "
- "by df[id='{}']:scaling-aspect[id='{}']:scaling-config-action"
- .format(df["id"], affected_sa["id"])),
- norm(str(e.exception)), "Wrong exception text")
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "'day1-2 configuration' not defined in the descriptor but it is referenced "
+ "by df[id='{}']:scaling-aspect[id='{}']:scaling-config-action".format(
+ df["id"], affected_sa["id"]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
- def test_validate_scaling_group_descriptor_when_missing_scaling_config_action_primitive(self):
+ def test_validate_scaling_group_descriptor_when_missing_scaling_config_action_primitive(
+ self,
+ ):
indata = deepcopy(db_vnfd_content)
- df = indata['df'][0]
- affected_sa = df['scaling-aspect'][0]
- affected_sca_primitive = affected_sa['scaling-config-action'][0]['vnf-config-primitive-name-ref']
- df["lcm-operations-configuration"]["operate-vnf-op-config"]["day1-2"][0]['config-primitive'] = []
+ df = indata["df"][0]
+ affected_sa = df["scaling-aspect"][0]
+ affected_sca_primitive = affected_sa["scaling-config-action"][0][
+ "vnf-config-primitive-name-ref"
+ ]
+ df["lcm-operations-configuration"]["operate-vnf-op-config"]["day1-2"][0][
+ "config-primitive"
+ ] = []
with self.assertRaises(EngineException) as e:
self.topic.validate_scaling_group_descriptor(indata)
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("df[id='{}']:scaling-aspect[id='{}']:scaling-config-action:vnf-"
- "config-primitive-name-ref='{}' does not match any "
- "day1-2 configuration:config-primitive:name"
- .format(df["id"], affected_sa["id"], affected_sca_primitive)),
- norm(str(e.exception)), "Wrong exception text")
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "df[id='{}']:scaling-aspect[id='{}']:scaling-config-action:vnf-"
+ "config-primitive-name-ref='{}' does not match any "
+ "day1-2 configuration:config-primitive:name".format(
+ df["id"], affected_sa["id"], affected_sca_primitive
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
class Test_NsdTopic(TestCase):
-
@classmethod
def setUpClass(cls):
cls.test_name = "test-nsd-topic"
did = db_nsd_content["_id"]
self.fs.get_params.return_value = {}
self.fs.file_exists.return_value = False
- self.fs.file_open.side_effect = lambda path, mode: open("/tmp/" + str(uuid4()), "a+b")
+ self.fs.file_open.side_effect = lambda path, mode: open(
+ "/tmp/" + str(uuid4()), "a+b"
+ )
test_nsd = deepcopy(db_nsd_content)
del test_nsd["_id"]
del test_nsd["_admin"]
- with self.subTest(i=1, t='Normal Creation'):
+ with self.subTest(i=1, t="Normal Creation"):
self.db.create.return_value = did
rollback = []
did2, oid = self.topic.new(rollback, fake_session, {})
self.assertEqual(db_args[0], self.topic.topic, "Wrong DB topic")
self.assertEqual(did2, did, "Wrong DB NSD id")
self.assertIsNotNone(db_args[1]["_admin"]["created"], "Wrong creation time")
- self.assertEqual(db_args[1]["_admin"]["modified"], db_args[1]["_admin"]["created"],
- "Wrong modification time")
- self.assertEqual(db_args[1]["_admin"]["projects_read"], [test_pid], "Wrong read-only project list")
- self.assertEqual(db_args[1]["_admin"]["projects_write"], [test_pid], "Wrong read-write project list")
+ self.assertEqual(
+ db_args[1]["_admin"]["modified"],
+ db_args[1]["_admin"]["created"],
+ "Wrong modification time",
+ )
+ self.assertEqual(
+ db_args[1]["_admin"]["projects_read"],
+ [test_pid],
+ "Wrong read-only project list",
+ )
+ self.assertEqual(
+ db_args[1]["_admin"]["projects_write"],
+ [test_pid],
+ "Wrong read-write project list",
+ )
try:
- self.db.get_one.side_effect = [{"_id": did, "_admin": db_nsd_content["_admin"]}, None]
+ self.db.get_one.side_effect = [
+ {"_id": did, "_admin": db_nsd_content["_admin"]},
+ None,
+ ]
self.db.get_list.return_value = [db_vnfd_content]
- self.topic.upload_content(fake_session, did, test_nsd, {}, {"Content-Type": []})
+ self.topic.upload_content(
+ fake_session, did, test_nsd, {}, {"Content-Type": []}
+ )
msg_args = self.msg.write.call_args[0]
test_nsd["_id"] = did
- self.assertEqual(msg_args[0], self.topic.topic_msg, "Wrong message topic")
+ self.assertEqual(
+ msg_args[0], self.topic.topic_msg, "Wrong message topic"
+ )
self.assertEqual(msg_args[1], "edited", "Wrong message action")
self.assertEqual(msg_args[2], test_nsd, "Wrong message content")
db_args = self.db.get_one.mock_calls[0][1]
self.assertEqual(db_args[1], did, "Wrong DB NSD id")
admin = db_args[2]["_admin"]
db_admin = db_nsd_content["_admin"]
- self.assertEqual(admin["created"], db_admin["created"], "Wrong creation time")
- self.assertGreater(admin["modified"], db_admin["created"], "Wrong modification time")
- self.assertEqual(admin["projects_read"], db_admin["projects_read"], "Wrong read-only project list")
- self.assertEqual(admin["projects_write"], db_admin["projects_write"], "Wrong read-write project list")
- self.assertEqual(admin["onboardingState"], "ONBOARDED", "Wrong onboarding state")
- self.assertEqual(admin["operationalState"], "ENABLED", "Wrong operational state")
+ self.assertEqual(
+ admin["created"], db_admin["created"], "Wrong creation time"
+ )
+ self.assertGreater(
+ admin["modified"], db_admin["created"], "Wrong modification time"
+ )
+ self.assertEqual(
+ admin["projects_read"],
+ db_admin["projects_read"],
+ "Wrong read-only project list",
+ )
+ self.assertEqual(
+ admin["projects_write"],
+ db_admin["projects_write"],
+ "Wrong read-write project list",
+ )
+ self.assertEqual(
+ admin["onboardingState"], "ONBOARDED", "Wrong onboarding state"
+ )
+ self.assertEqual(
+ admin["operationalState"], "ENABLED", "Wrong operational state"
+ )
self.assertEqual(admin["usageState"], "NOT_IN_USE", "Wrong usage state")
storage = admin["storage"]
self.assertEqual(storage["folder"], did, "Wrong storage folder")
- self.assertEqual(storage["descriptor"], "package", "Wrong storage descriptor")
+ self.assertEqual(
+ storage["descriptor"], "package", "Wrong storage descriptor"
+ )
compare_desc(self, test_nsd, db_args[2], "NSD")
finally:
pass
- self.db.get_one.side_effect = lambda table, filter, fail_on_empty=None, fail_on_more=None: \
- {"_id": did, "_admin": db_nsd_content["_admin"]}
- with self.subTest(i=2, t='Check Pyangbind Validation: required properties'):
+ self.db.get_one.side_effect = (
+ lambda table, filter, fail_on_empty=None, fail_on_more=None: {
+ "_id": did,
+ "_admin": db_nsd_content["_admin"],
+ }
+ )
+ with self.subTest(i=2, t="Check Pyangbind Validation: required properties"):
tmp = test_nsd["id"]
del test_nsd["id"]
try:
- with self.assertRaises(EngineException, msg="Accepted NSD with a missing required property") as e:
- self.topic.upload_content(fake_session, did, test_nsd, {}, {"Content-Type": []})
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("Error in pyangbind validation: '{}'".format("id")),
- norm(str(e.exception)), "Wrong exception text")
+ with self.assertRaises(
+ EngineException, msg="Accepted NSD with a missing required property"
+ ) as e:
+ self.topic.upload_content(
+ fake_session, did, test_nsd, {}, {"Content-Type": []}
+ )
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm("Error in pyangbind validation: '{}'".format("id")),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
finally:
test_nsd["id"] = tmp
- with self.subTest(i=3, t='Check Pyangbind Validation: additional properties'):
+ with self.subTest(i=3, t="Check Pyangbind Validation: additional properties"):
test_nsd["extra-property"] = 0
try:
- with self.assertRaises(EngineException, msg="Accepted NSD with an additional property") as e:
- self.topic.upload_content(fake_session, did, test_nsd, {}, {"Content-Type": []})
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("Error in pyangbind validation: {} ({})"
- .format("json object contained a key that did not exist", "extra-property")),
- norm(str(e.exception)), "Wrong exception text")
+ with self.assertRaises(
+ EngineException, msg="Accepted NSD with an additional property"
+ ) as e:
+ self.topic.upload_content(
+ fake_session, did, test_nsd, {}, {"Content-Type": []}
+ )
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "Error in pyangbind validation: {} ({})".format(
+ "json object contained a key that did not exist",
+ "extra-property",
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
finally:
del test_nsd["extra-property"]
- with self.subTest(i=4, t='Check Pyangbind Validation: property types'):
+ with self.subTest(i=4, t="Check Pyangbind Validation: property types"):
tmp = test_nsd["designer"]
test_nsd["designer"] = {"key": 0}
try:
- with self.assertRaises(EngineException, msg="Accepted NSD with a wrongly typed property") as e:
- self.topic.upload_content(fake_session, did, test_nsd, {}, {"Content-Type": []})
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("Error in pyangbind validation: {} ({})"
- .format("json object contained a key that did not exist", "key")),
- norm(str(e.exception)), "Wrong exception text")
+ with self.assertRaises(
+ EngineException, msg="Accepted NSD with a wrongly typed property"
+ ) as e:
+ self.topic.upload_content(
+ fake_session, did, test_nsd, {}, {"Content-Type": []}
+ )
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "Error in pyangbind validation: {} ({})".format(
+ "json object contained a key that did not exist", "key"
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
finally:
test_nsd["designer"] = tmp
- with self.subTest(i=5, t='Check Input Validation: mgmt-network+virtual-link-protocol-data'):
- df = test_nsd['df'][0]
- mgmt_profile = {'id': 'id', 'virtual-link-desc-id': 'mgmt',
- 'virtual-link-protocol-data': {'associated-layer-protocol': 'ipv4'}}
- df['virtual-link-profile'] = [mgmt_profile]
+ with self.subTest(
+ i=5, t="Check Input Validation: mgmt-network+virtual-link-protocol-data"
+ ):
+ df = test_nsd["df"][0]
+ mgmt_profile = {
+ "id": "id",
+ "virtual-link-desc-id": "mgmt",
+ "virtual-link-protocol-data": {"associated-layer-protocol": "ipv4"},
+ }
+ df["virtual-link-profile"] = [mgmt_profile]
try:
- with self.assertRaises(EngineException, msg="Accepted VLD with mgmt-network+ip-profile") as e:
- self.topic.upload_content(fake_session, did, test_nsd, {}, {"Content-Type": []})
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("Error at df[id='{}']:virtual-link-profile[id='{}']:virtual-link-protocol-data"
- " You cannot set a virtual-link-protocol-data when mgmt-network is True"
- .format(df["id"], mgmt_profile["id"])),
- norm(str(e.exception)), "Wrong exception text")
+ with self.assertRaises(
+ EngineException, msg="Accepted VLD with mgmt-network+ip-profile"
+ ) as e:
+ self.topic.upload_content(
+ fake_session, did, test_nsd, {}, {"Content-Type": []}
+ )
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "Error at df[id='{}']:virtual-link-profile[id='{}']:virtual-link-protocol-data"
+ " You cannot set a virtual-link-protocol-data when mgmt-network is True".format(
+ df["id"], mgmt_profile["id"]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
finally:
- del df['virtual-link-profile']
- with self.subTest(i=6, t='Check Descriptor Dependencies: vnfd-id[]'):
- self.db.get_one.side_effect = [{"_id": did, "_admin": db_nsd_content["_admin"]}, None]
+ del df["virtual-link-profile"]
+ with self.subTest(i=6, t="Check Descriptor Dependencies: vnfd-id[]"):
+ self.db.get_one.side_effect = [
+ {"_id": did, "_admin": db_nsd_content["_admin"]},
+ None,
+ ]
self.db.get_list.return_value = []
try:
- with self.assertRaises(EngineException, msg="Accepted wrong VNFD ID reference") as e:
- self.topic.upload_content(fake_session, did, test_nsd, {}, {"Content-Type": []})
- self.assertEqual(e.exception.http_code, HTTPStatus.CONFLICT, "Wrong HTTP status code")
- self.assertIn(norm("'vnfd-id'='{}' references a non existing vnfd".format(test_nsd['vnfd-id'][0])),
- norm(str(e.exception)), "Wrong exception text")
+ with self.assertRaises(
+ EngineException, msg="Accepted wrong VNFD ID reference"
+ ) as e:
+ self.topic.upload_content(
+ fake_session, did, test_nsd, {}, {"Content-Type": []}
+ )
+ self.assertEqual(
+ e.exception.http_code, HTTPStatus.CONFLICT, "Wrong HTTP status code"
+ )
+ self.assertIn(
+ norm(
+ "'vnfd-id'='{}' references a non existing vnfd".format(
+ test_nsd["vnfd-id"][0]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
finally:
pass
- with self.subTest(i=7, t='Check Descriptor Dependencies: '
- 'vld[vnfd-connection-point-ref][vnfd-connection-point-ref]'):
+ with self.subTest(
+ i=7,
+ t="Check Descriptor Dependencies: "
+ "vld[vnfd-connection-point-ref][vnfd-connection-point-ref]",
+ ):
vnfd_descriptor = deepcopy(db_vnfd_content)
- df = test_nsd['df'][0]
- affected_vnf_profile = df['vnf-profile'][0]
- affected_virtual_link = affected_vnf_profile['virtual-link-connectivity'][1]
- affected_cpd = vnfd_descriptor['ext-cpd'].pop()
- self.db.get_one.side_effect = [{"_id": did, "_admin": db_nsd_content["_admin"]}, None]
+ df = test_nsd["df"][0]
+ affected_vnf_profile = df["vnf-profile"][0]
+ affected_virtual_link = affected_vnf_profile["virtual-link-connectivity"][1]
+ affected_cpd = vnfd_descriptor["ext-cpd"].pop()
+ self.db.get_one.side_effect = [
+ {"_id": did, "_admin": db_nsd_content["_admin"]},
+ None,
+ ]
self.db.get_list.return_value = [vnfd_descriptor]
try:
- with self.assertRaises(EngineException, msg="Accepted wrong VLD CP reference") as e:
- self.topic.upload_content(fake_session, did, test_nsd, {}, {"Content-Type": []})
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("Error at df[id='{}']:vnf-profile[id='{}']:virtual-link-connectivity"
- "[virtual-link-profile-id='{}']:constituent-cpd-id='{}' references a "
- "non existing ext-cpd:id inside vnfd '{}'"
- .format(df["id"], affected_vnf_profile["id"],
- affected_virtual_link["virtual-link-profile-id"], affected_cpd["id"],
- vnfd_descriptor["id"])),
- norm(str(e.exception)), "Wrong exception text")
+ with self.assertRaises(
+ EngineException, msg="Accepted wrong VLD CP reference"
+ ) as e:
+ self.topic.upload_content(
+ fake_session, did, test_nsd, {}, {"Content-Type": []}
+ )
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "Error at df[id='{}']:vnf-profile[id='{}']:virtual-link-connectivity"
+ "[virtual-link-profile-id='{}']:constituent-cpd-id='{}' references a "
+ "non existing ext-cpd:id inside vnfd '{}'".format(
+ df["id"],
+ affected_vnf_profile["id"],
+ affected_virtual_link["virtual-link-profile-id"],
+ affected_cpd["id"],
+ vnfd_descriptor["id"],
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
finally:
pass
return
did = nsd_content["_id"]
self.fs.file_exists.return_value = True
self.fs.dir_ls.return_value = True
- with self.subTest(i=1, t='Normal Edition'):
+ with self.subTest(i=1, t="Normal Edition"):
now = time()
self.db.get_one.side_effect = [deepcopy(nsd_content), None]
self.db.get_list.return_value = [db_vnfd_content]
self.assertEqual(msg_args[2], data, "Wrong message content")
self.assertEqual(db_args[0], self.topic.topic, "Wrong DB topic")
self.assertEqual(db_args[1], did, "Wrong DB ID")
- self.assertEqual(db_args[2]["_admin"]["created"], nsd_content["_admin"]["created"],
- "Wrong creation time")
- self.assertGreater(db_args[2]["_admin"]["modified"], now, "Wrong modification time")
- self.assertEqual(db_args[2]["_admin"]["projects_read"], nsd_content["_admin"]["projects_read"],
- "Wrong read-only project list")
- self.assertEqual(db_args[2]["_admin"]["projects_write"], nsd_content["_admin"]["projects_write"],
- "Wrong read-write project list")
+ self.assertEqual(
+ db_args[2]["_admin"]["created"],
+ nsd_content["_admin"]["created"],
+ "Wrong creation time",
+ )
+ self.assertGreater(
+ db_args[2]["_admin"]["modified"], now, "Wrong modification time"
+ )
+ self.assertEqual(
+ db_args[2]["_admin"]["projects_read"],
+ nsd_content["_admin"]["projects_read"],
+ "Wrong read-only project list",
+ )
+ self.assertEqual(
+ db_args[2]["_admin"]["projects_write"],
+ nsd_content["_admin"]["projects_write"],
+ "Wrong read-write project list",
+ )
self.assertEqual(db_args[2]["id"], data["id"], "Wrong NSD ID")
self.assertEqual(db_args[2]["name"], data["name"], "Wrong NSD Name")
- with self.subTest(i=2, t='Conflict on Edit'):
+ with self.subTest(i=2, t="Conflict on Edit"):
data = {"id": "fake-nsd-id", "name": "new-nsd-name"}
- self.db.get_one.side_effect = [nsd_content, {"_id": str(uuid4()), "id": data["id"]}]
- with self.assertRaises(EngineException, msg="Accepted existing NSD ID") as e:
+ self.db.get_one.side_effect = [
+ nsd_content,
+ {"_id": str(uuid4()), "id": data["id"]},
+ ]
+ with self.assertRaises(
+ EngineException, msg="Accepted existing NSD ID"
+ ) as e:
self.topic.edit(fake_session, did, data)
- self.assertEqual(e.exception.http_code, HTTPStatus.CONFLICT, "Wrong HTTP status code")
- self.assertIn(norm("{} with id '{}' already exists for this project".format("nsd", data["id"])),
- norm(str(e.exception)), "Wrong exception text")
- with self.subTest(i=3, t='Check Envelope'):
+ self.assertEqual(
+ e.exception.http_code, HTTPStatus.CONFLICT, "Wrong HTTP status code"
+ )
+ self.assertIn(
+ norm(
+ "{} with id '{}' already exists for this project".format(
+ "nsd", data["id"]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+ with self.subTest(i=3, t="Check Envelope"):
data = {"nsd": {"nsd": {"id": "new-nsd-id", "name": "new-nsd-name"}}}
self.db.get_one.side_effect = [nsd_content, None]
- with self.assertRaises(EngineException, msg="Accepted NSD with wrong envelope") as e:
+ with self.assertRaises(
+ EngineException, msg="Accepted NSD with wrong envelope"
+ ) as e:
self.topic.edit(fake_session, did, data, content=nsd_content)
- self.assertEqual(e.exception.http_code, HTTPStatus.BAD_REQUEST, "Wrong HTTP status code")
- self.assertIn("'nsd' must be a list of only one element", norm(str(e.exception)), "Wrong exception text")
+ self.assertEqual(
+ e.exception.http_code, HTTPStatus.BAD_REQUEST, "Wrong HTTP status code"
+ )
+ self.assertIn(
+ "'nsd' must be a list of only one element",
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
return
def test_delete_nsd(self):
did = db_nsd_content["_id"]
self.db.get_one.return_value = db_nsd_content
p_id = db_nsd_content["_admin"]["projects_read"][0]
- with self.subTest(i=1, t='Normal Deletion'):
+ with self.subTest(i=1, t="Normal Deletion"):
self.db.get_list.return_value = []
self.db.del_one.return_value = {"deleted": 1}
self.topic.delete(fake_session, did)
self.assertEqual(msg_args[2], {"_id": did}, "Wrong message content")
self.assertEqual(db_args[0], self.topic.topic, "Wrong DB topic")
self.assertEqual(db_args[1]["_id"], did, "Wrong DB ID")
- self.assertEqual(db_args[1]["_admin.projects_write.cont"], [p_id, 'ANY'], "Wrong DB filter")
+ self.assertEqual(
+ db_args[1]["_admin.projects_write.cont"],
+ [p_id, "ANY"],
+ "Wrong DB filter",
+ )
db_g1_args = self.db.get_one.call_args[0]
self.assertEqual(db_g1_args[0], self.topic.topic, "Wrong DB topic")
self.assertEqual(db_g1_args[1]["_id"], did, "Wrong DB NSD ID")
self.assertEqual(db_gl_calls[0][0][0], "nsrs", "Wrong DB topic")
# self.assertEqual(db_gl_calls[0][0][1]["nsd-id"], did, "Wrong DB NSD ID") # Filter changed after call
self.assertEqual(db_gl_calls[1][0][0], "nsts", "Wrong DB topic")
- self.assertEqual(db_gl_calls[1][0][1]["netslice-subnet.ANYINDEX.nsd-ref"], db_nsd_content["id"],
- "Wrong DB NSD netslice-subnet nsd-ref")
+ self.assertEqual(
+ db_gl_calls[1][0][1]["netslice-subnet.ANYINDEX.nsd-ref"],
+ db_nsd_content["id"],
+ "Wrong DB NSD netslice-subnet nsd-ref",
+ )
self.db.set_one.assert_not_called()
fs_del_calls = self.fs.file_delete.call_args_list
self.assertEqual(fs_del_calls[0][0][0], did, "Wrong FS file id")
- self.assertEqual(fs_del_calls[1][0][0], did + '_', "Wrong FS folder id")
- with self.subTest(i=2, t='Conflict on Delete - NSD in use by nsr'):
+ self.assertEqual(fs_del_calls[1][0][0], did + "_", "Wrong FS folder id")
+ with self.subTest(i=2, t="Conflict on Delete - NSD in use by nsr"):
self.db.get_list.return_value = [{"_id": str(uuid4()), "name": "fake-nsr"}]
- with self.assertRaises(EngineException, msg="Accepted NSD in use by NSR") as e:
+ with self.assertRaises(
+ EngineException, msg="Accepted NSD in use by NSR"
+ ) as e:
self.topic.delete(fake_session, did)
- self.assertEqual(e.exception.http_code, HTTPStatus.CONFLICT, "Wrong HTTP status code")
- self.assertIn("there is at least one ns instance using this descriptor", norm(str(e.exception)),
- "Wrong exception text")
- with self.subTest(i=3, t='Conflict on Delete - NSD in use by NST'):
- self.db.get_list.side_effect = [[], [{"_id": str(uuid4()), "name": "fake-nst"}]]
- with self.assertRaises(EngineException, msg="Accepted NSD in use by NST") as e:
+ self.assertEqual(
+ e.exception.http_code, HTTPStatus.CONFLICT, "Wrong HTTP status code"
+ )
+ self.assertIn(
+ "there is at least one ns instance using this descriptor",
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+ with self.subTest(i=3, t="Conflict on Delete - NSD in use by NST"):
+ self.db.get_list.side_effect = [
+ [],
+ [{"_id": str(uuid4()), "name": "fake-nst"}],
+ ]
+ with self.assertRaises(
+ EngineException, msg="Accepted NSD in use by NST"
+ ) as e:
self.topic.delete(fake_session, did)
- self.assertEqual(e.exception.http_code, HTTPStatus.CONFLICT, "Wrong HTTP status code")
- self.assertIn("there is at least one netslice template referencing this descriptor", norm(str(e.exception)),
- "Wrong exception text")
- with self.subTest(i=4, t='Non-existent NSD'):
+ self.assertEqual(
+ e.exception.http_code, HTTPStatus.CONFLICT, "Wrong HTTP status code"
+ )
+ self.assertIn(
+ "there is at least one netslice template referencing this descriptor",
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+ with self.subTest(i=4, t="Non-existent NSD"):
excp_msg = "Not found any {} with filter='{}'".format("NSD", {"_id": did})
self.db.get_one.side_effect = DbException(excp_msg, HTTPStatus.NOT_FOUND)
- with self.assertRaises(DbException, msg="Accepted non-existent NSD ID") as e:
+ with self.assertRaises(
+ DbException, msg="Accepted non-existent NSD ID"
+ ) as e:
self.topic.delete(fake_session, did)
- self.assertEqual(e.exception.http_code, HTTPStatus.NOT_FOUND, "Wrong HTTP status code")
- self.assertIn(norm(excp_msg), norm(str(e.exception)), "Wrong exception text")
- with self.subTest(i=5, t='No delete because referenced by other project'):
+ self.assertEqual(
+ e.exception.http_code, HTTPStatus.NOT_FOUND, "Wrong HTTP status code"
+ )
+ self.assertIn(
+ norm(excp_msg), norm(str(e.exception)), "Wrong exception text"
+ )
+ with self.subTest(i=5, t="No delete because referenced by other project"):
db_nsd_content["_admin"]["projects_read"].append("other_project")
self.db.get_one = Mock(return_value=db_nsd_content)
self.db.get_list = Mock(return_value=[])
db_s1_args = self.db.set_one.call_args
self.assertEqual(db_s1_args[0][0], self.topic.topic, "Wrong DB topic")
self.assertEqual(db_s1_args[0][1]["_id"], did, "Wrong DB ID")
- self.assertIn(p_id, db_s1_args[0][1]["_admin.projects_write.cont"], "Wrong DB filter")
- self.assertIsNone(db_s1_args[1]["update_dict"], "Wrong DB update dictionary")
- self.assertEqual(db_s1_args[1]["pull_list"],
- {"_admin.projects_read": (p_id,), "_admin.projects_write": (p_id,)},
- "Wrong DB pull_list dictionary")
+ self.assertIn(
+ p_id, db_s1_args[0][1]["_admin.projects_write.cont"], "Wrong DB filter"
+ )
+ self.assertIsNone(
+ db_s1_args[1]["update_dict"], "Wrong DB update dictionary"
+ )
+ self.assertEqual(
+ db_s1_args[1]["pull_list"],
+ {"_admin.projects_read": (p_id,), "_admin.projects_write": (p_id,)},
+ "Wrong DB pull_list dictionary",
+ )
self.fs.file_delete.assert_not_called()
return
- def test_validate_vld_mgmt_network_with_virtual_link_protocol_data_on_valid_descriptor(self):
+ def test_validate_vld_mgmt_network_with_virtual_link_protocol_data_on_valid_descriptor(
+ self,
+ ):
indata = deepcopy(db_nsd_content)
- vld = indata['virtual-link-desc'][0]
- self.topic.validate_vld_mgmt_network_with_virtual_link_protocol_data(vld, indata)
+ vld = indata["virtual-link-desc"][0]
+ self.topic.validate_vld_mgmt_network_with_virtual_link_protocol_data(
+ vld, indata
+ )
- def test_validate_vld_mgmt_network_with_virtual_link_protocol_data_when_both_defined(self):
+ def test_validate_vld_mgmt_network_with_virtual_link_protocol_data_when_both_defined(
+ self,
+ ):
indata = deepcopy(db_nsd_content)
- vld = indata['virtual-link-desc'][0]
- df = indata['df'][0]
- affected_vlp = {'id': 'id', 'virtual-link-desc-id': 'mgmt',
- 'virtual-link-protocol-data': {'associated-layer-protocol': 'ipv4'}}
- df['virtual-link-profile'] = [affected_vlp]
+ vld = indata["virtual-link-desc"][0]
+ df = indata["df"][0]
+ affected_vlp = {
+ "id": "id",
+ "virtual-link-desc-id": "mgmt",
+ "virtual-link-protocol-data": {"associated-layer-protocol": "ipv4"},
+ }
+ df["virtual-link-profile"] = [affected_vlp]
with self.assertRaises(EngineException) as e:
- self.topic.validate_vld_mgmt_network_with_virtual_link_protocol_data(vld, indata)
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("Error at df[id='{}']:virtual-link-profile[id='{}']:virtual-link-protocol-data"
- " You cannot set a virtual-link-protocol-data when mgmt-network is True"
- .format(df["id"], affected_vlp["id"])),
- norm(str(e.exception)), "Wrong exception text")
+ self.topic.validate_vld_mgmt_network_with_virtual_link_protocol_data(
+ vld, indata
+ )
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "Error at df[id='{}']:virtual-link-profile[id='{}']:virtual-link-protocol-data"
+ " You cannot set a virtual-link-protocol-data when mgmt-network is True".format(
+ df["id"], affected_vlp["id"]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
def test_validate_vnf_profiles_vnfd_id_on_valid_descriptor(self):
indata = deepcopy(db_nsd_content)
def test_validate_vnf_profiles_vnfd_id_when_missing_vnfd(self):
indata = deepcopy(db_nsd_content)
- df = indata['df'][0]
- affected_vnf_profile = df['vnf-profile'][0]
- indata['vnfd-id'] = ['non-existing-vnfd']
+ df = indata["df"][0]
+ affected_vnf_profile = df["vnf-profile"][0]
+ indata["vnfd-id"] = ["non-existing-vnfd"]
with self.assertRaises(EngineException) as e:
self.topic.validate_vnf_profiles_vnfd_id(indata)
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("Error at df[id='{}']:vnf_profile[id='{}']:vnfd-id='{}' "
- "does not match any vnfd-id"
- .format(df["id"], affected_vnf_profile["id"], affected_vnf_profile['vnfd-id'])),
- norm(str(e.exception)), "Wrong exception text")
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "Error at df[id='{}']:vnf_profile[id='{}']:vnfd-id='{}' "
+ "does not match any vnfd-id".format(
+ df["id"],
+ affected_vnf_profile["id"],
+ affected_vnf_profile["vnfd-id"],
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
- def test_validate_df_vnf_profiles_constituent_connection_points_on_valid_descriptor(self):
+ def test_validate_df_vnf_profiles_constituent_connection_points_on_valid_descriptor(
+ self,
+ ):
nsd_descriptor = deepcopy(db_nsd_content)
vnfd_descriptor = deepcopy(db_vnfd_content)
- df = nsd_descriptor['df'][0]
- vnfds_index = {vnfd_descriptor['id']: vnfd_descriptor}
- self.topic.validate_df_vnf_profiles_constituent_connection_points(df, vnfds_index)
+ df = nsd_descriptor["df"][0]
+ vnfds_index = {vnfd_descriptor["id"]: vnfd_descriptor}
+ self.topic.validate_df_vnf_profiles_constituent_connection_points(
+ df, vnfds_index
+ )
- def test_validate_df_vnf_profiles_constituent_connection_points_when_missing_connection_point(self):
+ def test_validate_df_vnf_profiles_constituent_connection_points_when_missing_connection_point(
+ self,
+ ):
nsd_descriptor = deepcopy(db_nsd_content)
vnfd_descriptor = deepcopy(db_vnfd_content)
- df = nsd_descriptor['df'][0]
- affected_vnf_profile = df['vnf-profile'][0]
- affected_virtual_link = affected_vnf_profile['virtual-link-connectivity'][1]
- vnfds_index = {vnfd_descriptor['id']: vnfd_descriptor}
- affected_cpd = vnfd_descriptor['ext-cpd'].pop()
+ df = nsd_descriptor["df"][0]
+ affected_vnf_profile = df["vnf-profile"][0]
+ affected_virtual_link = affected_vnf_profile["virtual-link-connectivity"][1]
+ vnfds_index = {vnfd_descriptor["id"]: vnfd_descriptor}
+ affected_cpd = vnfd_descriptor["ext-cpd"].pop()
with self.assertRaises(EngineException) as e:
- self.topic.validate_df_vnf_profiles_constituent_connection_points(df, vnfds_index)
- self.assertEqual(e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, "Wrong HTTP status code")
- self.assertIn(norm("Error at df[id='{}']:vnf-profile[id='{}']:virtual-link-connectivity"
- "[virtual-link-profile-id='{}']:constituent-cpd-id='{}' references a "
- "non existing ext-cpd:id inside vnfd '{}'"
- .format(df["id"], affected_vnf_profile["id"],
- affected_virtual_link["virtual-link-profile-id"], affected_cpd["id"],
- vnfd_descriptor["id"])),
- norm(str(e.exception)), "Wrong exception text")
+ self.topic.validate_df_vnf_profiles_constituent_connection_points(
+ df, vnfds_index
+ )
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "Error at df[id='{}']:vnf-profile[id='{}']:virtual-link-connectivity"
+ "[virtual-link-profile-id='{}']:constituent-cpd-id='{}' references a "
+ "non existing ext-cpd:id inside vnfd '{}'".format(
+ df["id"],
+ affected_vnf_profile["id"],
+ affected_virtual_link["virtual-link-profile-id"],
+ affected_cpd["id"],
+ vnfd_descriptor["id"],
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
def test_check_conflict_on_edit_when_missing_constituent_vnfd_id(self):
nsd_descriptor = deepcopy(db_nsd_content)
- invalid_vnfd_id = 'invalid-vnfd-id'
- nsd_descriptor['id'] = 'invalid-vnfd-id-ns'
- nsd_descriptor['vnfd-id'][0] = invalid_vnfd_id
- nsd_descriptor['df'][0]['vnf-profile'][0]['vnfd-id'] = invalid_vnfd_id
- nsd_descriptor['df'][0]['vnf-profile'][1]['vnfd-id'] = invalid_vnfd_id
+ invalid_vnfd_id = "invalid-vnfd-id"
+ nsd_descriptor["id"] = "invalid-vnfd-id-ns"
+ nsd_descriptor["vnfd-id"][0] = invalid_vnfd_id
+ nsd_descriptor["df"][0]["vnf-profile"][0]["vnfd-id"] = invalid_vnfd_id
+ nsd_descriptor["df"][0]["vnf-profile"][1]["vnfd-id"] = invalid_vnfd_id
with self.assertRaises(EngineException) as e:
self.db.get_list.return_value = []
- nsd_descriptor = self.topic.check_conflict_on_edit(fake_session, nsd_descriptor, [], 'id')
- self.assertEqual(e.exception.http_code, HTTPStatus.CONFLICT, "Wrong HTTP status code")
- self.assertIn(norm("Descriptor error at 'vnfd-id'='{}' references a non "
- "existing vnfd".format(invalid_vnfd_id)),
- norm(str(e.exception)), "Wrong exception text")
+ nsd_descriptor = self.topic.check_conflict_on_edit(
+ fake_session, nsd_descriptor, [], "id"
+ )
+ self.assertEqual(
+ e.exception.http_code, HTTPStatus.CONFLICT, "Wrong HTTP status code"
+ )
+ self.assertIn(
+ norm(
+ "Descriptor error at 'vnfd-id'='{}' references a non "
+ "existing vnfd".format(invalid_vnfd_id)
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
-if __name__ == '__main__':
+if __name__ == "__main__":
unittest.main()
projects / osm / NBI.git / blobdiff