X-Git-Url: https://osm.etsi.org/gitweb/?p=osm%2FN2VC.git;a=blobdiff_plain;f=n2vc%2Ftests%2Funit%2Ftest_k8s_helm3_conn.py;h=91e1729a5ba404dd10a06f3b1e67d10785b7337e;hp=c175b7a0538cf8da4f8f15fffae5233de2b607a5;hb=a8980cc3f6508f2659dc4ba4fcbeed65ba3c8e95;hpb=82b591ceed704c798ead2d9104085a08e75b511b diff --git a/n2vc/tests/unit/test_k8s_helm3_conn.py b/n2vc/tests/unit/test_k8s_helm3_conn.py index c175b7a..91e1729 100644 --- a/n2vc/tests/unit/test_k8s_helm3_conn.py +++ b/n2vc/tests/unit/test_k8s_helm3_conn.py @@ -18,10 +18,10 @@ import asynctest import logging -from asynctest.mock import Mock +from asynctest.mock import Mock, patch from osm_common.dbmemory import DbMemory from osm_common.fslocal import FsLocal -from n2vc.k8s_helm3_conn import K8sHelm3Connector +from n2vc.k8s_helm3_conn import K8sHelm3Connector, K8sException __author__ = "Isabel Lloret " @@ -31,13 +31,15 @@ class TestK8sHelm3Conn(asynctest.TestCase): logger = logging.getLogger(__name__) logger.setLevel(logging.DEBUG) - async def setUp(self): + @patch("n2vc.k8s_helm_base_conn.EnvironConfig") + async def setUp(self, mock_env): + mock_env.return_value = {"stablerepourl": "https://charts.helm.sh/stable"} self.db = Mock(DbMemory()) self.fs = asynctest.Mock(FsLocal()) self.fs.path = "./tmp/" self.namespace = "testk8s" self.cluster_id = "helm3_cluster_id" - self.cluster_uuid = "{}:{}".format(self.namespace, self.cluster_id) + self.cluster_uuid = self.cluster_id # pass fake kubectl and helm commands to make sure it does not call actual commands K8sHelm3Connector._check_file_exists = asynctest.Mock(return_value=True) cluster_dir = self.fs.path + self.cluster_id @@ -64,8 +66,8 @@ class TestK8sHelm3Conn(asynctest.TestCase): self.assertEqual( k8scluster_uuid, - "{}:{}".format(self.namespace, self.cluster_id), - "Check cluster_uuid format: .", + self.cluster_id, + "Check cluster_uuid", ) self.helm_conn._get_namespaces.assert_called_once_with(self.cluster_id) self.helm_conn._create_namespace.assert_called_once_with( @@ -100,8 +102,10 @@ class TestK8sHelm3Conn(asynctest.TestCase): ), ) - repo_update_command = "/usr/bin/helm3 repo update" - repo_add_command = "/usr/bin/helm3 repo add {} {}".format(repo_name, repo_url) + repo_update_command = "env KUBECONFIG=./tmp/helm3_cluster_id/.kube/config /usr/bin/helm3 repo update" + repo_add_command = ( + "env KUBECONFIG=./tmp/helm3_cluster_id/.kube/config /usr/bin/helm3 repo add {} {}" + ).format(repo_name, repo_url) calls = self.helm_conn._local_async_exec.call_args_list call0_kargs = calls[0][1] self.assertEqual( @@ -137,7 +141,7 @@ class TestK8sHelm3Conn(asynctest.TestCase): self.helm_conn.fs.reverse_sync.assert_called_once_with( from_path=self.cluster_id ) - command = "/usr/bin/helm3 repo list --output yaml" + command = "env KUBECONFIG=./tmp/helm3_cluster_id/.kube/config /usr/bin/helm3 repo list --output yaml" self.helm_conn._local_async_exec.assert_called_with( command=command, env=self.env, raise_exception_on_error=False ) @@ -153,7 +157,9 @@ class TestK8sHelm3Conn(asynctest.TestCase): self.helm_conn.fs.reverse_sync.assert_called_once_with( from_path=self.cluster_id ) - command = "/usr/bin/helm3 repo remove {}".format(repo_name) + command = "env KUBECONFIG=./tmp/helm3_cluster_id/.kube/config /usr/bin/helm3 repo remove {}".format( + repo_name + ) self.helm_conn._local_async_exec.assert_called_with( command=command, env=self.env, raise_exception_on_error=True ) @@ -169,6 +175,9 @@ class TestK8sHelm3Conn(asynctest.TestCase): self.kdu_instance = "stable-openldap-0005399828" self.helm_conn.generate_kdu_instance_name = Mock(return_value=self.kdu_instance) self.helm_conn._get_namespaces = asynctest.CoroutineMock(return_value=[]) + self.helm_conn._namespace_exists = asynctest.CoroutineMock( + side_effect=self.helm_conn._namespace_exists + ) self.helm_conn._create_namespace = asynctest.CoroutineMock() await self.helm_conn.install( @@ -180,6 +189,7 @@ class TestK8sHelm3Conn(asynctest.TestCase): db_dict=db_dict, ) + self.helm_conn._namespace_exists.assert_called_once() self.helm_conn._get_namespaces.assert_called_once() self.helm_conn._create_namespace.assert_called_once_with( self.cluster_id, self.namespace @@ -198,13 +208,44 @@ class TestK8sHelm3Conn(asynctest.TestCase): check_every=0, ) command = ( - "/usr/bin/helm3 install stable-openldap-0005399828 --atomic --output yaml " + "env KUBECONFIG=./tmp/helm3_cluster_id/.kube/config /usr/bin/helm3 " + "install stable-openldap-0005399828 --atomic --output yaml " "--timeout 300s --namespace testk8s stable/openldap --version 1.2.2" ) self.helm_conn._local_async_exec.assert_called_once_with( command=command, env=self.env, raise_exception_on_error=False ) + # Exception test if namespace could not being created for some reason + self.helm_conn._namespace_exists.return_value = False + self.helm_conn._create_namespace.side_effect = Exception() + + with self.assertRaises(K8sException): + await self.helm_conn.install( + self.cluster_uuid, + kdu_model, + self.kdu_instance, + atomic=True, + namespace=self.namespace, + db_dict=db_dict, + ) + + @asynctest.fail_on(active_handles=True) + async def test_namespace_exists(self): + self.helm_conn._get_namespaces = asynctest.CoroutineMock() + + self.helm_conn._get_namespaces.return_value = ["testk8s", "kube-system"] + result = await self.helm_conn._namespace_exists(self.cluster_id, self.namespace) + self.helm_conn._get_namespaces.assert_called_once() + self.assertEqual(result, True) + + self.helm_conn._get_namespaces.reset_mock() + result = await self.helm_conn._namespace_exists( + self.cluster_id, "none-exists-namespace" + ) + self.helm_conn._get_namespaces.assert_called_once() + self.assertEqual(result, False) + @asynctest.fail_on(active_handles=True) async def test_upgrade(self): kdu_model = "stable/openldap:1.2.3" @@ -226,7 +267,7 @@ class TestK8sHelm3Conn(asynctest.TestCase): await self.helm_conn.upgrade( self.cluster_uuid, kdu_instance, kdu_model, atomic=True, db_dict=db_dict ) - self.helm_conn.fs.sync.assert_called_once_with(from_path=self.cluster_id) + self.helm_conn.fs.sync.assert_called_with(from_path=self.cluster_id) self.helm_conn.fs.reverse_sync.assert_called_once_with( from_path=self.cluster_id ) @@ -240,14 +281,100 @@ class TestK8sHelm3Conn(asynctest.TestCase): check_every=0, ) command = ( + "env KUBECONFIG=./tmp/helm3_cluster_id/.kube/config " "/usr/bin/helm3 upgrade stable-openldap-0005399828 stable/openldap " - "--namespace testk8s --atomic --output yaml --timeout 300s " + "--namespace testk8s --atomic --output yaml --timeout 300s " "--version 1.2.3" ) self.helm_conn._local_async_exec.assert_called_once_with( command=command, env=self.env, raise_exception_on_error=False ) + @asynctest.fail_on(active_handles=True) + async def test_scale(self): + kdu_model = "stable/openldap:1.2.3" + kdu_instance = "stable-openldap-0005399828" + db_dict = {} + instance_info = { + "chart": "openldap-1.2.3", + "name": kdu_instance, + "namespace": self.namespace, + "revision": 1, + "status": "DEPLOYED", + } + repo_list = [ + { + "name": "stable", + "url": "https://kubernetes-charts.storage.googleapis.com/", + } + ] + kdu_values = """ + # Default values for openldap. + # This is a YAML-formatted file. + # Declare variables to be passed into your templates. + + replicaCount: 1 + dummy-app: + replicas: 2 + """ + + self.helm_conn.repo_list = asynctest.CoroutineMock(return_value=repo_list) + self.helm_conn.values_kdu = asynctest.CoroutineMock(return_value=kdu_values) + self.helm_conn._local_async_exec = asynctest.CoroutineMock(return_value=("", 0)) + self.helm_conn._store_status = asynctest.CoroutineMock() + self.helm_conn.get_instance_info = asynctest.CoroutineMock( + return_value=instance_info + ) + + # TEST-1 + await self.helm_conn.scale( + kdu_instance, + 2, + "", + kdu_model=kdu_model, + cluster_uuid=self.cluster_uuid, + atomic=True, + db_dict=db_dict, + ) + command = ( + "env KUBECONFIG=./tmp/helm3_cluster_id/.kube/config " + "/usr/bin/helm3 upgrade stable-openldap-0005399828 stable/openldap " + "--namespace testk8s --atomic --output yaml --set replicaCount=2 --timeout 1800s " + "--version 1.2.3" + ) + self.helm_conn._local_async_exec.assert_called_once_with( + command=command, env=self.env, raise_exception_on_error=False + ) + # TEST-2 + await self.helm_conn.scale( + kdu_instance, + 3, + "dummy-app", + kdu_model=kdu_model, + cluster_uuid=self.cluster_uuid, + atomic=True, + db_dict=db_dict, + ) + command = ( + "env KUBECONFIG=./tmp/helm3_cluster_id/.kube/config " + "/usr/bin/helm3 upgrade stable-openldap-0005399828 stable/openldap " + "--namespace testk8s --atomic --output yaml --set dummy-app.replicas=3 --timeout 1800s " + "--version 1.2.3" + ) + self.helm_conn._local_async_exec.assert_called_with( + command=command, env=self.env, raise_exception_on_error=False + ) + self.helm_conn.fs.reverse_sync.assert_called_with(from_path=self.cluster_id) + self.helm_conn._store_status.assert_called_with( + cluster_id=self.cluster_id, + kdu_instance=kdu_instance, + namespace=self.namespace, + db_dict=db_dict, + operation="scale", + run_once=True, + check_every=0, + ) + @asynctest.fail_on(active_handles=True) async def test_rollback(self): kdu_instance = "stable-openldap-0005399828" @@ -268,7 +395,7 @@ class TestK8sHelm3Conn(asynctest.TestCase): await self.helm_conn.rollback( self.cluster_uuid, kdu_instance=kdu_instance, revision=1, db_dict=db_dict ) - self.helm_conn.fs.sync.assert_called_once_with(from_path=self.cluster_id) + self.helm_conn.fs.sync.assert_called_with(from_path=self.cluster_id) self.helm_conn.fs.reverse_sync.assert_called_once_with( from_path=self.cluster_id ) @@ -281,7 +408,10 @@ class TestK8sHelm3Conn(asynctest.TestCase): run_once=True, check_every=0, ) - command = "/usr/bin/helm3 rollback stable-openldap-0005399828 1 --namespace=testk8s --wait" + command = ( + "env KUBECONFIG=./tmp/helm3_cluster_id/.kube/config /usr/bin/helm3 " + "rollback stable-openldap-0005399828 1 --namespace=testk8s --wait" + ) self.helm_conn._local_async_exec.assert_called_once_with( command=command, env=self.env, raise_exception_on_error=False ) @@ -303,13 +433,13 @@ class TestK8sHelm3Conn(asynctest.TestCase): ) await self.helm_conn.uninstall(self.cluster_uuid, kdu_instance) - self.helm_conn.fs.sync.assert_called_once_with(from_path=self.cluster_id) + self.helm_conn.fs.sync.assert_called_with(from_path=self.cluster_id) self.helm_conn.fs.reverse_sync.assert_called_once_with( from_path=self.cluster_id ) - command = "/usr/bin/helm3 uninstall {} --namespace={}".format( - kdu_instance, self.namespace - ) + command = ( + "env KUBECONFIG=./tmp/helm3_cluster_id/.kube/config /usr/bin/helm3 uninstall {} --namespace={}" + ).format(kdu_instance, self.namespace) self.helm_conn._local_async_exec.assert_called_once_with( command=command, env=self.env, raise_exception_on_error=True ) @@ -332,9 +462,9 @@ class TestK8sHelm3Conn(asynctest.TestCase): from_path=self.cluster_id ) self.helm_conn._parse_services.assert_called_once() - command1 = "/usr/bin/helm3 get manifest {} --namespace=testk8s".format( - kdu_instance - ) + command1 = ( + "env KUBECONFIG=./tmp/helm3_cluster_id/.kube/config /usr/bin/helm3 get manifest {} --namespace=testk8s" + ).format(kdu_instance) command2 = "/usr/bin/kubectl get --namespace={} -f -".format(self.namespace) self.helm_conn._local_async_exec_pipe.assert_called_once_with( command1, command2, env=self.env, raise_exception_on_error=True @@ -377,9 +507,7 @@ class TestK8sHelm3Conn(asynctest.TestCase): "https://kubernetes-charts.storage.googleapis.com/ " "--version 1.2.4" ) - self.helm_conn._local_async_exec.assert_called_with( - command=command, encode_utf8=True - ) + self.helm_conn._local_async_exec.assert_called_with(command=command) @asynctest.fail_on(active_handles=True) async def test_help_kdu(self): @@ -394,9 +522,7 @@ class TestK8sHelm3Conn(asynctest.TestCase): "https://kubernetes-charts.storage.googleapis.com/ " "--version 1.2.4" ) - self.helm_conn._local_async_exec.assert_called_with( - command=command, encode_utf8=True - ) + self.helm_conn._local_async_exec.assert_called_with(command=command) @asynctest.fail_on(active_handles=True) async def test_values_kdu(self): @@ -411,9 +537,22 @@ class TestK8sHelm3Conn(asynctest.TestCase): "https://kubernetes-charts.storage.googleapis.com/ " "--version 1.2.4" ) - self.helm_conn._local_async_exec.assert_called_with( - command=command, encode_utf8=True + self.helm_conn._local_async_exec.assert_called_with(command=command) + + @asynctest.fail_on(active_handles=True) + async def test_get_values_kdu(self): + self.helm_conn._local_async_exec = asynctest.CoroutineMock(return_value=("", 0)) + + kdu_instance = "stable-openldap-0005399828" + await self.helm_conn.get_values_kdu( + kdu_instance, self.namespace, self.env["KUBECONFIG"] + ) + + command = ( + "env KUBECONFIG=./tmp/helm3_cluster_id/.kube/config /usr/bin/helm3 get values " + "stable-openldap-0005399828 --namespace=testk8s --output yaml" ) + self.helm_conn._local_async_exec.assert_called_with(command=command) @asynctest.fail_on(active_handles=True) async def test_instances_list(self): @@ -435,11 +574,11 @@ class TestK8sHelm3Conn(asynctest.TestCase): self.helm_conn._local_async_exec = asynctest.CoroutineMock(return_value=("", 0)) await self.helm_conn._status_kdu( - self.cluster_id, kdu_instance, self.namespace, return_text=True - ) - command = "/usr/bin/helm3 status {} --namespace={} --output yaml".format( - kdu_instance, self.namespace + self.cluster_id, kdu_instance, self.namespace, yaml_format=True ) + command = ( + "env KUBECONFIG=./tmp/helm3_cluster_id/.kube/config /usr/bin/helm3 status {} --namespace={} --output yaml" + ).format(kdu_instance, self.namespace) self.helm_conn._local_async_exec.assert_called_once_with( command=command, env=self.env, @@ -478,7 +617,7 @@ class TestK8sHelm3Conn(asynctest.TestCase): cluster_id=self.cluster_id, kdu_instance=kdu_instance, namespace=self.namespace, - return_text=False, + yaml_format=False, ) self.helm_conn.write_app_status_to_db.assert_called_once_with( db_dict=db_dict, @@ -512,6 +651,7 @@ class TestK8sHelm3Conn(asynctest.TestCase): "updated": "2020-10-30 11:11:20.376744191 +0000 UTC", } ] + self.helm_conn._get_namespace = Mock(return_value=self.namespace) self.helm_conn._uninstall_sw = asynctest.CoroutineMock() self.helm_conn.instances_list = asynctest.CoroutineMock(return_value=instances) self.helm_conn.uninstall = asynctest.CoroutineMock() @@ -521,6 +661,9 @@ class TestK8sHelm3Conn(asynctest.TestCase): self.helm_conn.fs.file_delete.assert_called_once_with( self.cluster_id, ignore_non_exist=True ) + self.helm_conn._get_namespace.assert_called_once_with( + cluster_uuid=self.cluster_uuid + ) self.helm_conn.instances_list.assert_called_once_with( cluster_uuid=self.cluster_uuid ) @@ -528,7 +671,7 @@ class TestK8sHelm3Conn(asynctest.TestCase): cluster_uuid=self.cluster_uuid, kdu_instance=kdu_instance ) self.helm_conn._uninstall_sw.assert_called_once_with( - self.cluster_id, self.namespace + cluster_id=self.cluster_id, namespace=self.namespace ) @asynctest.fail_on(active_handles=True)