Merge "Fix bug 564"
[osm/N2VC.git] / n2vc / vnf.py
index 06f1ff6..1bdfe2f 100644 (file)
@@ -19,7 +19,7 @@ if path not in sys.path:
 
 from juju.controller import Controller
 from juju.model import ModelObserver
-from juju.errors import JujuAPIError
+from juju.errors import JujuAPIError, JujuError
 
 # We might need this to connect to the websocket securely, but test and verify.
 try:
@@ -43,6 +43,10 @@ class N2VCPrimitiveExecutionFailed(Exception):
     """Something failed while attempting to execute a primitive."""
 
 
+class NetworkServiceDoesNotExist(Exception):
+    """The Network Service being acted against does not exist."""
+
+
 # Quiet the debug logging
 logging.getLogger('websockets.protocol').setLevel(logging.INFO)
 logging.getLogger('juju.client.connection').setLevel(logging.WARN)
@@ -176,7 +180,6 @@ class N2VC:
         }
 
         self.models = {}
-        self.default_model = None
 
         # Model Observers
         self.monitors = {}
@@ -235,26 +238,7 @@ class N2VC:
         return True
 
     # Public methods
-    async def CreateNetworkService(self, nsd):
-        """Create a new model to encapsulate this network service.
-
-        Create a new model in the Juju controller to encapsulate the
-        charms associated with a network service.
-
-        You can pass either the nsd record or the id of the network
-        service, but this method will fail without one of them.
-        """
-        if not self.authenticated:
-            await self.login()
-
-        # Ideally, we will create a unique model per network service.
-        # This change will require all components, i.e., LCM and SO, to use
-        # N2VC for 100% compatibility. If we adopt unique models for the LCM,
-        # services deployed via LCM would't be manageable via SO and vice versa
-
-        return self.default_model
-
-    async def Relate(self, ns_name, vnfd):
+    async def Relate(self, model_name, vnfd):
         """Create a relation between the charm-enabled VDUs in a VNF.
 
         The Relation mapping has two parts: the id of the vdu owning the endpoint, and the name of the endpoint.
@@ -300,7 +284,7 @@ class N2VC:
                 # Compare the named portion of the relation to the vdu's id
                 if vdu['id'] == name:
                     application_name = self.FormatApplicationName(
-                        ns_name,
+                        model_name,
                         vnf_name,
                         str(vnf_member_index),
                     )
@@ -339,7 +323,7 @@ class N2VC:
                                 requires
                             ))
                             await self.add_relation(
-                                ns_name,
+                                model_name,
                                 provides,
                                 requires,
                             )
@@ -355,7 +339,7 @@ class N2VC:
 
         Deploy the charm(s) referenced in a VNF Descriptor.
 
-        :param str model_name: The name of the network service.
+        :param str model_name: The name or unique id of the network service.
         :param str application_name: The name of the application
         :param dict vnfd: The name of the application
         :param str charm_path: The path to the Juju charm
@@ -365,6 +349,8 @@ class N2VC:
             'rw_mgmt_ip': '1.2.3.4',
             # Pass the initial-config-primitives section of the vnf or vdu
             'initial-config-primitives': {...}
+            'user_values': dictionary with the day-1 parameters provided at instantiation time. It will replace values
+                inside < >. rw_mgmt_ip will be included here also
           }
         :param dict machine_spec: A dictionary describing the machine to
         install to
@@ -402,9 +388,6 @@ class N2VC:
         ##########################################
         # Get the model for this network service #
         ##########################################
-        # TODO: In a point release, we will use a model per deployed network
-        # service. In the meantime, we will always use the 'default' model.
-        model_name = 'default'
         model = await self.get_model(model_name)
 
         ########################################
@@ -454,7 +437,8 @@ class N2VC:
             {'<rw_mgmt_ip>': rw_mgmt_ip}
         )
 
-        self.log.debug("JujuApi: Deploying charm ({}) from {}".format(
+        self.log.debug("JujuApi: Deploying charm ({}/{}) from {}".format(
+            model_name,
             application_name,
             charm_path,
             to=to,
@@ -543,9 +527,6 @@ class N2VC:
             if not self.authenticated:
                 await self.login()
 
-            # FIXME: This is hard-coded until model-per-ns is added
-            model_name = 'default'
-
             model = await self.get_model(model_name)
 
             results = await model.get_action_status(uuid)
@@ -571,9 +552,6 @@ class N2VC:
             if not self.authenticated:
                 await self.login()
 
-            # FIXME: This is hard-coded until model-per-ns is added
-            model_name = 'default'
-
             model = await self.get_model(model_name)
             results = await model.get_action_output(uuid, 60)
         except Exception as e:
@@ -675,15 +653,20 @@ class N2VC:
                 else:
                     seq = primitive['seq']
 
-                    params = {}
+                    params_ = {}
                     if 'parameter' in primitive:
-                        params = primitive['parameter']
+                        params_ = primitive['parameter']
+
+                    user_values = params.get("user_values", {})
+                    if 'rw_mgmt_ip' not in user_values:
+                        user_values['rw_mgmt_ip'] = None
+                        # just for backward compatibility, because it will be provided always by modern version of LCM
 
                     primitives[seq] = {
                         'name': primitive['name'],
                         'parameters': self._map_primitive_parameters(
-                            params,
-                            {'<rw_mgmt_ip>': None}
+                            params_,
+                            user_values
                         ),
                     }
 
@@ -711,7 +694,7 @@ class N2VC:
 
         Execute a primitive defined in the VNF descriptor.
 
-        :param str model_name: The name of the network service.
+        :param str model_name: The name or unique id of the network service.
         :param str application_name: The name of the application
         :param str primitive: The name of the primitive to execute.
         :param obj callback: A callback function to receive status changes.
@@ -726,15 +709,12 @@ class N2VC:
             'initial-config-primitives': {...}
           }
         """
-        self.log.debug("Executing {}".format(primitive))
+        self.log.debug("Executing primitive={} params={}".format(primitive, params))
         uuid = None
         try:
             if not self.authenticated:
                 await self.login()
 
-            # FIXME: This is hard-coded until model-per-ns is added
-            model_name = 'default'
-
             model = await self.get_model(model_name)
 
             if primitive == 'config':
@@ -787,11 +767,13 @@ class N2VC:
                 )
                 await app.remove()
 
-                # Notify the callback that this charm has been removed.
+                await self.disconnect_model(self.monitors[model_name])
+
                 self.notify_callback(
                     model_name,
                     application_name,
                     "removed",
+                    "Removing charm {}".format(application_name),
                     callback,
                     *callback_args,
                 )
@@ -801,13 +783,70 @@ class N2VC:
             self.log.debug(e)
             raise e
 
-    async def DestroyNetworkService(self, nsd):
-        raise NotImplementedError()
+    async def CreateNetworkService(self, ns_uuid):
+        """Create a new Juju model for the Network Service.
+
+        Creates a new Model in the Juju Controller.
+
+        :param str ns_uuid: A unique id representing an instaance of a
+            Network Service.
+
+        :returns: True if the model was created. Raises JujuError on failure.
+        """
+        if not self.authenticated:
+            await self.login()
+
+        models = await self.controller.list_models()
+        if ns_uuid not in models:
+            try:
+                self.models[ns_uuid] = await self.controller.add_model(
+                    ns_uuid
+                )
+            except JujuError as e:
+                if "already exists" not in e.message:
+                    raise e
+
+            # Create an observer for this model
+            await self.create_model_monitor(ns_uuid)
+
+        return True
+
+    async def DestroyNetworkService(self, ns_uuid):
+        """Destroy a Network Service.
+
+        Destroy the Network Service and any deployed charms.
+
+        :param ns_uuid The unique id of the Network Service
+
+        :returns: True if the model was created. Raises JujuError on failure.
+        """
+
+        # Do not delete the default model. The default model was used by all
+        # Network Services, prior to the implementation of a model per NS.
+        if ns_uuid.lower() == "default":
+            return False
+
+        if not self.authenticated:
+            self.log.debug("Authenticating with Juju")
+            await self.login()
+
+        # Disconnect from the Model
+        if ns_uuid in self.models:
+            await self.disconnect_model(self.models[ns_uuid])
+
+        try:
+            await self.controller.destroy_models(ns_uuid)
+        except JujuError:
+            raise NetworkServiceDoesNotExist(
+                "The Network Service '{}' does not exist".format(ns_uuid)
+            )
+
+        return True
 
     async def GetMetrics(self, model_name, application_name):
         """Get the metrics collected by the VCA.
 
-        :param model_name The name of the model
+        :param model_name The name or unique id of the network service
         :param application_name The name of the application
         """
         metrics = {}
@@ -830,9 +869,9 @@ class N2VC:
         """
         Add a relation between two application endpoints.
 
-        :param str model_name Name of the network service.
-        :param str relation1 '<application>[:<relation_name>]'
-        :param str relation12 '<application>[:<relation_name>]'
+        :param str model_name: The name or unique id of the network service
+        :param str relation1: '<application>[:<relation_name>]'
+        :param str relation2: '<application>[:<relation_name>]'
         """
 
         if not self.authenticated:
@@ -881,27 +920,45 @@ class N2VC:
 
         return config
 
-    def _map_primitive_parameters(self, parameters, values):
+    def _map_primitive_parameters(self, parameters, user_values):
         params = {}
         for parameter in parameters:
             param = str(parameter['name'])
-            value = None
+            value = parameter.get('value')
+
+            # map parameters inside a < >; e.g. <rw_mgmt_ip>. with the provided user_values.
+            # Must exist at user_values except if there is a default value
+            if isinstance(value, str) and value.startswith("<") and value.endswith(">"):
+                if parameter['value'][1:-1] in user_values:
+                    value = user_values[parameter['value'][1:-1]]
+                elif 'default-value' in parameter:
+                    value = parameter['default-value']
+                else:
+                    raise KeyError("parameter {}='{}' not supplied ".format(param, value))
+
+            # If there's no value, use the default-value (if set)
+            if value is None and 'default-value' in parameter:
+                value = parameter['default-value']
 
             # Typecast parameter value, if present
-            if 'data-type' in parameter:
-                paramtype = str(parameter['data-type']).lower()
+            paramtype = "string"
+            try:
+                if 'data-type' in parameter:
+                    paramtype = str(parameter['data-type']).lower()
 
-                if paramtype == "integer":
-                    value = int(parameter['value'])
-                elif paramtype == "boolean":
-                    value = bool(parameter['value'])
+                    if paramtype == "integer":
+                        value = int(value)
+                    elif paramtype == "boolean":
+                        value = bool(value)
+                    else:
+                        value = str(value)
                 else:
-                    value = str(parameter['value'])
+                    # If there's no data-type, assume the value is a string
+                    value = str(value)
+            except ValueError:
+                raise ValueError("parameter {}='{}' cannot be converted to type {}".format(param, value, paramtype))
 
-            if parameter['value'] == "<rw_mgmt_ip>":
-                params[param] = str(values[parameter['value']])
-            else:
-                params[param] = value
+            params[param] = value
         return params
 
     def _get_config_from_yang(self, config_primitive, values):
@@ -940,7 +997,7 @@ class N2VC:
             elif not c.isalpha():
                 c = "-"
             appname += c
-        return re.sub('\-+', '-', appname.lower())
+        return re.sub('-+', '-', appname.lower())
 
     # def format_application_name(self, nsd_name, vnfr_name, member_vnf_index=0):
     #     """Format the name of the application
@@ -980,7 +1037,7 @@ class N2VC:
 
         return app
 
-    async def get_model(self, model_name='default'):
+    async def get_model(self, model_name):
         """Get a model from the Juju Controller.
 
         Note: Model objects returned must call disconnected() before it goes
@@ -989,16 +1046,39 @@ class N2VC:
             await self.login()
 
         if model_name not in self.models:
-            self.models[model_name] = await self.controller.get_model(
-                model_name,
-            )
+            # Get the models in the controller
+            models = await self.controller.list_models()
+
+            if model_name not in models:
+                try:
+                    self.models[model_name] = await self.controller.add_model(
+                        model_name
+                    )
+                except JujuError as e:
+                    if "already exists" not in e.message:
+                        raise e
+            else:
+                self.models[model_name] = await self.controller.get_model(
+                    model_name
+                )
+
             self.refcount['model'] += 1
 
             # Create an observer for this model
+            await self.create_model_monitor(model_name)
+
+        return self.models[model_name]
+
+    async def create_model_monitor(self, model_name):
+        """Create a monitor for the model, if none exists."""
+        if not self.authenticated:
+            await self.login()
+
+        if model_name not in self.monitors:
             self.monitors[model_name] = VCAMonitor(model_name)
             self.models[model_name].add_observer(self.monitors[model_name])
 
-        return self.models[model_name]
+        return True
 
     async def login(self):
         """Login to the Juju controller."""
@@ -1046,21 +1126,11 @@ class N2VC:
     async def logout(self):
         """Logout of the Juju controller."""
         if not self.authenticated:
-            return
+            return False
 
         try:
-            if self.default_model:
-                self.log.debug("Disconnecting model {}".format(
-                    self.default_model
-                ))
-                await self.default_model.disconnect()
-                self.refcount['model'] -= 1
-                self.default_model = None
-
             for model in self.models:
-                await self.models[model].disconnect()
-                self.refcount['model'] -= 1
-                self.models[model] = None
+                await self.disconnect_model(model)
 
             if self.controller:
                 self.log.debug("Disconnecting controller {}".format(
@@ -1079,6 +1149,15 @@ class N2VC:
                 "Fatal error logging out of Juju Controller: {}".format(e)
             )
             raise e
+        return True
+
+    async def disconnect_model(self, model):
+        self.log.debug("Disconnecting model {}".format(model))
+        if model in self.models:
+            print("Disconnecting model")
+            await self.models[model].disconnect()
+            self.refcount['model'] -= 1
+            self.models[model] = None
 
     # async def remove_application(self, name):
     #     """Remove the application."""
@@ -1109,12 +1188,14 @@ class N2VC:
         finally:
             await m.disconnect()
 
-    async def resolve_error(self, application=None):
+    async def resolve_error(self, model_name, application=None):
         """Resolve units in error state."""
         if not self.authenticated:
             await self.login()
 
-        app = await self.get_application(self.default_model, application)
+        model = await self.get_model(model_name)
+
+        app = await self.get_application(model, application)
         if app:
             self.log.debug(
                 "JujuApi: Resolving errors for application {}".format(
@@ -1125,7 +1206,7 @@ class N2VC:
             for unit in app.units:
                 app.resolved(retry=True)
 
-    async def run_action(self, application, action_name, **params):
+    async def run_action(self, model_name, application, action_name, **params):
         """Execute an action and return an Action object."""
         if not self.authenticated:
             await self.login()
@@ -1136,7 +1217,10 @@ class N2VC:
                 'results': None,
             }
         }
-        app = await self.get_application(self.default_model, application)
+
+        model = await self.get_model(model_name)
+
+        app = await self.get_application(model, application)
         if app:
             # We currently only have one unit per application
             # so use the first unit available.
@@ -1199,14 +1283,10 @@ class N2VC:
         if not self.authenticated:
             await self.login()
 
-        # TODO: In a point release, we will use a model per deployed network
-        # service. In the meantime, we will always use the 'default' model.
-        model_name = 'default'
         model = await self.get_model(model_name)
 
         app = await self.get_application(model, application_name)
         self.log.debug("Application: {}".format(app))
-        # app = await self.get_application(model_name, application_name)
         if app:
             self.log.debug(
                 "JujuApi: Waiting {} seconds for Application {}".format(