Revert "Revert "Clean up commented or unused code"" This reverts commit c1cf1b9a33dd1929fb834424626661f9c9dce64d. Code Clean up approved by TSC on Feb 2nd Change-Id: I069215c71aaebf3cf7009a3538e4e5112e66103d
Revert "Clean up commented or unused code" This reverts commit b4e7f5c425df48f7e946d792184d1d1b44879fe9. Change-Id: I31a65516e65c3eb6528f241e36c1e45f3753f4c0 Signed-off-by: David Garcia <david.garcia@canonical.com>
Clean up commented or unused code Change-Id: Ib116128c15d727b9124e51d2475556045b79ac0d Signed-off-by: David Garcia <david.garcia@canonical.com>
Add License headers to all code files This was related to bug 547 https://osm.etsi.org/bugzilla/show_bug.cgi?id=547 Change-Id: Ief72f6e3b3de828be033729298ae905d163c6988 Signed-off-by: Dominik Fleischmann <dominik.fleischmann@canonical.com>
Add Juju Public Key This commit adds the requirement to provide the Juju public key to N2VC - Updates integration testing to use public key - Updates N2VC to accept juju_public_key and ca-cert - Updated docstring of N2VC constructor Change-Id: I4cad1f8c39024137a23060000d7502aad56ac644 Signed-off-by: Adam Israel <adam.israel@canonical.com>
Fix bug 628 - Better handling of model management In order to address the issue raised in bug 628, we've improved the handling of how N2VC creates and destroys models. Previously this was done transparently, but now they are explicit operations that will need to be performed by the LCM. The LCM will be required to call `CreateNetworkService()` prior to calling `DeployCharms`. This will return True if successful, or raise an exception if the model can't be created. After LCM has called `RemoveCharms()`, it will need to call `DestroyNetworkService()` to remove the model from the Juju controller. - Fix lint errors - Implement the `DestroyNetworkService` method, which will destroy the model per Network Service, and any applications deployed to it. - Adds a new test for creating and deleting models - Add `CreateNetworkService` to explicitly create a new model for a Network Service. - Add proper return values from `logout()` so we can assert against it during tests - Add dependency on pytest-assume so we can test multiple failures per test. This allows us to properly assert and still tear down the juju client. - Use pytest.assume. If a method asserts, we can continue with the teardown of the client. Change-Id: I3031b008f4ed79f978ecd84ade72e125153729a7 Signed-off-by: Adam Israel <adam.israel@canonical.com>
[bug 581] Fix parameter checking if no data-type Fix bug #581, which reported that the deployment of the simplecharm failed because the filename parameter was invalid. This turned out to be an issue introduced with the parameter type-checking added for R5. This has been fixed, and an integration test has been added that exercises the simplecharm example. Signed-off-by: Adam Israel <adam.israel@canonical.com>