X-Git-Url: https://osm.etsi.org/gitweb/?p=osm%2FMON.git;a=blobdiff_plain;f=osm_mon%2Ftests%2Funit%2Fcollector%2Fvnf_collectors%2Fvmware%2Ftest_vcd_collector.py;fp=osm_mon%2Ftests%2Funit%2Fcollector%2Fvnf_collectors%2Fvmware%2Ftest_vcd_collector.py;h=740de748da3836b97b5b47d7ea7630c3619f1d3a;hp=19d1496d8e4cea829d0464310eafb381f3b5e9d0;hb=7233ad262f6c5436c713784a443596c0aa919b04;hpb=829821e6cc5bb5b98066366755be4990e4b2afa0 diff --git a/osm_mon/tests/unit/collector/vnf_collectors/vmware/test_vcd_collector.py b/osm_mon/tests/unit/collector/vnf_collectors/vmware/test_vcd_collector.py index 19d1496..740de74 100644 --- a/osm_mon/tests/unit/collector/vnf_collectors/vmware/test_vcd_collector.py +++ b/osm_mon/tests/unit/collector/vnf_collectors/vmware/test_vcd_collector.py @@ -22,7 +22,7 @@ from osm_mon.collector.vnf_collectors.vmware import VMwareCollector from osm_mon.core.config import Config -from osm_mon.tests.unit.collector.vnf_collectors.vmware.mock_vcd import mock_vdc_response +from osm_mon.tests.unit.collector.vnf_collectors.vmware.mock_http import mock_http_response from unittest import TestCase, mock import json @@ -32,14 +32,12 @@ import requests_mock VIM_ACCOUNT = {"vrops_site": "https://vrops", "vrops_user": "", "vrops_password": "", - "vim_url": "", + "vim_url": "https://vcd", "admin_username": "", "admin_password": "", "vim_uuid": ""} -@mock.patch.object(VMwareCollector, 'get_vm_resource_id', - spec_set=True, autospec=True) @mock.patch.object(VMwareCollector, 'get_vm_moref_id', spec_set=True, autospec=True) class CollectorTest(TestCase): @@ -60,101 +58,168 @@ class CollectorTest(TestCase): def tearDown(self): super().tearDown() - def test_collect_cpu_and_memory(self, mock_vm_moref_id, mock_vm_resource_id): + def test_collect_cpu_and_memory(self, mock_vm_moref_id): - mock_vm_moref_id.return_value = "moref" - mock_vm_resource_id.return_value = "resource" + mock_vm_moref_id.return_value = "VMWARE-OID-VM-1" + self.vnfd['vdu'][0]['monitoring-param'] = [ + {"id": "ubuntu_vnfd-VM_cpu_util", "nfvi-metric": "cpu_utilization"}, + {"id": "ubuntu_vnfd-VM_average_memory_utilization", "nfvi-metric": "average_memory_utilization"} + ] self.mock_db.return_value.get_vnfd.return_value = self.vnfd with requests_mock.Mocker() as mock_requests: - mock_vdc_response(mock_requests, - url_pattern='/suite-api/api/resources/stats.*', - response_file='vrops_multi.json') + mock_http_response(mock_requests, + url_pattern='/suite-api/api/resources\\?resourceKind=VirtualMachine', + response_file='vrops_resources.json') + mock_http_response(mock_requests, + url_pattern='/suite-api/api/resources/stats.*', + response_file='vrops_multi.json') metrics = self.collector.collect(self.vnfr) - self.assertEqual(len(metrics), 2, "Number of metrics returned") - self.assertEqual(metrics[0].name, "cpu_utilization", "First metric name") - self.assertEqual(metrics[1].name, "average_memory_utilization", "Second metric name") - self.assertEqual(metrics[0].value, 100.0, "CPU metric value") - self.assertEqual(metrics[1].value, 20.515941619873047, "Memory metric value") - - def test_collect_one_metric_only(self, mock_vm_moref_id, mock_vm_resource_id): - - mock_vm_moref_id.return_value = "moref" - mock_vm_resource_id.return_value = "resource" - - self.vnfd['vdu'][0]['monitoring-param'] = [ - {'id': 'cirros_vnfd-VM_cpu_util', 'nfvi-metric': 'cpu_utilization'}, - ] + self.assertEqual(len(metrics), 2, "Number of metrics returned") + self.assertEqual(metrics[0].name, "cpu_utilization", "First metric name") + self.assertEqual(metrics[0].value, 100.0, "CPU metric value") + self.assertEqual(metrics[1].name, "average_memory_utilization", "Second metric name") + self.assertEqual(metrics[1].value, 20.515941619873047, "Memory metric value") + + def test_collect_no_moref(self, mock_vm_moref_id): + mock_vm_moref_id.return_value = None self.mock_db.return_value.get_vnfd.return_value = self.vnfd - with requests_mock.Mocker() as mock_requests: - mock_vdc_response(mock_requests, - url_pattern='/suite-api/api/resources/stats.*', - response_file='vrops_multi.json') + mock_http_response(mock_requests, + url_pattern='/suite-api/api/resources\\?resourceKind=VirtualMachine', + response_file='404.txt', status_code=404) metrics = self.collector.collect(self.vnfr) - self.assertEqual(len(metrics), 1, "Number of metrics returned") - self.assertEqual(metrics[0].name, "cpu_utilization", "First metric name") - self.assertEqual(metrics[0].value, 100.0, "CPU metric value") + self.assertEqual(len(metrics), 0, "Number of metrics returned") - def test_collect_adjusted_metric(self, mock_vm_moref_id, mock_vm_resource_id): - - mock_vm_moref_id.return_value = "moref" - mock_vm_resource_id.return_value = "resource" + def test_collect_no_monitoring_param(self, _): + self.vnfd['vdu'][0]['monitoring-param'] = [] + self.mock_db.return_value.get_vnfd.return_value = self.vnfd + with requests_mock.Mocker() as mock_requests: + mock_http_response(mock_requests, + url_pattern='/suite-api/api/resources\\?resourceKind=VirtualMachine', + response_file='vrops_resources.json') + mock_http_response(mock_requests, + url_pattern='/suite-api/api/resources/stats.*', + response_file='vrops_multi.json') + metrics = self.collector.collect(self.vnfr) + self.assertEqual(len(metrics), 0, "Number of metrics returned") - self.vnfd['vdu'][0]['monitoring-param'] = [ - {'id': 'cirros_vnfd-VM_cpu_util', 'nfvi-metric': 'disk_read_bytes'}, - ] + def test_collect_empty_monitoring_param(self, _): + del self.vnfd['vdu'][0]['monitoring-param'] self.mock_db.return_value.get_vnfd.return_value = self.vnfd + with requests_mock.Mocker() as mock_requests: + mock_http_response(mock_requests, + url_pattern='/suite-api/api/resources\\?resourceKind=VirtualMachine', + response_file='vrops_resources.json') + mock_http_response(mock_requests, + url_pattern='/suite-api/api/resources/stats.*', + response_file='vrops_multi.json') + metrics = self.collector.collect(self.vnfr) + self.assertEqual(len(metrics), 0, "Number of metrics returned") + def test_collect_no_name(self, _): + del self.vnfr['vdur'][0]['name'] + del self.vnfr['vdur'][1]['name'] + self.mock_db.return_value.get_vnfd.return_value = self.vnfd with requests_mock.Mocker() as mock_requests: - mock_vdc_response(mock_requests, - url_pattern='/suite-api/api/resources/stats.*', - response_file='vrops_multi.json') + mock_http_response(mock_requests, + url_pattern='/suite-api/api/resources\\?resourceKind=VirtualMachine', + response_file='vrops_resources.json') + mock_http_response(mock_requests, + url_pattern='/suite-api/api/resources/stats.*', + response_file='vrops_multi.json') metrics = self.collector.collect(self.vnfr) - self.assertEqual(len(metrics), 1, "Number of metrics returned") - self.assertEqual(metrics[0].name, "disk_read_bytes", "First metric name") - self.assertEqual(metrics[0].value, 10240.0, "Disk read bytes (not KB/s)") + self.assertEqual(len(metrics), 0, "Number of metrics returned") - def test_collect_not_provided_metric(self, mock_vm_moref_id, mock_vm_resource_id): - mock_vm_moref_id.return_value = "moref" - mock_vm_resource_id.return_value = "resource" +class VApp_Details_Test(TestCase): - self.vnfd['vdu'][0]['monitoring-param'] = [ - {'id': 'cirros_vnfd-VM_packets_sent', 'nfvi-metric': 'packets_sent'}, - ] - self.mock_db.return_value.get_vnfd.return_value = self.vnfd + @mock.patch.object(VMwareCollector, 'get_vim_account', + spec_set=True, autospec=True) + @mock.patch('osm_mon.collector.vnf_collectors.vmware.CommonDbClient') + def setUp(self, mock_db, mock_get_vim_account): + super().setUp() + self.mock_db = mock_db + mock_get_vim_account.return_value = VIM_ACCOUNT + self.collector = VMwareCollector(Config(), "9de6df67-b820-48c3-bcae-ee4838c5c5f4") + + def tearDown(self): + super().tearDown() + @mock.patch('osm_mon.collector.vnf_collectors.vmware.Client') + def test_get_vapp_details(self, mock_vcd_client): + mock_vcd_client.return_value._session.headers = {'x-vcloud-authorization': ''} with requests_mock.Mocker() as mock_requests: - mock_vdc_response(mock_requests, - url_pattern='/suite-api/api/resources/stats.*', - response_file='OK.json') - metrics = self.collector.collect(self.vnfr) - self.assertEqual(len(metrics), 0, "Number of metrics returned") + mock_http_response(mock_requests, + site='https://vcd', + url_pattern='/api/vApp/.*', + response_file='vcd_vapp_response.xml') + response = self.collector.get_vapp_details_rest('') + self.assertDictContainsSubset({'vm_vcenter_info': {'vm_moref_id': 'vm-4055'}}, + response, 'Managed object reference id incorrect') + + def test_no_admin_connect(self): + response = self.collector.get_vapp_details_rest('') + self.assertDictEqual(response, {}, 'Failed to connect should return empty dictionary') + + def test_no_id(self): + response = self.collector.get_vapp_details_rest() + self.assertDictEqual(response, {}, 'No id supplied should return empty dictionary') + + @mock.patch('osm_mon.collector.vnf_collectors.vmware.Client') + def test_get_vapp_details_404(self, mock_vcd_client): + mock_vcd_client.return_value._session.headers = {'x-vcloud-authorization': ''} + with requests_mock.Mocker() as mock_requests: + mock_http_response(mock_requests, + site='https://vcd', + url_pattern='/api/vApp/.*', + response_file='404.txt', status_code=404) + response = self.collector.get_vapp_details_rest('') + self.assertDictEqual(response, {}, 'HTTP error should return empty dictionary') + + @mock.patch('osm_mon.collector.vnf_collectors.vmware.Client') + def test_get_vapp_details_xml_parse_error(self, mock_vcd_client): + mock_vcd_client.return_value._session.headers = {'x-vcloud-authorization': ''} + with requests_mock.Mocker() as mock_requests: + mock_http_response(mock_requests, + site='https://vcd', + url_pattern='/api/vApp/.*', + response_file='404.txt') + response = self.collector.get_vapp_details_rest('') + self.assertDictEqual(response, {}, 'XML parse error should return empty dictionary') - def test_collect_unkown_metric(self, mock_vm_moref_id, mock_vm_resource_id): - mock_vm_moref_id.return_value = "moref" - mock_vm_resource_id.return_value = "resource" +class Get_VM_Moref_Test(TestCase): - self.vnfd['vdu'][0]['monitoring-param'] = [ - {'id': 'cirros_vnfd-Unknown_Metric', 'nfvi-metric': 'unknown'}, - ] - self.mock_db.return_value.get_vnfd.return_value = self.vnfd + @mock.patch.object(VMwareCollector, 'get_vim_account', + spec_set=True, autospec=True) + @mock.patch('osm_mon.collector.vnf_collectors.vmware.CommonDbClient') + def setUp(self, mock_db, mock_get_vim_account): + super().setUp() + self.mock_db = mock_db + mock_get_vim_account.return_value = VIM_ACCOUNT + self.collector = VMwareCollector(Config(), "9de6df67-b820-48c3-bcae-ee4838c5c5f4") - with requests_mock.Mocker() as mock_requests: - mock_vdc_response(mock_requests, - url_pattern='/suite-api/api/resources/stats.*', - response_file='vrops_multi.json') - metrics = self.collector.collect(self.vnfr) - self.assertEqual(len(metrics), 0, "Number of metrics returned") + def tearDown(self): + super().tearDown() - def test_collect_vrops_error(self, mock_vm_moref_id, mock_vm_resource_id): + @mock.patch.object(VMwareCollector, 'get_vapp_details_rest', + spec_set=True, autospec=True) + def test_get_vm_moref_id(self, mock_vapp_details): + mock_vapp_details.return_value = {'vm_vcenter_info': {'vm_moref_id': 'vm-4055'}} + response = self.collector.get_vm_moref_id('1234') + self.assertEqual(response, 'vm-4055', 'Did not fetch correct ref id from dictionary') - mock_vm_moref_id.return_value = "moref" - mock_vm_resource_id.return_value = "resource" - self.mock_db.return_value.get_vnfd.return_value = self.vnfd + @mock.patch.object(VMwareCollector, 'get_vapp_details_rest', + spec_set=True, autospec=True) + def test_get_vm_moref_bad_content(self, mock_vapp_details): + mock_vapp_details.return_value = {} + response = self.collector.get_vm_moref_id('1234') + self.assertEqual(response, None, 'Error fetching vapp details should return None') - with requests_mock.Mocker(): - metrics = self.collector.collect(self.vnfr) - self.assertEqual(len(metrics), 0, "Number of metrics returned") + @mock.patch.object(VMwareCollector, 'get_vapp_details_rest', + spec_set=True, autospec=True) + def test_get_vm_moref_has_exception(self, mock_vapp_details): + mock_vapp_details.side_effect = Exception('Testing') + response = self.collector.get_vm_moref_id('1234') + self.assertEqual(response, None, 'Exception while fetching vapp details should return None')