Refactors codebase
[osm/MON.git] / osm_mon / plugins / vRealiseOps / mon_plugin_vrops.py
index 6ca3d40..af68dfc 100644 (file)
 """
 Monitoring metrics & creating Alarm definitions in vROPs
 """
-import pytz
-import requests
 import logging
 
+import pytz
+import requests
 import six
 from pyvcloud.vcd.client import BasicLoginCredentials
 from pyvcloud.vcd.client import Client
-API_VERSION = '5.9'
 
 from xml.etree import ElementTree as XmlElementTree
 import traceback
@@ -44,31 +43,45 @@ import datetime
 from socket import getfqdn
 
 import urllib3
-urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning)
+
+from osm_mon.core.settings import Config
 
 sys.path.append(os.path.join(os.path.dirname(os.path.abspath(__file__)), '..', '..', '..'))
 from osm_mon.core.database import DatabaseManager
 
-OPERATION_MAPPING = {'GE':'GT_EQ', 'LE':'LT_EQ', 'GT':'GT', 'LT':'LT', 'EQ':'EQ'}
-severity_mano2vrops = {'WARNING':'WARNING', 'MINOR':'WARNING', 'MAJOR':"IMMEDIATE",\
-                        'CRITICAL':'CRITICAL', 'INDETERMINATE':'UNKNOWN'}
-PERIOD_MSEC = {'HR':3600000,'DAY':86400000,'WEEK':604800000,'MONTH':2678400000,'YEAR':31536000000}
+API_VERSION = '5.9'
 
-#To Do - Add actual webhook url & certificate
-#SSL_CERTIFICATE_FILE_NAME = 'vROPs_Webservice/SSL_certificate/www.vrops_webservice.com.cert'
-#webhook_url = "https://mano-dev-1:8080/notify/" #for testing
+urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning)
+OPERATION_MAPPING = {'GE': 'GT_EQ', 'LE': 'LT_EQ', 'GT': 'GT', 'LT': 'LT', 'EQ': 'EQ'}
+severity_mano2vrops = {'WARNING': 'WARNING', 'MINOR': 'WARNING', 'MAJOR': "IMMEDIATE",
+                       'CRITICAL': 'CRITICAL', 'INDETERMINATE': 'UNKNOWN'}
+PERIOD_MSEC = {'HR': 3600000, 'DAY': 86400000, 'WEEK': 604800000, 'MONTH': 2678400000, 'YEAR': 31536000000}
+
+# To Do - Add actual webhook url & certificate
+# SSL_CERTIFICATE_FILE_NAME = 'vROPs_Webservice/SSL_certificate/www.vrops_webservice.com.cert'
+# webhook_url = "https://mano-dev-1:8080/notify/" #for testing
 webhook_url = "https://" + getfqdn() + ":8080/notify/"
 SSL_CERTIFICATE_FILE_NAME = ('vROPs_Webservice/SSL_certificate/' + getfqdn() + ".cert")
-#SSL_CERTIFICATE_FILE_NAME = 'vROPs_Webservice/SSL_certificate/10.172.137.214.cert' #for testing
+# SSL_CERTIFICATE_FILE_NAME = 'vROPs_Webservice/SSL_certificate/10.172.137.214.cert' #for testing
 
 MODULE_DIR = os.path.dirname(__file__)
 CONFIG_FILE_NAME = 'vrops_config.xml'
 CONFIG_FILE_PATH = os.path.join(MODULE_DIR, CONFIG_FILE_NAME)
 SSL_CERTIFICATE_FILE_PATH = os.path.join(MODULE_DIR, SSL_CERTIFICATE_FILE_NAME)
 
-class MonPlugin():
+cfg = Config.instance()
+logging.basicConfig(stream=sys.stdout,
+                    format='%(asctime)s - %(name)s - %(levelname)s - %(message)s',
+                    datefmt='%m/%d/%Y %I:%M:%S %p',
+                    level=logging.getLevelName(cfg.OSMMON_LOG_LEVEL))
+
+logger = logging.getLogger(__name__)
+
+
+class MonPlugin:
     """MON Plugin class for vROPs telemetry plugin
     """
+
     def __init__(self, access_config=None):
         """Constructor of MON plugin
         Params:
@@ -87,37 +100,32 @@ class MonPlugin():
             check against the VIM
         """
 
-        self.logger = logging.getLogger('PluginReceiver.MonPlugin')
-        self.logger.setLevel(logging.DEBUG)
-
         if access_config is None:
-            self.logger.error("VIM Access Configuration not provided")
+            logger.error("VIM Access Configuration not provided")
             raise KeyError("VIM Access Configuration not provided")
 
         self.database_manager = DatabaseManager()
 
         self.access_config = access_config
         if not bool(access_config):
-            self.logger.error("VIM Account details are not added. Please add a VIM account")
+            logger.error("VIM Account details are not added. Please add a VIM account")
             raise KeyError("VIM Account details are not added. Please add a VIM account")
 
         try:
-            self.vrops_site =  access_config['vrops_site']
+            self.vrops_site = access_config['vrops_site']
             self.vrops_user = access_config['vrops_user']
             self.vrops_password = access_config['vrops_password']
             self.vcloud_site = access_config['vim_url']
             self.admin_username = access_config['admin_username']
             self.admin_password = access_config['admin_password']
-            #self.tenant_id = access_config['tenant_id']
+            # self.tenant_id = access_config['tenant_id']
             self.vim_uuid = access_config['vim_uuid']
 
         except KeyError as exp:
-            self.logger.error("Required VIM account details not provided: {}".format(exp))
+            logger.error("Required VIM account details not provided: {}".format(exp))
             raise KeyError("Required VIM account details not provided: {}".format(exp))
 
-
-
-    def configure_alarm(self, config_dict = {}):
+    def configure_alarm(self, config_dict={}):
         """Configures or creates a new alarm using the input parameters in config_dict
         Params:
         "alarm_name": Alarm name in string format
@@ -138,95 +146,93 @@ class MonPlugin():
 
         Returns the UUID of created alarm or None
         """
-        alarm_def = None
-        #1) get alarm & metrics parameters from plugin specific file
+        # 1) get alarm & metrics parameters from plugin specific file
         def_a_params = self.get_default_Params(config_dict['alarm_name'])
         if not def_a_params:
-            self.logger.warning("Alarm not supported: {}".format(config_dict['alarm_name']))
+            logger.warning("Alarm not supported: {}".format(config_dict['alarm_name']))
             return None
         metric_key_params = self.get_default_Params(config_dict['metric_name'])
         if not metric_key_params:
-            self.logger.warning("Metric not supported: {}".format(config_dict['metric_name']))
+            logger.warning("Metric not supported: {}".format(config_dict['metric_name']))
             return None
 
-        #1.2) Check if alarm definition already exists
-        vrops_alarm_name = def_a_params['vrops_alarm']+ '-' + config_dict['resource_uuid']
+        # 1.2) Check if alarm definition already exists
+        vrops_alarm_name = def_a_params['vrops_alarm'] + '-' + config_dict['resource_uuid']
         alert_def_list = self.get_alarm_defination_by_name(vrops_alarm_name)
         if alert_def_list:
-            self.logger.warning("Alarm already exists: {}. Try updating by update_alarm_request"\
-                            .format(vrops_alarm_name))
+            logger.warning("Alarm already exists: {}. Try updating by update_alarm_request"
+                           .format(vrops_alarm_name))
             return None
 
-        #2) create symptom definition
-        symptom_params ={'cancel_cycles': (def_a_params['cancel_period']/300)*def_a_params['cancel_cycles'],
-                        'wait_cycles': (def_a_params['period']/300)*def_a_params['evaluation'],
-                        'resource_kind_key': def_a_params['resource_kind'],
-                        'adapter_kind_key': def_a_params['adapter_kind'],
-                        'symptom_name':vrops_alarm_name,
-                        'severity': severity_mano2vrops[config_dict['severity'].upper()],
-                        'metric_key':metric_key_params['metric_key'],
-                        'operation':OPERATION_MAPPING[config_dict['operation']],
-                        'threshold_value':config_dict['threshold_value']}
+        # 2) create symptom definition
+        symptom_params = {'cancel_cycles': (def_a_params['cancel_period'] / 300) * def_a_params['cancel_cycles'],
+                          'wait_cycles': (def_a_params['period'] / 300) * def_a_params['evaluation'],
+                          'resource_kind_key': def_a_params['resource_kind'],
+                          'adapter_kind_key': def_a_params['adapter_kind'],
+                          'symptom_name': vrops_alarm_name,
+                          'severity': severity_mano2vrops[config_dict['severity'].upper()],
+                          'metric_key': metric_key_params['metric_key'],
+                          'operation': OPERATION_MAPPING[config_dict['operation']],
+                          'threshold_value': config_dict['threshold_value']}
 
         symptom_uuid = self.create_symptom(symptom_params)
         if symptom_uuid is not None:
-            self.logger.info("Symptom defined: {} with ID: {}".format(symptom_params['symptom_name'],symptom_uuid))
+            logger.info("Symptom defined: {} with ID: {}".format(symptom_params['symptom_name'], symptom_uuid))
         else:
-            self.logger.warning("Failed to create Symptom: {}".format(symptom_params['symptom_name']))
+            logger.warning("Failed to create Symptom: {}".format(symptom_params['symptom_name']))
             return None
-        #3) create alert definition
-        #To Do - Get type & subtypes for all 5 alarms
-        alarm_params = {'name':vrops_alarm_name,
-                        'description':config_dict['description']\
-                        if 'description' in config_dict and config_dict['description'] is not None else config_dict['alarm_name'],
-                        'adapterKindKey':def_a_params['adapter_kind'],
-                        'resourceKindKey':def_a_params['resource_kind'],
-                        'waitCycles':1, 'cancelCycles':1,
-                        'type':def_a_params['alarm_type'], 'subType':def_a_params['alarm_subType'],
-                        'severity':severity_mano2vrops[config_dict['severity'].upper()],
-                        'symptomDefinitionId':symptom_uuid,
-                        'impact':def_a_params['impact']}
+        # 3) create alert definition
+        # To Do - Get type & subtypes for all 5 alarms
+        alarm_params = {'name': vrops_alarm_name,
+                        'description': config_dict['description']
+                        if 'description' in config_dict and config_dict['description'] is not None else config_dict[
+                            'alarm_name'],
+                        'adapterKindKey': def_a_params['adapter_kind'],
+                        'resourceKindKey': def_a_params['resource_kind'],
+                        'waitCycles': 1, 'cancelCycles': 1,
+                        'type': def_a_params['alarm_type'], 'subType': def_a_params['alarm_subType'],
+                        'severity': severity_mano2vrops[config_dict['severity'].upper()],
+                        'symptomDefinitionId': symptom_uuid,
+                        'impact': def_a_params['impact']}
 
         alarm_def = self.create_alarm_definition(alarm_params)
         if alarm_def is None:
-            self.logger.warning("Failed to create Alert: {}".format(alarm_params['name']))
+            logger.warning("Failed to create Alert: {}".format(alarm_params['name']))
             return None
 
-        self.logger.info("Alarm defined: {} with ID: {}".format(alarm_params['name'],alarm_def))
+        logger.info("Alarm defined: {} with ID: {}".format(alarm_params['name'], alarm_def))
 
-        #4) Find vm_moref_id from vApp uuid in vCD
+        # 4) Find vm_moref_id from vApp uuid in vCD
         vm_moref_id = self.get_vm_moref_id(config_dict['resource_uuid'])
         if vm_moref_id is None:
-            self.logger.warning("Failed to find vm morefid for vApp in vCD: {}".format(config_dict['resource_uuid']))
+            logger.warning("Failed to find vm morefid for vApp in vCD: {}".format(config_dict['resource_uuid']))
             return None
 
-        #5) Based on vm_moref_id, find VM's corresponding resource_id in vROPs to set notification
+        # 5) Based on vm_moref_id, find VM's corresponding resource_id in vROPs to set notification
         resource_id = self.get_vm_resource_id(vm_moref_id)
         if resource_id is None:
-            self.logger.warning("Failed to find resource in vROPs: {}".format(config_dict['resource_uuid']))
+            logger.warning("Failed to find resource in vROPs: {}".format(config_dict['resource_uuid']))
             return None
 
-        #6) Configure alarm notification for a particular VM using it's resource_id
+        # 6) Configure alarm notification for a particular VM using it's resource_id
         notification_id = self.create_alarm_notification_rule(vrops_alarm_name, alarm_def, resource_id)
         if notification_id is None:
             return None
         else:
             alarm_def_uuid = alarm_def.split('-', 1)[1]
-            self.logger.info("Alarm definition created with notification: {} with ID: {}"\
-                    .format(alarm_params['name'],alarm_def_uuid))
-            ##self.database_manager.save_alarm(alarm_def_uuid, alarm_params['name'], self.vim_uuid)
-            self.database_manager.save_alarm(alarm_def_uuid,
-                                              self.vim_uuid,
-                                              ##alarm_params['name'],
-                                              config_dict['threshold_value'],
-                                              config_dict['operation'],
-                                              config_dict['metric_name'].lower(),
-                                              config_dict['vdu_name'].lower(),
-                                              config_dict['vnf_member_index'].lower(),
-                                              config_dict['ns_id'].lower()
-                                              )
-
-            #Return alarm definition UUID by removing 'AlertDefinition' from UUID
+            logger.info("Alarm definition created with notification: {} with ID: {}"
+                        .format(alarm_params['name'], alarm_def_uuid))
+            self.database_manager.save_alarm(alarm_params['name'],
+                                             self.vim_uuid,
+                                             config_dict['threshold_value'],
+                                             config_dict['operation'],
+                                             config_dict['metric_name'].lower(),
+                                             config_dict['vdu_name'].lower(),
+                                             config_dict['vnf_member_index'].lower(),
+                                             config_dict['ns_id'].lower()
+                                             )
+
+            # Return alarm definition UUID by removing 'AlertDefinition' from UUID
             return (alarm_def_uuid)
 
     def get_default_Params(self, metric_alarm_name):
@@ -239,9 +245,9 @@ class MonPlugin():
         try:
             source = open(CONFIG_FILE_PATH, 'r')
         except IOError as exp:
-            msg = ("Could not read Config file: {}, \nException: {}"\
-                        .format(CONFIG_FILE_PATH, exp))
-            self.logger.error(msg)
+            msg = ("Could not read Config file: {},  nException: {}"
+                   .format(CONFIG_FILE_PATH, exp))
+            logger.error(msg)
             raise IOError(msg)
 
         tree = XmlElementTree.parse(source)
@@ -249,11 +255,11 @@ class MonPlugin():
         for alarm in alarms:
             if alarm.tag.lower() == metric_alarm_name.lower():
                 for param in alarm:
-                    if param.tag in ("period", "evaluation", "cancel_period", "alarm_type",\
-                                    "cancel_cycles", "alarm_subType"):
+                    if param.tag in ("period", "evaluation", "cancel_period", "alarm_type",
+                                     "cancel_cycles", "alarm_subType"):
                         a_params[param.tag] = int(param.text)
                     elif param.tag in ("enabled", "repeat"):
-                        if(param.text.lower() == "true"):
+                        if param.text.lower() == "true":
                             a_params[param.tag] = True
                         else:
                             a_params[param.tag] = False
@@ -262,7 +268,6 @@ class MonPlugin():
         source.close()
         return a_params
 
-
     def create_symptom(self, symptom_params):
         """Create Symptom definition for an alarm
         Params:
@@ -282,37 +287,37 @@ class MonPlugin():
 
         try:
             api_url = '/suite-api/api/symptomdefinitions'
-            headers = {'Content-Type': 'application/json','Accept': 'application/json'}
+            headers = {'Content-Type': 'application/json', 'Accept': 'application/json'}
             data = {
-                        "id": None,
-                        "name": symptom_params['symptom_name'],
-                        "adapterKindKey": symptom_params['adapter_kind_key'],
-                        "resourceKindKey": symptom_params['resource_kind_key'],
-                        "waitCycles": symptom_params['wait_cycles'],
-                        "cancelCycles": symptom_params['cancel_cycles'],
-                        "state": {
-                            "severity": symptom_params['severity'],
-                            "condition": {
-                                "type": "CONDITION_HT",
-                                "key": symptom_params['metric_key'],
-                                "operator": symptom_params['operation'],
-                                "value": symptom_params['threshold_value'],
-                                "valueType": "NUMERIC",
-                                "instanced": False,
-                                "thresholdType": "STATIC"
-                            }
-                        }
+                "id": None,
+                "name": symptom_params['symptom_name'],
+                "adapterKindKey": symptom_params['adapter_kind_key'],
+                "resourceKindKey": symptom_params['resource_kind_key'],
+                "waitCycles": symptom_params['wait_cycles'],
+                "cancelCycles": symptom_params['cancel_cycles'],
+                "state": {
+                    "severity": symptom_params['severity'],
+                    "condition": {
+                        "type": "CONDITION_HT",
+                        "key": symptom_params['metric_key'],
+                        "operator": symptom_params['operation'],
+                        "value": symptom_params['threshold_value'],
+                        "valueType": "NUMERIC",
+                        "instanced": False,
+                        "thresholdType": "STATIC"
                     }
+                }
+            }
 
             resp = requests.post(self.vrops_site + api_url,
                                  auth=(self.vrops_user, self.vrops_password),
                                  headers=headers,
-                                 verify = False,
+                                 verify=False,
                                  data=json.dumps(data))
 
             if resp.status_code != 201:
-                self.logger.warning("Failed to create Symptom definition: {}, response {}"\
-                        .format(symptom_params['symptom_name'], resp.content))
+                logger.warning("Failed to create Symptom definition: {}, response {}"
+                               .format(symptom_params['symptom_name'], resp.content))
                 return None
 
             resp_data = json.loads(resp.content)
@@ -322,9 +327,8 @@ class MonPlugin():
             return symptom_id
 
         except Exception as exp:
-            self.logger.warning("Error creating symptom definition : {}\n{}"\
-            .format(exp, traceback.format_exc()))
-
+            logger.warning("Error creating symptom definition : {} n{}"
+                           .format(exp, traceback.format_exc()))
 
     def create_alarm_definition(self, alarm_params):
         """
@@ -351,42 +355,42 @@ class MonPlugin():
             api_url = '/suite-api/api/alertdefinitions'
             headers = {'Content-Type': 'application/json', 'Accept': 'application/json'}
             data = {
-                        "name": alarm_params['name'],
-                        "description": alarm_params['description'],
-                        "adapterKindKey": alarm_params['adapterKindKey'],
-                        "resourceKindKey": alarm_params['resourceKindKey'],
-                        "waitCycles": 1,
-                        "cancelCycles": 1,
-                        "type": alarm_params['type'],
-                        "subType": alarm_params['subType'],
-                        "states": [
+                "name": alarm_params['name'],
+                "description": alarm_params['description'],
+                "adapterKindKey": alarm_params['adapterKindKey'],
+                "resourceKindKey": alarm_params['resourceKindKey'],
+                "waitCycles": 1,
+                "cancelCycles": 1,
+                "type": alarm_params['type'],
+                "subType": alarm_params['subType'],
+                "states": [
+                    {
+                        "severity": alarm_params['severity'],
+                        "base-symptom-set":
                             {
-                                "severity": alarm_params['severity'],
-                                "base-symptom-set":
-                                    {
-                                        "type": "SYMPTOM_SET",
-                                        "relation": "SELF",
-                                        "aggregation": "ALL",
-                                        "symptomSetOperator": "AND",
-                                        "symptomDefinitionIds": [alarm_params['symptomDefinitionId']]
-                                    },
-                                "impact": {
-                                    "impactType": "BADGE",
-                                    "detail": alarm_params['impact']
-                                }
-                            }
-                        ]
+                                "type": "SYMPTOM_SET",
+                                "relation": "SELF",
+                                "aggregation": "ALL",
+                                "symptomSetOperator": "AND",
+                                "symptomDefinitionIds": [alarm_params['symptomDefinitionId']]
+                            },
+                        "impact": {
+                            "impactType": "BADGE",
+                            "detail": alarm_params['impact']
+                        }
                     }
+                ]
+            }
 
             resp = requests.post(self.vrops_site + api_url,
                                  auth=(self.vrops_user, self.vrops_password),
                                  headers=headers,
-                                 verify = False,
+                                 verify=False,
                                  data=json.dumps(data))
 
             if resp.status_code != 201:
-                self.logger.warning("Failed to create Alarm definition: {}, response {}"\
-                        .format(alarm_params['name'], resp.content))
+                logger.warning("Failed to create Alarm definition: {}, response {}"
+                               .format(alarm_params['name'], resp.content))
                 return None
 
             resp_data = json.loads(resp.content)
@@ -396,8 +400,7 @@ class MonPlugin():
             return alarm_uuid
 
         except Exception as exp:
-            self.logger.warning("Error creating alarm definition : {}\n{}".format(exp, traceback.format_exc()))
-
+            logger.warning("Error creating alarm definition : {} n{}".format(exp, traceback.format_exc()))
 
     def configure_rest_plugin(self):
         """
@@ -409,7 +412,7 @@ class MonPlugin():
         plugin_name = 'MON_module_REST_Plugin'
         plugin_id = self.check_if_plugin_configured(plugin_name)
 
-        #If REST plugin not configured, configure it
+        # If REST plugin not configured, configure it
         if plugin_id is not None:
             return plugin_id
         else:
@@ -417,45 +420,45 @@ class MonPlugin():
                 cert_file_string = open(SSL_CERTIFICATE_FILE_PATH, "rb").read()
             except IOError as exp:
                 msg = ("Could not read SSL certificate file: {}".format(SSL_CERTIFICATE_FILE_PATH))
-                self.logger.error(msg)
+                logger.error(msg)
                 raise IOError(msg)
             cert = load_certificate(FILETYPE_PEM, cert_file_string)
             certificate = cert.digest("sha1")
             api_url = '/suite-api/api/alertplugins'
             headers = {'Content-Type': 'application/json', 'Accept': 'application/json'}
             data = {
-                        "pluginTypeId": "RestPlugin",
-                        "name": plugin_name,
-                        "configValues": [
-                            {
-                                "name": "Url",
-                                "value": webhook_url
-                            },
-                            {
-                                "name": "Content-type",
-                                "value": "application/json"
-                            },
-                            {
-                                "name": "Certificate",
-                                "value": certificate
-                            },
-                            {
-                                "name": "ConnectionCount",
-                                "value": "20"
-                            }
-                        ]
+                "pluginTypeId": "RestPlugin",
+                "name": plugin_name,
+                "configValues": [
+                    {
+                        "name": "Url",
+                        "value": webhook_url
+                    },
+                    {
+                        "name": "Content-type",
+                        "value": "application/json"
+                    },
+                    {
+                        "name": "Certificate",
+                        "value": certificate
+                    },
+                    {
+                        "name": "ConnectionCount",
+                        "value": "20"
                     }
+                ]
+            }
 
             resp = requests.post(self.vrops_site + api_url,
                                  auth=(self.vrops_user, self.vrops_password),
                                  headers=headers,
-                                 verify = False,
+                                 verify=False,
                                  data=json.dumps(data))
 
             if resp.status_code is not 201:
-                self.logger.warning("Failed to create REST Plugin: {} for url: {}, \nresponse code: {},"\
-                            "\nresponse content: {}".format(plugin_name, webhook_url,\
-                            resp.status_code, resp.content))
+                logger.warning("Failed to create REST Plugin: {} for url: {},  nresponse code: {},"
+                               " nresponse content: {}".format(plugin_name, webhook_url,
+                                                               resp.status_code, resp.content))
                 return None
 
             resp_data = json.loads(resp.content)
@@ -463,16 +466,18 @@ class MonPlugin():
                 plugin_id = resp_data['pluginId']
 
             if plugin_id is None:
-                self.logger.warning("Failed to get REST Plugin ID for {}, url: {}".format(plugin_name, webhook_url))
+                logger.warning("Failed to get REST Plugin ID for {}, url: {}".format(plugin_name, webhook_url))
                 return None
             else:
-                self.logger.info("Created REST Plugin: {} with ID : {} for url: {}".format(plugin_name, plugin_id, webhook_url))
+                logger.info(
+                    "Created REST Plugin: {} with ID : {} for url: {}".format(plugin_name, plugin_id, webhook_url))
                 status = self.enable_rest_plugin(plugin_id, plugin_name)
                 if status is False:
-                    self.logger.warning("Failed to enable created REST Plugin: {} for url: {}".format(plugin_name, webhook_url))
+                    logger.warning(
+                        "Failed to enable created REST Plugin: {} for url: {}".format(plugin_name, webhook_url))
                     return None
                 else:
-                    self.logger.info("Enabled REST Plugin: {} for url: {}".format(plugin_name, webhook_url))
+                    logger.info("Enabled REST Plugin: {} for url: {}".format(plugin_name, webhook_url))
                     return plugin_id
 
     def check_if_plugin_configured(self, plugin_name):
@@ -480,17 +485,17 @@ class MonPlugin():
         Returns: plugin_id: if already created, None: if needs to be created
         """
         plugin_id = None
-        #Find the REST Plugin id details for - MON_module_REST_Plugin
+        # Find the REST Plugin id details for - MON_module_REST_Plugin
         api_url = '/suite-api/api/alertplugins'
         headers = {'Accept': 'application/json'}
 
         resp = requests.get(self.vrops_site + api_url,
                             auth=(self.vrops_user, self.vrops_password),
-                            verify = False, headers = headers)
+                            verify=False, headers=headers)
 
         if resp.status_code is not 200:
-            self.logger.warning("Failed to REST GET Alarm plugin details \nResponse code: {}\nResponse content: {}"\
-            .format(resp.status_code, resp.content))
+            logger.warning("Failed to REST GET Alarm plugin details  nResponse code: {} nResponse content: {}"
+                           .format(resp.status_code, resp.content))
             return None
 
         # Look for specific plugin & parse pluginId for 'MON_module_REST_Plugin'
@@ -501,13 +506,12 @@ class MonPlugin():
                     plugin_id = notify_plugin.get('pluginId')
 
         if plugin_id is None:
-            self.logger.warning("REST plugin {} not found".format(plugin_name))
+            logger.warning("REST plugin {} not found".format(plugin_name))
             return None
         else:
-            self.logger.info("Found REST Plugin: {}".format(plugin_name))
+            logger.info("Found REST Plugin: {}".format(plugin_name))
             return plugin_id
 
-
     def enable_rest_plugin(self, plugin_id, plugin_name):
         """
         Enable the REST plugin using plugin_id
@@ -516,8 +520,8 @@ class MonPlugin():
         """
 
         if plugin_id is None or plugin_name is None:
-            self.logger.debug("enable_rest_plugin() : Plugin ID or plugin_name not provided for {} plugin"\
-                        .format(plugin_name))
+            logger.debug("enable_rest_plugin() : Plugin ID or plugin_name not provided for {} plugin"
+                         .format(plugin_name))
             return False
 
         try:
@@ -525,19 +529,19 @@ class MonPlugin():
 
             resp = requests.put(self.vrops_site + api_url,
                                 auth=(self.vrops_user, self.vrops_password),
-                                verify = False)
+                                verify=False)
 
             if resp.status_code is not 204:
-                self.logger.warning("Failed to enable REST plugin {}. \nResponse code {}\nResponse Content: {}"\
-                        .format(plugin_name, resp.status_code, resp.content))
+                logger.warning("Failed to enable REST plugin {}.  nResponse code {} nResponse Content: {}"
+                               .format(plugin_name, resp.status_code, resp.content))
                 return False
 
-            self.logger.info("Enabled REST plugin {}.".format(plugin_name))
+            logger.info("Enabled REST plugin {}.".format(plugin_name))
             return True
 
         except Exception as exp:
-            self.logger.warning("Error enabling REST plugin for {} plugin: Exception: {}\n{}"\
-                    .format(plugin_name, exp, traceback.format_exc()))
+            logger.warning("Error enabling REST plugin for {} plugin: Exception: {} n{}"
+                           .format(plugin_name, exp, traceback.format_exc()))
 
     def create_alarm_notification_rule(self, alarm_name, alarm_id, resource_id):
         """
@@ -554,45 +558,45 @@ class MonPlugin():
         notification_id = None
         plugin_name = 'MON_module_REST_Plugin'
 
-        #1) Find the REST Plugin id details for - MON_module_REST_Plugin
+        # 1) Find the REST Plugin id details for - MON_module_REST_Plugin
         plugin_id = self.check_if_plugin_configured(plugin_name)
         if plugin_id is None:
-            self.logger.warning("Failed to get REST plugin_id for : {}".format('MON_module_REST_Plugin'))
+            logger.warning("Failed to get REST plugin_id for : {}".format('MON_module_REST_Plugin'))
             return None
 
-        #2) Create Alarm notification rule
+        # 2) Create Alarm notification rule
         api_url = '/suite-api/api/notifications/rules'
         headers = {'Content-Type': 'application/json', 'Accept': 'application/json'}
         data = {
-                    "name" : notification_name,
-                    "pluginId" : plugin_id,
-                    "resourceFilter": {
-                        "matchResourceIdOnly": True,
-                        "resourceId": resource_id
-                        },
-                    "alertDefinitionIdFilters" : {
-                    "values" : [ alarm_id ]
-                    }
-                }
+            "name": notification_name,
+            "pluginId": plugin_id,
+            "resourceFilter": {
+                "matchResourceIdOnly": True,
+                "resourceId": resource_id
+            },
+            "alertDefinitionIdFilters": {
+                "values": [alarm_id]
+            }
+        }
 
         resp = requests.post(self.vrops_site + api_url,
                              auth=(self.vrops_user, self.vrops_password),
                              headers=headers,
-                             verify = False,
+                             verify=False,
                              data=json.dumps(data))
 
         if resp.status_code is not 201:
-            self.logger.warning("Failed to create Alarm notification rule {} for {} alarm."\
-                        "\nResponse code: {}\nResponse content: {}"\
-                        .format(notification_name, alarm_name, resp.status_code, resp.content))
+            logger.warning("Failed to create Alarm notification rule {} for {} alarm."
+                           " nResponse code: {} nResponse content: {}"
+                           .format(notification_name, alarm_name, resp.status_code, resp.content))
             return None
 
-        #parse notification id from response
+        # parse notification id from response
         resp_data = json.loads(resp.content)
         if resp_data.get('id') is not None:
             notification_id = resp_data['id']
 
-        self.logger.info("Created Alarm notification rule {} for {} alarm.".format(notification_name, alarm_name))
+        logger.info("Created Alarm notification rule {} for {} alarm.".format(notification_name, alarm_name))
         return notification_id
 
     def get_vm_moref_id(self, vapp_uuid):
@@ -604,14 +608,12 @@ class MonPlugin():
                 vm_details = self.get_vapp_details_rest(vapp_uuid)
                 if vm_details and "vm_vcenter_info" in vm_details:
                     vm_moref_id = vm_details["vm_vcenter_info"].get("vm_moref_id", None)
-
-            self.logger.info("Found vm_moref_id: {} for vApp UUID: {}".format(vm_moref_id, vapp_uuid))
-            return vm_moref_id
+                    logger.info("Found vm_moref_id: {} for vApp UUID: {}".format(vm_moref_id, vapp_uuid))
+                    return vm_moref_id
 
         except Exception as exp:
-            self.logger.warning("Error occurred while getting VM moref ID for VM : {}\n{}"\
-                        .format(exp, traceback.format_exc()))
-
+            logger.warning("Error occurred while getting VM moref ID for VM : {} n{}"
+                           .format(exp, traceback.format_exc()))
 
     def get_vapp_details_rest(self, vapp_uuid=None):
         """
@@ -632,31 +634,31 @@ class MonPlugin():
 
         vca = self.connect_as_admin()
         if not vca:
-            self.logger.warning("Failed to connect to vCD")
+            logger.warning("Failed to connect to vCD")
             return parsed_respond
 
         url_list = [self.vcloud_site, '/api/vApp/vapp-', vapp_uuid]
         get_vapp_restcall = ''.join(url_list)
 
         if vca._session:
-            headers = {'Accept':'application/*+xml;version=' + API_VERSION,
+            headers = {'Accept': 'application/*+xml;version=' + API_VERSION,
                        'x-vcloud-authorization': vca._session.headers['x-vcloud-authorization']}
             response = requests.get(get_vapp_restcall,
                                     headers=headers,
                                     verify=False)
 
             if response.status_code != 200:
-                self.logger.warning("REST API call {} failed. Return status code {}"\
-                            .format(get_vapp_restcall, response.content))
+                logger.warning("REST API call {} failed. Return status code {}"
+                               .format(get_vapp_restcall, response.content))
                 return parsed_respond
 
             try:
                 xmlroot_respond = XmlElementTree.fromstring(response.content)
 
                 namespaces = {'vm': 'http://www.vmware.com/vcloud/v1.5',
-                              "vmext":"http://www.vmware.com/vcloud/extension/v1.5",
-                              "xmlns":"http://www.vmware.com/vcloud/v1.5"
-                             }
+                              "vmext": "http://www.vmware.com/vcloud/extension/v1.5",
+                              "xmlns": "http://www.vmware.com/vcloud/v1.5"
+                              }
 
                 # parse children section for other attrib
                 children_section = xmlroot_respond.find('vm:Children/', namespaces)
@@ -668,15 +670,14 @@ class MonPlugin():
                         vmext = vim_info.find('vmext:VmVimObjectRef', namespaces)
                         if vmext is not None:
                             vm_vcenter_info["vm_moref_id"] = vmext.find('vmext:MoRef', namespaces).text
-                        parsed_respond["vm_vcenter_info"]= vm_vcenter_info
+                        parsed_respond["vm_vcenter_info"] = vm_vcenter_info
 
-            except Exception as exp :
-                self.logger.warning("Error occurred calling rest api for getting vApp details: {}\n{}"\
-                            .format(exp, traceback.format_exc()))
+            except Exception as exp:
+                logger.warning("Error occurred calling rest api for getting vApp details: {} n{}"
+                               .format(exp, traceback.format_exc()))
 
         return parsed_respond
 
-
     def connect_as_admin(self):
         """ Method connect as pvdc admin user to vCloud director.
             There are certain action that can be done only by provider vdc admin user.
@@ -686,20 +687,19 @@ class MonPlugin():
                 The return vca object that letter can be used to connect to vcloud direct as admin for provider vdc
         """
 
-        self.logger.debug("Logging into vCD org as admin.")
+        logger.debug("Logging into vCD org as admin.")
 
         try:
             host = self.vcloud_site
             org = 'System'
             client_as_admin = Client(host, verify_ssl_certs=False)
-            client_as_admin.set_credentials(BasicLoginCredentials(self.admin_username, org,\
+            client_as_admin.set_credentials(BasicLoginCredentials(self.admin_username, org,
                                                                   self.admin_password))
-        except Exception as e:
-            self.logger.warning("Can't connect to a vCloud director as: {} with exception {}"\
-                             .format(self.admin_username, e))
-
-        return client_as_admin
+            return client_as_admin
 
+        except Exception as e:
+            logger.warning("Can't connect to a vCloud director as: {} with exception {}"
+                           .format(self.admin_username, e))
 
     def get_vm_resource_id(self, vm_moref_id):
         """ Find resource ID in vROPs using vm_moref_id
@@ -712,12 +712,12 @@ class MonPlugin():
 
         resp = requests.get(self.vrops_site + api_url,
                             auth=(self.vrops_user, self.vrops_password),
-                            verify = False, headers = headers)
+                            verify=False, headers=headers)
 
         if resp.status_code is not 200:
-            self.logger.warning("Failed to get resource details from vROPs for {}"\
-                             "\nResponse code:{}\nResponse Content: {}"\
-                             .format(vm_moref_id, resp.status_code, resp.content))
+            logger.warning("Failed to get resource details from vROPs for {}"
+                           " nResponse code:{} nResponse Content: {}"
+                           .format(vm_moref_id, resp.status_code, resp.content))
             return None
 
         vm_resource_id = None
@@ -731,20 +731,19 @@ class MonPlugin():
                         if resource_details.get('resourceIdentifiers') is not None:
                             resource_identifiers = resource_details['resourceIdentifiers']
                             for resource_identifier in resource_identifiers:
-                                if resource_identifier['identifierType']['name']=='VMEntityObjectID':
+                                if resource_identifier['identifierType']['name'] == 'VMEntityObjectID':
                                     if resource_identifier.get('value') is not None and \
-                                        resource_identifier['value']==vm_moref_id:
+                                            resource_identifier['value'] == vm_moref_id:
                                         vm_resource_id = resource['identifier']
-                                        self.logger.info("Found VM resource ID: {} for vm_moref_id: {}"\
-                                                         .format(vm_resource_id, vm_moref_id))
+                                        logger.info("Found VM resource ID: {} for vm_moref_id: {}"
+                                                    .format(vm_resource_id, vm_moref_id))
 
         except Exception as exp:
-            self.logger.warning("get_vm_resource_id: Error in parsing {}\n{}"\
-                             .format(exp, traceback.format_exc()))
+            logger.warning("get_vm_resource_id: Error in parsing {} n{}"
+                           .format(exp, traceback.format_exc()))
 
         return vm_resource_id
 
-
     def get_metrics_data(self, metric={}):
         """Get an individual metric's data of a resource.
         Params:
@@ -768,79 +767,80 @@ class MonPlugin():
         return_data['schema_type'] = 'read_metric_data_response'
         return_data['vim_uuid'] = metric['vim_uuid']
         return_data['metric_name'] = metric['metric_name']
-        #To do - No metric_uuid in vROPs, thus returning '0'
+        # To do - No metric_uuid in vROPs, thus returning '0'
         return_data['metric_uuid'] = '0'
         return_data['correlation_id'] = metric['correlation_id']
         return_data['resource_uuid'] = metric['resource_uuid']
-        return_data['metrics_data'] = {'time_series':[], 'metrics_series':[]}
-        #To do - Need confirmation about uuid & id
+        return_data['metrics_data'] = {'time_series': [], 'metrics_series': []}
+        # To do - Need confirmation about uuid & id
         ##if 'tenant_uuid' in metric and metric['tenant_uuid'] is not None:
         ##    return_data['tenant_uuid'] = metric['tenant_uuid']
         ##else:
         ##    return_data['tenant_uuid'] = None
         return_data['unit'] = None
-        #return_data['tenant_id'] = self.tenant_id
-        #self.logger.warning("return_data: {}".format(return_data))
+        # return_data['tenant_id'] = self.tenant_id
+        # logger.warning("return_data: {}".format(return_data))
 
-        #1) Get metric details from plugin specific file & format it into vROPs metrics
+        # 1) Get metric details from plugin specific file & format it into vROPs metrics
         metric_key_params = self.get_default_Params(metric['metric_name'])
 
         if not metric_key_params:
-            self.logger.warning("Metric not supported: {}".format(metric['metric_name']))
-            #To Do: Return message
+            logger.warning("Metric not supported: {}".format(metric['metric_name']))
+            # To Do: Return message
             return return_data
 
         return_data['unit'] = metric_key_params['unit']
 
-        #2) Find the resource id in vROPs based on OSM resource_uuid
-        #2.a) Find vm_moref_id from vApp uuid in vCD
+        # 2) Find the resource id in vROPs based on OSM resource_uuid
+        # 2.a) Find vm_moref_id from vApp uuid in vCD
         vm_moref_id = self.get_vm_moref_id(metric['resource_uuid'])
         if vm_moref_id is None:
-            self.logger.warning("Failed to find vm morefid for vApp in vCD: {}".format(metric['resource_uuid']))
+            logger.warning("Failed to find vm morefid for vApp in vCD: {}".format(metric['resource_uuid']))
             return return_data
-        #2.b) Based on vm_moref_id, find VM's corresponding resource_id in vROPs to set notification
+        # 2.b) Based on vm_moref_id, find VM's corresponding resource_id in vROPs to set notification
         resource_id = self.get_vm_resource_id(vm_moref_id)
         if resource_id is None:
-            self.logger.warning("Failed to find resource in vROPs: {}".format(metric['resource_uuid']))
+            logger.warning("Failed to find resource in vROPs: {}".format(metric['resource_uuid']))
             return return_data
 
-        #3) Calculate begin & end time for period & period unit
+        # 3) Calculate begin & end time for period & period unit
         end_time = int(round(time.time() * 1000))
         if metric['collection_unit'] == 'YR':
             time_diff = PERIOD_MSEC[metric['collection_unit']]
         else:
-            time_diff = metric['collection_period']* PERIOD_MSEC[metric['collection_unit']]
+            time_diff = metric['collection_period'] * PERIOD_MSEC[metric['collection_unit']]
         begin_time = end_time - time_diff
 
-        #4) Get the metrics data
-        self.logger.info("metric_key_params['metric_key'] = {}".format(metric_key_params['metric_key']))
-        self.logger.info("end_time: {}, begin_time: {}".format(end_time, begin_time))
+        # 4) Get the metrics data
+        logger.info("metric_key_params['metric_key'] = {}".format(metric_key_params['metric_key']))
+        logger.info("end_time: {}, begin_time: {}".format(end_time, begin_time))
 
-        url_list = ['/suite-api/api/resources/', resource_id, '/stats?statKey=',\
-                    metric_key_params['metric_key'], '&begin=', str(begin_time),'&end=',str(end_time)]
+        url_list = ['/suite-api/api/resources/', resource_id, '/stats?statKey=',
+                    metric_key_params['metric_key'], '&begin=', str(begin_time), '&end=', str(end_time)]
         api_url = ''.join(url_list)
         headers = {'Accept': 'application/json'}
 
         resp = requests.get(self.vrops_site + api_url,
                             auth=(self.vrops_user, self.vrops_password),
-                            verify = False, headers = headers)
+                            verify=False, headers=headers)
 
         if resp.status_code is not 200:
-            self.logger.warning("Failed to retrieve Metric data from vROPs for {}\nResponse code:{}\nResponse Content: {}"\
+            logger.warning(
+                "Failed to retrieve Metric data from vROPs for {} nResponse code:{} nResponse Content: {}"
                     .format(metric['metric_name'], resp.status_code, resp.content))
             return return_data
 
-        #5) Convert to required format
+        # 5) Convert to required format
         metrics_data = {}
         json_data = json.loads(resp.content)
-        for resp_key,resp_val in six.iteritems(json_data):
+        for resp_key, resp_val in six.iteritems(json_data):
             if resp_key == 'values':
                 data = json_data['values'][0]
-                for data_k,data_v in six.iteritems(data):
+                for data_k, data_v in six.iteritems(data):
                     if data_k == 'stat-list':
                         stat_list = data_v
-                        for stat_list_k,stat_list_v in six.iteritems(stat_list):
-                            for stat_keys,stat_vals in six.iteritems(stat_list_v[0]):
+                        for stat_list_k, stat_list_v in six.iteritems(stat_list):
+                            for stat_keys, stat_vals in six.iteritems(stat_list_v[0]):
                                 if stat_keys == 'timestamps':
                                     metrics_data['time_series'] = stat_list_v[0]['timestamps']
                                 if stat_keys == 'data':
@@ -854,27 +854,27 @@ class MonPlugin():
         """Update alarm configuration (i.e. Symptom & alarm) as per request
         """
         if new_alarm_config.get('alarm_uuid') is None:
-            self.logger.warning("alarm_uuid is required to update an Alarm")
+            logger.warning("alarm_uuid is required to update an Alarm")
             return None
-        #1) Get Alarm details from it's uuid & find the symptom definition
+        # 1) Get Alarm details from it's uuid & find the symptom definition
         alarm_details_json, alarm_details = self.get_alarm_defination_details(new_alarm_config['alarm_uuid'])
         if alarm_details_json is None:
             return None
 
         try:
-            #2) Update the symptom definition
+            # 2) Update the symptom definition
             if alarm_details['alarm_id'] is not None and alarm_details['symptom_definition_id'] is not None:
                 symptom_defination_id = alarm_details['symptom_definition_id']
             else:
-                self.logger.info("Symptom Definition ID not found for {}".format(new_alarm_config['alarm_uuid']))
+                logger.info("Symptom Definition ID not found for {}".format(new_alarm_config['alarm_uuid']))
                 return None
 
             symptom_uuid = self.update_symptom_defination(symptom_defination_id, new_alarm_config)
 
-            #3) Update the alarm definition & Return UUID if successful update
+            # 3) Update the alarm definition & Return UUID if successful update
             if symptom_uuid is None:
-                self.logger.info("Symptom Definition details not found for {}"\
-                                .format(new_alarm_config['alarm_uuid']))
+                logger.info("Symptom Definition details not found for {}"
+                            .format(new_alarm_config['alarm_uuid']))
                 return None
             else:
                 alarm_uuid = self.reconfigure_alarm(alarm_details_json, new_alarm_config)
@@ -883,13 +883,13 @@ class MonPlugin():
                 else:
                     return alarm_uuid
         except:
-            self.logger.error("Exception while updating alarm: {}".format(traceback.format_exc()))
+            logger.error("Exception while updating alarm: {}".format(traceback.format_exc()))
 
     def get_alarm_defination_details(self, alarm_uuid):
         """Get alarm details based on alarm UUID
         """
         if alarm_uuid is None:
-            self.logger.warning("get_alarm_defination_details: Alarm UUID not provided")
+            logger.warning("get_alarm_defination_details: Alarm UUID not provided")
             return None, None
 
         alarm_details = {}
@@ -899,11 +899,11 @@ class MonPlugin():
 
         resp = requests.get(self.vrops_site + api_url + alarm_uuid,
                             auth=(self.vrops_user, self.vrops_password),
-                            verify = False, headers = headers)
+                            verify=False, headers=headers)
 
         if resp.status_code is not 200:
-            self.logger.warning("Alarm to be updated not found: {}\nResponse code:{}\nResponse Content: {}"\
-                    .format(alarm_uuid, resp.status_code, resp.content))
+            logger.warning("Alarm to be updated not found: {} nResponse code:{} nResponse Content: {}"
+                           .format(alarm_uuid, resp.status_code, resp.content))
             return None, None
 
         try:
@@ -915,14 +915,14 @@ class MonPlugin():
                 alarm_details['resource_kind'] = json_data['resourceKindKey']
                 alarm_details['type'] = json_data['type']
                 alarm_details['sub_type'] = json_data['subType']
-                alarm_details['symptom_definition_id'] = json_data['states'][0]['base-symptom-set']['symptomDefinitionIds'][0]
+                alarm_details['symptom_definition_id'] = \
+                    json_data['states'][0]['base-symptom-set']['symptomDefinitionIds'][0]
         except Exception as exp:
-            self.logger.warning("Exception while retrieving alarm definition details: {}".format(exp))
+            logger.warning("Exception while retrieving alarm definition details: {}".format(exp))
             return None, None
 
         return json_data, alarm_details
 
-
     def get_alarm_defination_by_name(self, alarm_name):
         """Get alarm details based on alarm name
         """
@@ -930,7 +930,7 @@ class MonPlugin():
         alert_match_list = []
 
         if alarm_name is None:
-            self.logger.warning("get_alarm_defination_by_name: Alarm name not provided")
+            logger.warning("get_alarm_defination_by_name: Alarm name not provided")
             return alert_match_list
 
         json_data = {}
@@ -939,11 +939,11 @@ class MonPlugin():
 
         resp = requests.get(self.vrops_site + api_url,
                             auth=(self.vrops_user, self.vrops_password),
-                            verify = False, headers = headers)
+                            verify=False, headers=headers)
 
         if resp.status_code is not 200:
-            self.logger.warning("get_alarm_defination_by_name: Error in response: {}\nResponse code:{}"\
-                    "\nResponse Content: {}".format(alarm_name, resp.status_code, resp.content))
+            logger.warning("get_alarm_defination_by_name: Error in response: {} nResponse code:{}"
+                           " nResponse Content: {}".format(alarm_name, resp.status_code, resp.content))
             return alert_match_list
 
         try:
@@ -952,21 +952,20 @@ class MonPlugin():
                 alerts_list = json_data['alertDefinitions']
                 alert_match_list = list(filter(lambda alert: alert['name'] == alarm_name, alerts_list))
                 status = False if not alert_match_list else True
-                #self.logger.debug("Found alert_match_list: {}for larm_name: {},\nstatus: {}".format(alert_match_list, alarm_name,status))
+                # logger.debug("Found alert_match_list: {}for larm_name: {}, nstatus: {}".format(alert_match_list, alarm_name,status))
 
             return alert_match_list
 
         except Exception as exp:
-            self.logger.warning("Exception while searching alarm definition: {}".format(exp))
+            logger.warning("Exception while searching alarm definition: {}".format(exp))
             return alert_match_list
 
-
     def update_symptom_defination(self, symptom_uuid, new_alarm_config):
         """Update symptom definition based on new alarm input configuration
         """
-        #1) Get symptom definition details
+        # 1) Get symptom definition details
         symptom_details = self.get_symptom_defination_details(symptom_uuid)
-        #print "\n\nsymptom_details: {}".format(symptom_details)
+        # print " n nsymptom_details: {}".format(symptom_details)
         if symptom_details is None:
             return None
 
@@ -976,48 +975,46 @@ class MonPlugin():
             symptom_details['state']['condition']['operator'] = OPERATION_MAPPING[new_alarm_config['operation']]
         if 'threshold_value' in new_alarm_config and new_alarm_config['threshold_value'] is not None:
             symptom_details['state']['condition']['value'] = new_alarm_config['threshold_value']
-        #Find vrops metric key from metric_name, if required
+        # Find vrops metric key from metric_name, if required
         """
         if 'metric_name' in new_alarm_config and new_alarm_config['metric_name'] is not None:
             metric_key_params = self.get_default_Params(new_alarm_config['metric_name'])
             if not metric_key_params:
-                self.logger.warning("Metric not supported: {}".format(config_dict['metric_name']))
+                logger.warning("Metric not supported: {}".format(config_dict['metric_name']))
                 return None
             symptom_details['state']['condition']['key'] = metric_key_params['metric_key']
         """
-        self.logger.info("Fetched Symptom details : {}".format(symptom_details))
+        logger.info("Fetched Symptom details : {}".format(symptom_details))
 
         api_url = '/suite-api/api/symptomdefinitions'
-        headers = {'Content-Type': 'application/json', 'Accept':'application/json'}
+        headers = {'Content-Type': 'application/json', 'Accept': 'application/json'}
         data = json.dumps(symptom_details)
         resp = requests.put(self.vrops_site + api_url,
-                             auth=(self.vrops_user, self.vrops_password),
-                             headers=headers,
-                             verify = False,
-                             data=data)
+                            auth=(self.vrops_user, self.vrops_password),
+                            headers=headers,
+                            verify=False,
+                            data=data)
 
         if resp.status_code != 200:
-            self.logger.warning("Failed to update Symptom definition: {}, response {}"\
-                    .format(symptom_uuid, resp.content))
+            logger.warning("Failed to update Symptom definition: {}, response {}"
+                           .format(symptom_uuid, resp.content))
             return None
 
-
         if symptom_uuid is not None:
-            self.logger.info("Symptom definition updated {} for alarm: {}"\
-                    .format(symptom_uuid, new_alarm_config['alarm_uuid']))
+            logger.info("Symptom definition updated {} for alarm: {}"
+                        .format(symptom_uuid, new_alarm_config['alarm_uuid']))
             return symptom_uuid
         else:
-            self.logger.warning("Failed to update Symptom Definition {} for : {}"\
-                    .format(symptom_uuid, new_alarm_config['alarm_uuid']))
+            logger.warning("Failed to update Symptom Definition {} for : {}"
+                           .format(symptom_uuid, new_alarm_config['alarm_uuid']))
             return None
 
-
     def get_symptom_defination_details(self, symptom_uuid):
         """Get symptom definition details
         """
         symptom_details = {}
         if symptom_uuid is None:
-            self.logger.warning("get_symptom_defination_details: Symptom UUID not provided")
+            logger.warning("get_symptom_defination_details: Symptom UUID not provided")
             return None
 
         api_url = '/suite-api/api/symptomdefinitions/'
@@ -1025,18 +1022,17 @@ class MonPlugin():
 
         resp = requests.get(self.vrops_site + api_url + symptom_uuid,
                             auth=(self.vrops_user, self.vrops_password),
-                            verify = False, headers = headers)
+                            verify=False, headers=headers)
 
         if resp.status_code is not 200:
-            self.logger.warning("Symptom definition not found {} \nResponse code:{}\nResponse Content: {}"\
-                    .format(symptom_uuid, resp.status_code, resp.content))
+            logger.warning("Symptom definition not found {}  nResponse code:{} nResponse Content: {}"
+                           .format(symptom_uuid, resp.status_code, resp.content))
             return None
 
         symptom_details = json.loads(resp.content)
-        #print "New symptom Details: {}".format(symptom_details)
+        # print "New symptom Details: {}".format(symptom_details)
         return symptom_details
 
-
     def reconfigure_alarm(self, alarm_details_json, new_alarm_config):
         """Reconfigure alarm definition as per input
         """
@@ -1046,52 +1042,52 @@ class MonPlugin():
             alarm_details_json['description'] = new_alarm_config['description']
 
         api_url = '/suite-api/api/alertdefinitions'
-        headers = {'Content-Type': 'application/json', 'Accept':'application/json'}
+        headers = {'Content-Type': 'application/json', 'Accept': 'application/json'}
         data = json.dumps(alarm_details_json)
         resp = requests.put(self.vrops_site + api_url,
-                             auth=(self.vrops_user, self.vrops_password),
-                             headers=headers,
-                             verify = False,
-                             data=data)
+                            auth=(self.vrops_user, self.vrops_password),
+                            headers=headers,
+                            verify=False,
+                            data=data)
 
         if resp.status_code != 200:
-            self.logger.warning("Failed to update Alarm definition: {}, response code {}, response content: {}"\
-                    .format(alarm_details_json['id'], resp.status_code, resp.content))
+            logger.warning("Failed to update Alarm definition: {}, response code {}, response content: {}"
+                           .format(alarm_details_json['id'], resp.status_code, resp.content))
             return None
         else:
             parsed_alarm_details = json.loads(resp.content)
             alarm_def_uuid = parsed_alarm_details['id'].split('-', 1)[1]
-            self.logger.info("Successfully updated Alarm definition: {}".format(alarm_def_uuid))
+            logger.info("Successfully updated Alarm definition: {}".format(alarm_def_uuid))
             return alarm_def_uuid
 
     def delete_alarm_configuration(self, delete_alarm_req_dict):
         """Delete complete alarm configuration
         """
         if delete_alarm_req_dict['alarm_uuid'] is None:
-            self.logger.info("delete_alarm_configuration: Alarm UUID not provided")
+            logger.info("delete_alarm_configuration: Alarm UUID not provided")
             return None
-        #1)Get alarm & symptom definition details
+        # 1)Get alarm & symptom definition details
         alarm_details_json, alarm_details = self.get_alarm_defination_details(delete_alarm_req_dict['alarm_uuid'])
         if alarm_details is None or alarm_details_json is None:
             return None
 
-        #2) Delete alarm notification
+        # 2) Delete alarm notification
         rule_id = self.delete_notification_rule(alarm_details['alarm_name'])
         if rule_id is None:
             return None
 
-        #3) Delete alarm configuration
+        # 3) Delete alarm configuration
         alarm_id = self.delete_alarm_defination(alarm_details['alarm_id'])
         if alarm_id is None:
             return None
 
-        #4) Delete alarm symptom
+        # 4) Delete alarm symptom
         symptom_id = self.delete_symptom_definition(alarm_details['symptom_definition_id'])
         if symptom_id is None:
             return None
         else:
-            self.logger.info("Completed deleting alarm configuration: {}"\
-                    .format(delete_alarm_req_dict['alarm_uuid']))
+            logger.info("Completed deleting alarm configuration: {}"
+                        .format(delete_alarm_req_dict['alarm_uuid']))
             return delete_alarm_req_dict['alarm_uuid']
 
     def delete_notification_rule(self, alarm_name):
@@ -1102,15 +1098,15 @@ class MonPlugin():
             return None
         else:
             api_url = '/suite-api/api/notifications/rules/'
-            headers = {'Accept':'application/json'}
+            headers = {'Accept': 'application/json'}
             resp = requests.delete(self.vrops_site + api_url + rule_id,
-                                auth=(self.vrops_user, self.vrops_password),
-                                verify = False, headers = headers)
+                                   auth=(self.vrops_user, self.vrops_password),
+                                   verify=False, headers=headers)
             if resp.status_code is not 204:
-                self.logger.warning("Failed to delete notification rules for {}".format(alarm_name))
+                logger.warning("Failed to delete notification rules for {}".format(alarm_name))
                 return None
             else:
-                self.logger.info("Deleted notification rules for {}".format(alarm_name))
+                logger.info("Deleted notification rules for {}".format(alarm_name))
                 return rule_id
 
     def get_notification_rule_id_by_alarm_name(self, alarm_name):
@@ -1118,14 +1114,14 @@ class MonPlugin():
         """
         alarm_notify_id = 'notify_' + alarm_name
         api_url = '/suite-api/api/notifications/rules'
-        headers = {'Content-Type': 'application/json', 'Accept':'application/json'}
+        headers = {'Content-Type': 'application/json', 'Accept': 'application/json'}
         resp = requests.get(self.vrops_site + api_url,
                             auth=(self.vrops_user, self.vrops_password),
-                            verify = False, headers = headers)
+                            verify=False, headers=headers)
 
         if resp.status_code is not 200:
-            self.logger.warning("Failed to get notification rules details for {}"\
-                    .format(alarm_name))
+            logger.warning("Failed to get notification rules details for {}"
+                           .format(alarm_name))
             return None
 
         notifications = json.loads(resp.content)
@@ -1134,45 +1130,44 @@ class MonPlugin():
             for dict in notifications_list:
                 if dict['name'] is not None and dict['name'] == alarm_notify_id:
                     notification_id = dict['id']
-                    self.logger.info("Found Notification id to be deleted: {} for {}"\
-                            .format(notification_id, alarm_name))
+                    logger.info("Found Notification id to be deleted: {} for {}"
+                                .format(notification_id, alarm_name))
                     return notification_id
 
-            self.logger.warning("Notification id to be deleted not found for {}"\
-                            .format(alarm_name))
+            logger.warning("Notification id to be deleted not found for {}"
+                           .format(alarm_name))
             return None
 
     def delete_alarm_defination(self, alarm_id):
         """Delete created Alarm definition
         """
         api_url = '/suite-api/api/alertdefinitions/'
-        headers = {'Accept':'application/json'}
+        headers = {'Accept': 'application/json'}
         resp = requests.delete(self.vrops_site + api_url + alarm_id,
-                            auth=(self.vrops_user, self.vrops_password),
-                            verify = False, headers = headers)
+                               auth=(self.vrops_user, self.vrops_password),
+                               verify=False, headers=headers)
         if resp.status_code is not 204:
-            self.logger.warning("Failed to delete alarm definition {}".format(alarm_id))
+            logger.warning("Failed to delete alarm definition {}".format(alarm_id))
             return None
         else:
-            self.logger.info("Deleted alarm definition {}".format(alarm_id))
+            logger.info("Deleted alarm definition {}".format(alarm_id))
             return alarm_id
 
     def delete_symptom_definition(self, symptom_id):
         """Delete symptom definition
         """
         api_url = '/suite-api/api/symptomdefinitions/'
-        headers = {'Accept':'application/json'}
+        headers = {'Accept': 'application/json'}
         resp = requests.delete(self.vrops_site + api_url + symptom_id,
-                            auth=(self.vrops_user, self.vrops_password),
-                            verify = False, headers = headers)
+                               auth=(self.vrops_user, self.vrops_password),
+                               verify=False, headers=headers)
         if resp.status_code is not 204:
-            self.logger.warning("Failed to delete symptom definition {}".format(symptom_id))
+            logger.warning("Failed to delete symptom definition {}".format(symptom_id))
             return None
         else:
-            self.logger.info("Deleted symptom definition {}".format(symptom_id))
+            logger.info("Deleted symptom definition {}".format(symptom_id))
             return symptom_id
 
-
     def verify_metric_support(self, metric_info):
         """Verify, if Metric is supported by vROPs plugin, verify metric unit & return status
             Returns:
@@ -1180,108 +1175,107 @@ class MonPlugin():
         """
         status = False
         if 'metric_name' not in metric_info:
-            self.logger.debug("Metric name not provided: {}".format(metric_info))
+            logger.debug("Metric name not provided: {}".format(metric_info))
             return status
         metric_key_params = self.get_default_Params(metric_info['metric_name'].lower())
         if not metric_key_params:
-            self.logger.warning("Metric not supported: {}".format(metric_info['metric_name']))
+            logger.warning("Metric not supported: {}".format(metric_info['metric_name']))
             return status
         else:
-            #If Metric is supported, verify optional metric unit & return status
+            # If Metric is supported, verify optional metric unit & return status
             if 'metric_unit' in metric_info:
                 if metric_key_params.get('unit') == metric_info['metric_unit']:
-                    self.logger.info("Metric is supported with unit: {}".format(metric_info['metric_name']))
+                    logger.info("Metric is supported with unit: {}".format(metric_info['metric_name']))
                     status = True
                 else:
-                    self.logger.debug("Metric supported but there is unit mismatch for: {}."\
-                                    "Supported unit: {}"\
-                                    .format(metric_info['metric_name'],metric_key_params['unit']))
+                    logger.debug("Metric supported but there is unit mismatch for: {}."
+                                 "Supported unit: {}"
+                                 .format(metric_info['metric_name'], metric_key_params['unit']))
                     status = True
         return status
 
     def get_triggered_alarms_list(self, list_alarm_input):
         """Get list of triggered alarms on a resource based on alarm input request.
         """
-        #TO Do - Need to add filtering of alarms based on Severity & alarm name
+        # TO Do - Need to add filtering of alarms based on Severity & alarm name
 
         triggered_alarms_list = []
         if list_alarm_input.get('resource_uuid') is None:
-            self.logger.warning("Resource UUID is required to get triggered alarms list")
+            logger.warning("Resource UUID is required to get triggered alarms list")
             return triggered_alarms_list
 
-        #1)Find vROPs resource ID using RO resource UUID
+        # 1)Find vROPs resource ID using RO resource UUID
         vrops_resource_id = self.get_vrops_resourceid_from_ro_uuid(list_alarm_input['resource_uuid'])
         if vrops_resource_id is None:
             return triggered_alarms_list
 
-        #2)Get triggered alarms on particular resource
-        triggered_alarms_list = self.get_triggered_alarms_on_resource(list_alarm_input['resource_uuid'], vrops_resource_id)
+        # 2)Get triggered alarms on particular resource
+        triggered_alarms_list = self.get_triggered_alarms_on_resource(list_alarm_input['resource_uuid'],
+                                                                      vrops_resource_id)
         return triggered_alarms_list
 
     def get_vrops_resourceid_from_ro_uuid(self, ro_resource_uuid):
         """Fetch vROPs resource ID using resource UUID from RO/SO
         """
-        #1) Find vm_moref_id from vApp uuid in vCD
+        # 1) Find vm_moref_id from vApp uuid in vCD
         vm_moref_id = self.get_vm_moref_id(ro_resource_uuid)
         if vm_moref_id is None:
-            self.logger.warning("Failed to find vm morefid for vApp in vCD: {}".format(ro_resource_uuid))
+            logger.warning("Failed to find vm morefid for vApp in vCD: {}".format(ro_resource_uuid))
             return None
 
-        #2) Based on vm_moref_id, find VM's corresponding resource_id in vROPs to set notification
+        # 2) Based on vm_moref_id, find VM's corresponding resource_id in vROPs to set notification
         vrops_resource_id = self.get_vm_resource_id(vm_moref_id)
         if vrops_resource_id is None:
-            self.logger.warning("Failed to find resource in vROPs: {}".format(ro_resource_uuid))
+            logger.warning("Failed to find resource in vROPs: {}".format(ro_resource_uuid))
             return None
         return vrops_resource_id
 
-
     def get_triggered_alarms_on_resource(self, ro_resource_uuid, vrops_resource_id):
         """Get triggered alarms on particular resource & return list of dictionary of alarms
         """
         resource_alarms = []
         api_url = '/suite-api/api/alerts?resourceId='
-        headers = {'Accept':'application/json'}
+        headers = {'Accept': 'application/json'}
         resp = requests.get(self.vrops_site + api_url + vrops_resource_id,
                             auth=(self.vrops_user, self.vrops_password),
-                            verify = False, headers = headers)
+                            verify=False, headers=headers)
 
         if resp.status_code is not 200:
-            self.logger.warning("Failed to get triggered alarms for {}"\
-                    .format(ro_resource_uuid))
+            logger.warning("Failed to get triggered alarms for {}"
+                           .format(ro_resource_uuid))
             return None
 
         all_alerts = json.loads(resp.content)
         if 'alerts' in all_alerts:
             if not all_alerts['alerts']:
-                self.logger.info("No alarms present on resource {}".format(ro_resource_uuid))
+                logger.info("No alarms present on resource {}".format(ro_resource_uuid))
                 return resource_alarms
             all_alerts_list = all_alerts['alerts']
             for alarm in all_alerts_list:
-                #self.logger.info("Triggered Alarm {}".format(alarm))
-                if alarm['alertDefinitionName'] is not None and\
-                    len(alarm['alertDefinitionName'].split('-', 1)) == 2:
-                        if alarm['alertDefinitionName'].split('-', 1)[1] == ro_resource_uuid:
-                            alarm_instance = {}
-                            alarm_instance['alarm_uuid'] = alarm['alertDefinitionId'].split('-', 1)[1]
-                            alarm_instance['resource_uuid'] = ro_resource_uuid
-                            alarm_instance['alarm_instance_uuid'] = alarm['alertId']
-                            alarm_instance['vim_type'] = 'VMware'
-                            #find severity of alarm
-                            severity = None
-                            for key,value in six.iteritems(severity_mano2vrops):
-                                if value == alarm['alertLevel']:
-                                    severity = key
-                            if severity is None:
-                                severity = 'INDETERMINATE'
-                            alarm_instance['severity'] = severity
-                            alarm_instance['status'] = alarm['status']
-                            alarm_instance['start_date'] = self.convert_date_time(alarm['startTimeUTC'])
-                            alarm_instance['update_date'] = self.convert_date_time(alarm['updateTimeUTC'])
-                            alarm_instance['cancel_date'] = self.convert_date_time(alarm['cancelTimeUTC'])
-                            self.logger.info("Triggered Alarm on resource {}".format(alarm_instance))
-                            resource_alarms.append(alarm_instance)
+                # logger.info("Triggered Alarm {}".format(alarm))
+                if alarm['alertDefinitionName'] is not None and \
+                        len(alarm['alertDefinitionName'].split('-', 1)) == 2:
+                    if alarm['alertDefinitionName'].split('-', 1)[1] == ro_resource_uuid:
+                        alarm_instance = {'alarm_uuid': alarm['alertDefinitionId'].split('-', 1)[1],
+                                          'resource_uuid': ro_resource_uuid,
+                                          'alarm_instance_uuid': alarm['alertId'],
+                                          'vim_type': 'VMware'}
+                        # find severity of alarm
+                        severity = None
+                        for key, value in six.iteritems(severity_mano2vrops):
+                            if value == alarm['alertLevel']:
+                                severity = key
+                        if severity is None:
+                            severity = 'INDETERMINATE'
+                        alarm_instance['severity'] = severity
+                        alarm_instance['status'] = alarm['status']
+                        alarm_instance['start_date'] = self.convert_date_time(alarm['startTimeUTC'])
+                        alarm_instance['update_date'] = self.convert_date_time(alarm['updateTimeUTC'])
+                        alarm_instance['cancel_date'] = self.convert_date_time(alarm['cancelTimeUTC'])
+                        logger.info("Triggered Alarm on resource {}".format(alarm_instance))
+                        resource_alarms.append(alarm_instance)
         if not resource_alarms:
-            self.logger.info("No alarms present on resource {}".format(ro_resource_uuid))
+            logger.info("No alarms present on resource {}".format(ro_resource_uuid))
         return resource_alarms
 
     def convert_date_time(self, date_time):
@@ -1289,7 +1283,6 @@ class MonPlugin():
         """
         date_time_formatted = '0000-00-00T00:00:00'
         if date_time != 0:
-            complete_datetime = datetime.datetime.fromtimestamp(date_time/1000.0, tz=pytz.utc).isoformat('T')
-            date_time_formatted = complete_datetime.split('.',1)[0]
+            complete_datetime = datetime.datetime.fromtimestamp(date_time / 1000.0, tz=pytz.utc).isoformat('T')
+            date_time_formatted = complete_datetime.split('.', 1)[0]
         return date_time_formatted
-