Reformat LCM to standardized format
[osm/LCM.git] / osm_lcm / tests / test_ns.py
index 28b8fbe..192f8e0 100644 (file)
@@ -16,7 +16,7 @@
 ##
 
 
-import asynctest   # pip3 install asynctest --user
+import asynctest  # pip3 install asynctest --user
 import asyncio
 import yaml
 import copy
@@ -50,36 +50,46 @@ It allows, if some testing ENV are supplied, testing without mocking some extern
 """
 
 lcm_config = {
-    "global": {
-        "loglevel": "DEBUG"
-    },
+    "global": {"loglevel": "DEBUG"},
     "timeout": {},
-    "VCA": {   # TODO replace with os.get_env to get other configurations
+    "VCA": {  # TODO replace with os.get_env to get other configurations
         "host": getenv("OSMLCM_VCA_HOST", "vca"),
         "port": getenv("OSMLCM_VCA_PORT", 17070),
         "user": getenv("OSMLCM_VCA_USER", "admin"),
         "secret": getenv("OSMLCM_VCA_SECRET", "vca"),
         "public_key": getenv("OSMLCM_VCA_PUBKEY", None),
-        'ca_cert': getenv("OSMLCM_VCA_CACERT", None),
-        'apiproxy': getenv("OSMLCM_VCA_APIPROXY", "192.168.1.1"),
+        "ca_cert": getenv("OSMLCM_VCA_CACERT", None),
+        "apiproxy": getenv("OSMLCM_VCA_APIPROXY", "192.168.1.1"),
     },
     "ro_config": {
-        "uri": "http://{}:{}/openmano".format(getenv("OSMLCM_RO_HOST", "ro"),
-                                              getenv("OSMLCM_RO_PORT", "9090")),
+        "uri": "http://{}:{}/openmano".format(
+            getenv("OSMLCM_RO_HOST", "ro"), getenv("OSMLCM_RO_PORT", "9090")
+        ),
         "tenant": getenv("OSMLCM_RO_TENANT", "osm"),
         "logger_name": "lcm.ROclient",
         "loglevel": "DEBUG",
-        "ng": True
-    }
+        "ng": True,
+    },
 }
 
 
 class TestMyNS(asynctest.TestCase):
-
-    async def _n2vc_DeployCharms(self, model_name, application_name, vnfd, charm_path, params={}, machine_spec={},
-                                 callback=None, *callback_args):
+    async def _n2vc_DeployCharms(
+        self,
+        model_name,
+        application_name,
+        vnfd,
+        charm_path,
+        params={},
+        machine_spec={},
+        callback=None,
+        *callback_args
+    ):
         if callback:
-            for status, message in (("maintenance", "installing sofwware"), ("active", "Ready!")):
+            for status, message in (
+                ("maintenance", "installing sofwware"),
+                ("active", "Ready!"),
+            ):
                 # call callback after some time
                 asyncio.sleep(5, loop=self.loop)
                 callback(model_name, application_name, status, message, *callback_args)
@@ -91,7 +101,9 @@ class TestMyNS(asynctest.TestCase):
             yield "app_name-{}".format(num_calls)
             num_calls += 1
 
-    def _n2vc_CreateExecutionEnvironment(self, namespace, reuse_ee_id, db_dict, *args, **kwargs):
+    def _n2vc_CreateExecutionEnvironment(
+        self, namespace, reuse_ee_id, db_dict, *args, **kwargs
+    ):
         k_list = namespace.split(".")
         ee_id = k_list[1] + "."
         if len(k_list) >= 2:
@@ -105,7 +117,9 @@ class TestMyNS(asynctest.TestCase):
         print("Args > {}".format(args))
         print("kwargs > {}".format(kwargs))
         if kwargs.get("delete"):
-            ro_ns_desc = yaml.load(descriptors.ro_delete_action_text, Loader=yaml.Loader)
+            ro_ns_desc = yaml.load(
+                descriptors.ro_delete_action_text, Loader=yaml.Loader
+            )
             while True:
                 yield ro_ns_desc
 
@@ -138,11 +152,7 @@ class TestMyNS(asynctest.TestCase):
                             break
 
     def _ro_deploy(self, *args, **kwargs):
-        return {
-            'action_id': args[1]["action_id"],
-            'nsr_id': args[0],
-            'status': 'ok'
-        }
+        return {"action_id": args[1]["action_id"], "nsr_id": args[0], "status": "ok"}
 
     def _return_uuid(self, *args, **kwargs):
         return str(uuid4())
@@ -154,32 +164,45 @@ class TestMyNS(asynctest.TestCase):
             # Cleanup singleton Database instance
             Database.instance = None
 
-            self.db = Database({
-                "database": {
-                    "driver": "memory"
-                }
-            }).instance.db
-            self.db.create_list("vnfds", yaml.load(descriptors.db_vnfds_text, Loader=yaml.Loader))
-            self.db.create_list("nsds", yaml.load(descriptors.db_nsds_text, Loader=yaml.Loader))
-            self.db.create_list("nsrs", yaml.load(descriptors.db_nsrs_text, Loader=yaml.Loader))
-            self.db.create_list("vim_accounts", yaml.load(descriptors.db_vim_accounts_text, Loader=yaml.Loader))
-            self.db.create_list("k8sclusters", yaml.load(descriptors.db_k8sclusters_text, Loader=yaml.Loader))
-            self.db.create_list("nslcmops", yaml.load(descriptors.db_nslcmops_text, Loader=yaml.Loader))
-            self.db.create_list("vnfrs", yaml.load(descriptors.db_vnfrs_text, Loader=yaml.Loader))
-            self.db_vim_accounts = yaml.load(descriptors.db_vim_accounts_text, Loader=yaml.Loader)
+            self.db = Database({"database": {"driver": "memory"}}).instance.db
+            self.db.create_list(
+                "vnfds", yaml.load(descriptors.db_vnfds_text, Loader=yaml.Loader)
+            )
+            self.db.create_list(
+                "nsds", yaml.load(descriptors.db_nsds_text, Loader=yaml.Loader)
+            )
+            self.db.create_list(
+                "nsrs", yaml.load(descriptors.db_nsrs_text, Loader=yaml.Loader)
+            )
+            self.db.create_list(
+                "vim_accounts",
+                yaml.load(descriptors.db_vim_accounts_text, Loader=yaml.Loader),
+            )
+            self.db.create_list(
+                "k8sclusters",
+                yaml.load(descriptors.db_k8sclusters_text, Loader=yaml.Loader),
+            )
+            self.db.create_list(
+                "nslcmops", yaml.load(descriptors.db_nslcmops_text, Loader=yaml.Loader)
+            )
+            self.db.create_list(
+                "vnfrs", yaml.load(descriptors.db_vnfrs_text, Loader=yaml.Loader)
+            )
+            self.db_vim_accounts = yaml.load(
+                descriptors.db_vim_accounts_text, Loader=yaml.Loader
+            )
 
         # Mock kafka
         self.msg = asynctest.Mock(MsgKafka())
 
         # Mock filesystem
         if not getenv("OSMLCMTEST_FS_NOMOCK"):
-            self.fs = asynctest.Mock(Filesystem({
-                "storage": {
-                    "driver": "local",
-                    "path": "/"
-                }
-            }).instance.fs)
-            self.fs.get_params.return_value = {"path": getenv("OSMLCMTEST_PACKAGES_PATH", "./test/temp/packages")}
+            self.fs = asynctest.Mock(
+                Filesystem({"storage": {"driver": "local", "path": "/"}}).instance.fs
+            )
+            self.fs.get_params.return_value = {
+                "path": getenv("OSMLCMTEST_PACKAGES_PATH", "./test/temp/packages")
+            }
             self.fs.file_open = asynctest.mock_open()
             # self.fs.file_open.return_value.__enter__.return_value = asynctest.MagicMock()  # called on a python "with"
             # self.fs.file_open.return_value.__enter__.return_value.read.return_value = ""   # empty file
@@ -214,30 +237,57 @@ class TestMyNS(asynctest.TestCase):
         if not getenv("OSMLCMTEST_VCA_NOMOCK"):
             pub_key = getenv("OSMLCMTEST_NS_PUBKEY", "ssh-rsa test-pub-key t@osm.com")
             # self.my_ns.n2vc = asynctest.Mock(N2VC())
-            self.my_ns.n2vc.GetPublicKey.return_value = getenv("OSMLCM_VCA_PUBKEY", "public_key")
+            self.my_ns.n2vc.GetPublicKey.return_value = getenv(
+                "OSMLCM_VCA_PUBKEY", "public_key"
+            )
             # allow several versions of n2vc
-            self.my_ns.n2vc.FormatApplicationName = asynctest.Mock(side_effect=self._n2vc_FormatApplicationName())
-            self.my_ns.n2vc.DeployCharms = asynctest.CoroutineMock(side_effect=self._n2vc_DeployCharms)
+            self.my_ns.n2vc.FormatApplicationName = asynctest.Mock(
+                side_effect=self._n2vc_FormatApplicationName()
+            )
+            self.my_ns.n2vc.DeployCharms = asynctest.CoroutineMock(
+                side_effect=self._n2vc_DeployCharms
+            )
             self.my_ns.n2vc.create_execution_environment = asynctest.CoroutineMock(
-                side_effect=self._n2vc_CreateExecutionEnvironment)
-            self.my_ns.n2vc.install_configuration_sw = asynctest.CoroutineMock(return_value=pub_key)
-            self.my_ns.n2vc.get_ee_ssh_public__key = asynctest.CoroutineMock(return_value=pub_key)
-            self.my_ns.n2vc.exec_primitive = asynctest.CoroutineMock(side_effect=self._return_uuid)
-            self.my_ns.n2vc.exec_primitive = asynctest.CoroutineMock(side_effect=self._return_uuid)
-            self.my_ns.n2vc.GetPrimitiveStatus = asynctest.CoroutineMock(return_value="completed")
-            self.my_ns.n2vc.GetPrimitiveOutput = asynctest.CoroutineMock(return_value={"result": "ok",
-                                                                                       "pubkey": pub_key})
-            self.my_ns.n2vc.delete_execution_environment = asynctest.CoroutineMock(return_value=None)
+                side_effect=self._n2vc_CreateExecutionEnvironment
+            )
+            self.my_ns.n2vc.install_configuration_sw = asynctest.CoroutineMock(
+                return_value=pub_key
+            )
+            self.my_ns.n2vc.get_ee_ssh_public__key = asynctest.CoroutineMock(
+                return_value=pub_key
+            )
+            self.my_ns.n2vc.exec_primitive = asynctest.CoroutineMock(
+                side_effect=self._return_uuid
+            )
+            self.my_ns.n2vc.exec_primitive = asynctest.CoroutineMock(
+                side_effect=self._return_uuid
+            )
+            self.my_ns.n2vc.GetPrimitiveStatus = asynctest.CoroutineMock(
+                return_value="completed"
+            )
+            self.my_ns.n2vc.GetPrimitiveOutput = asynctest.CoroutineMock(
+                return_value={"result": "ok", "pubkey": pub_key}
+            )
+            self.my_ns.n2vc.delete_execution_environment = asynctest.CoroutineMock(
+                return_value=None
+            )
             self.my_ns.n2vc.get_public_key = asynctest.CoroutineMock(
-                return_value=getenv("OSMLCM_VCA_PUBKEY", "public_key"))
-            self.my_ns.n2vc.delete_namespace = asynctest.CoroutineMock(return_value=None)
+                return_value=getenv("OSMLCM_VCA_PUBKEY", "public_key")
+            )
+            self.my_ns.n2vc.delete_namespace = asynctest.CoroutineMock(
+                return_value=None
+            )
 
         # Mock RO
         if not getenv("OSMLCMTEST_RO_NOMOCK"):
-            self.my_ns.RO = asynctest.Mock(NgRoClient(self.loop, **lcm_config["ro_config"]))
+            self.my_ns.RO = asynctest.Mock(
+                NgRoClient(self.loop, **lcm_config["ro_config"])
+            )
             # TODO first time should be empty list, following should return a dict
             # self.my_ns.RO.get_list = asynctest.CoroutineMock(self.my_ns.RO.get_list, return_value=[])
-            self.my_ns.RO.deploy = asynctest.CoroutineMock(self.my_ns.RO.deploy, side_effect=self._ro_deploy)
+            self.my_ns.RO.deploy = asynctest.CoroutineMock(
+                self.my_ns.RO.deploy, side_effect=self._ro_deploy
+            )
             # self.my_ns.RO.status = asynctest.CoroutineMock(self.my_ns.RO.status, side_effect=self._ro_status)
             # self.my_ns.RO.create_action = asynctest.CoroutineMock(self.my_ns.RO.create_action,
             #                                                      return_value={"vm-id": {"vim_result": 200,
@@ -326,7 +376,7 @@ class TestMyNS(asynctest.TestCase):
     #     # this will check that the initial-congig-primitive 'not_to_be_called' is not called
 
     # Test scale() and related methods
-    @asynctest.fail_on(active_handles=True)   # all async tasks must be completed
+    @asynctest.fail_on(active_handles=True)  # all async tasks must be completed
     async def test_scale(self):
         # print("Test scale started")
 
@@ -337,8 +387,10 @@ class TestMyNS(asynctest.TestCase):
         nsr_id = descriptors.test_ids["TEST-A"]["ns"]
         nslcmop_id = descriptors.test_ids["TEST-A"]["instantiate"]
         await self.my_ns.scale(nsr_id, nslcmop_id)
-        expected_value = 'FAILED'
-        return_value = self.db.get_one("nslcmops", {"_id": nslcmop_id}).get("operationState")
+        expected_value = "FAILED"
+        return_value = self.db.get_one("nslcmops", {"_id": nslcmop_id}).get(
+            "operationState"
+        )
         self.assertEqual(return_value, expected_value)
         # print("scale_result: {}".format(self.db.get_one("nslcmops", {"_id": nslcmop_id}).get("detailed-status")))
 
@@ -352,12 +404,24 @@ class TestMyNS(asynctest.TestCase):
         for i, _ in enumerate(vnf_descriptors):
             for j, value in enumerate(vnf_descriptors[i]["df"]):
                 if "lcm-operations-configuration" in vnf_descriptors[i]["df"][j]:
-                    if "day1-2" in value["lcm-operations-configuration"]["operate-vnf-op-config"]:
-                        for k, v in enumerate(value["lcm-operations-configuration"]["operate-vnf-op-config"]["day1-2"]):
+                    if (
+                        "day1-2"
+                        in value["lcm-operations-configuration"][
+                            "operate-vnf-op-config"
+                        ]
+                    ):
+                        for k, v in enumerate(
+                            value["lcm-operations-configuration"][
+                                "operate-vnf-op-config"
+                            ]["day1-2"]
+                        ):
                             if "juju" in v["execution-environment-list"][k]:
-                                expected_value = self.db.get_list("nsrs")[i]["vcaStatus"]
-                                await self.my_ns._on_update_n2vc_db("nsrs", {"_id": nsr_id},
-                                                                    "_admin.deployed.VCA.0", {})
+                                expected_value = self.db.get_list("nsrs")[i][
+                                    "vcaStatus"
+                                ]
+                                await self.my_ns._on_update_n2vc_db(
+                                    "nsrs", {"_id": nsr_id}, "_admin.deployed.VCA.0", {}
+                                )
                                 return_value = self.db.get_list("nsrs")[i]["vcaStatus"]
         self.assertEqual(return_value, expected_value)
 
@@ -368,15 +432,15 @@ class TestMyNS(asynctest.TestCase):
     def test_scale_retry_or_skip_suboperation(self):
         # Load an alternative 'nslcmops' YAML for this test
         nslcmop_id = descriptors.test_ids["TEST-A"]["instantiate"]
-        db_nslcmop = self.db.get_one('nslcmops', {"_id": nslcmop_id})
+        db_nslcmop = self.db.get_one("nslcmops", {"_id": nslcmop_id})
         op_index = 2
         # Test when 'operationState' is 'COMPLETED'
-        db_nslcmop['_admin']['operations'][op_index]['operationState'] = 'COMPLETED'
+        db_nslcmop["_admin"]["operations"][op_index]["operationState"] = "COMPLETED"
         return_value = self.my_ns._retry_or_skip_suboperation(db_nslcmop, op_index)
         expected_value = self.my_ns.SUBOPERATION_STATUS_SKIP
         self.assertEqual(return_value, expected_value)
         # Test when 'operationState' is not 'COMPLETED'
-        db_nslcmop['_admin']['operations'][op_index]['operationState'] = None
+        db_nslcmop["_admin"]["operations"][op_index]["operationState"] = None
         return_value = self.my_ns._retry_or_skip_suboperation(db_nslcmop, op_index)
         expected_value = op_index
         self.assertEqual(return_value, expected_value)
@@ -386,24 +450,26 @@ class TestMyNS(asynctest.TestCase):
     def test_scale_find_suboperation(self):
         # Load an alternative 'nslcmops' YAML for this test
         nslcmop_id = descriptors.test_ids["TEST-A"]["instantiate"]
-        db_nslcmop = self.db.get_one('nslcmops', {"_id": nslcmop_id})
+        db_nslcmop = self.db.get_one("nslcmops", {"_id": nslcmop_id})
         # Find this sub-operation
         op_index = 2
-        vnf_index = db_nslcmop['_admin']['operations'][op_index]['member_vnf_index']
-        primitive = db_nslcmop['_admin']['operations'][op_index]['primitive']
-        primitive_params = db_nslcmop['_admin']['operations'][op_index]['primitive_params']
+        vnf_index = db_nslcmop["_admin"]["operations"][op_index]["member_vnf_index"]
+        primitive = db_nslcmop["_admin"]["operations"][op_index]["primitive"]
+        primitive_params = db_nslcmop["_admin"]["operations"][op_index][
+            "primitive_params"
+        ]
         match = {
-            'member_vnf_index': vnf_index,
-            'primitive': primitive,
-            'primitive_params': primitive_params,
+            "member_vnf_index": vnf_index,
+            "primitive": primitive,
+            "primitive_params": primitive_params,
         }
         found_op_index = self.my_ns._find_suboperation(db_nslcmop, match)
         self.assertEqual(found_op_index, op_index)
         # Test with not-matching params
         match = {
-            'member_vnf_index': vnf_index,
-            'primitive': '',
-            'primitive_params': primitive_params,
+            "member_vnf_index": vnf_index,
+            "primitive": "",
+            "primitive_params": primitive_params,
         }
         found_op_index = self.my_ns._find_suboperation(db_nslcmop, match)
         self.assertEqual(found_op_index, self.my_ns.SUBOPERATION_STATUS_NOT_FOUND)
@@ -416,65 +482,112 @@ class TestMyNS(asynctest.TestCase):
     def test_scale_update_suboperation_status(self):
         self.db.set_one = asynctest.Mock()
         nslcmop_id = descriptors.test_ids["TEST-A"]["instantiate"]
-        db_nslcmop = self.db.get_one('nslcmops', {"_id": nslcmop_id})
+        db_nslcmop = self.db.get_one("nslcmops", {"_id": nslcmop_id})
         op_index = 0
         # Force the initial values to be distinct from the updated ones
         q_filter = {"_id": db_nslcmop["_id"]}
         # Test to change 'operationState' and 'detailed-status'
-        operationState = 'COMPLETED'
-        detailed_status = 'Done'
-        expected_update_dict = {'_admin.operations.0.operationState': operationState,
-                                '_admin.operations.0.detailed-status': detailed_status,
-                                }
-        self.my_ns._update_suboperation_status(db_nslcmop, op_index, operationState, detailed_status)
-        self.db.set_one.assert_called_once_with("nslcmops", q_filter=q_filter, update_dict=expected_update_dict,
-                                                fail_on_empty=False)
+        operationState = "COMPLETED"
+        detailed_status = "Done"
+        expected_update_dict = {
+            "_admin.operations.0.operationState": operationState,
+            "_admin.operations.0.detailed-status": detailed_status,
+        }
+        self.my_ns._update_suboperation_status(
+            db_nslcmop, op_index, operationState, detailed_status
+        )
+        self.db.set_one.assert_called_once_with(
+            "nslcmops",
+            q_filter=q_filter,
+            update_dict=expected_update_dict,
+            fail_on_empty=False,
+        )
 
     def test_scale_add_suboperation(self):
         nslcmop_id = descriptors.test_ids["TEST-A"]["instantiate"]
-        db_nslcmop = self.db.get_one('nslcmops', {"_id": nslcmop_id})
-        vnf_index = '1'
-        num_ops_before = len(db_nslcmop.get('_admin', {}).get('operations', [])) - 1
+        db_nslcmop = self.db.get_one("nslcmops", {"_id": nslcmop_id})
+        vnf_index = "1"
+        num_ops_before = len(db_nslcmop.get("_admin", {}).get("operations", [])) - 1
         vdu_id = None
         vdu_count_index = None
         vdu_name = None
-        primitive = 'touch'
-        mapped_primitive_params = {'parameter':
-                                   [{'data-type': 'STRING',
-                                     'name': 'filename',
-                                     'default-value': '<touch_filename2>'}],
-                                   'name': 'touch'}
-        operationState = 'PROCESSING'
-        detailed_status = 'In progress'
-        operationType = 'PRE-SCALE'
+        primitive = "touch"
+        mapped_primitive_params = {
+            "parameter": [
+                {
+                    "data-type": "STRING",
+                    "name": "filename",
+                    "default-value": "<touch_filename2>",
+                }
+            ],
+            "name": "touch",
+        }
+        operationState = "PROCESSING"
+        detailed_status = "In progress"
+        operationType = "PRE-SCALE"
         # Add a 'pre-scale' suboperation
-        op_index_after = self.my_ns._add_suboperation(db_nslcmop, vnf_index, vdu_id, vdu_count_index,
-                                                      vdu_name, primitive, mapped_primitive_params,
-                                                      operationState, detailed_status, operationType)
+        op_index_after = self.my_ns._add_suboperation(
+            db_nslcmop,
+            vnf_index,
+            vdu_id,
+            vdu_count_index,
+            vdu_name,
+            primitive,
+            mapped_primitive_params,
+            operationState,
+            detailed_status,
+            operationType,
+        )
         self.assertEqual(op_index_after, num_ops_before + 1)
 
         # Delete all suboperations and add the same operation again
-        del db_nslcmop['_admin']['operations']
-        op_index_zero = self.my_ns._add_suboperation(db_nslcmop, vnf_index, vdu_id, vdu_count_index,
-                                                     vdu_name, primitive, mapped_primitive_params,
-                                                     operationState, detailed_status, operationType)
+        del db_nslcmop["_admin"]["operations"]
+        op_index_zero = self.my_ns._add_suboperation(
+            db_nslcmop,
+            vnf_index,
+            vdu_id,
+            vdu_count_index,
+            vdu_name,
+            primitive,
+            mapped_primitive_params,
+            operationState,
+            detailed_status,
+            operationType,
+        )
         self.assertEqual(op_index_zero, 0)
 
         # Add a 'RO' suboperation
-        RO_nsr_id = '1234567890'
-        RO_scaling_info = [{'type': 'create', 'count': 1, 'member-vnf-index': '1', 'osm_vdu_id': 'dataVM'}]
-        op_index = self.my_ns._add_suboperation(db_nslcmop, vnf_index, vdu_id, vdu_count_index,
-                                                vdu_name, primitive, mapped_primitive_params,
-                                                operationState, detailed_status, operationType,
-                                                RO_nsr_id, RO_scaling_info)
-        db_RO_nsr_id = db_nslcmop['_admin']['operations'][op_index]['RO_nsr_id']
+        RO_nsr_id = "1234567890"
+        RO_scaling_info = [
+            {
+                "type": "create",
+                "count": 1,
+                "member-vnf-index": "1",
+                "osm_vdu_id": "dataVM",
+            }
+        ]
+        op_index = self.my_ns._add_suboperation(
+            db_nslcmop,
+            vnf_index,
+            vdu_id,
+            vdu_count_index,
+            vdu_name,
+            primitive,
+            mapped_primitive_params,
+            operationState,
+            detailed_status,
+            operationType,
+            RO_nsr_id,
+            RO_scaling_info,
+        )
+        db_RO_nsr_id = db_nslcmop["_admin"]["operations"][op_index]["RO_nsr_id"]
         self.assertEqual(op_index, 1)
         self.assertEqual(RO_nsr_id, db_RO_nsr_id)
 
         # Try to add an invalid suboperation, should return SUBOPERATION_STATUS_NOT_FOUND
-        op_index_invalid = self.my_ns._add_suboperation(None, None, None, None, None,
-                                                        None, None, None,
-                                                        None, None, None)
+        op_index_invalid = self.my_ns._add_suboperation(
+            None, None, None, None, None, None, None, None, None, None, None
+        )
         self.assertEqual(op_index_invalid, self.my_ns.SUBOPERATION_STATUS_NOT_FOUND)
 
     # Test _check_or_add_scale_suboperation() and _check_or_add_scale_suboperation_RO()
@@ -484,68 +597,92 @@ class TestMyNS(asynctest.TestCase):
     # - SUBOPERATION_STATUS_SKIP: This is an existing sub-operation, operationState == 'COMPLETED'
     def test_scale_check_or_add_scale_suboperation(self):
         nslcmop_id = descriptors.test_ids["TEST-A"]["instantiate"]
-        db_nslcmop = self.db.get_one('nslcmops', {"_id": nslcmop_id})
-        operationType = 'PRE-SCALE'
-        vnf_index = '1'
-        primitive = 'touch'
-        primitive_params = {'parameter':
-                            [{'data-type': 'STRING',
-                              'name': 'filename',
-                              'default-value': '<touch_filename2>'}],
-                            'name': 'touch'}
+        db_nslcmop = self.db.get_one("nslcmops", {"_id": nslcmop_id})
+        operationType = "PRE-SCALE"
+        vnf_index = "1"
+        primitive = "touch"
+        primitive_params = {
+            "parameter": [
+                {
+                    "data-type": "STRING",
+                    "name": "filename",
+                    "default-value": "<touch_filename2>",
+                }
+            ],
+            "name": "touch",
+        }
 
         # Delete all sub-operations to be sure this is a new sub-operation
-        del db_nslcmop['_admin']['operations']
+        del db_nslcmop["_admin"]["operations"]
 
         # Add a new sub-operation
         # For new sub-operations, operationState is set to 'PROCESSING' by default
         op_index_new = self.my_ns._check_or_add_scale_suboperation(
-            db_nslcmop, vnf_index, primitive, primitive_params, operationType)
+            db_nslcmop, vnf_index, primitive, primitive_params, operationType
+        )
         self.assertEqual(op_index_new, self.my_ns.SUBOPERATION_STATUS_NEW)
 
         # Use the same parameters again to match the already added sub-operation
         # which has status 'PROCESSING' (!= 'COMPLETED') by default
         # The expected return value is a non-negative number
         op_index_existing = self.my_ns._check_or_add_scale_suboperation(
-            db_nslcmop, vnf_index, primitive, primitive_params, operationType)
+            db_nslcmop, vnf_index, primitive, primitive_params, operationType
+        )
         self.assertTrue(op_index_existing >= 0)
 
         # Change operationState 'manually' for this sub-operation
-        db_nslcmop['_admin']['operations'][op_index_existing]['operationState'] = 'COMPLETED'
+        db_nslcmop["_admin"]["operations"][op_index_existing][
+            "operationState"
+        ] = "COMPLETED"
         # Then use the same parameters again to match the already added sub-operation,
         # which now has status 'COMPLETED'
         # The expected return value is SUBOPERATION_STATUS_SKIP
         op_index_skip = self.my_ns._check_or_add_scale_suboperation(
-            db_nslcmop, vnf_index, primitive, primitive_params, operationType)
+            db_nslcmop, vnf_index, primitive, primitive_params, operationType
+        )
         self.assertEqual(op_index_skip, self.my_ns.SUBOPERATION_STATUS_SKIP)
 
         # RO sub-operation test:
         # Repeat tests for the very similar _check_or_add_scale_suboperation_RO(),
-        RO_nsr_id = '1234567890'
-        RO_scaling_info = [{'type': 'create', 'count': 1, 'member-vnf-index': '1', 'osm_vdu_id': 'dataVM'}]
+        RO_nsr_id = "1234567890"
+        RO_scaling_info = [
+            {
+                "type": "create",
+                "count": 1,
+                "member-vnf-index": "1",
+                "osm_vdu_id": "dataVM",
+            }
+        ]
         op_index_new_RO = self.my_ns._check_or_add_scale_suboperation(
-            db_nslcmop, vnf_index, None, None, 'SCALE-RO', RO_nsr_id, RO_scaling_info)
+            db_nslcmop, vnf_index, None, None, "SCALE-RO", RO_nsr_id, RO_scaling_info
+        )
         self.assertEqual(op_index_new_RO, self.my_ns.SUBOPERATION_STATUS_NEW)
 
         # Use the same parameters again to match the already added RO sub-operation
         op_index_existing_RO = self.my_ns._check_or_add_scale_suboperation(
-            db_nslcmop, vnf_index, None, None, 'SCALE-RO', RO_nsr_id, RO_scaling_info)
+            db_nslcmop, vnf_index, None, None, "SCALE-RO", RO_nsr_id, RO_scaling_info
+        )
         self.assertTrue(op_index_existing_RO >= 0)
 
         # Change operationState 'manually' for this RO sub-operation
-        db_nslcmop['_admin']['operations'][op_index_existing_RO]['operationState'] = 'COMPLETED'
+        db_nslcmop["_admin"]["operations"][op_index_existing_RO][
+            "operationState"
+        ] = "COMPLETED"
         # Then use the same parameters again to match the already added sub-operation,
         # which now has status 'COMPLETED'
         # The expected return value is SUBOPERATION_STATUS_SKIP
         op_index_skip_RO = self.my_ns._check_or_add_scale_suboperation(
-            db_nslcmop, vnf_index, None, None, 'SCALE-RO', RO_nsr_id, RO_scaling_info)
+            db_nslcmop, vnf_index, None, None, "SCALE-RO", RO_nsr_id, RO_scaling_info
+        )
         self.assertEqual(op_index_skip_RO, self.my_ns.SUBOPERATION_STATUS_SKIP)
 
     async def test_deploy_kdus(self):
         nsr_id = descriptors.test_ids["TEST-KDU"]["ns"]
         nslcmop_id = descriptors.test_ids["TEST-KDU"]["instantiate"]
         db_nsr = self.db.get_one("nsrs", {"_id": nsr_id})
-        db_vnfr = self.db.get_one("vnfrs", {"nsr-id-ref": nsr_id, "member-vnf-index-ref": "multikdu"})
+        db_vnfr = self.db.get_one(
+            "vnfrs", {"nsr-id-ref": nsr_id, "member-vnf-index-ref": "multikdu"}
+        )
         db_vnfrs = {"multikdu": db_vnfr}
         db_vnfd = self.db.get_one("vnfds", {"_id": db_vnfr["vnfd-id"]})
         db_vnfds = [db_vnfd]
@@ -554,26 +691,44 @@ class TestMyNS(asynctest.TestCase):
         self.my_ns.k8sclusterhelm3.generate_kdu_instance_name = asynctest.mock.Mock()
         self.my_ns.k8sclusterhelm3.generate_kdu_instance_name.return_value = "k8s_id"
         self.my_ns.k8sclusterhelm3.install = asynctest.CoroutineMock()
-        self.my_ns.k8sclusterhelm3.synchronize_repos = asynctest.CoroutineMock(return_value=("", ""))
-        self.my_ns.k8sclusterhelm3.get_services = asynctest.CoroutineMock(return_value=([]))
-        await self.my_ns.deploy_kdus(logging_text, nsr_id, nslcmop_id, db_vnfrs, db_vnfds, task_register)
+        self.my_ns.k8sclusterhelm3.synchronize_repos = asynctest.CoroutineMock(
+            return_value=("", "")
+        )
+        self.my_ns.k8sclusterhelm3.get_services = asynctest.CoroutineMock(
+            return_value=([])
+        )
+        await self.my_ns.deploy_kdus(
+            logging_text, nsr_id, nslcmop_id, db_vnfrs, db_vnfds, task_register
+        )
         await asyncio.wait(list(task_register.keys()), timeout=100)
         db_nsr = self.db.get_list("nsrs")[1]
-        self.assertIn("K8s", db_nsr["_admin"]["deployed"], "K8s entry not created at '_admin.deployed'")
-        self.assertIsInstance(db_nsr["_admin"]["deployed"]["K8s"], list, "K8s entry is not of type list")
-        self.assertEqual(len(db_nsr["_admin"]["deployed"]["K8s"]), 2, "K8s entry is not of type list")
-        k8s_instace_info = {"kdu-instance": "k8s_id", "k8scluster-uuid": "73d96432-d692-40d2-8440-e0c73aee209c",
-                            "k8scluster-type": "helm-chart-v3",
-                            "kdu-name": "ldap",
-                            "member-vnf-index": "multikdu",
-                            "namespace": None}
+        self.assertIn(
+            "K8s",
+            db_nsr["_admin"]["deployed"],
+            "K8s entry not created at '_admin.deployed'",
+        )
+        self.assertIsInstance(
+            db_nsr["_admin"]["deployed"]["K8s"], list, "K8s entry is not of type list"
+        )
+        self.assertEqual(
+            len(db_nsr["_admin"]["deployed"]["K8s"]), 2, "K8s entry is not of type list"
+        )
+        k8s_instace_info = {
+            "kdu-instance": "k8s_id",
+            "k8scluster-uuid": "73d96432-d692-40d2-8440-e0c73aee209c",
+            "k8scluster-type": "helm-chart-v3",
+            "kdu-name": "ldap",
+            "member-vnf-index": "multikdu",
+            "namespace": None,
+        }
 
         nsr_result = copy.deepcopy(db_nsr["_admin"]["deployed"]["K8s"][0])
         nsr_kdu_model_result = nsr_result.pop("kdu-model")
         expected_kdu_model = "stable/openldap:1.2.1"
         self.assertEqual(nsr_result, k8s_instace_info)
         self.assertTrue(
-            nsr_kdu_model_result in expected_kdu_model or expected_kdu_model in nsr_kdu_model_result
+            nsr_kdu_model_result in expected_kdu_model
+            or expected_kdu_model in nsr_kdu_model_result
         )
         nsr_result = copy.deepcopy(db_nsr["_admin"]["deployed"]["K8s"][1])
         nsr_kdu_model_result = nsr_result.pop("kdu-model")
@@ -581,7 +736,8 @@ class TestMyNS(asynctest.TestCase):
         expected_kdu_model = "stable/mongodb"
         self.assertEqual(nsr_result, k8s_instace_info)
         self.assertTrue(
-            nsr_kdu_model_result in expected_kdu_model or expected_kdu_model in nsr_kdu_model_result
+            nsr_kdu_model_result in expected_kdu_model
+            or expected_kdu_model in nsr_kdu_model_result
         )
 
     # async def test_instantiate_pdu(self):
@@ -665,5 +821,5 @@ class TestMyNS(asynctest.TestCase):
     #     self.assertEqual(db_nsr.get("errorDetail"), None, "errorDetail different than None")
 
 
-if __name__ == '__main__':
+if __name__ == "__main__":
     asynctest.main()