Fix multiple minor security vulnerabilities

[osm/LCM.git] / osm_lcm / tests / test_lcm_utils.py

diff --git a/osm_lcm/tests/test_lcm_utils.py b/osm_lcm/tests/test_lcm_utils.py
index bcd242f..14aa5a5 100644 (file)
--- a/osm_lcm/tests/test_lcm_utils.py
+++ b/osm_lcm/tests/test_lcm_utils.py
@@ -253,14 +253,14 @@ class TestLcmBase(TestCase):
         charm = tmpfile
         hexdigest = self.hexdigest
         mock_file_hash = MagicMock()
-        mock_hashlib.md5.return_value = mock_file_hash
+        mock_hashlib.sha256.return_value = mock_file_hash
         mock_file_hash.hexdigest.return_value = hexdigest
         result = LcmBase.calculate_charm_hash(charm)
         self.assertEqual(result, hexdigest)
         self.assertEqual(mocking_open.call_count, 1)
         self.assertEqual(mock_file_hash.update.call_count, 1)
         self.assertEqual(mock_file_hash.hexdigest.call_count, 1)
-        self.assertEqual(mock_hashlib.md5.call_count, 1)
+        self.assertEqual(mock_hashlib.sha256.call_count, 1)
 
     @patch("builtins.open", new_callable=mock_open(read_data="charm content"))
     @patch("osm_lcm.lcm_utils.hashlib")
@@ -269,7 +269,7 @@ class TestLcmBase(TestCase):
         charm = tmpfile
         hexdigest = self.hexdigest
         mock_file_hash = MagicMock()
-        mock_hashlib.md5.return_value = mock_file_hash
+        mock_hashlib.sha256.return_value = mock_file_hash
         mock_file_hash.hexdigest.return_value = hexdigest
         mocking_open.side_effect = IOError
         with self.assertRaises(IOError):
@@ -277,7 +277,7 @@ class TestLcmBase(TestCase):
         self.assertEqual(mocking_open.call_count, 1)
         mock_file_hash.update.assert_not_called()
         mock_file_hash.hexdigest.assert_not_called()
-        self.assertEqual(mock_hashlib.md5.call_count, 1)
+        self.assertEqual(mock_hashlib.sha256.call_count, 1)
 
     @patch("builtins.open", new_callable=mock_open(read_data="charm content"))
     @patch("osm_lcm.lcm_utils.hashlib")
@@ -287,14 +287,14 @@ class TestLcmBase(TestCase):
         hexdigest = self.hexdigest
         mock_file_hash = MagicMock()
         mock_file_hash.update.side_effect = Exception
-        mock_hashlib.md5.return_value = mock_file_hash
+        mock_hashlib.sha256.return_value = mock_file_hash
         mock_file_hash.hexdigest.return_value = hexdigest
         with self.assertRaises(Exception):
             LcmBase.calculate_charm_hash(charm)
         self.assertEqual(mocking_open.call_count, 1)
         self.assertEqual(mock_file_hash.update.call_count, 1)
         mock_file_hash.hexdigest.assert_not_called()
-        self.assertEqual(mock_hashlib.md5.call_count, 1)
+        self.assertEqual(mock_hashlib.sha256.call_count, 1)
 
     @patch("builtins.open", new_callable=mock_open(read_data="charm content"))
     @patch("osm_lcm.lcm_utils.hashlib")
@@ -304,27 +304,27 @@ class TestLcmBase(TestCase):
         """Filehash hexdigest raises exception."""
         charm = tmpfile
         mock_file_hash = MagicMock()
-        mock_hashlib.md5.return_value = mock_file_hash
+        mock_hashlib.sha256.return_value = mock_file_hash
         mock_file_hash.hexdigest.side_effect = Exception
         with self.assertRaises(Exception):
             LcmBase.calculate_charm_hash(charm)
         self.assertEqual(mocking_open.call_count, 1)
         self.assertEqual(mock_file_hash.update.call_count, 1)
         mock_file_hash.hexdigest.assert_called_once()
-        self.assertEqual(mock_hashlib.md5.call_count, 1)
+        self.assertEqual(mock_hashlib.sha256.call_count, 1)
         mock_file_hash.update.assert_called_once()
 
     @patch("builtins.open", new_callable=mock_open(read_data="charm content"))
     @patch("osm_lcm.lcm_utils.hashlib")
-    def test_calculate_charm_filehash_hashlib_md5_raises(
+    def test_calculate_charm_filehash_hashlib_sha256_raises(
         self, mock_hashlib, mocking_open
     ):
-        """Filehash hashlib md5 raises exception."""
+        """Filehash hashlib sha256 raises exception."""
         charm = tmpfile
-        mock_hashlib.md5.side_effect = Exception
+        mock_hashlib.sha256.side_effect = Exception
         with self.assertRaises(Exception):
             LcmBase.calculate_charm_hash(charm)
-        self.assertEqual(mock_hashlib.md5.call_count, 1)
+        self.assertEqual(mock_hashlib.sha256.call_count, 1)
         mocking_open.assert_not_called()
 
     @patch("builtins.open", new_callable=mock_open(read_data="charm content"))
@@ -333,14 +333,14 @@ class TestLcmBase(TestCase):
         """Calculate charm hash, charm file does not exist."""
         file = None
         mock_file_hash = MagicMock()
-        mock_hashlib.md5.return_value = mock_file_hash
+        mock_hashlib.sha256.return_value = mock_file_hash
         mocking_open.side_effect = FileNotFoundError
         with self.assertRaises(FileNotFoundError):
             LcmBase.calculate_charm_hash(file)
         self.assertEqual(mocking_open.call_count, 1)
         mock_file_hash.update.assert_not_called()
         mock_file_hash.hexdigest.assert_not_called()
-        self.assertEqual(mock_hashlib.md5.call_count, 1)
+        self.assertEqual(mock_hashlib.sha256.call_count, 1)
 
     @patch("osm_lcm.lcm_utils.LcmBase.calculate_charm_hash")
     def test_compare_charm_hash_charm_changed(self, mock_calculate_charm_hash):