From 0389d9e766bb7049d45dbcc9e322de22c7203fae Mon Sep 17 00:00:00 2001 From: "selvi.j" Date: Wed, 26 Apr 2023 12:13:10 +0000 Subject: [PATCH] Coverity-CWE 330: Use of Insufficiently Random Values Added fix for CWE 330: Use of Insufficiently Random Value (Cryptographically weak PRNG) Change-Id: If17007c4e14fa91b3c378a504e7fbd03ea44a69b Signed-off-by: selvi.j --- osm_nbi/tests/test_admin_topics.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/osm_nbi/tests/test_admin_topics.py b/osm_nbi/tests/test_admin_topics.py index eb1cf32..90f4acd 100755 --- a/osm_nbi/tests/test_admin_topics.py +++ b/osm_nbi/tests/test_admin_topics.py @@ -18,12 +18,12 @@ __author__ = "Pedro de la Cruz Ramos, pedro.delacruzramos@altran.com" __date__ = "$2019-10-019" import unittest +import random from unittest import TestCase from unittest.mock import Mock, patch, call from uuid import uuid4 from http import HTTPStatus from time import time -from random import randint from osm_common import dbbase, fsbase, msgbase from osm_nbi import authconn, validation from osm_nbi.admin_topics import ( @@ -240,7 +240,10 @@ class Test_ProjectTopicAuth(TestCase): with self.subTest(i=1): self.auth.get_project_list.side_effect = [[proj], []] new_name = "new-project-name" - quotas = {"vnfds": randint(0, 100), "nsds": randint(0, 100)} + quotas = { + "vnfds": random.SystemRandom().randint(0, 100), + "nsds": random.SystemRandom().randint(0, 100), + } self.topic.edit( self.fake_session, pid, {"name": new_name, "quotas": quotas} ) @@ -255,7 +258,7 @@ class Test_ProjectTopicAuth(TestCase): self.assertEqual(content["quotas"], quotas, "Wrong quotas") with self.subTest(i=2): new_name = "other-project-name" - quotas = {"baditems": randint(0, 100)} + quotas = {"baditems": random.SystemRandom().randint(0, 100)} self.auth.get_project_list.side_effect = [[proj], []] with self.assertRaises(EngineException, msg="Accepted wrong quotas") as e: self.topic.edit( -- 2.25.1