Coverity CWE 476: NULL Pointer Dereference

Added fixes for NULL Pointer Dereference Coverity Issue

Change-Id: I2c68ff720f563631fba3ea8586e325a163d752c6
Signed-off-by: elumalai <deepika.e@tataelxsi.co.in>

Add support of nova client microversion 2.60

Change-Id: I5ab566de7db67dc1e9665d7cb399be7af268ba6f
Signed-off-by: Gabriel Cuba <gcuba@whitestack.com>
Signed-off-by: vegall <lvega@whitestack.com>

Change Nova api microversion from 2.63 back to 2.1

Change-Id: I73d46df2a7c4bc07f56b5999cfc8a2b2eee3c458
Signed-off-by: Gulsum Atici <gulsum.atici@canonical.com>

Feature 10972: Support of volume multi-attach

Change-Id: I6e88ee52e5e882dbb4ec7d66cf648fbe07d40509
Signed-off-by: vegall <lvega@whitestack.com>

Feature 10937: Transport API (TAPI) WIM connector for RO

Change-Id: If0dac9f8ba2d00945eb86a89fb0b2f174c672794
Signed-off-by: gifrerenom <lluis.gifre@cttc.es>

Feature 10979: Static IPv6 Dual Stack Assignment

Added support for static dual stack IP assignment

Change-Id: Ief10ae955fb870a3417f68e1c5f7bda570cb6470
Signed-off-by: elumalai <deepika.e@tataelxsi.co.in>

Fix Bug 2098: Get VDUs from VNFR when Heal op has no additionalPrameters

When Heal is requested without vdu or count-index parameters, RO will recreate all VDUs from VNFR

Change-Id: Idf2cf158bcb33e7b0c307298c14504cc7aa77e2a
Signed-off-by: Gabriel Cuba <gcuba@whitestack.com>
(cherry picked from commit 2fbb3a264e4117f4a6569fede6558836d67ac4a4)

Fix VimAdminThread run method

The run_coroutine_threadsafe() function is used to schedule a coroutine object from a different thread and returns a concurrent.futures.Future.
run_coroutine_threadsafe is unnecessary to run the main task and replaced with asyncio.run().

Change-Id: I8ea31828a9798140d596165443bdf26659b4eef8
Signed-off-by: Gulsum Atici <gulsum.atici@canonical.com>

Minor updates in Dockerfile

Change-Id: I79b43654d181f6976a4e544d58fb92aa1b67e760
Signed-off-by: Gulsum Atici <gulsum.atici@canonical.com>

Ubuntu 22.04 and Python 3.10 preparation

Change-Id: I87164827a8849c16b5e3a804d9673a578e5a5593
Signed-off-by: Gulsum Atici <gulsum.atici@canonical.com>

Clean stage-archive.sh and use allowlist_extenals in tox.ini

Change-Id: I18f0bc3e263063b5b1d2cf211f028f6bb0e4bceb
Signed-off-by: garciadeblas <gerardo.garciadeblas@telefonica.com>

Coverity CWE 330: Use of Insufficiently Random Values

Added support to fix CWE 330: Use of Insufficiently Random Values
Coverity issue

Change-Id: Ib12ebeeb9b0cc10af9980fe8661eb6230c2f6d6d
Signed-off-by: elumalai <deepika.e@tataelxsi.co.in>

Coverity CWE 688: Function Call With Incorrect Variable or Reference as Argument

Added fix for CWE 688 Typo in Identifier

Change-Id: I53b5142451b809be638d73626265531057722169
Signed-off-by: elumalai <deepika.e@tataelxsi.co.in>

Feature 10975: get flavor-id from additionalParams if specified

Change-Id: I1c9b1ec43c80f3793b475187681f4c2005d77375
Signed-off-by: Gabriel Cuba <gcuba@whitestack.com>

Update stage-build to run tox sequentially

Change-Id: I967f19a8c35700290e93c9d8bd863b63b7c2d239
Signed-off-by: garciadeblas <gerardo.garciadeblas@telefonica.com>
(cherry picked from commit ea063c7a6ae6a5d7e11e8c22f9707d5c8f674ac7)

Feature 10978: Add support of ipv6_address_mode and ipv6_ra_mode to openstack connector

Change-Id: I8ca741a215bd2c52999dee1ea301d4e02aafcb24
Signed-off-by: Gabriel Cuba <gcuba@whitestack.com>

Keep vim_details while reporting VM deletion

Change-Id: I27577b2fc93a585affc947abcec8352562f23f49
Signed-off-by: Gulsum Atici <gulsum.atici@canonical.com>

Bug 2217 fixed: modified the cloud-init merge configs and defined the default SSH keys within the system_info instead of users

Change-Id: I12e26a88fb9b50c4a78b9fa8ee2cb5d4b4bf6d00
Signed-off-by: Pedro Escaleira <escaleira@av.it.pt>

Feature 10960 Performance optimizations for the polling of VM status in RO

Change-Id: If785bbeaab66e0839541bf94184ce37114e67bd4
Signed-off-by: Gulsum Atici <gulsum.atici@canonical.com>

Refactor ns.py so that RO uses the IP profile as it comes from LCM

Change-Id: I36983c86d7c76ad8a9b93eb6eae254f844717e0e
Signed-off-by: Gabriel Cuba <gcuba@whitestack.com>

Fix bug 2216 to remove hardcoded numa affinity in VIO

Change-Id: I0912c2841e7c5c1febe056ba092afedaea77f6a1
Signed-off-by: garciadeblas <gerardo.garciadeblas@telefonica.com>

Bug 2202: Adding support for cinder V3 API with V2 API for persistent volumes.

Change-Id: I7034564b91b94e6be242cb2ce0f4a5b147b87d64
Signed-off-by: Lovejeet Singh <lovejeet.singh@hsc.com>

Revert "Revert "Removing unused methods from RO module""

This reverts commit 6986244790d12f4ce734fd5cd2599e84b29c3f84.

Re-revert as discussed with TSC

Change-Id: Ib2feb94d4f13e97c12f51381d3e28372d140baaa
Signed-off-by: Gulsum Atici <gulsum.atici@canonical.com>

Feature 10950: Replace pycrypto with pycryptodome

Change-Id: If7e0f2d58b4354127e5bee17f770a622c98805d2
Signed-off-by: Gulsum Atici <gulsum.atici@canonical.com>

Revert "Removing unused methods from RO module"

This reverts commit eaccf71d78032c68f6fb4dadfc98308f007b63af.

Change-Id: Ie864b6e031f7c9227d4032f6bf2e3d894464ff3c
Signed-off-by: Gulsum Atici <gulsum.atici@canonical.com>

Reformat files according to new black validation

Change-Id: I68f6423f5f9a204c35b7c0c5239eb8a66e605f2c
Signed-off-by: Gulsum Atici <gulsum.atici@canonical.com>

Removing unused methods from RO module

Change-Id: Ic2e771ebeec9a0ff8d0d45cacbd0cdb87d131a27
Signed-off-by: Gulsum Atici <gulsum.atici@canonical.com>

Fix Bug 2180 Adding VIO Numa support with unit tests

Change-Id: I7a7b18a00b22156c6b8116f07e3a04d8c2dd8a99
Signed-off-by: Gulsum Atici <gulsum.atici@canonical.com>

Correcting invalid vcpu calculation and vcpu pinning policy evaluation.

Correcting invalid vcpu calculation according to numa nodes core and thread settings, correcting vcpu pinning policy evaluation.

Change-Id: I8126a1e5a47e879a42809ded8ca07b8d1c78ac8f
Signed-off-by: Gulsum Atici <gulsum.atici@canonical.com>

Updating python dependencies

Update of Python packages (using pip-compile) in preparation for
Release FOURTEEN

Change-Id: Ie27634899f752975227416c3b86b68f6b8cecc33
Signed-off-by: Gulsum Atici <gulsum.atici@canonical.com>

Refactoring new_flavor method in Openstack VIM connector

Change-Id: If852a4c20f41cba2609d9d0d30865649a748e067
Signed-off-by: Gulsum Atici <gulsum.atici@canonical.com>

Enabling Pylint in RO and removing unused methods

Enabling pylint, removing some unused and erroneous methods,
updating required libraries.

Change-Id: I7ad823f83faa1fd9f055a92041cabc7a53f707ac
Signed-off-by: Gulsum Atici <gulsum.atici@canonical.com>

Fix Bug 2159: Use provider-network profile when specified even if it's overlay or management

Change-Id: Ib1f910e0f8ce9ed5fbb6ffbcb09847c90c2c9710
Signed-off-by: Gabriel Cuba <gcuba@whitestack.com>

Fixing the signature of method

Correcting the signature of method _get_free_floating_ip in vimconn_openstack.py

Change-Id: I0351b1c9af9543c02985601a30fe1e684db71e8a
Signed-off-by: Gulsum Atici <gulsum.atici@canonical.com>

Binding flake8 version to 5.0.4

Change-Id: Ia2739577b7f4f50345ef2242323ecb5da3cc2780
Signed-off-by: Gulsum Atici <gulsum.atici@canonical.com>

Feature 10936 Keeping persistent volume of VNF

Change-Id: I3be4b402c9776f145d59b5c40d645f8ab92d34c6
Signed-off-by: aticig <gulsum.atici@canonical.com>

Refactor NG_RO/ns.py _process_vdu_params method

Refactoring NG_RO/ns.py _process_vdu_params and vimconn_openstack.py delete_vminstance methods together with adding unit tests.

Change-Id: I66b5e4dac296fff7bdac77add997818653ee0801
Signed-off-by: Gulsum Atici <gulsum.atici@canonical.com>

Adding missing variable

Missing variable block_device_mapping is added to prepare_disk_for_vminstance method

Change-Id: Ic759df4d53b6d0f454b2a851215aa40402b3053a
Signed-off-by: Gulsum Atici <gulsum.atici@canonical.com>

Refactor openstack new_vminstance method

Change-Id: I33bba6d4ce911e6429835d93705f9b7f4704ebae
Signed-off-by: Gulsum Atici <gulsum.atici@canonical.com>

Bug 2180 fixed

Change-Id: Ib136760251c09cd803f2e313b184fa87428efd9b
Signed-off-by: sritharan <priyadarshini@tataelxsi.co.in>

Fix Bug 2172

Fixing FileNotFoundError during unloading VIM and
Changing log level while getting installed RO version

Change-Id: I6511072efd47ce9c96c3534a7328e1f5df6e5eb1
Signed-off-by: Gulsum Atici <gulsum.atici@canonical.com>

Get VIM certificates from DB

Change-Id: Iaf11da954dd8faedbc27e0055bdf134433ea680f
Signed-off-by: Guillermo Calvino <guillermo.calvino@canonical.com>

Fix bug 2157 to resolve issues with IETF L2VPN WIM connector

Change-Id: If03acb8469f36bbca51a936bfb0808ec0124468f
Signed-off-by: gifrerenom <lluis.gifre@cttc.es>

Fix bug 2156 to select correct WIM connector class and prevent exceptions with missing parameters.

Change-Id: I6f67b8a0fccc5a2ebf3f839899d748c41fac169a
Signed-off-by: gifrerenom <lluis.gifre@cttc.es>

Fixing inappropriate warning log level usage

This patch is correcting the log levels of some successful operations
as they were logged with warning level.

Change-Id: I5f572e0b9d31e32253f7fbd8d5d1da7a360e074e
Signed-off-by: aticig <gulsum.atici@canonical.com>

Fixing improper certificate validation security vulnerability

Enabling certificate validation in Juniper Contrail SDN plugin.

Change-Id: I75b523fbff3d450599f888b06549e46b61dcf95a
Signed-off-by: aticig <gulsum.atici@canonical.com>

Fixing RO Security Vulnerabilities

Jinja2 sets autoescape to False, disabling SSL certificate checks, use of unsafe yaml load,
Try-Except-Pass detected, use of assert detected.
Removing openmanoconfig.py.

Change-Id: I3353208e150ae6c2f91befa1a3bbed33ed0c528d
Signed-off-by: aticig <gulsum.atici@canonical.com>

Fix Bug 2086 Updating VNF status configurable

This fix allows to set REFRESH_ACTIVE period as config option which
periodically checks the VM status from VIM. Env variable can be set in the
ro container export OSMRO_PERIOD_REFRESH_ACTIVE=-1 to disable VM status updates.
This config parameter allowed to set >= 60 seconds or -1.
Making the stage-releasenotes.sh executable.

Change-Id: I90a859d9b831c1ce24faea4eab12dc998ac655d5
Signed-off-by: aticig <gulsum.atici@canonical.com>

Jenkins refresh

Change the jenkins node label from 'docker'
to 'stage_2' as part of the Jenkins cleanup

Change-Id: Ic2837c0f6163a511e064eb5a2a254c58c1c0c960
Signed-off-by: Mark Beierl <mark.beierl@canonical.com>

Fix bug 2092 to update params of delete_vminstance in all VIM connectors

Change-Id: I906817cc8443d958ef295835af440268528912f3
Signed-off-by: garciadeblas <gerardo.garciadeblas@telefonica.com>

Find the existing persistent volume by vim_id keyword

It's possible to find an existing disk id searching with vim_id or
vim_volume_id depend on situation. vim_id is added in the search key list.

Change-Id: I7847cfc30a26bfa5f860eae2aefdbc4c44050234
Signed-off-by: aticig <gulsum.atici@canonical.com>

Update pip requirements

Change-Id: Ie13a8e81a0182b9b9b6f37c17ae454793f658c47
Signed-off-by: garciadeblas <gerardo.garciadeblas@telefonica.com>

Match the correct clause when interface position is zero

Change-Id: I6eacc818c1596442295d39ff704fe56dea319c11
Signed-off-by: aticig <gulsum.atici@canonical.com>

Fixing Bug 1851, 1852, 1854

Network related problems while creating an basic network service using
AWS VIM Plugin are fixed in this patch.

Change-Id: Ic36ff57f8c9bd5b362eb9ffb752ce863f621dd54
Signed-off-by: aticig <gulsum.atici@canonical.com>

Fix Bug 2012 use existing volumes as instantiation parameters

RO processes the existing vim-volume-id which is provided through the
instantation parameters, then they are consumed while creating the new VDUs.

Change-Id: Ic3bd71ac7679ab0ccbe9ee0847e4a8d3059c7c58
Signed-off-by: aticig <gulsum.atici@canonical.com>

RO Unit Tests for Feature: 10910

Added unit tests in RO for feature 10910 - Migration of
Openstack based VM instances

Change-Id: I2bbca8db3fd253fccbfcfb1e5aaf732b571dbfb2
Signed-off-by: elumalai <deepika.e@tataelxsi.co.in>

Find the interface ports regardless of VM's existence

This patch will find and delete the network interface ports regardless of VM's existence.
In healing feature, when the VM is deleted manually, network interfaces ports still
exist in the Openstack Cloud. If we check the network ports' presence according to vm_id,
those ports are not deleted and heal operation fails. This patch will find all the ports,
than deletion required interface will be deleted.

Change-Id: I139559844aa148109588f70f1472ee2e07d7df67
Signed-off-by: aticig <gulsum.atici@canonical.com>

Feature 10911-Vertical scaling of VM instances from OSM

Change-Id: Ie52edb13367a253ed3fc1a434ca2a170803035e4
Signed-off-by: sritharan <priyadarshini@tataelxsi.co.in>

Feature 10922: Stop, start and rebuild

Added support for feature start stop rebuild of VNF instances
Added unit test case for start stop rebuil of VNF instances

Change-Id: I09d2512084268c190f5ae9cfdaae41269c6bc069
Signed-off-by: k4.rahul <rahul.k4@tataelxsi.co.in>

Fix Bug 1607 Interface position is not taken into account

This fix provides to attach interfaces to VNF according to the position order
which is defined in the VNFD.

Change-Id: Ibe17d63548c8b753f791de2440fec4c763fd8fe2
Signed-off-by: aticig <gulsum.atici@canonical.com>

Fixing Bug 1376

This fix will check the port existence before deleting the port.
It will solve the error "Error deleting port: PortNotFoundClient".

Change-Id: I2b0b841c6111578e0d1a0cde9057eb3ab0b5a86a
Signed-off-by: aticig <gulsum.atici@canonical.com>

Use interfaces_backup for healing

Change-Id: Idb2d950963754259163e23a0ed9ef1aafc3ce45e
Signed-off-by: garciadeblas <gerardo.garciadeblas@telefonica.com>

Feature 10909: Heal operation for VDU. Fix virtual machine deletion and volume deletion when terminating network service

Change-Id: Iffe66e3dcb87b0b24ee09fd74129b26dfd87c320
Signed-off-by: palaciosj <jmpalacios@indra.es>

Extracting stage releasenotes script from stage-test.sh

Release notes checking in stage-test.sh causes the failure in  merge and revert jobs.
So it is added as an separate script.

Change-Id: Ie20878cb4822ba72e9d81f3e6ede8dcd1f65d99e
Signed-off-by: aticig <gulsum.atici@canonical.com>

Fix Bug 2041: Backup VDU interfaces for healing features

If a VDU is manually deleted in Openstack, the RO overwrites the
interfaces as an empty list. However, healing features (10909 and 10923) need the
interfaces information to heal the VDU again. This fix backups the interfaces of
VDU under interfaces_backup keyword.

Change-Id: I17ea28c2c4f486d0bbecdcbc5005413222bfeed9
Signed-off-by: aticig <gulsum.atici@canonical.com>

Update paramiko version to 2.11.0

Update paramiko version and increase auth_timeout and log paramiko operations
in order to fix Authentication Failed error during ssh key injection

Change-Id: I544850ae3ca5ff826b71deeacb71c5ab2308ee5a
Signed-off-by: aticig <gulsum.atici@canonical.com>

Feature 10910: Migration of Openstack based VM instances

Added feature support for Migration of Openstack based VM instances
from OSM

Change-Id: I1e16c3ba323d284c30e4761aec614b18119691af
Signed-off-by: elumalai <deepika.e@tataelxsi.co.in>

Bug 2029 mempage-size is ignored

Change-Id: I2ca791474b9a717413964f1b85d7659489702f14
Signed-off-by: rodriguezgar <frodriguezg@indra.es>

Logging traceback for key injection error in robot tests

Add traceback for key injection error in robot tests
and increase the paramiko ssh client timeout from 10s to 30s.

Change-Id: I4f0c24f550e98dc072210cebb36a57b4530818ac
Signed-off-by: aticig <gulsum.atici@canonical.com>

Fixes bug 2026 : Persistent volumes to be created in the same AZ as the VM that will use them.

Change-Id: I1f4161aa4f7b294e1acf2b33ba3208480f09eacc
Signed-off-by: Alexis Romero <garomero@indra.es>

Fix Bug 2022: RO updating VIM details with null info when VM is in error state

This patch prevents to override the vim_details when VM
is in error state. By this way, vim_details could be used for healing operations.
The messages regarding with the failure is kept in another key names "vim_message".

Change-Id: Ie0b73040074865a89d9ab2d447e20a8f3d38d520
Signed-off-by: aticig <gulsum.atici@canonical.com>

Fixing Black and Flake8 errors in RO master

Change-Id: I401c94bc8bd67e03e2f039d69237187fd77c10f4
Signed-off-by: aticig <gulsum.atici@canonical.com>

Feature 10909: Heal operation for VDU

Change-Id: I4f15fca7874cfc443f09fa65855579e1318a899d
Signed-off-by: gallardo <sgallardor@indra.es>
Signed-off-by: garciadeblas <gerardo.garciadeblas@telefonica.com>
Signed-off-by: palaciosj <jmpalacios@indra.es>

Fixes bug 2013 : Passing Anti-affinity group as additionalParamsForVnf

Change-Id: I4c14ef26cd78547cb74a19cdd50dbec9b40a0a93
Signed-off-by: Alexis Romero <garomero@indra.es>

Fix Bug 1911 Root disk cannot be a Persistent Volume

By this fix, VNFs could have persistent root disk if the disk type is defined as persistent-storage.
Besides, the problem of creating unnecessary empty persistent volume is solved.

Change-Id: Id032701bba4ce71080c338bc7f112261ec98861e
Signed-off-by: aticig <gulsum.atici@canonical.com>

Fix Bug 1785 Openstack VIM connector failed Unittests

This patch fixes bug 1785 the Openstack VIM connector failed Unittests.
Openstack VIM unittests and coverage are also enabled in tox.ini.

Change-Id: I136a53a6f59c48a1681cfe3c87dbe9aada253a98
Signed-off-by: aticig <gulsum.atici@canonical.com>

Feature 10906: Support for Anti-Affinity groups

Change-Id: I5eabb222faf9a5422bfb729ff50984f23ac4b9ba
Signed-off-by: Alexis Romero <garomero@indra.es>

Added check for release notes

Change-Id: Id6d0fb10e7bd56574c18a8c6750b2920353ea12f
Signed-off-by: garciadeblas <gerardo.garciadeblas@telefonica.com>

Fix bug 1927 for EPA_04 test (exception management error)

Change-Id: I3e75de24a12b7fc88ee63f68dfea0c6c87877905
Signed-off-by: gallardo <sgallardor@indra.es>

Fix Bug 1910 Enabling stage-test failing by tox results

Change-Id: I9d8fd2104916a1b16fccb68d21126891ac512b9f
Signed-off-by: aticig <gulsum.atici@canonical.com>

Fix bug 1904 for EPA tests (no valid hostname)

Change-Id: Ia2f2b71812e46f33144178d342c3559e54d8a03c
Signed-off-by: gallardo <sgallardor@indra.es>

Refactor method deploy

This change removes the method `_process_items` and refactors the method
`deploy` to do the following tasks:

- `calculate_all_differences_to_deploy`: returns the list of items to be
  created and deleted
- `define_all_tasks`: creates all the task structures
- `upload_all_tasks`: saves all tasks in the common DB

Change-Id: I5cb59dd697875634a4a92df8673c9842a4578d5f
Signed-off-by: gallardo <sgallardor@indra.es>

Add log to trace task workflow

Change-Id: I7f65766ca22dad2f9cc3d2968bc10bc8f7a2779d
Signed-off-by: gallardo <sgallardor@indra.es>

Fix bug 1598 to update the time to refresh the status of CREATE task

Change-Id: I350e0e8cbfb7818dcd26ffcb23799c16ff8282a2
Signed-off-by: gallardo <sgallardor@indra.es>

Fix bug 1859 for VNET supporting in a different resource group

Change-Id: Iaddd2515995eb4c49977c7c705b7634638bb3071
Signed-off-by: gallardo <sgallardor@indra.es>

Fix Bug1832-Use existing flavors with true

Change-Id: I0025b2be85c4153f1812ebbb9108ea14b92770c8
Signed-off-by: preethika.p <preethika.p@tataelxsi.co.in>

Adding header to release notes

Change-Id: I66726de18610a4405f519371d0ca3edcec1eb252
Signed-off-by: sousaedu <eduardo.sousa@canonical.com>

Updating Dockerfile.local to align latest Bug-1849

Change-Id: I188fa8e7cbbd3ae5a02523c7ba68ffe2af870bb8
Signed-off-by: preethika.p <preethika.p@tataelxsi.co.in>

Bug 1849: LTS Support

Updates base to Ubuntu 20.04
Updates python to 3.8
Updates pip dependencies to more recent versions
Adds apt cache to stage 2 dockerfile

Fixes bug 1849

Change-Id: I8a589bbc76bb11f4bc0c42ebb727729da5c5c906
Signed-off-by: beierlm <mark.beierl@canonical.com>

Fix Bug 1781 RO does not create management networks where appropriate

If there is mgmt-network in the descriptor,
there is no mapping of that network to a VIM network in the descriptor,
also there is no mapping in the "--config" parameter or at VIM creation;
that mgmt-network will be created.

Change-Id: Ic3ba8bed0417c49bf7d205b91c04703c6aa1b6a3
Signed-off-by: aticig <gulsum.atici@canonical.com>

Extracting Ns._process_vdu_params() and creating unit test

Change-Id: Ie5bf2a57d85114d3eacc9a416004423a18d1f27c
Signed-off-by: sousaedu <eduardo.sousa@canonical.com>

Adding Unit tests for TestVimInteractionNet Class

Unit tests are added for TestVIMInteractionNet Class which belongs to osm_ng_ro.ns_thread

Change-Id: I66a096083667c0c25f663b15cd5080850b69212b
Signed-off-by: aticig <gulsum.atici@canonical.com>

Enabling Flake8 and import sorting

Enabling flake8 verifications in tox.ini and adding import sorting.
All the plugins have been fixed for flake8 errors and the imports
have been sorted.

Change-Id: Icdefe9a877e891a683cc833315e4c3f94fffbab9
Signed-off-by: sousaedu <eduardo.sousa@canonical.com>

Removing Fog05 VIM RO Plugin

Change-Id: I90e81463ac804d52ea65635f5da6386c2cc3e7df
Signed-off-by: sousaedu <eduardo.sousa@canonical.com>

Extracting Ns._process_net_params() and creating unit test

Change-Id: I97165a76371cdf46e472642e3d75d95ef5256650
Signed-off-by: sousaedu <eduardo.sousa@canonical.com>

Extracting Ns._ip_profile_to_ro() and creating unit test

Change-Id: I0a04a7b2cbe24660529389926f7b4d51f010ca7d
Signed-off-by: sousaedu <eduardo.sousa@canonical.com>

Extracting Ns._process_flavor_params() and creating unit test

Change-Id: I7146a1a7a2fa703443bf218be351e39f6d98d699
Signed-off-by: sousaedu <eduardo.sousa@canonical.com>

Revert "Revert "Removing OpenNebula code""

This reverts commit 37d0befd4a0e244c1fee3ea0ea68be23f89b7c1d.

Requested by TSC

Change-Id: I4c53c0fcb29acef1ee082acd28738296ea7e8a80

Revert "Removing OpenNebula code"

This reverts commit 5af67b3295859894c458e94c979834e6a20ffb52.

Change-Id: I0d758b038057af83df007c153a7baa23e974c7c0
Signed-off-by: sousaedu <eduardo.sousa@canonical.com>

Removing OpenNebula code

Change-Id: Iae91ed12897a6d99b37b13585a9aefd556069d8c
Signed-off-by: sousaedu <eduardo.sousa@canonical.com>