From: garciadeblas Date: Mon, 8 Nov 2021 09:30:56 +0000 (+0100) Subject: Fix bug 1735 to assign floating IP addresses only when use_floating_ip set to true X-Git-Tag: v12.0.0rc1~60 X-Git-Url: https://osm.etsi.org/gitweb/?a=commitdiff_plain;h=refs%2Fchanges%2F09%2F11309%2F1;p=osm%2FRO.git Fix bug 1735 to assign floating IP addresses only when use_floating_ip set to true Change-Id: I9d3eb727ae0c9954082b63ea416c57b1217bfb46 Signed-off-by: garciadeblas --- diff --git a/RO-VIM-gcp/osm_rovim_gcp/vimconn_gcp.py b/RO-VIM-gcp/osm_rovim_gcp/vimconn_gcp.py index 73b77bab..ecfdb068 100644 --- a/RO-VIM-gcp/osm_rovim_gcp/vimconn_gcp.py +++ b/RO-VIM-gcp/osm_rovim_gcp/vimconn_gcp.py @@ -926,12 +926,12 @@ class vimconnector(vimconn.VimConnector): ] = "regions/%s/subnetworks/" % self.region + net.get("name") else: net_iface["subnetwork"] = net.get("net_id") - # According to documentation "type" can be only ONE_TO_ONE_NAT and the recomended value for "name" is "External NAT", - # so an external IP will be generated for the instance - # TODO: check if it's possible to allow internet access to the instance with no external IP - net_iface["accessConfigs"] = [ - {"type": "ONE_TO_ONE_NAT", "name": "External NAT"} - ] + # In order to get an external IP address, the key "accessConfigs" must be used + # in the interace. It has to be of type "ONE_TO_ONE_NAT" and name "External NAT" + if net.get("floating_ip", False) or (net["use"] == "mgmt" and self.config.get("use_floating_ip")): + net_iface["accessConfigs"] = [ + {"type": "ONE_TO_ONE_NAT", "name": "External NAT"} + ] network_interfaces.append(net_iface)