From: beierlm <mark.beierl@canonical.com>
Date: Tue, 15 Feb 2022 16:30:56 +0000 (-0500)
Subject: Fix 1703 - Adding non-root user to run NBI
X-Git-Tag: v10.1.0-rc1~6
X-Git-Url: https://osm.etsi.org/gitweb/?a=commitdiff_plain;h=e259b321ba575dee95274b3841d5063e54f75a97;p=osm%2Fdevops.git

Fix 1703 - Adding non-root user to run NBI

The idea behind this is to run NBI as a non-root user for security
reasons. This required the creation of a new user in the container
image and setting permissions acordingly.

Change-Id: Idf967204b19818ad623c67a19c134cd78a97b9dc
Signed-off-by: beierlm <mark.beierl@canonical.com>
---

diff --git a/docker/NBI/Dockerfile b/docker/NBI/Dockerfile
index 49399fbe..f128f735 100644
--- a/docker/NBI/Dockerfile
+++ b/docker/NBI/Dockerfile
@@ -62,21 +62,25 @@ RUN DEBIAN_FRONTEND=noninteractive apt-get --yes update && \
 COPY --from=INSTALL /usr/lib/python3/dist-packages /usr/lib/python3/dist-packages
 COPY --from=INSTALL /usr/local/lib/python3.8/dist-packages  /usr/local/lib/python3.8/dist-packages
 
-RUN mkdir -p /app/storage/kafka && mkdir -p /app/log
+# Creating the user for the app
+RUN groupadd -g 1000 appuser && \
+    useradd -u 1000 -g 1000 -d /app appuser && \
+    mkdir -p /app/osm_nbi && \
+    mkdir -p /app/storage/kafka && \
+    mkdir /app/log && \
+    chown -R appuser:appuser /app
 
 WORKDIR /app/osm_nbi
 
+# Changing the security context
+USER appuser
+
 EXPOSE 9999
 
 RUN cp -R /usr/lib/python3/dist-packages/osm_nbi/html_public /app/osm_nbi/html_public
 RUN cp /usr/lib/python3/dist-packages/osm_nbi/nbi.cfg /app/osm_nbi/
 RUN cp -R /usr/lib/python3/dist-packages/osm_nbi/http /app/osm_nbi/
 
-# Used for local storage
-VOLUME /app/storage
-# Used for logs
-VOLUME /app/log
-
 # The following ENV can be added with "docker run -e xxx' to configure
 # server
 ENV OSMNBI_SOCKET_HOST     0.0.0.0
@@ -119,4 +123,3 @@ HEALTHCHECK --start-period=120s --interval=10s --timeout=5s --retries=5 \
 
 # Run app.py when the container launches
 CMD python3 -m osm_nbi.nbi
-
diff --git a/installers/docker/osm_pods/nbi.yaml b/installers/docker/osm_pods/nbi.yaml
index 54f72571..7b3616e3 100644
--- a/installers/docker/osm_pods/nbi.yaml
+++ b/installers/docker/osm_pods/nbi.yaml
@@ -44,6 +44,10 @@ spec:
       labels:
         app: nbi
     spec:
+      securityContext:
+        runAsUser: 1000
+        runAsGroup: 1000
+        fsGroup: 1000
       initContainers:
       - name: kafka-mongo-test
         image: alpine:latest
@@ -70,10 +74,3 @@ spec:
         envFrom:
         - secretRef:
            name: nbi-secret
-        volumeMounts:
-         - name: osm-packages
-           mountPath: /app/storage
-      volumes:
-       - name: osm-packages
-         hostPath:
-          path: /var/lib/osm/osm_osm_packages/_data