From: Gulsum Atici <gulsum.atici@canonical.com>
Date: Tue, 10 Jan 2023 11:10:42 +0000 (+0300)
Subject: Fix Bug 2208 KeyError while checking SDN assists requirement
X-Git-Tag: release-v14.0-start~30
X-Git-Url: https://osm.etsi.org/gitweb/?a=commitdiff_plain;ds=sidebyside;h=refs%2Fchanges%2F31%2F12831%2F2;hp=411af2e5804302a45c911556a60fe702227fa799;p=osm%2FLCM.git

Fix Bug 2208 KeyError while checking SDN assists requirement

VIM config is optional so code is fixed by checking the existence of VIM config.

Change-Id: I1aca37cf169a766219630c90968df9d729ffd621
Signed-off-by: Gulsum Atici <gulsum.atici@canonical.com>
---

diff --git a/osm_lcm/ns.py b/osm_lcm/ns.py
index 5d960c5..20e813f 100644
--- a/osm_lcm/ns.py
+++ b/osm_lcm/ns.py
@@ -1014,16 +1014,16 @@ class NsLcm(LcmBase):
             # check if this network needs SDN assist
             if vld.get("pci-interfaces"):
                 db_vim = get_vim_account(ns_params["vimAccountId"])
-                sdnc_id = db_vim["config"].get("sdn-controller")
-                if sdnc_id:
-                    sdn_vld = "nsrs:{}:vld.{}".format(nsr_id, vld["id"])
-                    target_sdn = "sdn:{}".format(sdnc_id)
-                    target_vld["vim_info"][target_sdn] = {
-                        "sdn": True,
-                        "target_vim": target_vim,
-                        "vlds": [sdn_vld],
-                        "type": vld.get("type"),
-                    }
+                if vim_config := db_vim.get("config"):
+                    if sdnc_id := vim_config.get("sdn-controller"):
+                        sdn_vld = "nsrs:{}:vld.{}".format(nsr_id, vld["id"])
+                        target_sdn = "sdn:{}".format(sdnc_id)
+                        target_vld["vim_info"][target_sdn] = {
+                            "sdn": True,
+                            "target_vim": target_vim,
+                            "vlds": [sdn_vld],
+                            "type": vld.get("type"),
+                        }
 
             nsd_vnf_profiles = get_vnf_profiles(nsd)
             for nsd_vnf_profile in nsd_vnf_profiles: