Coverity-CWE 260: Password in Configuration File

Hardcoded credentials in​ configuration file​
remove from the cloud-config.txt file as it is not being used anywhere in the test case

Change-Id: I101e4b9b6f48fa6d34822bc6f400552329f9aa18
Signed-off-by: k4.rahul <rahul.k4@tataelxsi.co.in>

diff --git a/osm_common/tests/packages/invalid_package_vnf/Scripts/cloud_init/cloud-config.txt b/osm_common/tests/packages/invalid_package_vnf/Scripts/cloud_init/cloud-config.txt
index 7a83e12..5c78ae3 100755 (executable)
--- a/osm_common/tests/packages/invalid_package_vnf/Scripts/cloud_init/cloud-config.txt
+++ b/osm_common/tests/packages/invalid_package_vnf/Scripts/cloud_init/cloud-config.txt
@@ -19,7 +19,6 @@
 #\r
 \r
 #cloud-config\r
-password: osm4u\r
 chpasswd: { expire: False }\r
 ssh_pwauth: True\r
 \r

diff --git a/osm_common/tests/packages/native_charm_with_metadata_dir_vnf/Scripts/cloud_init/cloud-config.txt b/osm_common/tests/packages/native_charm_with_metadata_dir_vnf/Scripts/cloud_init/cloud-config.txt
index f5d56f6..1e33dd4 100755 (executable)
--- a/osm_common/tests/packages/native_charm_with_metadata_dir_vnf/Scripts/cloud_init/cloud-config.txt
+++ b/osm_common/tests/packages/native_charm_with_metadata_dir_vnf/Scripts/cloud_init/cloud-config.txt
@@ -20,7 +20,6 @@
 \r
 \r
 #cloud-config\r
-password: osm4u\r
 chpasswd: { expire: False }\r
 ssh_pwauth: True\r
 \r

diff --git a/osm_common/tests/packages/native_charm_without_metadata_dir_vnf/Scripts/cloud_init/cloud-config.txt b/osm_common/tests/packages/native_charm_without_metadata_dir_vnf/Scripts/cloud_init/cloud-config.txt
index f5d56f6..1e33dd4 100755 (executable)
--- a/osm_common/tests/packages/native_charm_without_metadata_dir_vnf/Scripts/cloud_init/cloud-config.txt
+++ b/osm_common/tests/packages/native_charm_without_metadata_dir_vnf/Scripts/cloud_init/cloud-config.txt
@@ -20,7 +20,6 @@
 \r
 \r
 #cloud-config\r
-password: osm4u\r
 chpasswd: { expire: False }\r
 ssh_pwauth: True\r
 \r

diff --git a/releasenotes/notes/fix_cwe_260-badcbfc255dd5e34.yaml b/releasenotes/notes/fix_cwe_260-badcbfc255dd5e34.yaml
new file mode 100644 (file)
index 0000000..51f03a9
--- /dev/null
+++ b/releasenotes/notes/fix_cwe_260-badcbfc255dd5e34.yaml
@@ -0,0 +1,22 @@
+#######################################################################################
+# Copyright ETSI Contributors and Others.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+# implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#######################################################################################
+---
+security:
+  - |
+    Coverity-CWE 260: Password in Configuration File 
+    Hardcoded credentials in configuration file are removed from the cloud-config.txt file
+    as it is not being used anywhere in the test case.