Fixing workflow passthrough 02/13602/2
authorMark Beierl <mark.beierl@canonical.com>
Fri, 30 Jun 2023 19:32:35 +0000 (19:32 +0000)
committerMark Beierl <mark.beierl@canonical.com>
Fri, 30 Jun 2023 19:37:10 +0000 (19:37 +0000)
LCM Operation Workflow abstract classes should not interfere
with the impl's ability to call super() on wrap_nslcmop method

Change-Id: If46a643f0d7b34f77d47638ad9de8786aba15932
Signed-off-by: Mark Beierl <mark.beierl@canonical.com>
osm_common/temporal/workflows/lcm.py

index ee5b6ad..09b1c52 100644 (file)
@@ -20,8 +20,8 @@ from dataclasses import dataclass
 from datetime import timedelta
 
 from osm_common.temporal.activities.lcm import UpdateNsLcmOperationState
-from osm_common.temporal.workflows.base import BaseWorkflow
 from osm_common.temporal.states import LcmOperationState
+from osm_common.temporal.workflows.base import BaseWorkflow
 from temporalio import workflow
 from temporalio.common import RetryPolicy
 from temporalio.exceptions import ActivityError, ChildWorkflowError
@@ -158,10 +158,6 @@ class NsNoOpWorkflow(LcmOperationWorkflow):
 
         nslcmop: dict
 
-    @abstractmethod
-    async def wrap_nslcmop(self, workflow_input: Input) -> None:
-        pass
-
     @abstractmethod
     async def run(self, workflow_input: Input) -> None:
         pass