X-Git-Url: https://osm.etsi.org/gitweb/?a=blobdiff_plain;f=rwlaunchpad%2Fplugins%2Frwvnfm%2Frift%2Ftasklets%2Frwvnfmtasklet%2Frwvnfmtasklet.py;h=e39a8ae8eea90bf4b9c0b3b83ef6cbfc23051f9a;hb=55e01f61d558380f6cc8b34a2d7834819371defd;hp=1a896812c6b69c6125d597a160e5447e49ad4155;hpb=055eabb8205cf0707a139f394f0afb5dbfa7423c;p=osm%2FSO.git diff --git a/rwlaunchpad/plugins/rwvnfm/rift/tasklets/rwvnfmtasklet/rwvnfmtasklet.py b/rwlaunchpad/plugins/rwvnfm/rift/tasklets/rwvnfmtasklet/rwvnfmtasklet.py index 1a896812..e39a8ae8 100755 --- a/rwlaunchpad/plugins/rwvnfm/rift/tasklets/rwvnfmtasklet/rwvnfmtasklet.py +++ b/rwlaunchpad/plugins/rwvnfm/rift/tasklets/rwvnfmtasklet/rwvnfmtasklet.py @@ -49,6 +49,7 @@ from gi.repository import ( import rift.tasklets import rift.package.store import rift.package.cloud_init +import rift.mano.dts as mano_dts class VMResourceError(Exception): @@ -270,6 +271,7 @@ class VirtualDeploymentUnitRecord(object): vdud, vnfr, mgmt_intf, + mgmt_network, cloud_account_name, vnfd_package_store, vdur_id=None, @@ -282,6 +284,7 @@ class VirtualDeploymentUnitRecord(object): self._mgmt_intf = mgmt_intf self._cloud_account_name = cloud_account_name self._vnfd_package_store = vnfd_package_store + self._mgmt_network = mgmt_network self._vdur_id = vdur_id or str(uuid.uuid4()) self._int_intf = [] @@ -337,6 +340,8 @@ class VirtualDeploymentUnitRecord(object): @property def image_name(self): """ name that should be used to lookup the image on the CMP """ + if 'image' not in self._vdud: + return None return os.path.basename(self._vdud.image) @property @@ -377,6 +382,7 @@ class VirtualDeploymentUnitRecord(object): "vswitch_epa", "hypervisor_epa", "host_epa", + "volumes", "name"] vdu_copy_dict = {k: v for k, v in self._vdud.as_dict().items() if k in vdu_fields} @@ -387,9 +393,10 @@ class VirtualDeploymentUnitRecord(object): } if self.vm_resp is not None: vdur_dict.update({"vim_id": self.vm_resp.vdu_id, - "flavor_id": self.vm_resp.flavor_id, - "image_id": self.vm_resp.image_id, + "flavor_id": self.vm_resp.flavor_id }) + if self._vm_resp.has_field('image_id'): + vdur_dict.update({ "image_id": self.vm_resp.image_id }) if self.management_ip is not None: vdur_dict["management_ip"] = self.management_ip @@ -399,6 +406,13 @@ class VirtualDeploymentUnitRecord(object): vdur_dict.update(vdu_copy_dict) + if self.vm_resp is not None: + if self._vm_resp.has_field('volumes'): + for opvolume in self._vm_resp.volumes: + vdurvol_data = [vduvol for vduvol in vdur_dict['volumes'] if vduvol['name'] == opvolume.name] + if len(vdurvol_data) == 1: + vdurvol_data[0]["volume_id"] = opvolume.volume_id + icp_list = [] ii_list = [] @@ -408,7 +422,7 @@ class VirtualDeploymentUnitRecord(object): icp_list.append({"name": cp.name, "id": cp.id, "type_yang": "VPORT", - "ip_address": self.cp_ip_addr(cp.id)}) + "ip_address": self.cp_ip_addr(cp.name)}) ii_list.append({"name": intf.name, "vdur_internal_connection_point_ref": cp.id, @@ -420,18 +434,18 @@ class VirtualDeploymentUnitRecord(object): ei_list = [] for intf, cp, vlr in self._ext_intf: - ei_list.append({"name": cp, - "vnfd_connection_point_ref": cp, + ei_list.append({"name": cp.name, + "vnfd_connection_point_ref": cp.name, "virtual_interface": {}}) - self._vnfr.update_cp(cp, self.cp_ip_addr(cp), self.cp_id(cp)) + self._vnfr.update_cp(cp.name, self.cp_ip_addr(cp.name), self.cp_id(cp.name)) vdur_dict["external_interface"] = ei_list placement_groups = [] for group in self._placement_groups: placement_groups.append(group.as_dict()) - vdur_dict['placement_groups_info'] = placement_groups + return RwVnfrYang.YangData_Vnfr_VnfrCatalog_Vnfr_Vdur.from_dict(vdur_dict) @property @@ -538,9 +552,11 @@ class VirtualDeploymentUnitRecord(object): vm_create_msg_dict = { "name": self.name, - "image_name": self.image_name, } + if self.image_name is not None: + vm_create_msg_dict["image_name"] = self.image_name + if self.image_checksum is not None: vm_create_msg_dict["image_checksum"] = self.image_checksum @@ -552,12 +568,21 @@ class VirtualDeploymentUnitRecord(object): if config is not None: vm_create_msg_dict['vdu_init'] = {'userdata': config} + if self._mgmt_network: + vm_create_msg_dict['mgmt_network'] = self._mgmt_network + cp_list = [] for intf, cp, vlr in self._ext_intf: - cp_info = {"name": cp, + cp_info = {"name": cp.name, "virtual_link_id": vlr.network_id, "type_yang": intf.virtual_interface.type_yang} + try: + if cp.static_ip_address: + cp_info["static_ip_address"] = cp.static_ip_address + except AttributeError as e: + pass + if (intf.virtual_interface.has_field('vpci') and intf.virtual_interface.vpci is not None): cp_info["vpci"] = intf.virtual_interface.vpci @@ -565,19 +590,28 @@ class VirtualDeploymentUnitRecord(object): if (vlr.has_field('ip_profile_params')) and (vlr.ip_profile_params.has_field('security_group')): cp_info['security_group'] = vlr.ip_profile_params.security_group + self._log.debug("External CP info {}".format(cp_info)) cp_list.append(cp_info) - for intf, cp, vlr in self._int_intf: + for intf, cp_id, vlr in self._int_intf: + cp = self.find_internal_cp_by_cp_id(cp_id) + + cp_dict = {"name": cp_id, + "virtual_link_id": vlr.network_id, + "type_yang": intf.virtual_interface.type_yang} + if (intf.virtual_interface.has_field('vpci') and intf.virtual_interface.vpci is not None): - cp_list.append({"name": cp, - "virtual_link_id": vlr.network_id, - "type_yang": intf.virtual_interface.type_yang, - "vpci": intf.virtual_interface.vpci}) - else: - cp_list.append({"name": cp, - "virtual_link_id": vlr.network_id, - "type_yang": intf.virtual_interface.type_yang}) + cp_dict["vpci"] = intf.virtual_interface.vpci + + try: + if cp.static_ip_address: + cp_dict["static_ip_address"] = cp.static_ip_address + except AttributeError as e: + pass + + self._log.debug("Internal CP info {}".format(cp_info)) + cp_list.append(cp_dict) vm_create_msg_dict["connection_points"] = cp_list vm_create_msg_dict.update(vdu_copy_dict) @@ -588,6 +622,10 @@ class VirtualDeploymentUnitRecord(object): msg.event_id = self._request_id msg.cloud_account = self.cloud_account_name msg.request_info.from_dict(vm_create_msg_dict) + + for volume in self._vdud.volumes: + v = msg.request_info.volumes.add() + v.from_dict(volume.as_dict()) return msg @asyncio.coroutine @@ -657,28 +695,15 @@ class VirtualDeploymentUnitRecord(object): cp_name) return cp - def find_internal_vlr_by_cp_name(cp_name): - """ Find the VLR corresponding to the connection point name""" - cp = None - - self._log.debug("find_internal_vlr_by_cp_name(%s) called", - cp_name) - - for int_cp in self._vdud.internal_connection_point: - self._log.debug("Checking for int cp %s in internal connection points", - int_cp.id) - if int_cp.id == cp_name: - cp = int_cp - break + def find_internal_vlr_by_cp_id(cp_id): + self._log.debug("find_internal_vlr_by_cp_id(%s) called", + cp_id) - if cp is None: - self._log.debug("Failed to find cp %s in internal connection points", - cp_name) - msg = "Failed to find cp %s in internal connection points" % cp_name - raise VduRecordError(msg) + # Validate the cp + cp = self.find_internal_cp_by_cp_id(cp_id) # return the VLR associated with the connection point - return vnfr.find_vlr_by_cp(cp_name) + return vnfr.find_vlr_by_cp(cp_id) block = xact.block_create() @@ -699,7 +724,7 @@ class VirtualDeploymentUnitRecord(object): vlr = vnfr.ext_vlr_by_id(cp.vlr_ref) - etuple = (ext_intf, cp.name, vlr) + etuple = (ext_intf, cp, vlr) self._ext_intf.append(etuple) self._log.debug("Created external interface tuple : %s", etuple) @@ -711,7 +736,7 @@ class VirtualDeploymentUnitRecord(object): intf.name, cp_id) try: - vlr = find_internal_vlr_by_cp_name(cp_id) + vlr = find_internal_vlr_by_cp_id(cp_id) except Exception as e: self._log.debug("Failed to find cp %s in internal VLR list", cp_id) msg = "Failed to find cp %s in internal VLR list, e = %s" % (cp_id, e) @@ -1046,19 +1071,20 @@ class InternalVirtualLinkRecord(object): class VirtualNetworkFunctionRecord(object): """ Virtual Network Function Record """ - def __init__(self, dts, log, loop, cluster_name, vnfm, vcs_handler, vnfr_msg): + def __init__(self, dts, log, loop, cluster_name, vnfm, vcs_handler, vnfr_msg, mgmt_network=None): self._dts = dts self._log = log self._loop = loop self._cluster_name = cluster_name self._vnfr_msg = vnfr_msg self._vnfr_id = vnfr_msg.id - self._vnfd_id = vnfr_msg.vnfd_ref + self._vnfd_id = vnfr_msg.vnfd.id self._vnfm = vnfm self._vcs_handler = vcs_handler self._vnfr = vnfr_msg + self._mgmt_network = mgmt_network - self._vnfd = None + self._vnfd = vnfr_msg.vnfd self._state = VirtualNetworkFunctionRecordState.INIT self._state_failed_reason = None self._ext_vlrs = {} # The list of external virtual links @@ -1071,6 +1097,8 @@ class VirtualNetworkFunctionRecord(object): self._vnf_mon = None self._config_status = vnfr_msg.config_status self._vnfd_package_store = rift.package.store.VnfdPackageFilesystemStore(self._log) + self._rw_vnfd = None + self._vnfd_ref_count = 0 def _get_vdur_from_vdu_id(self, vdu_id): self._log.debug("Finding vdur for vdu_id %s", vdu_id) @@ -1096,11 +1124,36 @@ class VirtualNetworkFunctionRecord(object): "FAILED": "failed", } return op_status_map[self._state.name] - @property - def vnfd_xpath(self): + @staticmethod + def vnfd_xpath(vnfd_id): """ VNFD xpath associated with this VNFR """ - return("C,/vnfd:vnfd-catalog/" - "vnfd:vnfd[vnfd:id = '{}']".format(self._vnfd_id)) + return "C,/vnfd:vnfd-catalog/vnfd:vnfd[vnfd:id = '{}']".format(vnfd_id) + + @property + def vnfd_ref_count(self): + """ Returns the VNFD reference count associated with this VNFR """ + return self._vnfd_ref_count + + def vnfd_in_use(self): + """ Returns whether vnfd is in use or not """ + return True if self._vnfd_ref_count > 0 else False + + def vnfd_ref(self): + """ Take a reference on this object """ + self._vnfd_ref_count += 1 + return self._vnfd_ref_count + + def vnfd_unref(self): + """ Release reference on this object """ + if self._vnfd_ref_count < 1: + msg = ("Unref on a VNFD object - vnfd id %s, vnfd_ref_count = %s" % + (self.vnfd.id, self._vnfd_ref_count)) + self._log.critical(msg) + raise VnfRecordError(msg) + self._log.debug("Releasing ref on VNFD %s - curr vnfd_ref_count:%s", + self.vnfd.id, self._vnfd_ref_count) + self._vnfd_ref_count -= 1 + return self._vnfd_ref_count @property def vnfd(self): @@ -1182,7 +1235,7 @@ class VirtualNetworkFunctionRecord(object): def mgmt_intf_info(self): """ Get Management interface info for this VNFR """ - mgmt_intf_desc = self.vnfd.msg.mgmt_interface + mgmt_intf_desc = self.vnfd.mgmt_interface ip_addr = None if mgmt_intf_desc.has_field("cp"): ip_addr = self.cp_ip_addr(mgmt_intf_desc.cp) @@ -1203,7 +1256,7 @@ class VirtualNetworkFunctionRecord(object): def msg(self): """ Message associated with this VNFR """ vnfd_fields = ["short_name", "vendor", "description", "version"] - vnfd_copy_dict = {k: v for k, v in self.vnfd.msg.as_dict().items() if k in vnfd_fields} + vnfd_copy_dict = {k: v for k, v in self.vnfd.as_dict().items() if k in vnfd_fields} mgmt_intf = VnfrYang.YangData_Vnfr_VnfrCatalog_Vnfr_MgmtInterface() ip_address, port = self.mgmt_intf_info() @@ -1217,7 +1270,6 @@ class VirtualNetworkFunctionRecord(object): "nsr_id_ref": self._vnfr_msg.nsr_id_ref, "name": self.name, "member_vnf_index_ref": self.member_vnf_index, - "vnfd_ref": self.vnfd_id, "operational_status": self.operational_status, "operational_status_details": self._state_failed_reason, "cloud_account": self.cloud_account_name, @@ -1227,6 +1279,9 @@ class VirtualNetworkFunctionRecord(object): vnfr_dict.update(vnfd_copy_dict) vnfr_msg = RwVnfrYang.YangData_Vnfr_VnfrCatalog_Vnfr.from_dict(vnfr_dict) + vnfr_msg.vnfd = VnfrYang.YangData_Vnfr_VnfrCatalog_Vnfr_Vnfd.from_dict(self.vnfd.as_dict()) + + vnfr_msg.create_time = self._create_time vnfr_msg.uptime = int(time.time()) - self._create_time vnfr_msg.mgmt_interface = mgmt_intf @@ -1241,7 +1296,7 @@ class VirtualNetworkFunctionRecord(object): vdur = vnfr_msg.vdur.add() vdur.from_dict(vdu.msg.as_dict()) - if self.vnfd.msg.mgmt_interface.has_field('dashboard_params'): + if self.vnfd.mgmt_interface.has_field('dashboard_params'): vnfr_msg.dashboard_url = self.dashboard_url for cpr in self._cprs: @@ -1271,18 +1326,18 @@ class VirtualNetworkFunctionRecord(object): ip, cfg_port = self.mgmt_intf_info() protocol = 'http' http_port = 80 - if self.vnfd.msg.mgmt_interface.dashboard_params.has_field('https'): - if self.vnfd.msg.mgmt_interface.dashboard_params.https is True: + if self.vnfd.mgmt_interface.dashboard_params.has_field('https'): + if self.vnfd.mgmt_interface.dashboard_params.https is True: protocol = 'https' http_port = 443 - if self.vnfd.msg.mgmt_interface.dashboard_params.has_field('port'): - http_port = self.vnfd.msg.mgmt_interface.dashboard_params.port + if self.vnfd.mgmt_interface.dashboard_params.has_field('port'): + http_port = self.vnfd.mgmt_interface.dashboard_params.port url = "{protocol}://{ip_address}:{port}/{path}".format( protocol=protocol, ip_address=ip, port=http_port, - path=self.vnfd.msg.mgmt_interface.dashboard_params.path.lstrip("/"), + path=self.vnfd.mgmt_interface.dashboard_params.path.lstrip("/"), ) return url @@ -1309,7 +1364,7 @@ class VirtualNetworkFunctionRecord(object): """ Publish The VLs associated with this VNF """ self._log.debug("Publishing Internal Virtual Links for vnfd id: %s", self.vnfd_id) - for ivld_msg in self.vnfd.msg.internal_vld: + for ivld_msg in self.vnfd.internal_vld: self._log.debug("Creating internal vld:" " %s, int_cp_ref = %s", ivld_msg, ivld_msg.internal_connection_point @@ -1380,7 +1435,7 @@ class VirtualNetworkFunctionRecord(object): nsr_config = yield from self.get_nsr_config() ### Step-3: Get VDU level placement groups - for group in self.vnfd.msg.placement_groups: + for group in self.vnfd.placement_groups: for member_vdu in group.member_vdus: if member_vdu.member_vdu_ref == vdu.id: group_info = self.resolve_placement_group_cloud_construct(group, @@ -1422,7 +1477,7 @@ class VirtualNetworkFunctionRecord(object): self._log.info("Creating VDU's for vnfd id: %s", self.vnfd_id) - for vdu in self.vnfd.msg.vdu: + for vdu in self._rw_vnfd.vdu: self._log.debug("Creating vdu: %s", vdu) vdur_id = get_vdur_id(vdu) @@ -1440,6 +1495,7 @@ class VirtualNetworkFunctionRecord(object): vdud=vdu, vnfr=vnfr, mgmt_intf=self.has_mgmt_interface(vdu), + mgmt_network=self._mgmt_network, cloud_account_name=self.cloud_account_name, vnfd_package_store=self._vnfd_package_store, vdur_id=vdur_id, @@ -1525,7 +1581,7 @@ class VirtualNetworkFunctionRecord(object): datastore.add(vdu) # Substitute any variables contained in the cloud config script - config = str(vdu.vdud_cloud_init) + config = str(vdu.vdud_cloud_init) if vdu.vdud_cloud_init is not None else "" parts = re.split("\{\{ ([^\}]+) \}\}", config) if len(parts) > 1: @@ -1577,7 +1633,7 @@ class VirtualNetworkFunctionRecord(object): def has_mgmt_interface(self, vdu): # ## TODO: Support additional mgmt_interface type options - if self.vnfd.msg.mgmt_interface.vdu_id == vdu.id: + if self.vnfd.mgmt_interface.vdu_id == vdu.id: return True return False @@ -1596,7 +1652,7 @@ class VirtualNetworkFunctionRecord(object): """ Publish the inventory associated with this VNF """ self._log.debug("Publishing inventory for VNFR id: %s", self._vnfr_id) - for component in self.vnfd.msg.component: + for component in self._rw_vnfd.component: self._log.debug("Creating inventory component %s", component) mangled_name = VcsComponent.mangle_name(component.component_name, self.vnf_name, @@ -1674,6 +1730,7 @@ class VirtualNetworkFunctionRecord(object): def instantiate(self, xact, restart_mode=False): """ instantiate this VNF """ self.set_state(VirtualNetworkFunctionRecordState.VL_INIT_PHASE) + self._rw_vnfd = yield from self._vnfm.fetch_vnfd(self._vnfd_id) @asyncio.coroutine def fetch_vlrs(): @@ -1683,7 +1740,7 @@ class VirtualNetworkFunctionRecord(object): def cpr_from_cp(cp): """ Creates a record level connection point from the desciptor cp""" - cp_fields = ["name", "image", "vm-flavor"] + cp_fields = ["name", "image", "vm-flavor", "static_ip_address"] cp_copy_dict = {k: v for k, v in cp.as_dict().items() if k in cp_fields} cpr_dict = {} cpr_dict.update(cp_copy_dict) @@ -1708,12 +1765,10 @@ class VirtualNetworkFunctionRecord(object): cpr.vlr_ref = cp.vlr_ref self._log.debug("Fetched VLR [%s] with path = [%s]", d, vlr_path) - # Fetch the VNFD associated with the VNFR - self._log.debug("VNFR-ID %s: Fetching vnfds", self._vnfr_id) - self._vnfd = yield from self._vnfm.get_vnfd_ref(self._vnfd_id) - self._log.debug("VNFR-ID %s: Fetched vnfd:%s", self._vnfr_id, self._vnfd) + # Increase the VNFD reference count + self.vnfd_ref() - assert self.vnfd is not None + assert self.vnfd # Fetch External VLRs self._log.debug("VNFR-ID %s: Fetching vlrs", self._vnfr_id) @@ -1842,13 +1897,6 @@ class VnfdDtsHandler(object): xact, action, scratch) is_recovery = xact.xact is None and action == rwdts.AppconfAction.INSTALL - # Create/Update a VNFD record - for cfg in self._regh.get_xact_elements(xact): - # Only interested in those VNFD cfgs whose ID was received in prepare callback - if cfg.id in scratch.get('vnfds', []) or is_recovery: - self._vnfm.update_vnfd(cfg) - - scratch.pop('vnfds', None) @asyncio.coroutine def on_prepare(dts, acg, xact, xact_info, ks_path, msg, scratch): @@ -1858,7 +1906,7 @@ class VnfdDtsHandler(object): fref = ProtobufC.FieldReference.alloc() fref.goto_whole_message(msg.to_pbcm()) - # Handle deletes in prepare_callback, but adds/updates in apply_callback + # Handle deletes in prepare_callback if fref.is_field_deleted(): # Delete an VNFD record self._log.debug("Deleting VNFD with id %s", msg.id) @@ -1868,17 +1916,6 @@ class VnfdDtsHandler(object): raise VirtualNetworkFunctionDescriptorRefCountExists(err) # Delete a VNFD record yield from self._vnfm.delete_vnfd(msg.id) - else: - # Handle actual adds/updates in apply_callback, - # just check if VNFD in use in prepare_callback - if self._vnfm.vnfd_in_use(msg.id): - self._log.debug("Cannot modify an VNFD in use - %s", msg) - err = "Cannot modify an VNFD in use - %s" % msg - raise VirtualNetworkFunctionDescriptorRefCountExists(err) - - # Add this VNFD to scratch to create/update in apply callback - vnfds = scratch.setdefault('vnfds', []) - vnfds.append(msg.id) xact_info.respond_xpath(rwdts.XactRspCode.ACK) @@ -2085,8 +2122,8 @@ class VnfrDtsHandler(object): ) if action == rwdts.QueryAction.CREATE: - if not msg.has_field("vnfd_ref"): - err = "Vnfd reference not provided" + if not msg.has_field("vnfd"): + err = "Vnfd not provided" self._log.error(err) raise VnfRecordError(err) @@ -2113,7 +2150,7 @@ class VnfrDtsHandler(object): try: yield from vnfr.terminate(xact_info.xact) # Unref the VNFD - vnfr.vnfd.unref() + vnfr.vnfd_unref() yield from self._vnfm.delete_vnfr(xact_info.xact, vnfr) except Exception as e: self._log.exception(e) @@ -2195,100 +2232,6 @@ class VnfrDtsHandler(object): self._log.debug("Deleted VNFR xact = %s, %s", xact, path) -class VirtualNetworkFunctionDescriptor(object): - """ - Virtual Network Function descriptor class - """ - - def __init__(self, dts, log, loop, vnfm, vnfd): - self._dts = dts - self._log = log - self._loop = loop - - self._vnfm = vnfm - self._vnfd = vnfd - self._ref_count = 0 - - @property - def ref_count(self): - """ Returns the reference count associated with - this Virtual Network Function Descriptor""" - return self._ref_count - - @property - def id(self): - """ Returns vnfd id """ - return self._vnfd.id - - @property - def name(self): - """ Returns vnfd name """ - return self._vnfd.name - - def in_use(self): - """ Returns whether vnfd is in use or not """ - return True if self._ref_count > 0 else False - - def ref(self): - """ Take a reference on this object """ - self._ref_count += 1 - return self._ref_count - - def unref(self): - """ Release reference on this object """ - if self.ref_count < 1: - msg = ("Unref on a VNFD object - vnfd id %s, ref_count = %s" % - (self.id, self._ref_count)) - self._log.critical(msg) - raise VnfRecordError(msg) - self._log.debug("Releasing ref on VNFD %s - curr ref_count:%s", - self.id, self.ref_count) - self._ref_count -= 1 - return self._ref_count - - @property - def msg(self): - """ Return the message associated with this NetworkServiceDescriptor""" - return self._vnfd - - @staticmethod - def path_for_id(vnfd_id): - """ Return path for the passed vnfd_id""" - return "C,/vnfd:vnfd-catalog/vnfd:vnfd[vnfd:id = '{}']".format(vnfd_id) - - def path(self): - """ Return the path associated with this NetworkServiceDescriptor""" - return VirtualNetworkFunctionDescriptor.path_for_id(self.id) - - def update(self, vnfd): - """ Update the Virtual Network Function Descriptor """ - if self.in_use(): - self._log.error("Cannot update descriptor %s in use refcnt=%d", - self.id, self.ref_count) - - # The following loop is added to debug RIFT-13284 - for vnf_rec in self._vnfm._vnfrs.values(): - if vnf_rec.vnfd_id == self.id: - self._log.error("descriptor %s in used by %s:%s", - self.id, vnf_rec.vnfr_id, vnf_rec.msg) - raise VirtualNetworkFunctionDescriptorRefCountExists("Cannot update descriptor in use %s" % self.id) - self._vnfd = vnfd - - def delete(self): - """ Delete the Virtual Network Function Descriptor """ - if self.in_use(): - self._log.error("Cannot delete descriptor %s in use refcnt=%d", - self.id) - - # The following loop is added to debug RIFT-13284 - for vnf_rec in self._vnfm._vnfrs.values(): - if vnf_rec.vnfd_id == self.id: - self._log.error("descriptor %s in used by %s:%s", - self.id, vnf_rec.vnfr_id, vnf_rec.msg) - raise VirtualNetworkFunctionDescriptorRefCountExists("Cannot delete descriptor in use %s" % self.id) - self._vnfm.delete_vnfd(self.id) - - class VnfdRefCountDtsHandler(object): """ The VNFD Ref Count DTS handler """ XPATH = "D,/vnfr:vnfr-catalog/rw-vnfr:vnfd-ref-count" @@ -2476,13 +2419,17 @@ class VnfManager(object): self._vcs_handler = VcsComponentDtsHandler(dts, log, loop, self) self._vnfr_handler = VnfrDtsHandler(dts, log, loop, self) + self._vnfr_ref_handler = VnfdRefCountDtsHandler(dts, log, loop, self) + self._nsr_handler = mano_dts.NsInstanceConfigSubscriber(log, dts, loop, callback=self.handle_nsr) self._dts_handlers = [VnfdDtsHandler(dts, log, loop, self), self._vnfr_handler, self._vcs_handler, - VnfdRefCountDtsHandler(dts, log, loop, self)] + self._vnfr_ref_handler, + self._nsr_handler] self._vnfrs = {} - self._vnfds = {} + self._vnfds_to_vnfr = {} + self._nsrs = {} @property def vnfr_handler(self): @@ -2506,6 +2453,35 @@ class VnfManager(object): self._log.debug("Run VNFManager - registering static DTS handlers""") yield from self.register() + def handle_nsr(self, nsr, action): + if action in [rwdts.QueryAction.CREATE]: + self._nsrs[nsr.id] = nsr + elif action == rwdts.QueryAction.DELETE: + if nsr.id in self._nsrs: + del self._nsrs[nsr.id] + + def get_linked_mgmt_network(self, vnfr): + """For the given VNFR get the related mgmt network from the NSD, if + available. + """ + vnfd_id = vnfr.vnfd.id + nsr_id = vnfr.nsr_id_ref + + # for the given related VNFR, get the corresponding NSR-config + nsr_obj = None + try: + nsr_obj = self._nsrs[nsr_id] + except KeyError: + raise("Unable to find the NS with the ID: {}".format(nsr_id)) + + # for the related NSD check if a VLD exists such that it's a mgmt + # network + for vld in nsr_obj.nsd.vld: + if vld.mgmt_network: + return vld.name + + return None + def get_vnfr(self, vnfr_id): """ get VNFR by vnfr id """ @@ -2523,11 +2499,15 @@ class VnfManager(object): self._log.info("Create VirtualNetworkFunctionRecord %s from vnfd_id: %s", vnfr.id, - vnfr.vnfd_ref) + vnfr.vnfd.id) + + mgmt_network = self.get_linked_mgmt_network(vnfr) self._vnfrs[vnfr.id] = VirtualNetworkFunctionRecord( - self._dts, self._log, self._loop, self._cluster_name, self, self.vcs_handler, vnfr + self._dts, self._log, self._loop, self._cluster_name, self, self.vcs_handler, vnfr, + mgmt_network=mgmt_network ) + self._vnfds_to_vnfr[vnfr.vnfd.id] = self._vnfrs[vnfr.id] return self._vnfrs[vnfr.id] @asyncio.coroutine @@ -2541,7 +2521,7 @@ class VnfManager(object): @asyncio.coroutine def fetch_vnfd(self, vnfd_id): """ Fetch VNFDs based with the vnfd id""" - vnfd_path = VirtualNetworkFunctionDescriptor.path_for_id(vnfd_id) + vnfd_path = VirtualNetworkFunctionRecord.vnfd_xpath(vnfd_id) self._log.debug("Fetch vnfd with path %s", vnfd_path) vnfd = None @@ -2560,39 +2540,11 @@ class VnfManager(object): return vnfd - @asyncio.coroutine - def get_vnfd_ref(self, vnfd_id): - """ Get Virtual Network Function descriptor for the passed vnfd_id""" - vnfd = yield from self.get_vnfd(vnfd_id) - vnfd.ref() - return vnfd - - @asyncio.coroutine - def get_vnfd(self, vnfd_id): - """ Get Virtual Network Function descriptor for the passed vnfd_id""" - vnfd = None - if vnfd_id not in self._vnfds: - self._log.error("Cannot find VNFD id:%s", vnfd_id) - vnfd = yield from self.fetch_vnfd(vnfd_id) - - if vnfd is None: - self._log.error("Cannot find VNFD id:%s", vnfd_id) - raise VirtualNetworkFunctionDescriptorError("Cannot find VNFD id:%s", vnfd_id) - - if vnfd.id != vnfd_id: - self._log.error("Bad Recovery state {} found for {}".format(vnfd.id, vnfd_id)) - raise VirtualNetworkFunctionDescriptorError("Bad Recovery state {} found for {}".format(vnfd.id, vnfd_id)) - - if vnfd.id not in self._vnfds: - self.create_vnfd(vnfd) - - return self._vnfds[vnfd_id] - def vnfd_in_use(self, vnfd_id): """ Is this VNFD in use """ self._log.debug("Is this VNFD in use - msg:%s", vnfd_id) - if vnfd_id in self._vnfds: - return self._vnfds[vnfd_id].in_use() + if vnfd_id in self._vnfds_to_vnfr: + return self._vnfds_to_vnfr[vnfd_id].in_use() return False @asyncio.coroutine @@ -2602,47 +2554,22 @@ class VnfManager(object): path, msg) yield from self.vnfr_handler.update(xact, path, msg) - def create_vnfd(self, vnfd): - """ Create a virtual network function descriptor """ - self._log.debug("Create virtual networkfunction descriptor - %s", vnfd) - if vnfd.id in self._vnfds: - self._log.error("Cannot create VNFD %s -VNFD id already exists", vnfd) - raise VirtualNetworkFunctionDescriptorError("VNFD already exists-%s", vnfd.id) - - self._vnfds[vnfd.id] = VirtualNetworkFunctionDescriptor(self._dts, - self._log, - self._loop, - self, - vnfd) - return self._vnfds[vnfd.id] - - def update_vnfd(self, vnfd): - """ update the Virtual Network Function descriptor """ - self._log.debug("Update virtual network function descriptor - %s", vnfd) - - if vnfd.id not in self._vnfds: - self._log.debug("No VNFD found - creating VNFD id = %s", vnfd.id) - self.create_vnfd(vnfd) - else: - self._log.debug("Updating VNFD id = %s, vnfd = %s", vnfd.id, vnfd) - self._vnfds[vnfd.id].update(vnfd) - @asyncio.coroutine def delete_vnfd(self, vnfd_id): """ Delete the Virtual Network Function descriptor with the passed id """ self._log.debug("Deleting the virtual network function descriptor - %s", vnfd_id) - if vnfd_id not in self._vnfds: + if vnfd_id not in self._vnfds_to_vnfr: self._log.debug("Delete VNFD failed - cannot find vnfd-id %s", vnfd_id) raise VirtualNetworkFunctionDescriptorNotFound("Cannot find %s", vnfd_id) - if self._vnfds[vnfd_id].in_use(): + if self._vnfds_to_vnfr[vnfd_id].in_use(): self._log.debug("Cannot delete VNFD id %s reference exists %s", vnfd_id, - self._vnfds[vnfd_id].ref_count) + self._vnfds_to_vnfr[vnfd_id].vnfd_ref_count) raise VirtualNetworkFunctionDescriptorRefCountExists( "Cannot delete :%s, ref_count:%s", vnfd_id, - self._vnfds[vnfd_id].ref_count) + self._vnfds_to_vnfr[vnfd_id].vnfd_ref_count) # Remove any files uploaded with VNFD and stored under $RIFT_ARTIFACTS/libs/ try: @@ -2652,10 +2579,10 @@ class VnfManager(object): shutil.rmtree(vnfd_dir, ignore_errors=True) except Exception as e: self._log.error("Exception in cleaning up VNFD {}: {}". - format(self._vnfds[vnfd_id].name, e)) + format(self._vnfds_to_vnfr[vnfd_id].vnfd.name, e)) self._log.exception(e) - del self._vnfds[vnfd_id] + del self._vnfds_to_vnfr[vnfd_id] def vnfd_refcount_xpath(self, vnfd_id): """ xpath for ref count entry """ @@ -2667,14 +2594,15 @@ class VnfManager(object): """ Get the vnfd_list from this VNFM""" vnfd_list = [] if vnfd_id is None or vnfd_id == "": - for vnfd in self._vnfds.values(): + for vnfr in self._vnfds_to_vnfr.values(): + vnfd_msg = RwVnfrYang.YangData_Vnfr_VnfrCatalog_VnfdRefCount() + vnfd_msg.vnfd_id_ref = vnfr.vnfd.id + vnfd_msg.instance_ref_count = vnfr.vnfd_ref_count + vnfd_list.append((self.vnfd_refcount_xpath(vnfr.vnfd.id), vnfd_msg)) + elif vnfd_id in self._vnfds_to_vnfr: vnfd_msg = RwVnfrYang.YangData_Vnfr_VnfrCatalog_VnfdRefCount() - vnfd_msg.vnfd_id_ref = vnfd.id - vnfd_msg.instance_ref_count = vnfd.ref_count - vnfd_list.append((self.vnfd_refcount_xpath(vnfd.id), vnfd_msg)) - elif vnfd_id in self._vnfds: - vnfd_msg.vnfd_id_ref = self._vnfds[vnfd_id].id - vnfd_msg.instance_ref_count = self._vnfds[vnfd_id].ref_count + vnfd_msg.vnfd_id_ref = self._vnfds_to_vnfr[vnfd_id].vnfd.id + vnfd_msg.instance_ref_count = self._vnfds_to_vnfr[vnfd_id].vnfd_ref_count vnfd_list.append((self.vnfd_refcount_xpath(vnfd_id), vnfd_msg)) return vnfd_list