X-Git-Url: https://osm.etsi.org/gitweb/?a=blobdiff_plain;f=osm_nbi%2Ftests%2Ftest_descriptor_topics.py;h=f6d4001f5d46aa278bb3af58dad7eb2752eb2a90;hb=bd02208d93ce9e5319b911258f60b85803d1c3be;hp=b2df34ffba5ec4688808c01d39a9ce92e7d314e2;hpb=4568a372eb5a204e04d917213de03ec51f9110c1;p=osm%2FNBI.git diff --git a/osm_nbi/tests/test_descriptor_topics.py b/osm_nbi/tests/test_descriptor_topics.py index b2df34f..f6d4001 100755 --- a/osm_nbi/tests/test_descriptor_topics.py +++ b/osm_nbi/tests/test_descriptor_topics.py @@ -17,24 +17,36 @@ __author__ = "Pedro de la Cruz Ramos, pedro.delacruzramos@altran.com" __date__ = "2019-11-20" +from contextlib import contextmanager import unittest from unittest import TestCase -from unittest.mock import Mock +from unittest.mock import Mock, patch from uuid import uuid4 from http import HTTPStatus from copy import deepcopy from time import time from osm_common import dbbase, fsbase, msgbase from osm_nbi import authconn -from osm_nbi.tests.test_pkg_descriptors import db_vnfds_text, db_nsds_text +from osm_nbi.tests.test_pkg_descriptors import ( + db_vnfds_text, + db_nsds_text, + vnfd_exploit_text, + vnfd_exploit_fixed_text, + db_sfc_nsds_text, +) from osm_nbi.descriptor_topics import VnfdTopic, NsdTopic from osm_nbi.engine import EngineException from osm_common.dbbase import DbException import yaml +import tempfile +import collections +import collections.abc + +collections.MutableSequence = collections.abc.MutableSequence test_name = "test-user" -db_vnfd_content = yaml.load(db_vnfds_text, Loader=yaml.Loader)[0] -db_nsd_content = yaml.load(db_nsds_text, Loader=yaml.Loader)[0] +db_vnfd_content = yaml.safe_load(db_vnfds_text)[0] +db_nsd_content = yaml.safe_load(db_nsds_text)[0] test_pid = db_vnfd_content["_admin"]["projects_read"][0] fake_session = { "username": test_name, @@ -45,11 +57,23 @@ fake_session = { "public": False, "allow_show_user_project_role": True, } +UUID = "00000000-0000-0000-0000-000000000000" + + +def admin_value(): + return {"projects_read": []} -def norm(str): +def setup_mock_fs(fs): + fs.path = "" + fs.get_params.return_value = {} + fs.file_exists.return_value = False + fs.file_open.side_effect = lambda path, mode: tempfile.TemporaryFile(mode="a+b") + + +def norm(s: str): """Normalize string for checking""" - return " ".join(str.strip().split()).lower() + return " ".join(s.strip().split()).lower() def compare_desc(tc, d1, d2, k): @@ -61,7 +85,7 @@ def compare_desc(tc, d1, d2, k): Lists of different length are not compared :param tc: Test Case wich provides context (in particular the assert* methods) :param d1,d2: Descriptors to be compared - :param key/item being compared + :param k: key/item being compared :return: Nothing """ if isinstance(d1, dict) and isinstance(d2, dict): @@ -92,502 +116,610 @@ class Test_VnfdTopic(TestCase): self.topic = VnfdTopic(self.db, self.fs, self.msg, self.auth) self.topic.check_quota = Mock(return_value=None) # skip quota - def test_new_vnfd(self): - did = db_vnfd_content["_id"] - self.fs.get_params.return_value = {} - self.fs.file_exists.return_value = False - self.fs.file_open.side_effect = lambda path, mode: open( - "/tmp/" + str(uuid4()), "a+b" - ) + @contextmanager + def assertNotRaises(self, exception_type=Exception): + try: + yield None + except exception_type: + raise self.failureException("{} raised".format(exception_type.__name__)) + + def create_desc_temp(self, template): + old_desc = deepcopy(template) + new_desc = deepcopy(template) + return old_desc, new_desc + + def prepare_vnfd_creation(self): + setup_mock_fs(self.fs) test_vnfd = deepcopy(db_vnfd_content) + did = db_vnfd_content["_id"] + self.db.create.return_value = did + self.db.get_one.side_effect = [ + {"_id": did, "_admin": deepcopy(db_vnfd_content["_admin"])}, + None, + ] + return did, test_vnfd + + def prepare_vnfd(self, vnfd_text): + setup_mock_fs(self.fs) + test_vnfd = yaml.safe_load(vnfd_text) + self.db.create.return_value = UUID + self.db.get_one.side_effect = [ + {"_id": UUID, "_admin": admin_value()}, + None, + ] + return UUID, test_vnfd + + def prepare_test_vnfd(self, test_vnfd): del test_vnfd["_id"] del test_vnfd["_admin"] - with self.subTest(i=1, t="Normal Creation"): - self.db.create.return_value = did - rollback = [] - did2, oid = self.topic.new(rollback, fake_session, {}) - db_args = self.db.create.call_args[0] - msg_args = self.msg.write.call_args[0] - self.assertEqual(len(rollback), 1, "Wrong rollback length") - self.assertEqual(msg_args[0], self.topic.topic_msg, "Wrong message topic") - self.assertEqual(msg_args[1], "created", "Wrong message action") - self.assertEqual(msg_args[2], {"_id": did}, "Wrong message content") - self.assertEqual(db_args[0], self.topic.topic, "Wrong DB topic") - self.assertEqual(did2, did, "Wrong DB VNFD id") - self.assertIsNotNone(db_args[1]["_admin"]["created"], "Wrong creation time") - self.assertEqual( - db_args[1]["_admin"]["modified"], - db_args[1]["_admin"]["created"], - "Wrong modification time", - ) - self.assertEqual( - db_args[1]["_admin"]["projects_read"], - [test_pid], - "Wrong read-only project list", + del test_vnfd["vdu"][0]["cloud-init-file"] + del test_vnfd["df"][0]["lcm-operations-configuration"]["operate-vnf-op-config"][ + "day1-2" + ][0]["execution-environment-list"][0]["juju"] + return test_vnfd + + @patch("osm_nbi.descriptor_topics.shutil") + @patch("osm_nbi.descriptor_topics.os.rename") + def test_new_vnfd_normal_creation(self, mock_rename, mock_shutil): + did, test_vnfd = self.prepare_vnfd_creation() + test_vnfd = self.prepare_test_vnfd(test_vnfd) + rollback = [] + did2, oid = self.topic.new(rollback, fake_session, {}) + db_args = self.db.create.call_args[0] + msg_args = self.msg.write.call_args[0] + + self.assertEqual(len(rollback), 1, "Wrong rollback length") + self.assertEqual(msg_args[0], self.topic.topic_msg, "Wrong message topic") + self.assertEqual(msg_args[1], "created", "Wrong message action") + self.assertEqual(msg_args[2], {"_id": did}, "Wrong message content") + self.assertEqual(db_args[0], self.topic.topic, "Wrong DB topic") + self.assertEqual(did2, did, "Wrong DB VNFD id") + self.assertIsNotNone(db_args[1]["_admin"]["created"], "Wrong creation time") + self.assertEqual( + db_args[1]["_admin"]["modified"], + db_args[1]["_admin"]["created"], + "Wrong modification time", + ) + self.assertEqual( + db_args[1]["_admin"]["projects_read"], + [test_pid], + "Wrong read-only project list", + ) + self.assertEqual( + db_args[1]["_admin"]["projects_write"], + [test_pid], + "Wrong read-write project list", + ) + + self.db.get_one.side_effect = [ + {"_id": did, "_admin": deepcopy(db_vnfd_content["_admin"])}, + None, + ] + + self.topic.upload_content( + fake_session, did, test_vnfd, {}, {"Content-Type": []} + ) + msg_args = self.msg.write.call_args[0] + test_vnfd["_id"] = did + self.assertEqual(msg_args[0], self.topic.topic_msg, "Wrong message topic") + self.assertEqual(msg_args[1], "edited", "Wrong message action") + self.assertEqual(msg_args[2], test_vnfd, "Wrong message content") + + db_args = self.db.get_one.mock_calls[0][1] + self.assertEqual(db_args[0], self.topic.topic, "Wrong DB topic") + self.assertEqual(db_args[1]["_id"], did, "Wrong DB VNFD id") + + db_args = self.db.replace.call_args[0] + self.assertEqual(db_args[0], self.topic.topic, "Wrong DB topic") + self.assertEqual(db_args[1], did, "Wrong DB VNFD id") + + admin = db_args[2]["_admin"] + db_admin = deepcopy(db_vnfd_content["_admin"]) + self.assertEqual(admin["type"], "vnfd", "Wrong descriptor type") + self.assertEqual(admin["created"], db_admin["created"], "Wrong creation time") + self.assertGreater( + admin["modified"], db_admin["created"], "Wrong modification time" + ) + self.assertEqual( + admin["projects_read"], + db_admin["projects_read"], + "Wrong read-only project list", + ) + self.assertEqual( + admin["projects_write"], + db_admin["projects_write"], + "Wrong read-write project list", + ) + self.assertEqual( + admin["onboardingState"], "ONBOARDED", "Wrong onboarding state" + ) + self.assertEqual( + admin["operationalState"], "ENABLED", "Wrong operational state" + ) + self.assertEqual(admin["usageState"], "NOT_IN_USE", "Wrong usage state") + + storage = admin["storage"] + self.assertEqual(storage["folder"], did + ":1", "Wrong storage folder") + self.assertEqual(storage["descriptor"], "package", "Wrong storage descriptor") + self.assertEqual(admin["revision"], 1, "Wrong revision number") + compare_desc(self, test_vnfd, db_args[2], "VNFD") + + @patch("osm_nbi.descriptor_topics.shutil") + @patch("osm_nbi.descriptor_topics.os.rename") + def test_new_vnfd_exploit(self, mock_rename, mock_shutil): + id, test_vnfd = self.prepare_vnfd(vnfd_exploit_text) + + with self.assertRaises(EngineException): + self.topic.upload_content( + fake_session, id, test_vnfd, {}, {"Content-Type": []} ) - self.assertEqual( - db_args[1]["_admin"]["projects_write"], - [test_pid], - "Wrong read-write project list", + + @patch("osm_nbi.descriptor_topics.shutil") + @patch("osm_nbi.descriptor_topics.os.rename") + def test_new_vnfd_valid_helm_chart(self, mock_rename, mock_shutil): + id, test_vnfd = self.prepare_vnfd(vnfd_exploit_fixed_text) + + with self.assertNotRaises(): + self.topic.upload_content( + fake_session, id, test_vnfd, {}, {"Content-Type": []} ) - tmp1 = test_vnfd["vdu"][0]["cloud-init-file"] - tmp2 = test_vnfd["df"][0]["lcm-operations-configuration"][ - "operate-vnf-op-config" - ]["day1-2"][0]["execution-environment-list"][0]["juju"] - del test_vnfd["vdu"][0]["cloud-init-file"] - del test_vnfd["df"][0]["lcm-operations-configuration"][ - "operate-vnf-op-config" - ]["day1-2"][0]["execution-environment-list"][0]["juju"] - try: - self.db.get_one.side_effect = [ - {"_id": did, "_admin": deepcopy(db_vnfd_content["_admin"])}, - None, - ] - self.topic.upload_content( - fake_session, did, test_vnfd, {}, {"Content-Type": []} - ) - msg_args = self.msg.write.call_args[0] - test_vnfd["_id"] = did - self.assertEqual( - msg_args[0], self.topic.topic_msg, "Wrong message topic" - ) - self.assertEqual(msg_args[1], "edited", "Wrong message action") - self.assertEqual(msg_args[2], test_vnfd, "Wrong message content") - db_args = self.db.get_one.mock_calls[0][1] - self.assertEqual(db_args[0], self.topic.topic, "Wrong DB topic") - self.assertEqual(db_args[1]["_id"], did, "Wrong DB VNFD id") - db_args = self.db.replace.call_args[0] - self.assertEqual(db_args[0], self.topic.topic, "Wrong DB topic") - self.assertEqual(db_args[1], did, "Wrong DB VNFD id") - admin = db_args[2]["_admin"] - db_admin = deepcopy(db_vnfd_content["_admin"]) - self.assertEqual(admin["type"], "vnfd", "Wrong descriptor type") - self.assertEqual( - admin["created"], db_admin["created"], "Wrong creation time" - ) - self.assertGreater( - admin["modified"], db_admin["created"], "Wrong modification time" - ) - self.assertEqual( - admin["projects_read"], - db_admin["projects_read"], - "Wrong read-only project list", - ) - self.assertEqual( - admin["projects_write"], - db_admin["projects_write"], - "Wrong read-write project list", - ) - self.assertEqual( - admin["onboardingState"], "ONBOARDED", "Wrong onboarding state" - ) - self.assertEqual( - admin["operationalState"], "ENABLED", "Wrong operational state" - ) - self.assertEqual(admin["usageState"], "NOT_IN_USE", "Wrong usage state") - storage = admin["storage"] - self.assertEqual(storage["folder"], did, "Wrong storage folder") - self.assertEqual( - storage["descriptor"], "package", "Wrong storage descriptor" - ) - compare_desc(self, test_vnfd, db_args[2], "VNFD") - finally: - test_vnfd["vdu"][0]["cloud-init-file"] = tmp1 - test_vnfd["df"][0]["lcm-operations-configuration"][ - "operate-vnf-op-config" - ]["day1-2"][0]["execution-environment-list"][0]["juju"] = tmp2 + + @patch("osm_nbi.descriptor_topics.shutil") + @patch("osm_nbi.descriptor_topics.os.rename") + def test_new_vnfd_check_pyangbind_validation_additional_properties( + self, mock_rename, mock_shutil + ): + did, test_vnfd = self.prepare_vnfd_creation() + test_vnfd = self.prepare_test_vnfd(test_vnfd) + self.topic.upload_content( + fake_session, did, test_vnfd, {}, {"Content-Type": []} + ) + test_vnfd["_id"] = did + test_vnfd["extra-property"] = 0 self.db.get_one.side_effect = ( lambda table, filter, fail_on_empty=None, fail_on_more=None: { "_id": did, "_admin": deepcopy(db_vnfd_content["_admin"]), } ) - with self.subTest(i=2, t="Check Pyangbind Validation: additional properties"): - test_vnfd["extra-property"] = 0 - try: - with self.assertRaises( - EngineException, msg="Accepted VNFD with an additional property" - ) as e: - self.topic.upload_content( - fake_session, did, test_vnfd, {}, {"Content-Type": []} - ) - self.assertEqual( - e.exception.http_code, - HTTPStatus.UNPROCESSABLE_ENTITY, - "Wrong HTTP status code", - ) - self.assertIn( - norm( - "Error in pyangbind validation: {} ({})".format( - "json object contained a key that did not exist", - "extra-property", - ) - ), - norm(str(e.exception)), - "Wrong exception text", - ) - finally: - del test_vnfd["extra-property"] - with self.subTest(i=3, t="Check Pyangbind Validation: property types"): - tmp = test_vnfd["product-name"] - test_vnfd["product-name"] = {"key": 0} - try: - with self.assertRaises( - EngineException, msg="Accepted VNFD with a wrongly typed property" - ) as e: - self.topic.upload_content( - fake_session, did, test_vnfd, {}, {"Content-Type": []} - ) - self.assertEqual( - e.exception.http_code, - HTTPStatus.UNPROCESSABLE_ENTITY, - "Wrong HTTP status code", - ) - self.assertIn( - norm( - "Error in pyangbind validation: {} ({})".format( - "json object contained a key that did not exist", "key" - ) - ), - norm(str(e.exception)), - "Wrong exception text", + + with self.assertRaises( + EngineException, msg="Accepted VNFD with an additional property" + ) as e: + self.topic.upload_content( + fake_session, did, test_vnfd, {}, {"Content-Type": []} + ) + self.assertEqual( + e.exception.http_code, + HTTPStatus.UNPROCESSABLE_ENTITY, + "Wrong HTTP status code", + ) + self.assertIn( + norm( + "Error in pyangbind validation: {} ({})".format( + "json object contained a key that did not exist", "extra-property" ) - finally: - test_vnfd["product-name"] = tmp - with self.subTest(i=4, t="Check Input Validation: cloud-init"): - with self.assertRaises( - EngineException, msg="Accepted non-existent cloud_init file" - ) as e: - self.topic.upload_content( - fake_session, did, test_vnfd, {}, {"Content-Type": []} + ), + norm(str(e.exception)), + "Wrong exception text", + ) + db_args = self.db.replace.call_args[0] + admin = db_args[2]["_admin"] + self.assertEqual(admin["revision"], 1, "Wrong revision number") + + @patch("osm_nbi.descriptor_topics.shutil") + @patch("osm_nbi.descriptor_topics.os.rename") + def test_new_vnfd_check_pyangbind_validation_property_types( + self, mock_rename, mock_shutil + ): + did, test_vnfd = self.prepare_vnfd_creation() + test_vnfd = self.prepare_test_vnfd(test_vnfd) + test_vnfd["_id"] = did + test_vnfd["product-name"] = {"key": 0} + + with self.assertRaises( + EngineException, msg="Accepted VNFD with a wrongly typed property" + ) as e: + self.topic.upload_content( + fake_session, did, test_vnfd, {}, {"Content-Type": []} + ) + self.assertEqual( + e.exception.http_code, + HTTPStatus.UNPROCESSABLE_ENTITY, + "Wrong HTTP status code", + ) + self.assertIn( + norm( + "Error in pyangbind validation: {} ({})".format( + "json object contained a key that did not exist", "key" ) - self.assertEqual( - e.exception.http_code, HTTPStatus.BAD_REQUEST, "Wrong HTTP status code" + ), + norm(str(e.exception)), + "Wrong exception text", + ) + + @patch("osm_nbi.descriptor_topics.shutil") + @patch("osm_nbi.descriptor_topics.os.rename") + def test_new_vnfd_check_input_validation_cloud_init(self, mock_rename, mock_shutil): + did, test_vnfd = self.prepare_vnfd_creation() + del test_vnfd["df"][0]["lcm-operations-configuration"]["operate-vnf-op-config"][ + "day1-2" + ][0]["execution-environment-list"][0]["juju"] + + with self.assertRaises( + EngineException, msg="Accepted non-existent cloud_init file" + ) as e: + self.topic.upload_content( + fake_session, did, test_vnfd, {}, {"Content-Type": []} ) - self.assertIn( - norm( - "{} defined in vnf[id={}]:vdu[id={}] but not present in package".format( - "cloud-init", test_vnfd["id"], test_vnfd["vdu"][0]["id"] - ) - ), - norm(str(e.exception)), - "Wrong exception text", + self.assertEqual( + e.exception.http_code, HTTPStatus.BAD_REQUEST, "Wrong HTTP status code" + ) + self.assertIn( + norm( + "{} defined in vnf[id={}]:vdu[id={}] but not present in package".format( + "cloud-init", test_vnfd["id"], test_vnfd["vdu"][0]["id"] + ) + ), + norm(str(e.exception)), + "Wrong exception text", + ) + + @patch("osm_nbi.descriptor_topics.shutil") + @patch("osm_nbi.descriptor_topics.os.rename") + def test_new_vnfd_check_input_validation_day12_configuration( + self, mock_rename, mock_shutil + ): + did, test_vnfd = self.prepare_vnfd_creation() + del test_vnfd["vdu"][0]["cloud-init-file"] + + with self.assertRaises( + EngineException, msg="Accepted non-existent charm in VNF configuration" + ) as e: + self.topic.upload_content( + fake_session, did, test_vnfd, {}, {"Content-Type": []} ) - with self.subTest(i=5, t="Check Input Validation: day1-2 configuration[juju]"): - del test_vnfd["vdu"][0]["cloud-init-file"] - with self.assertRaises( - EngineException, msg="Accepted non-existent charm in VNF configuration" - ) as e: - self.topic.upload_content( - fake_session, did, test_vnfd, {}, {"Content-Type": []} + self.assertEqual( + e.exception.http_code, HTTPStatus.BAD_REQUEST, "Wrong HTTP status code" + ) + self.assertIn( + norm( + "{} defined in vnf[id={}] but not present in package".format( + "charm", test_vnfd["id"] ) - print(str(e.exception)) - self.assertEqual( - e.exception.http_code, HTTPStatus.BAD_REQUEST, "Wrong HTTP status code" + ), + norm(str(e.exception)), + "Wrong exception text", + ) + + @patch("osm_nbi.descriptor_topics.shutil") + @patch("osm_nbi.descriptor_topics.os.rename") + def test_new_vnfd_check_input_validation_mgmt_cp(self, mock_rename, mock_shutil): + did, test_vnfd = self.prepare_vnfd_creation() + test_vnfd = self.prepare_test_vnfd(test_vnfd) + del test_vnfd["mgmt-cp"] + + with self.assertRaises( + EngineException, msg="Accepted VNFD without management interface" + ) as e: + self.topic.upload_content( + fake_session, did, test_vnfd, {}, {"Content-Type": []} ) - self.assertIn( - norm( - "{} defined in vnf[id={}] but not present in package".format( - "charm", test_vnfd["id"] - ) - ), - norm(str(e.exception)), - "Wrong exception text", + self.assertEqual( + e.exception.http_code, + HTTPStatus.UNPROCESSABLE_ENTITY, + "Wrong HTTP status code", + ) + self.assertIn( + norm("'{}' is a mandatory field and it is not defined".format("mgmt-cp")), + norm(str(e.exception)), + "Wrong exception text", + ) + + @patch("osm_nbi.descriptor_topics.shutil") + @patch("osm_nbi.descriptor_topics.os.rename") + def test_new_vnfd_check_input_validation_mgmt_cp_connection_point( + self, mock_rename, mock_shutil + ): + did, test_vnfd = self.prepare_vnfd_creation() + test_vnfd = self.prepare_test_vnfd(test_vnfd) + test_vnfd["mgmt-cp"] = "wrong-cp" + + with self.assertRaises( + EngineException, msg="Accepted wrong mgmt-cp connection point" + ) as e: + self.topic.upload_content( + fake_session, did, test_vnfd, {}, {"Content-Type": []} ) - del test_vnfd["df"][0]["lcm-operations-configuration"][ - "operate-vnf-op-config" - ]["day1-2"][0]["execution-environment-list"][0]["juju"] - with self.subTest(i=6, t="Check Input Validation: mgmt-cp"): - tmp = test_vnfd["mgmt-cp"] - del test_vnfd["mgmt-cp"] - try: - with self.assertRaises( - EngineException, msg="Accepted VNFD without management interface" - ) as e: - self.topic.upload_content( - fake_session, did, test_vnfd, {}, {"Content-Type": []} - ) - self.assertEqual( - e.exception.http_code, - HTTPStatus.UNPROCESSABLE_ENTITY, - "Wrong HTTP status code", - ) - self.assertIn( - norm( - "'{}' is a mandatory field and it is not defined".format( - "mgmt-cp" - ) - ), - norm(str(e.exception)), - "Wrong exception text", - ) - finally: - test_vnfd["mgmt-cp"] = tmp - with self.subTest(i=7, t="Check Input Validation: mgmt-cp connection point"): - tmp = test_vnfd["mgmt-cp"] - test_vnfd["mgmt-cp"] = "wrong-cp" - try: - with self.assertRaises( - EngineException, msg="Accepted wrong mgmt-cp connection point" - ) as e: - self.topic.upload_content( - fake_session, did, test_vnfd, {}, {"Content-Type": []} - ) - self.assertEqual( - e.exception.http_code, - HTTPStatus.UNPROCESSABLE_ENTITY, - "Wrong HTTP status code", - ) - self.assertIn( - norm( - "mgmt-cp='{}' must match an existing ext-cpd".format( - test_vnfd["mgmt-cp"] - ) - ), - norm(str(e.exception)), - "Wrong exception text", - ) - finally: - test_vnfd["mgmt-cp"] = tmp - with self.subTest(i=8, t="Check Input Validation: vdu int-cpd"): - ext_cpd = test_vnfd["ext-cpd"][1] - tmp = ext_cpd["int-cpd"]["cpd"] - ext_cpd["int-cpd"]["cpd"] = "wrong-cpd" - try: - with self.assertRaises( - EngineException, - msg="Accepted wrong ext-cpd internal connection point", - ) as e: - self.topic.upload_content( - fake_session, did, test_vnfd, {}, {"Content-Type": []} - ) - self.assertEqual( - e.exception.http_code, - HTTPStatus.UNPROCESSABLE_ENTITY, - "Wrong HTTP status code", - ) - self.assertIn( - norm( - "ext-cpd[id='{}']:int-cpd must match an existing vdu int-cpd".format( - ext_cpd["id"] - ) - ), - norm(str(e.exception)), - "Wrong exception text", - ) - finally: - ext_cpd["int-cpd"]["cpd"] = tmp - with self.subTest(i=9, t="Check Input Validation: Duplicated VLD"): - test_vnfd["int-virtual-link-desc"].insert(0, {"id": "internal"}) - try: - with self.assertRaises( - EngineException, msg="Accepted duplicated VLD name" - ) as e: - self.topic.upload_content( - fake_session, did, test_vnfd, {}, {"Content-Type": []} - ) - self.assertEqual( - e.exception.http_code, - HTTPStatus.UNPROCESSABLE_ENTITY, - "Wrong HTTP status code", - ) - self.assertIn( - norm( - "identifier id '{}' is not unique".format( - test_vnfd["int-virtual-link-desc"][0]["id"] - ) - ), - norm(str(e.exception)), - "Wrong exception text", - ) - finally: - del test_vnfd["int-virtual-link-desc"][0] - with self.subTest(i=10, t="Check Input Validation: vdu int-virtual-link-desc"): - vdu = test_vnfd["vdu"][0] - int_cpd = vdu["int-cpd"][1] - tmp = int_cpd["int-virtual-link-desc"] - int_cpd["int-virtual-link-desc"] = "non-existing-int-virtual-link-desc" - try: - with self.assertRaises( - EngineException, msg="Accepted int-virtual-link-desc" - ) as e: - self.topic.upload_content( - fake_session, did, test_vnfd, {}, {"Content-Type": []} - ) - self.assertEqual( - e.exception.http_code, - HTTPStatus.UNPROCESSABLE_ENTITY, - "Wrong HTTP status code", - ) - self.assertIn( - norm( - "vdu[id='{}']:int-cpd[id='{}']:int-virtual-link-desc='{}' must match an existing " - "int-virtual-link-desc".format( - vdu["id"], int_cpd["id"], int_cpd["int-virtual-link-desc"] - ) - ), - norm(str(e.exception)), - "Wrong exception text", - ) - finally: - int_cpd["int-virtual-link-desc"] = tmp - with self.subTest(i=11, t="Check Input Validation: virtual-link-profile)"): - fake_ivld_profile = {"id": "fake-profile-ref", "flavour": "fake-flavour"} - df = test_vnfd["df"][0] - df["virtual-link-profile"] = [fake_ivld_profile] - try: - with self.assertRaises( - EngineException, msg="Accepted non-existent Profile Ref" - ) as e: - self.topic.upload_content( - fake_session, did, test_vnfd, {}, {"Content-Type": []} - ) - self.assertEqual( - e.exception.http_code, - HTTPStatus.UNPROCESSABLE_ENTITY, - "Wrong HTTP status code", - ) - self.assertIn( - norm( - "df[id='{}']:virtual-link-profile='{}' must match an existing " - "int-virtual-link-desc".format( - df["id"], fake_ivld_profile["id"] - ) - ), - norm(str(e.exception)), - "Wrong exception text", - ) - finally: - del df["virtual-link-profile"] - with self.subTest( - i=12, t="Check Input Validation: scaling-criteria monitoring-param-ref" - ): - vdu = test_vnfd["vdu"][1] - affected_df = test_vnfd["df"][0] - sa = affected_df["scaling-aspect"][0] - sp = sa["scaling-policy"][0] - sc = sp["scaling-criteria"][0] - tmp = vdu.pop("monitoring-parameter") - try: - with self.assertRaises( - EngineException, - msg="Accepted non-existent Scaling Group Policy Criteria", - ) as e: - self.topic.upload_content( - fake_session, did, test_vnfd, {}, {"Content-Type": []} - ) - self.assertEqual( - e.exception.http_code, - HTTPStatus.UNPROCESSABLE_ENTITY, - "Wrong HTTP status code", + self.assertEqual( + e.exception.http_code, + HTTPStatus.UNPROCESSABLE_ENTITY, + "Wrong HTTP status code", + ) + self.assertIn( + norm( + "mgmt-cp='{}' must match an existing ext-cpd".format( + test_vnfd["mgmt-cp"] ) - self.assertIn( - norm( - "df[id='{}']:scaling-aspect[id='{}']:scaling-policy" - "[name='{}']:scaling-criteria[name='{}']: " - "vnf-monitoring-param-ref='{}' not defined in any monitoring-param".format( - affected_df["id"], - sa["id"], - sp["name"], - sc["name"], - sc["vnf-monitoring-param-ref"], - ) - ), - norm(str(e.exception)), - "Wrong exception text", + ), + norm(str(e.exception)), + "Wrong exception text", + ) + + @patch("osm_nbi.descriptor_topics.shutil") + @patch("osm_nbi.descriptor_topics.os.rename") + def test_new_vnfd_check_input_validation_vdu_int_cpd( + self, mock_rename, mock_shutil + ): + """Testing input validation during new vnfd creation + for vdu internal connection point""" + did, test_vnfd = self.prepare_vnfd_creation() + test_vnfd = self.prepare_test_vnfd(test_vnfd) + ext_cpd = test_vnfd["ext-cpd"][1] + ext_cpd["int-cpd"]["cpd"] = "wrong-cpd" + + with self.assertRaises( + EngineException, msg="Accepted wrong ext-cpd internal connection point" + ) as e: + self.topic.upload_content( + fake_session, did, test_vnfd, {}, {"Content-Type": []} + ) + self.assertEqual( + e.exception.http_code, + HTTPStatus.UNPROCESSABLE_ENTITY, + "Wrong HTTP status code", + ) + self.assertIn( + norm( + "ext-cpd[id='{}']:int-cpd must match an existing vdu int-cpd".format( + ext_cpd["id"] ) - finally: - vdu["monitoring-parameter"] = tmp - with self.subTest( - i=13, t="Check Input Validation: scaling-aspect vnf-configuration" - ): - df = test_vnfd["df"][0] - tmp = test_vnfd["df"][0]["lcm-operations-configuration"][ - "operate-vnf-op-config" - ]["day1-2"].pop() - try: - with self.assertRaises( - EngineException, - msg="Accepted non-existent Scaling Group VDU ID Reference", - ) as e: - self.topic.upload_content( - fake_session, did, test_vnfd, {}, {"Content-Type": []} - ) - self.assertEqual( - e.exception.http_code, - HTTPStatus.UNPROCESSABLE_ENTITY, - "Wrong HTTP status code", + ), + norm(str(e.exception)), + "Wrong exception text", + ) + + @patch("osm_nbi.descriptor_topics.shutil") + @patch("osm_nbi.descriptor_topics.os.rename") + def test_new_vnfd_check_input_validation_duplicated_vld( + self, mock_rename, mock_shutil + ): + """Testing input validation during new vnfd creation + for dublicated virtual link description""" + did, test_vnfd = self.prepare_vnfd_creation() + test_vnfd = self.prepare_test_vnfd(test_vnfd) + test_vnfd["int-virtual-link-desc"].insert(0, {"id": "internal"}) + + with self.assertRaises( + EngineException, msg="Accepted duplicated VLD name" + ) as e: + self.topic.upload_content( + fake_session, did, test_vnfd, {}, {"Content-Type": []} + ) + self.assertEqual( + e.exception.http_code, + HTTPStatus.UNPROCESSABLE_ENTITY, + "Wrong HTTP status code", + ) + self.assertIn( + norm( + "identifier id '{}' is not unique".format( + test_vnfd["int-virtual-link-desc"][0]["id"] ) - self.assertIn( - norm( - "'day1-2 configuration' not defined in the descriptor but it is referenced " - "by df[id='{}']:scaling-aspect[id='{}']:scaling-config-action".format( - df["id"], df["scaling-aspect"][0]["id"] - ) - ), - norm(str(e.exception)), - "Wrong exception text", + ), + norm(str(e.exception)), + "Wrong exception text", + ) + + @patch("osm_nbi.descriptor_topics.shutil") + @patch("osm_nbi.descriptor_topics.os.rename") + def test_new_vnfd_check_input_validation_vdu_int_virtual_link_desc( + self, mock_rename, mock_shutil + ): + """Testing input validation during new vnfd creation + for vdu internal virtual link description""" + did, test_vnfd = self.prepare_vnfd_creation() + test_vnfd = self.prepare_test_vnfd(test_vnfd) + vdu = test_vnfd["vdu"][0] + int_cpd = vdu["int-cpd"][1] + int_cpd["int-virtual-link-desc"] = "non-existing-int-virtual-link-desc" + + with self.assertRaises( + EngineException, msg="Accepted int-virtual-link-desc" + ) as e: + self.topic.upload_content( + fake_session, did, test_vnfd, {}, {"Content-Type": []} + ) + self.assertEqual( + e.exception.http_code, + HTTPStatus.UNPROCESSABLE_ENTITY, + "Wrong HTTP status code", + ) + self.assertIn( + norm( + "vdu[id='{}']:int-cpd[id='{}']:int-virtual-link-desc='{}' must match an existing " + "int-virtual-link-desc".format( + vdu["id"], int_cpd["id"], int_cpd["int-virtual-link-desc"] ) - finally: - test_vnfd["df"][0]["lcm-operations-configuration"][ - "operate-vnf-op-config" - ]["day1-2"].append(tmp) - with self.subTest(i=14, t="Check Input Validation: scaling-config-action"): - df = test_vnfd["df"][0] - tmp = ( - test_vnfd["df"][0] - .get("lcm-operations-configuration") - .get("operate-vnf-op-config")["day1-2"][0]["config-primitive"] - ) - test_vnfd["df"][0].get("lcm-operations-configuration").get( - "operate-vnf-op-config" - )["day1-2"][0]["config-primitive"] = [{"name": "wrong-primitive"}] - try: - with self.assertRaises( - EngineException, - msg="Accepted non-existent Scaling Group VDU ID Reference", - ) as e: - self.topic.upload_content( - fake_session, did, test_vnfd, {}, {"Content-Type": []} - ) - self.assertEqual( - e.exception.http_code, - HTTPStatus.UNPROCESSABLE_ENTITY, - "Wrong HTTP status code", + ), + norm(str(e.exception)), + "Wrong exception text", + ) + + @patch("osm_nbi.descriptor_topics.shutil") + @patch("osm_nbi.descriptor_topics.os.rename") + def test_new_vnfd_check_input_validation_virtual_link_profile( + self, mock_rename, mock_shutil + ): + """Testing input validation during new vnfd creation + for virtual link profile""" + did, test_vnfd = self.prepare_vnfd_creation() + test_vnfd = self.prepare_test_vnfd(test_vnfd) + fake_ivld_profile = {"id": "fake-profile-ref", "flavour": "fake-flavour"} + df = test_vnfd["df"][0] + df["virtual-link-profile"] = [fake_ivld_profile] + + with self.assertRaises( + EngineException, msg="Accepted non-existent Profile Ref" + ) as e: + self.topic.upload_content( + fake_session, did, test_vnfd, {}, {"Content-Type": []} + ) + self.assertEqual( + e.exception.http_code, + HTTPStatus.UNPROCESSABLE_ENTITY, + "Wrong HTTP status code", + ) + self.assertIn( + norm( + "df[id='{}']:virtual-link-profile='{}' must match an existing " + "int-virtual-link-desc".format(df["id"], fake_ivld_profile["id"]) + ), + norm(str(e.exception)), + "Wrong exception text", + ) + + @patch("osm_nbi.descriptor_topics.shutil") + @patch("osm_nbi.descriptor_topics.os.rename") + def test_new_vnfd_check_input_validation_scaling_criteria_monitoring_param_ref( + self, mock_rename, mock_shutil + ): + """Testing input validation during new vnfd creation + for scaling criteria without monitoring parameter""" + did, test_vnfd = self.prepare_vnfd_creation() + test_vnfd = self.prepare_test_vnfd(test_vnfd) + vdu = test_vnfd["vdu"][1] + affected_df = test_vnfd["df"][0] + sa = affected_df["scaling-aspect"][0] + sp = sa["scaling-policy"][0] + sc = sp["scaling-criteria"][0] + vdu.pop("monitoring-parameter") + + with self.assertRaises( + EngineException, msg="Accepted non-existent Scaling Group Policy Criteria" + ) as e: + self.topic.upload_content( + fake_session, did, test_vnfd, {}, {"Content-Type": []} + ) + self.assertEqual( + e.exception.http_code, + HTTPStatus.UNPROCESSABLE_ENTITY, + "Wrong HTTP status code", + ) + self.assertIn( + norm( + "df[id='{}']:scaling-aspect[id='{}']:scaling-policy" + "[name='{}']:scaling-criteria[name='{}']: " + "vnf-monitoring-param-ref='{}' not defined in any monitoring-param".format( + affected_df["id"], + sa["id"], + sp["name"], + sc["name"], + sc["vnf-monitoring-param-ref"], ) - self.assertIn( - norm( - "df[id='{}']:scaling-aspect[id='{}']:scaling-config-action:vnf-" - "config-primitive-name-ref='{}' does not match any " - "day1-2 configuration:config-primitive:name".format( - df["id"], - df["scaling-aspect"][0]["id"], - sa["scaling-config-action"][0][ - "vnf-config-primitive-name-ref" - ], - ) - ), - norm(str(e.exception)), - "Wrong exception text", + ), + norm(str(e.exception)), + "Wrong exception text", + ) + + @patch("osm_nbi.descriptor_topics.shutil") + @patch("osm_nbi.descriptor_topics.os.rename") + def test_new_vnfd_check_input_validation_scaling_aspect_vnf_configuration( + self, mock_rename, mock_shutil + ): + """Testing input validation during new vnfd creation + for scaling criteria without day12 configuration""" + did, test_vnfd = self.prepare_vnfd_creation() + test_vnfd = self.prepare_test_vnfd(test_vnfd) + test_vnfd["df"][0]["lcm-operations-configuration"]["operate-vnf-op-config"][ + "day1-2" + ].pop() + df = test_vnfd["df"][0] + + with self.assertRaises( + EngineException, msg="Accepted non-existent Scaling Group VDU ID Reference" + ) as e: + self.topic.upload_content( + fake_session, did, test_vnfd, {}, {"Content-Type": []} + ) + self.assertEqual( + e.exception.http_code, + HTTPStatus.UNPROCESSABLE_ENTITY, + "Wrong HTTP status code", + ) + self.assertIn( + norm( + "'day1-2 configuration' not defined in the descriptor but it is referenced " + "by df[id='{}']:scaling-aspect[id='{}']:scaling-config-action".format( + df["id"], df["scaling-aspect"][0]["id"] ) - finally: - test_vnfd["df"][0].get("lcm-operations-configuration").get( - "operate-vnf-op-config" - )["day1-2"][0]["config-primitive"] = tmp - with self.subTest(i=15, t="Check Input Validation: everything right"): - test_vnfd["id"] = "fake-vnfd-id" - test_vnfd["df"][0].get("lcm-operations-configuration").get( - "operate-vnf-op-config" - )["day1-2"][0]["id"] = "fake-vnfd-id" - self.db.get_one.side_effect = [ - {"_id": did, "_admin": deepcopy(db_vnfd_content["_admin"])}, - None, - ] - rc = self.topic.upload_content( + ), + norm(str(e.exception)), + "Wrong exception text", + ) + + @patch("osm_nbi.descriptor_topics.shutil") + @patch("osm_nbi.descriptor_topics.os.rename") + def test_new_vnfd_check_input_validation_scaling_config_action( + self, mock_rename, mock_shutil + ): + """Testing input validation during new vnfd creation + for scaling criteria wrong config primitive""" + did, test_vnfd = self.prepare_vnfd_creation() + test_vnfd = self.prepare_test_vnfd(test_vnfd) + df = test_vnfd["df"][0] + affected_df = test_vnfd["df"][0] + sa = affected_df["scaling-aspect"][0] + test_vnfd["df"][0].get("lcm-operations-configuration").get( + "operate-vnf-op-config" + )["day1-2"][0]["config-primitive"] = [{"name": "wrong-primitive"}] + + with self.assertRaises( + EngineException, msg="Accepted non-existent Scaling Group VDU ID Reference" + ) as e: + self.topic.upload_content( fake_session, did, test_vnfd, {}, {"Content-Type": []} ) - self.assertTrue(rc, "Input Validation: Unexpected failure") - return + self.assertEqual( + e.exception.http_code, + HTTPStatus.UNPROCESSABLE_ENTITY, + "Wrong HTTP status code", + ) + self.assertIn( + norm( + "df[id='{}']:scaling-aspect[id='{}']:scaling-config-action:vnf-" + "config-primitive-name-ref='{}' does not match any " + "day1-2 configuration:config-primitive:name".format( + df["id"], + df["scaling-aspect"][0]["id"], + sa["scaling-config-action"][0]["vnf-config-primitive-name-ref"], + ) + ), + norm(str(e.exception)), + "Wrong exception text", + ) + + @patch("osm_nbi.descriptor_topics.shutil") + @patch("osm_nbi.descriptor_topics.os.rename") + def test_new_vnfd_check_input_validation_everything_right( + self, mock_rename, mock_shutil + ): + """Testing input validation during new vnfd creation + everything correct""" + did, test_vnfd = self.prepare_vnfd_creation() + test_vnfd = self.prepare_test_vnfd(test_vnfd) + test_vnfd["id"] = "fake-vnfd-id" + test_vnfd["df"][0].get("lcm-operations-configuration").get( + "operate-vnf-op-config" + )["day1-2"][0]["id"] = "fake-vnfd-id" + self.db.get_one.side_effect = [ + {"_id": did, "_admin": deepcopy(db_vnfd_content["_admin"])}, + None, + ] + rc = self.topic.upload_content( + fake_session, did, test_vnfd, {}, {"Content-Type": []} + ) + self.assertTrue(rc, "Input Validation: Unexpected failure") def test_edit_vnfd(self): vnfd_content = deepcopy(db_vnfd_content) @@ -697,6 +829,18 @@ class Test_VnfdTopic(TestCase): "Wrong DB NSD vnfd-id", ) + self.assertEqual( + self.db.del_list.call_args[0][0], + self.topic.topic + "_revisions", + "Wrong DB topic", + ) + + self.assertEqual( + self.db.del_list.call_args[0][1]["_id"]["$regex"], + did, + "Wrong ID for rexep delete", + ) + self.db.set_one.assert_not_called() fs_del_calls = self.fs.file_delete.call_args_list self.assertEqual(fs_del_calls[0][0][0], did, "Wrong FS file id") @@ -768,13 +912,125 @@ class Test_VnfdTopic(TestCase): self.assertIsNone( db_s1_args[1]["update_dict"], "Wrong DB update dictionary" ) - self.assertEqual( - db_s1_args[1]["pull_list"], - {"_admin.projects_read": (p_id,), "_admin.projects_write": (p_id,)}, - "Wrong DB pull_list dictionary", + self.assertEqual( + db_s1_args[1]["pull_list"], + {"_admin.projects_read": (p_id,), "_admin.projects_write": (p_id,)}, + "Wrong DB pull_list dictionary", + ) + self.fs.file_delete.assert_not_called() + return + + def prepare_vnfd_validation(self): + descriptor_name = "test_descriptor" + self.fs.file_open.side_effect = lambda path, mode: open( + "/tmp/" + str(uuid4()), "a+b" + ) + old_vnfd, new_vnfd = self.create_desc_temp(db_vnfd_content) + return descriptor_name, old_vnfd, new_vnfd + + @patch("osm_nbi.descriptor_topics.detect_descriptor_usage") + @patch("osm_nbi.descriptor_topics.yaml.safe_load") + def test_validate_vnfd_changes_day12_config_primitive_changed( + self, mock_safe_load, mock_detect_usage + ): + """Validating VNFD for VNFD updates, day1-2 config primitive has changed""" + descriptor_name, old_vnfd, new_vnfd = self.prepare_vnfd_validation() + did = old_vnfd["_id"] + new_vnfd["df"][0]["lcm-operations-configuration"]["operate-vnf-op-config"][ + "day1-2" + ][0]["config-primitive"][0]["name"] = "new_action" + mock_safe_load.side_effect = [old_vnfd, new_vnfd] + mock_detect_usage.return_value = True + self.db.get_one.return_value = old_vnfd + + with self.assertNotRaises(EngineException): + self.topic._validate_descriptor_changes( + did, descriptor_name, "/tmp/", "/tmp:1/" + ) + self.db.get_one.assert_called_once() + mock_detect_usage.assert_called_once() + self.assertEqual(mock_safe_load.call_count, 2) + + @patch("osm_nbi.descriptor_topics.detect_descriptor_usage") + @patch("osm_nbi.descriptor_topics.yaml.safe_load") + def test_validate_vnfd_changes_sw_version_changed( + self, mock_safe_load, mock_detect_usage + ): + """Validating VNFD for updates, software version has changed""" + # old vnfd uses the default software version: 1.0 + descriptor_name, old_vnfd, new_vnfd = self.prepare_vnfd_validation() + did = old_vnfd["_id"] + new_vnfd["software-version"] = "1.3" + new_vnfd["sw-image-desc"][0]["name"] = "new-image" + mock_safe_load.side_effect = [old_vnfd, new_vnfd] + mock_detect_usage.return_value = True + self.db.get_one.return_value = old_vnfd + + with self.assertNotRaises(EngineException): + self.topic._validate_descriptor_changes( + did, descriptor_name, "/tmp/", "/tmp:1/" + ) + self.db.get_one.assert_called_once() + mock_detect_usage.assert_called_once() + self.assertEqual(mock_safe_load.call_count, 2) + + @patch("osm_nbi.descriptor_topics.detect_descriptor_usage") + @patch("osm_nbi.descriptor_topics.yaml.safe_load") + def test_validate_vnfd_changes_sw_version_not_changed_mgm_cp_changed( + self, mock_safe_load, mock_detect_usage + ): + """Validating VNFD for updates, software version has not + changed, mgmt-cp has changed.""" + descriptor_name, old_vnfd, new_vnfd = self.prepare_vnfd_validation() + new_vnfd["mgmt-cp"] = "new-mgmt-cp" + mock_safe_load.side_effect = [old_vnfd, new_vnfd] + did = old_vnfd["_id"] + mock_detect_usage.return_value = True + self.db.get_one.return_value = old_vnfd + + with self.assertRaises( + EngineException, msg="there are disallowed changes in the vnf descriptor" + ) as e: + self.topic._validate_descriptor_changes( + did, descriptor_name, "/tmp/", "/tmp:1/" + ) + + self.assertEqual( + e.exception.http_code, + HTTPStatus.UNPROCESSABLE_ENTITY, + "Wrong HTTP status code", + ) + self.assertIn( + norm("there are disallowed changes in the vnf descriptor"), + norm(str(e.exception)), + "Wrong exception text", + ) + self.db.get_one.assert_called_once() + mock_detect_usage.assert_called_once() + self.assertEqual(mock_safe_load.call_count, 2) + + @patch("osm_nbi.descriptor_topics.detect_descriptor_usage") + @patch("osm_nbi.descriptor_topics.yaml.safe_load") + def test_validate_vnfd_changes_sw_version_not_changed_mgm_cp_changed_vnfd_not_in_use( + self, mock_safe_load, mock_detect_usage + ): + """Validating VNFD for updates, software version has not + changed, mgmt-cp has changed, vnfd is not in use.""" + descriptor_name, old_vnfd, new_vnfd = self.prepare_vnfd_validation() + new_vnfd["mgmt-cp"] = "new-mgmt-cp" + mock_safe_load.side_effect = [old_vnfd, new_vnfd] + did = old_vnfd["_id"] + mock_detect_usage.return_value = None + self.db.get_one.return_value = old_vnfd + + with self.assertNotRaises(EngineException): + self.topic._validate_descriptor_changes( + did, descriptor_name, "/tmp/", "/tmp:1/" ) - self.fs.file_delete.assert_not_called() - return + + self.db.get_one.assert_called_once() + mock_detect_usage.assert_called_once() + mock_safe_load.assert_not_called() def test_validate_mgmt_interface_connection_point_on_valid_descriptor(self): indata = deepcopy(db_vnfd_content) @@ -1003,17 +1259,377 @@ class Test_VnfdTopic(TestCase): "Wrong exception text", ) - def test_validate_monitoring_params_on_duplicated_vdu_monitoring_param(self): - indata = deepcopy(db_vnfd_content) - duplicated_mp = { - "id": "dataVM_cpu_util", - "name": "dataVM_cpu_util", - "performance_metric": "cpu", - } - affected_vdu = indata["vdu"][1] - affected_vdu["monitoring-parameter"].insert(0, duplicated_mp) - with self.assertRaises(EngineException) as e: - self.topic.validate_monitoring_params(indata) + def test_validate_monitoring_params_on_duplicated_vdu_monitoring_param(self): + indata = deepcopy(db_vnfd_content) + duplicated_mp = { + "id": "dataVM_cpu_util", + "name": "dataVM_cpu_util", + "performance_metric": "cpu", + } + affected_vdu = indata["vdu"][1] + affected_vdu["monitoring-parameter"].insert(0, duplicated_mp) + with self.assertRaises(EngineException) as e: + self.topic.validate_monitoring_params(indata) + self.assertEqual( + e.exception.http_code, + HTTPStatus.UNPROCESSABLE_ENTITY, + "Wrong HTTP status code", + ) + self.assertIn( + norm( + "Duplicated monitoring-parameter id in " + "vdu[id='{}']:monitoring-parameter[id='{}']".format( + affected_vdu["id"], duplicated_mp["id"] + ) + ), + norm(str(e.exception)), + "Wrong exception text", + ) + + def test_validate_monitoring_params_on_duplicated_df_monitoring_param(self): + indata = deepcopy(db_vnfd_content) + duplicated_mp = { + "id": "memory", + "name": "memory", + "performance_metric": "memory", + } + affected_df = indata["df"][0] + affected_df["monitoring-parameter"] = [duplicated_mp, duplicated_mp] + with self.assertRaises(EngineException) as e: + self.topic.validate_monitoring_params(indata) + self.assertEqual( + e.exception.http_code, + HTTPStatus.UNPROCESSABLE_ENTITY, + "Wrong HTTP status code", + ) + self.assertIn( + norm( + "Duplicated monitoring-parameter id in " + "df[id='{}']:monitoring-parameter[id='{}']".format( + affected_df["id"], duplicated_mp["id"] + ) + ), + norm(str(e.exception)), + "Wrong exception text", + ) + + def test_validate_scaling_group_descriptor_on_valid_descriptor(self): + indata = db_vnfd_content + self.topic.validate_scaling_group_descriptor(indata) + + def test_validate_scaling_group_descriptor_when_missing_monitoring_param(self): + indata = deepcopy(db_vnfd_content) + vdu = indata["vdu"][1] + affected_df = indata["df"][0] + affected_sa = affected_df["scaling-aspect"][0] + affected_sp = affected_sa["scaling-policy"][0] + affected_sc = affected_sp["scaling-criteria"][0] + vdu.pop("monitoring-parameter") + with self.assertRaises(EngineException) as e: + self.topic.validate_scaling_group_descriptor(indata) + self.assertEqual( + e.exception.http_code, + HTTPStatus.UNPROCESSABLE_ENTITY, + "Wrong HTTP status code", + ) + self.assertIn( + norm( + "df[id='{}']:scaling-aspect[id='{}']:scaling-policy" + "[name='{}']:scaling-criteria[name='{}']: " + "vnf-monitoring-param-ref='{}' not defined in any monitoring-param".format( + affected_df["id"], + affected_sa["id"], + affected_sp["name"], + affected_sc["name"], + affected_sc["vnf-monitoring-param-ref"], + ) + ), + norm(str(e.exception)), + "Wrong exception text", + ) + + def test_validate_scaling_group_descriptor_when_missing_vnf_configuration(self): + indata = deepcopy(db_vnfd_content) + df = indata["df"][0] + affected_sa = df["scaling-aspect"][0] + indata["df"][0]["lcm-operations-configuration"]["operate-vnf-op-config"][ + "day1-2" + ].pop() + with self.assertRaises(EngineException) as e: + self.topic.validate_scaling_group_descriptor(indata) + self.assertEqual( + e.exception.http_code, + HTTPStatus.UNPROCESSABLE_ENTITY, + "Wrong HTTP status code", + ) + self.assertIn( + norm( + "'day1-2 configuration' not defined in the descriptor but it is referenced " + "by df[id='{}']:scaling-aspect[id='{}']:scaling-config-action".format( + df["id"], affected_sa["id"] + ) + ), + norm(str(e.exception)), + "Wrong exception text", + ) + + def test_validate_scaling_group_descriptor_when_missing_scaling_config_action_primitive( + self, + ): + indata = deepcopy(db_vnfd_content) + df = indata["df"][0] + affected_sa = df["scaling-aspect"][0] + affected_sca_primitive = affected_sa["scaling-config-action"][0][ + "vnf-config-primitive-name-ref" + ] + df["lcm-operations-configuration"]["operate-vnf-op-config"]["day1-2"][0][ + "config-primitive" + ] = [] + with self.assertRaises(EngineException) as e: + self.topic.validate_scaling_group_descriptor(indata) + self.assertEqual( + e.exception.http_code, + HTTPStatus.UNPROCESSABLE_ENTITY, + "Wrong HTTP status code", + ) + self.assertIn( + norm( + "df[id='{}']:scaling-aspect[id='{}']:scaling-config-action:vnf-" + "config-primitive-name-ref='{}' does not match any " + "day1-2 configuration:config-primitive:name".format( + df["id"], affected_sa["id"], affected_sca_primitive + ) + ), + norm(str(e.exception)), + "Wrong exception text", + ) + + def test_new_vnfd_revision(self): + did = db_vnfd_content["_id"] + self.fs.get_params.return_value = {} + self.fs.file_exists.return_value = False + self.fs.file_open.side_effect = lambda path, mode: open( + "/tmp/" + str(uuid4()), "a+b" + ) + test_vnfd = deepcopy(db_vnfd_content) + del test_vnfd["_id"] + del test_vnfd["_admin"] + self.db.create.return_value = did + rollback = [] + did2, oid = self.topic.new(rollback, fake_session, {}) + db_args = self.db.create.call_args[0] + self.assertEqual( + db_args[1]["_admin"]["revision"], 0, "New package should be at revision 0" + ) + + @patch("osm_nbi.descriptor_topics.shutil") + @patch("osm_nbi.descriptor_topics.os.rename") + def test_update_vnfd(self, mock_rename, mock_shutil): + old_revision = 5 + did = db_vnfd_content["_id"] + self.fs.path = "" + self.fs.get_params.return_value = {} + self.fs.file_exists.return_value = False + self.fs.file_open.side_effect = lambda path, mode: open( + "/tmp/" + str(uuid4()), "a+b" + ) + new_vnfd = deepcopy(db_vnfd_content) + del new_vnfd["_id"] + self.db.create.return_value = did + rollback = [] + did2, oid = self.topic.new(rollback, fake_session, {}) + del new_vnfd["vdu"][0]["cloud-init-file"] + del new_vnfd["df"][0]["lcm-operations-configuration"]["operate-vnf-op-config"][ + "day1-2" + ][0]["execution-environment-list"][0]["juju"] + + old_vnfd = {"_id": did, "_admin": deepcopy(db_vnfd_content["_admin"])} + old_vnfd["_admin"]["revision"] = old_revision + + self.db.get_one.side_effect = [old_vnfd, old_vnfd, None] + self.topic.upload_content(fake_session, did, new_vnfd, {}, {"Content-Type": []}) + + db_args = self.db.replace.call_args[0] + self.assertEqual( + db_args[2]["_admin"]["revision"], + old_revision + 1, + "Revision should increment", + ) + + +class Test_NsdTopic(TestCase): + @classmethod + def setUpClass(cls): + cls.test_name = "test-nsd-topic" + + @classmethod + def tearDownClass(cls): + pass + + def setUp(self): + self.db = Mock(dbbase.DbBase()) + self.fs = Mock(fsbase.FsBase()) + self.msg = Mock(msgbase.MsgBase()) + self.auth = Mock(authconn.Authconn(None, None, None)) + self.topic = NsdTopic(self.db, self.fs, self.msg, self.auth) + self.topic.check_quota = Mock(return_value=None) # skip quota + + @contextmanager + def assertNotRaises(self, exception_type): + try: + yield None + except exception_type: + raise self.failureException("{} raised".format(exception_type.__name__)) + + def create_desc_temp(self, template): + old_desc = deepcopy(template) + new_desc = deepcopy(template) + return old_desc, new_desc + + def prepare_nsd_creation(self): + self.fs.path = "" + did = db_nsd_content["_id"] + self.fs.get_params.return_value = {} + self.fs.file_exists.return_value = False + self.fs.file_open.side_effect = lambda path, mode: tempfile.TemporaryFile( + mode="a+b" + ) + self.db.get_one.side_effect = [ + {"_id": did, "_admin": deepcopy(db_nsd_content["_admin"])}, + None, + ] + test_nsd = deepcopy(db_nsd_content) + del test_nsd["_id"] + del test_nsd["_admin"] + return did, test_nsd + + @patch("osm_nbi.descriptor_topics.shutil") + @patch("osm_nbi.descriptor_topics.os.rename") + def test_new_nsd_normal_creation(self, mock_rename, mock_shutil): + did, test_nsd = self.prepare_nsd_creation() + self.db.create.return_value = did + rollback = [] + + did2, oid = self.topic.new(rollback, fake_session, {}) + db_args = self.db.create.call_args[0] + msg_args = self.msg.write.call_args[0] + self.assertEqual(len(rollback), 1, "Wrong rollback length") + self.assertEqual(msg_args[0], self.topic.topic_msg, "Wrong message topic") + self.assertEqual(msg_args[1], "created", "Wrong message action") + self.assertEqual(msg_args[2], {"_id": did}, "Wrong message content") + self.assertEqual(db_args[0], self.topic.topic, "Wrong DB topic") + self.assertEqual(did2, did, "Wrong DB NSD id") + self.assertIsNotNone(db_args[1]["_admin"]["created"], "Wrong creation time") + self.assertEqual( + db_args[1]["_admin"]["modified"], + db_args[1]["_admin"]["created"], + "Wrong modification time", + ) + self.assertEqual( + db_args[1]["_admin"]["projects_read"], + [test_pid], + "Wrong read-only project list", + ) + self.assertEqual( + db_args[1]["_admin"]["projects_write"], + [test_pid], + "Wrong read-write project list", + ) + + self.db.get_list.return_value = [db_vnfd_content] + + self.topic.upload_content(fake_session, did, test_nsd, {}, {"Content-Type": []}) + msg_args = self.msg.write.call_args[0] + test_nsd["_id"] = did + self.assertEqual(msg_args[0], self.topic.topic_msg, "Wrong message topic") + self.assertEqual(msg_args[1], "edited", "Wrong message action") + self.assertEqual(msg_args[2], test_nsd, "Wrong message content") + + db_args = self.db.get_one.mock_calls[0][1] + self.assertEqual(db_args[0], self.topic.topic, "Wrong DB topic") + self.assertEqual(db_args[1]["_id"], did, "Wrong DB NSD id") + + db_args = self.db.replace.call_args[0] + self.assertEqual(db_args[0], self.topic.topic, "Wrong DB topic") + self.assertEqual(db_args[1], did, "Wrong DB NSD id") + + admin = db_args[2]["_admin"] + db_admin = db_nsd_content["_admin"] + self.assertEqual(admin["created"], db_admin["created"], "Wrong creation time") + self.assertGreater( + admin["modified"], db_admin["created"], "Wrong modification time" + ) + self.assertEqual( + admin["projects_read"], + db_admin["projects_read"], + "Wrong read-only project list", + ) + self.assertEqual( + admin["projects_write"], + db_admin["projects_write"], + "Wrong read-write project list", + ) + self.assertEqual( + admin["onboardingState"], "ONBOARDED", "Wrong onboarding state" + ) + self.assertEqual( + admin["operationalState"], "ENABLED", "Wrong operational state" + ) + self.assertEqual(admin["usageState"], "NOT_IN_USE", "Wrong usage state") + + storage = admin["storage"] + self.assertEqual(storage["folder"], did + ":1", "Wrong storage folder") + self.assertEqual(storage["descriptor"], "package", "Wrong storage descriptor") + + compare_desc(self, test_nsd, db_args[2], "NSD") + revision_args = self.db.create.call_args[0] + self.assertEqual( + revision_args[0], self.topic.topic + "_revisions", "Wrong topic" + ) + self.assertEqual(revision_args[1]["id"], db_args[2]["id"], "Wrong revision id") + self.assertEqual( + revision_args[1]["_id"], db_args[2]["_id"] + ":1", "Wrong revision _id" + ) + + @patch("osm_nbi.descriptor_topics.shutil") + @patch("osm_nbi.descriptor_topics.os.rename") + def test_new_nsd_check_pyangbind_validation_required_properties( + self, mock_rename, mock_shutil + ): + did, test_nsd = self.prepare_nsd_creation() + del test_nsd["id"] + + with self.assertRaises( + EngineException, msg="Accepted NSD with a missing required property" + ) as e: + self.topic.upload_content( + fake_session, did, test_nsd, {}, {"Content-Type": []} + ) + self.assertEqual( + e.exception.http_code, + HTTPStatus.UNPROCESSABLE_ENTITY, + "Wrong HTTP status code", + ) + self.assertIn( + norm("Error in pyangbind validation: '{}'".format("id")), + norm(str(e.exception)), + "Wrong exception text", + ) + + @patch("osm_nbi.descriptor_topics.shutil") + @patch("osm_nbi.descriptor_topics.os.rename") + def test_new_nsd_check_pyangbind_validation_additional_properties( + self, mock_rename, mock_shutil + ): + did, test_nsd = self.prepare_nsd_creation() + test_nsd["extra-property"] = 0 + + with self.assertRaises( + EngineException, msg="Accepted NSD with an additional property" + ) as e: + self.topic.upload_content( + fake_session, did, test_nsd, {}, {"Content-Type": []} + ) self.assertEqual( e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, @@ -1021,26 +1637,28 @@ class Test_VnfdTopic(TestCase): ) self.assertIn( norm( - "Duplicated monitoring-parameter id in " - "vdu[id='{}']:monitoring-parameter[id='{}']".format( - affected_vdu["id"], duplicated_mp["id"] + "Error in pyangbind validation: {} ({})".format( + "json object contained a key that did not exist", "extra-property" ) ), norm(str(e.exception)), "Wrong exception text", ) - def test_validate_monitoring_params_on_duplicated_df_monitoring_param(self): - indata = deepcopy(db_vnfd_content) - duplicated_mp = { - "id": "memory", - "name": "memory", - "performance_metric": "memory", - } - affected_df = indata["df"][0] - affected_df["monitoring-parameter"] = [duplicated_mp, duplicated_mp] - with self.assertRaises(EngineException) as e: - self.topic.validate_monitoring_params(indata) + @patch("osm_nbi.descriptor_topics.shutil") + @patch("osm_nbi.descriptor_topics.os.rename") + def test_new_nsd_check_pyangbind_validation_property_types( + self, mock_rename, mock_shutil + ): + did, test_nsd = self.prepare_nsd_creation() + test_nsd["designer"] = {"key": 0} + + with self.assertRaises( + EngineException, msg="Accepted NSD with a wrongly typed property" + ) as e: + self.topic.upload_content( + fake_session, did, test_nsd, {}, {"Content-Type": []} + ) self.assertEqual( e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, @@ -1048,29 +1666,34 @@ class Test_VnfdTopic(TestCase): ) self.assertIn( norm( - "Duplicated monitoring-parameter id in " - "df[id='{}']:monitoring-parameter[id='{}']".format( - affected_df["id"], duplicated_mp["id"] + "Error in pyangbind validation: {} ({})".format( + "json object contained a key that did not exist", "key" ) ), norm(str(e.exception)), "Wrong exception text", ) - def test_validate_scaling_group_descriptor_on_valid_descriptor(self): - indata = db_vnfd_content - self.topic.validate_scaling_group_descriptor(indata) + @patch("osm_nbi.descriptor_topics.shutil") + @patch("osm_nbi.descriptor_topics.os.rename") + def test_new_nsd_check_input_validation_mgmt_network_virtual_link_protocol_data( + self, mock_rename, mock_shutil + ): + did, test_nsd = self.prepare_nsd_creation() + df = test_nsd["df"][0] + mgmt_profile = { + "id": "id", + "virtual-link-desc-id": "mgmt", + "virtual-link-protocol-data": {"associated-layer-protocol": "ipv4"}, + } + df["virtual-link-profile"] = [mgmt_profile] - def test_validate_scaling_group_descriptor_when_missing_monitoring_param(self): - indata = deepcopy(db_vnfd_content) - vdu = indata["vdu"][1] - affected_df = indata["df"][0] - affected_sa = affected_df["scaling-aspect"][0] - affected_sp = affected_sa["scaling-policy"][0] - affected_sc = affected_sp["scaling-criteria"][0] - vdu.pop("monitoring-parameter") - with self.assertRaises(EngineException) as e: - self.topic.validate_scaling_group_descriptor(indata) + with self.assertRaises( + EngineException, msg="Accepted VLD with mgmt-network+ip-profile" + ) as e: + self.topic.upload_content( + fake_session, did, test_nsd, {}, {"Content-Type": []} + ) self.assertEqual( e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, @@ -1078,59 +1701,62 @@ class Test_VnfdTopic(TestCase): ) self.assertIn( norm( - "df[id='{}']:scaling-aspect[id='{}']:scaling-policy" - "[name='{}']:scaling-criteria[name='{}']: " - "vnf-monitoring-param-ref='{}' not defined in any monitoring-param".format( - affected_df["id"], - affected_sa["id"], - affected_sp["name"], - affected_sc["name"], - affected_sc["vnf-monitoring-param-ref"], + "Error at df[id='{}']:virtual-link-profile[id='{}']:virtual-link-protocol-data" + " You cannot set a virtual-link-protocol-data when mgmt-network is True".format( + df["id"], mgmt_profile["id"] ) ), norm(str(e.exception)), "Wrong exception text", ) - def test_validate_scaling_group_descriptor_when_missing_vnf_configuration(self): - indata = deepcopy(db_vnfd_content) - df = indata["df"][0] - affected_sa = df["scaling-aspect"][0] - indata["df"][0]["lcm-operations-configuration"]["operate-vnf-op-config"][ - "day1-2" - ].pop() - with self.assertRaises(EngineException) as e: - self.topic.validate_scaling_group_descriptor(indata) + @patch("osm_nbi.descriptor_topics.shutil") + @patch("osm_nbi.descriptor_topics.os.rename") + def test_new_nsd_check_descriptor_dependencies_vnfd_id( + self, mock_rename, mock_shutil + ): + did, test_nsd = self.prepare_nsd_creation() + self.db.get_list.return_value = [] + + with self.assertRaises( + EngineException, msg="Accepted wrong VNFD ID reference" + ) as e: + self.topic.upload_content( + fake_session, did, test_nsd, {}, {"Content-Type": []} + ) self.assertEqual( - e.exception.http_code, - HTTPStatus.UNPROCESSABLE_ENTITY, - "Wrong HTTP status code", + e.exception.http_code, HTTPStatus.CONFLICT, "Wrong HTTP status code" ) self.assertIn( norm( - "'day1-2 configuration' not defined in the descriptor but it is referenced " - "by df[id='{}']:scaling-aspect[id='{}']:scaling-config-action".format( - df["id"], affected_sa["id"] + "'vnfd-id'='{}' references a non existing vnfd".format( + test_nsd["vnfd-id"][0] ) ), norm(str(e.exception)), "Wrong exception text", ) - def test_validate_scaling_group_descriptor_when_missing_scaling_config_action_primitive( - self, + @patch("osm_nbi.descriptor_topics.shutil") + @patch("osm_nbi.descriptor_topics.os.rename") + def test_new_nsd_check_descriptor_dependencies_vld_vnfd_connection_point_ref( + self, mock_rename, mock_shutil ): - indata = deepcopy(db_vnfd_content) - df = indata["df"][0] - affected_sa = df["scaling-aspect"][0] - affected_sca_primitive = affected_sa["scaling-config-action"][0][ - "vnf-config-primitive-name-ref" - ] - df["lcm-operations-configuration"]["operate-vnf-op-config"]["day1-2"][0][ - "config-primitive" - ] = [] - with self.assertRaises(EngineException) as e: - self.topic.validate_scaling_group_descriptor(indata) + # Check Descriptor Dependencies: "vld[vnfd-connection-point-ref][vnfd-connection-point-ref] + did, test_nsd = self.prepare_nsd_creation() + vnfd_descriptor = deepcopy(db_vnfd_content) + df = test_nsd["df"][0] + affected_vnf_profile = df["vnf-profile"][0] + affected_virtual_link = affected_vnf_profile["virtual-link-connectivity"][1] + affected_cpd = vnfd_descriptor["ext-cpd"].pop() + self.db.get_list.return_value = [vnfd_descriptor] + + with self.assertRaises( + EngineException, msg="Accepted wrong VLD CP reference" + ) as e: + self.topic.upload_content( + fake_session, did, test_nsd, {}, {"Content-Type": []} + ) self.assertEqual( e.exception.http_code, HTTPStatus.UNPROCESSABLE_ENTITY, @@ -1138,314 +1764,20 @@ class Test_VnfdTopic(TestCase): ) self.assertIn( norm( - "df[id='{}']:scaling-aspect[id='{}']:scaling-config-action:vnf-" - "config-primitive-name-ref='{}' does not match any " - "day1-2 configuration:config-primitive:name".format( - df["id"], affected_sa["id"], affected_sca_primitive + "Error at df[id='{}']:vnf-profile[id='{}']:virtual-link-connectivity" + "[virtual-link-profile-id='{}']:constituent-cpd-id='{}' references a " + "non existing ext-cpd:id inside vnfd '{}'".format( + df["id"], + affected_vnf_profile["id"], + affected_virtual_link["virtual-link-profile-id"], + affected_cpd["id"], + vnfd_descriptor["id"], ) ), norm(str(e.exception)), "Wrong exception text", ) - -class Test_NsdTopic(TestCase): - @classmethod - def setUpClass(cls): - cls.test_name = "test-nsd-topic" - - @classmethod - def tearDownClass(cls): - pass - - def setUp(self): - self.db = Mock(dbbase.DbBase()) - self.fs = Mock(fsbase.FsBase()) - self.msg = Mock(msgbase.MsgBase()) - self.auth = Mock(authconn.Authconn(None, None, None)) - self.topic = NsdTopic(self.db, self.fs, self.msg, self.auth) - self.topic.check_quota = Mock(return_value=None) # skip quota - - def test_new_nsd(self): - did = db_nsd_content["_id"] - self.fs.get_params.return_value = {} - self.fs.file_exists.return_value = False - self.fs.file_open.side_effect = lambda path, mode: open( - "/tmp/" + str(uuid4()), "a+b" - ) - test_nsd = deepcopy(db_nsd_content) - del test_nsd["_id"] - del test_nsd["_admin"] - with self.subTest(i=1, t="Normal Creation"): - self.db.create.return_value = did - rollback = [] - did2, oid = self.topic.new(rollback, fake_session, {}) - db_args = self.db.create.call_args[0] - msg_args = self.msg.write.call_args[0] - self.assertEqual(len(rollback), 1, "Wrong rollback length") - self.assertEqual(msg_args[0], self.topic.topic_msg, "Wrong message topic") - self.assertEqual(msg_args[1], "created", "Wrong message action") - self.assertEqual(msg_args[2], {"_id": did}, "Wrong message content") - self.assertEqual(db_args[0], self.topic.topic, "Wrong DB topic") - self.assertEqual(did2, did, "Wrong DB NSD id") - self.assertIsNotNone(db_args[1]["_admin"]["created"], "Wrong creation time") - self.assertEqual( - db_args[1]["_admin"]["modified"], - db_args[1]["_admin"]["created"], - "Wrong modification time", - ) - self.assertEqual( - db_args[1]["_admin"]["projects_read"], - [test_pid], - "Wrong read-only project list", - ) - self.assertEqual( - db_args[1]["_admin"]["projects_write"], - [test_pid], - "Wrong read-write project list", - ) - try: - self.db.get_one.side_effect = [ - {"_id": did, "_admin": db_nsd_content["_admin"]}, - None, - ] - self.db.get_list.return_value = [db_vnfd_content] - self.topic.upload_content( - fake_session, did, test_nsd, {}, {"Content-Type": []} - ) - msg_args = self.msg.write.call_args[0] - test_nsd["_id"] = did - self.assertEqual( - msg_args[0], self.topic.topic_msg, "Wrong message topic" - ) - self.assertEqual(msg_args[1], "edited", "Wrong message action") - self.assertEqual(msg_args[2], test_nsd, "Wrong message content") - db_args = self.db.get_one.mock_calls[0][1] - self.assertEqual(db_args[0], self.topic.topic, "Wrong DB topic") - self.assertEqual(db_args[1]["_id"], did, "Wrong DB NSD id") - db_args = self.db.replace.call_args[0] - self.assertEqual(db_args[0], self.topic.topic, "Wrong DB topic") - self.assertEqual(db_args[1], did, "Wrong DB NSD id") - admin = db_args[2]["_admin"] - db_admin = db_nsd_content["_admin"] - self.assertEqual( - admin["created"], db_admin["created"], "Wrong creation time" - ) - self.assertGreater( - admin["modified"], db_admin["created"], "Wrong modification time" - ) - self.assertEqual( - admin["projects_read"], - db_admin["projects_read"], - "Wrong read-only project list", - ) - self.assertEqual( - admin["projects_write"], - db_admin["projects_write"], - "Wrong read-write project list", - ) - self.assertEqual( - admin["onboardingState"], "ONBOARDED", "Wrong onboarding state" - ) - self.assertEqual( - admin["operationalState"], "ENABLED", "Wrong operational state" - ) - self.assertEqual(admin["usageState"], "NOT_IN_USE", "Wrong usage state") - storage = admin["storage"] - self.assertEqual(storage["folder"], did, "Wrong storage folder") - self.assertEqual( - storage["descriptor"], "package", "Wrong storage descriptor" - ) - compare_desc(self, test_nsd, db_args[2], "NSD") - finally: - pass - self.db.get_one.side_effect = ( - lambda table, filter, fail_on_empty=None, fail_on_more=None: { - "_id": did, - "_admin": db_nsd_content["_admin"], - } - ) - with self.subTest(i=2, t="Check Pyangbind Validation: required properties"): - tmp = test_nsd["id"] - del test_nsd["id"] - try: - with self.assertRaises( - EngineException, msg="Accepted NSD with a missing required property" - ) as e: - self.topic.upload_content( - fake_session, did, test_nsd, {}, {"Content-Type": []} - ) - self.assertEqual( - e.exception.http_code, - HTTPStatus.UNPROCESSABLE_ENTITY, - "Wrong HTTP status code", - ) - self.assertIn( - norm("Error in pyangbind validation: '{}'".format("id")), - norm(str(e.exception)), - "Wrong exception text", - ) - finally: - test_nsd["id"] = tmp - with self.subTest(i=3, t="Check Pyangbind Validation: additional properties"): - test_nsd["extra-property"] = 0 - try: - with self.assertRaises( - EngineException, msg="Accepted NSD with an additional property" - ) as e: - self.topic.upload_content( - fake_session, did, test_nsd, {}, {"Content-Type": []} - ) - self.assertEqual( - e.exception.http_code, - HTTPStatus.UNPROCESSABLE_ENTITY, - "Wrong HTTP status code", - ) - self.assertIn( - norm( - "Error in pyangbind validation: {} ({})".format( - "json object contained a key that did not exist", - "extra-property", - ) - ), - norm(str(e.exception)), - "Wrong exception text", - ) - finally: - del test_nsd["extra-property"] - with self.subTest(i=4, t="Check Pyangbind Validation: property types"): - tmp = test_nsd["designer"] - test_nsd["designer"] = {"key": 0} - try: - with self.assertRaises( - EngineException, msg="Accepted NSD with a wrongly typed property" - ) as e: - self.topic.upload_content( - fake_session, did, test_nsd, {}, {"Content-Type": []} - ) - self.assertEqual( - e.exception.http_code, - HTTPStatus.UNPROCESSABLE_ENTITY, - "Wrong HTTP status code", - ) - self.assertIn( - norm( - "Error in pyangbind validation: {} ({})".format( - "json object contained a key that did not exist", "key" - ) - ), - norm(str(e.exception)), - "Wrong exception text", - ) - finally: - test_nsd["designer"] = tmp - with self.subTest( - i=5, t="Check Input Validation: mgmt-network+virtual-link-protocol-data" - ): - df = test_nsd["df"][0] - mgmt_profile = { - "id": "id", - "virtual-link-desc-id": "mgmt", - "virtual-link-protocol-data": {"associated-layer-protocol": "ipv4"}, - } - df["virtual-link-profile"] = [mgmt_profile] - try: - with self.assertRaises( - EngineException, msg="Accepted VLD with mgmt-network+ip-profile" - ) as e: - self.topic.upload_content( - fake_session, did, test_nsd, {}, {"Content-Type": []} - ) - self.assertEqual( - e.exception.http_code, - HTTPStatus.UNPROCESSABLE_ENTITY, - "Wrong HTTP status code", - ) - self.assertIn( - norm( - "Error at df[id='{}']:virtual-link-profile[id='{}']:virtual-link-protocol-data" - " You cannot set a virtual-link-protocol-data when mgmt-network is True".format( - df["id"], mgmt_profile["id"] - ) - ), - norm(str(e.exception)), - "Wrong exception text", - ) - finally: - del df["virtual-link-profile"] - with self.subTest(i=6, t="Check Descriptor Dependencies: vnfd-id[]"): - self.db.get_one.side_effect = [ - {"_id": did, "_admin": db_nsd_content["_admin"]}, - None, - ] - self.db.get_list.return_value = [] - try: - with self.assertRaises( - EngineException, msg="Accepted wrong VNFD ID reference" - ) as e: - self.topic.upload_content( - fake_session, did, test_nsd, {}, {"Content-Type": []} - ) - self.assertEqual( - e.exception.http_code, HTTPStatus.CONFLICT, "Wrong HTTP status code" - ) - self.assertIn( - norm( - "'vnfd-id'='{}' references a non existing vnfd".format( - test_nsd["vnfd-id"][0] - ) - ), - norm(str(e.exception)), - "Wrong exception text", - ) - finally: - pass - with self.subTest( - i=7, - t="Check Descriptor Dependencies: " - "vld[vnfd-connection-point-ref][vnfd-connection-point-ref]", - ): - vnfd_descriptor = deepcopy(db_vnfd_content) - df = test_nsd["df"][0] - affected_vnf_profile = df["vnf-profile"][0] - affected_virtual_link = affected_vnf_profile["virtual-link-connectivity"][1] - affected_cpd = vnfd_descriptor["ext-cpd"].pop() - self.db.get_one.side_effect = [ - {"_id": did, "_admin": db_nsd_content["_admin"]}, - None, - ] - self.db.get_list.return_value = [vnfd_descriptor] - try: - with self.assertRaises( - EngineException, msg="Accepted wrong VLD CP reference" - ) as e: - self.topic.upload_content( - fake_session, did, test_nsd, {}, {"Content-Type": []} - ) - self.assertEqual( - e.exception.http_code, - HTTPStatus.UNPROCESSABLE_ENTITY, - "Wrong HTTP status code", - ) - self.assertIn( - norm( - "Error at df[id='{}']:vnf-profile[id='{}']:virtual-link-connectivity" - "[virtual-link-profile-id='{}']:constituent-cpd-id='{}' references a " - "non existing ext-cpd:id inside vnfd '{}'".format( - df["id"], - affected_vnf_profile["id"], - affected_virtual_link["virtual-link-profile-id"], - affected_cpd["id"], - vnfd_descriptor["id"], - ) - ), - norm(str(e.exception)), - "Wrong exception text", - ) - finally: - pass - return - def test_edit_nsd(self): nsd_content = deepcopy(db_nsd_content) did = nsd_content["_id"] @@ -1522,6 +1854,7 @@ class Test_NsdTopic(TestCase): norm(str(e.exception)), "Wrong exception text", ) + self.db.reset_mock() return def test_delete_nsd(self): @@ -1633,8 +1966,98 @@ class Test_NsdTopic(TestCase): "Wrong DB pull_list dictionary", ) self.fs.file_delete.assert_not_called() + self.db.reset_mock() return + def prepare_nsd_validation(self): + descriptor_name = "test_ns_descriptor" + self.fs.file_open.side_effect = lambda path, mode: open( + "/tmp/" + str(uuid4()), "a+b" + ) + old_nsd, new_nsd = self.create_desc_temp(db_nsd_content) + return descriptor_name, old_nsd, new_nsd + + @patch("osm_nbi.descriptor_topics.detect_descriptor_usage") + @patch("osm_nbi.descriptor_topics.yaml.safe_load") + def test_validate_descriptor_ns_configuration_changed( + self, mock_safe_load, mock_detect_usage + ): + """Validating NSD and NSD has changes in ns-configuration:config-primitive""" + descriptor_name, old_nsd, new_nsd = self.prepare_nsd_validation() + mock_safe_load.side_effect = [old_nsd, new_nsd] + mock_detect_usage.return_value = True + self.db.get_one.return_value = old_nsd + old_nsd.update( + {"ns-configuration": {"config-primitive": [{"name": "add-user"}]}} + ) + new_nsd.update( + {"ns-configuration": {"config-primitive": [{"name": "del-user"}]}} + ) + + with self.assertNotRaises(EngineException): + self.topic._validate_descriptor_changes( + old_nsd["_id"], descriptor_name, "/tmp", "/tmp:1" + ) + self.db.get_one.assert_called_once() + mock_detect_usage.assert_called_once() + self.assertEqual(mock_safe_load.call_count, 2) + + @patch("osm_nbi.descriptor_topics.detect_descriptor_usage") + @patch("osm_nbi.descriptor_topics.yaml.safe_load") + def test_validate_descriptor_nsd_name_changed( + self, mock_safe_load, mock_detect_usage + ): + """Validating NSD, NSD name has changed.""" + descriptor_name, old_nsd, new_nsd = self.prepare_nsd_validation() + did = old_nsd["_id"] + new_nsd["name"] = "nscharm-ns2" + mock_safe_load.side_effect = [old_nsd, new_nsd] + mock_detect_usage.return_value = True + self.db.get_one.return_value = old_nsd + + with self.assertRaises( + EngineException, msg="there are disallowed changes in the ns descriptor" + ) as e: + self.topic._validate_descriptor_changes( + did, descriptor_name, "/tmp", "/tmp:1" + ) + self.assertEqual( + e.exception.http_code, + HTTPStatus.UNPROCESSABLE_ENTITY, + "Wrong HTTP status code", + ) + self.assertIn( + norm("there are disallowed changes in the ns descriptor"), + norm(str(e.exception)), + "Wrong exception text", + ) + + self.db.get_one.assert_called_once() + mock_detect_usage.assert_called_once() + self.assertEqual(mock_safe_load.call_count, 2) + + @patch("osm_nbi.descriptor_topics.detect_descriptor_usage") + @patch("osm_nbi.descriptor_topics.yaml.safe_load") + def test_validate_descriptor_nsd_name_changed_nsd_not_in_use( + self, mock_safe_load, mock_detect_usage + ): + """Validating NSD, NSD name has changed, NSD is not in use.""" + descriptor_name, old_nsd, new_nsd = self.prepare_nsd_validation() + did = old_nsd["_id"] + new_nsd["name"] = "nscharm-ns2" + mock_safe_load.side_effect = [old_nsd, new_nsd] + mock_detect_usage.return_value = None + self.db.get_one.return_value = old_nsd + + with self.assertNotRaises(Exception): + self.topic._validate_descriptor_changes( + did, descriptor_name, "/tmp", "/tmp:1" + ) + + self.db.get_one.assert_called_once() + mock_detect_usage.assert_called_once() + mock_safe_load.assert_not_called() + def test_validate_vld_mgmt_network_with_virtual_link_protocol_data_on_valid_descriptor( self, ): @@ -1775,6 +2198,61 @@ class Test_NsdTopic(TestCase): "Wrong exception text", ) + def test_validate_vnffgd_descriptor_on_valid_descriptor(self): + indata = yaml.safe_load(db_sfc_nsds_text)[0] + vnffgd = indata.get("vnffgd") + fg = vnffgd[0] + self.topic.validate_vnffgd_data(fg, indata) + + def test_validate_vnffgd_descriptor_not_matching_nfp_position_element(self): + indata = yaml.safe_load(db_sfc_nsds_text)[0] + vnffgd = indata.get("vnffgd") + fg = vnffgd[0] + nfpd = fg.get("nfpd")[0] + with self.assertRaises(EngineException) as e: + fg.update({"nfp-position-element": [{"id": "test1"}]}) + self.topic.validate_vnffgd_data(fg, indata) + self.assertEqual( + e.exception.http_code, + HTTPStatus.UNPROCESSABLE_ENTITY, + "Wrong HTTP status code", + ) + self.assertIn( + norm( + "Error at vnffgd nfpd[id='{}']:nfp-position-element-id='{}' " + "does not match any nfp-position-element".format(nfpd["id"], "test") + ), + norm(str(e.exception)), + "Wrong exception text", + ) + + def test_validate_vnffgd_descriptor_not_matching_constituent_base_element_id( + self, + ): + indata = yaml.safe_load(db_sfc_nsds_text)[0] + vnffgd = indata.get("vnffgd") + fg = vnffgd[0] + fg["nfpd"][0]["position-desc-id"][0]["cp-profile-id"][0][ + "constituent-profile-elements" + ][0]["constituent-base-element-id"] = "error_vnf" + with self.assertRaises(EngineException) as e: + self.topic.validate_vnffgd_data(fg, indata) + self.assertEqual( + e.exception.http_code, + HTTPStatus.UNPROCESSABLE_ENTITY, + "Wrong HTTP status code", + ) + self.assertIn( + norm( + "Error at vnffgd constituent_profile[id='{}']:vnfd-id='{}' " + "does not match any constituent-base-element-id".format( + "vnf1", "error_vnf" + ) + ), + norm(str(e.exception)), + "Wrong exception text", + ) + if __name__ == "__main__": unittest.main()