X-Git-Url: https://osm.etsi.org/gitweb/?a=blobdiff_plain;f=installers%2Fcharm%2Fpol%2Fsrc%2Fcharm.py;h=7b92b453c56ccf90ae80eeca4be03b47f4f8e89b;hb=refs%2Fchanges%2F95%2F11695%2F6;hp=e2fcdb3eb95d0dd11bcb388a9cc7fb293281e85b;hpb=d326e879ade43b12055f37c5deab6972b2674f47;p=osm%2Fdevops.git diff --git a/installers/charm/pol/src/charm.py b/installers/charm/pol/src/charm.py index e2fcdb3e..7b92b453 100755 --- a/installers/charm/pol/src/charm.py +++ b/installers/charm/pol/src/charm.py @@ -27,9 +27,9 @@ import logging import re from typing import NoReturn, Optional +from charms.kafka_k8s.v0.kafka import KafkaEvents, KafkaRequires from ops.main import main from opslib.osm.charm import CharmedOsmBase, RelationsMissing -from opslib.osm.interfaces.kafka import KafkaClient from opslib.osm.interfaces.mongo import MongoClient from opslib.osm.interfaces.mysql import MysqlClient from opslib.osm.pod import ( @@ -87,6 +87,9 @@ class ConfigModel(ModelValidator): class PolCharm(CharmedOsmBase): + + on = KafkaEvents() + def __init__(self, *args) -> NoReturn: super().__init__( *args, @@ -107,9 +110,9 @@ class PolCharm(CharmedOsmBase): }, }, ) - self.kafka_client = KafkaClient(self, "kafka") - self.framework.observe(self.on["kafka"].relation_changed, self.configure_pod) - self.framework.observe(self.on["kafka"].relation_broken, self.configure_pod) + self.kafka = KafkaRequires(self) + self.framework.observe(self.on.kafka_available, self.configure_pod) + self.framework.observe(self.on.kafka_broken, self.configure_pod) self.mongodb_client = MongoClient(self, "mongodb") self.framework.observe(self.on["mongodb"].relation_changed, self.configure_pod) @@ -122,10 +125,7 @@ class PolCharm(CharmedOsmBase): def _check_missing_dependencies(self, config: ConfigModel): missing_relations = [] - if ( - self.kafka_client.is_missing_data_in_unit() - and self.kafka_client.is_missing_data_in_app() - ): + if not self.kafka.host or not self.kafka.port: missing_relations.append("kafka") if not config.mongodb_uri and self.mongodb_client.is_missing_data_in_unit(): missing_relations.append("mongodb") @@ -185,8 +185,8 @@ class PolCharm(CharmedOsmBase): "OSMPOL_GLOBAL_LOGLEVEL": config.log_level, # Kafka configuration "OSMPOL_MESSAGE_DRIVER": "kafka", - "OSMPOL_MESSAGE_HOST": self.kafka_client.host, - "OSMPOL_MESSAGE_PORT": self.kafka_client.port, + "OSMPOL_MESSAGE_HOST": self.kafka.host, + "OSMPOL_MESSAGE_PORT": self.kafka.port, # Database configuration "OSMPOL_DATABASE_DRIVER": "mongo", }