X-Git-Url: https://osm.etsi.org/gitweb/?a=blobdiff_plain;f=installers%2Fcharm%2Fpla%2Fsrc%2Fcharm.py;h=2663763b5d42a5121d2b4fb7f623b44a28756be2;hb=refs%2Fchanges%2F95%2F11695%2F6;hp=3238dde5408af53e282c46fbe320bdc829873e21;hpb=d326e879ade43b12055f37c5deab6972b2674f47;p=osm%2Fdevops.git diff --git a/installers/charm/pla/src/charm.py b/installers/charm/pla/src/charm.py index 3238dde5..2663763b 100755 --- a/installers/charm/pla/src/charm.py +++ b/installers/charm/pla/src/charm.py @@ -26,9 +26,9 @@ import logging from typing import NoReturn, Optional +from charms.kafka_k8s.v0.kafka import KafkaEvents, KafkaRequires from ops.main import main from opslib.osm.charm import CharmedOsmBase, RelationsMissing -from opslib.osm.interfaces.kafka import KafkaClient from opslib.osm.interfaces.mongo import MongoClient from opslib.osm.pod import ( ContainerV3Builder, @@ -76,12 +76,15 @@ class ConfigModel(ModelValidator): class PlaCharm(CharmedOsmBase): + + on = KafkaEvents() + def __init__(self, *args) -> NoReturn: super().__init__(*args, oci_image="image") - self.kafka_client = KafkaClient(self, "kafka") - self.framework.observe(self.on["kafka"].relation_changed, self.configure_pod) - self.framework.observe(self.on["kafka"].relation_broken, self.configure_pod) + self.kafka = KafkaRequires(self) + self.framework.observe(self.on.kafka_available, self.configure_pod) + self.framework.observe(self.on.kafka_broken, self.configure_pod) self.mongodb_client = MongoClient(self, "mongodb") self.framework.observe(self.on["mongodb"].relation_changed, self.configure_pod) @@ -90,10 +93,7 @@ class PlaCharm(CharmedOsmBase): def _check_missing_dependencies(self, config: ConfigModel): missing_relations = [] - if ( - self.kafka_client.is_missing_data_in_unit() - and self.kafka_client.is_missing_data_in_app() - ): + if not self.kafka.host or not self.kafka.port: missing_relations.append("kafka") if not config.mongodb_uri and self.mongodb_client.is_missing_data_in_unit(): missing_relations.append("mongodb") @@ -141,8 +141,8 @@ class PlaCharm(CharmedOsmBase): "OSMPLA_GLOBAL_LOG_LEVEL": config.log_level, # Kafka configuration "OSMPLA_MESSAGE_DRIVER": "kafka", - "OSMPLA_MESSAGE_HOST": self.kafka_client.host, - "OSMPLA_MESSAGE_PORT": self.kafka_client.port, + "OSMPLA_MESSAGE_HOST": self.kafka.host, + "OSMPLA_MESSAGE_PORT": self.kafka.port, # Database configuration "OSMPLA_DATABASE_DRIVER": "mongo", }