X-Git-Url: https://osm.etsi.org/gitweb/?a=blobdiff_plain;f=installers%2Fcharm%2Fosm-ro%2Fsrc%2Fcharm.py;h=84c0ee3090a847f4a684392c193bae6e84029c03;hb=be1ab182ee509d5b458fcd1379a9101a7d2a09b1;hp=e112d4ccb154f71eb90bd03e32401afa014c4ed8;hpb=8675e580f375a52b790c899420cebae973ea0c7f;p=osm%2Fdevops.git diff --git a/installers/charm/osm-ro/src/charm.py b/installers/charm/osm-ro/src/charm.py index e112d4cc..84c0ee30 100755 --- a/installers/charm/osm-ro/src/charm.py +++ b/installers/charm/osm-ro/src/charm.py @@ -31,6 +31,7 @@ import base64 import logging from typing import Any, Dict +from charms.data_platform_libs.v0.data_interfaces import DatabaseRequires from charms.kafka_k8s.v0.kafka import KafkaEvents, KafkaRequires from charms.observability_libs.v1.kubernetes_service_patch import KubernetesServicePatch from charms.osm_libs.v0.utils import ( @@ -47,8 +48,6 @@ from ops.framework import StoredState from ops.main import main from ops.model import ActiveStatus, Container -from legacy_interfaces import MongoClient - ro_host_paths = { "NG-RO": "/usr/lib/python3/dist-packages/osm_ng_ro", "RO-plugin": "/usr/lib/python3/dist-packages/osm_ro_plugin", @@ -101,7 +100,7 @@ class OsmRoCharm(CharmBase): super().__init__(*args) self._stored.set_default(certificates=set()) self.kafka = KafkaRequires(self) - self.mongodb_client = MongoClient(self, "mongodb") + self.mongodb_client = DatabaseRequires(self, "mongodb", database_name="osm") self._observe_charm_events() self._patch_k8s_service() self.ro = RoProvides(self) @@ -197,7 +196,7 @@ class OsmRoCharm(CharmBase): # Relation events self.on.kafka_available: self._on_config_changed, self.on["kafka"].relation_broken: self._on_required_relation_broken, - self.on["mongodb"].relation_changed: self._on_config_changed, + self.mongodb_client.on.database_created: self._on_config_changed, self.on["mongodb"].relation_broken: self._on_required_relation_broken, self.on.ro_relation_joined: self._update_ro_relation, # Action events @@ -207,6 +206,12 @@ class OsmRoCharm(CharmBase): for event, handler in event_handler_mapping.items(): self.framework.observe(event, handler) + def _is_database_available(self) -> bool: + try: + return self.mongodb_client.is_resource_created() + except KeyError: + return False + def _validate_config(self) -> None: """Validate charm configuration. @@ -241,7 +246,7 @@ class OsmRoCharm(CharmBase): if not self.kafka.host or not self.kafka.port: missing_relations.append("kafka") - if self.mongodb_client.is_missing_data_in_unit(): + if not self._is_database_available(): missing_relations.append("mongodb") if missing_relations: @@ -310,13 +315,13 @@ class OsmRoCharm(CharmBase): "OSMRO_MESSAGE_DRIVER": "kafka", # Database configuration "OSMRO_DATABASE_DRIVER": "mongo", - "OSMRO_DATABASE_URI": self.mongodb_client.connection_string, + "OSMRO_DATABASE_URI": self._get_mongodb_uri(), "OSMRO_DATABASE_COMMONKEY": self.config["database-commonkey"], # Storage configuration "OSMRO_STORAGE_DRIVER": "mongo", "OSMRO_STORAGE_PATH": "/app/storage", "OSMRO_STORAGE_COLLECTION": "files", - "OSMRO_STORAGE_URI": self.mongodb_client.connection_string, + "OSMRO_STORAGE_URI": self._get_mongodb_uri(), "OSMRO_PERIOD_REFRESH_ACTIVE": self.config.get("period_refresh_active") or 60, }, @@ -324,6 +329,9 @@ class OsmRoCharm(CharmBase): }, } + def _get_mongodb_uri(self): + return list(self.mongodb_client.fetch_relation_data().values())[0]["uris"] + if __name__ == "__main__": # pragma: no cover main(OsmRoCharm)