X-Git-Url: https://osm.etsi.org/gitweb/?a=blobdiff_plain;f=installers%2Fcharm%2Fosm-pol%2Fsrc%2Fcharm.py;fp=installers%2Fcharm%2Fosm-pol%2Fsrc%2Fcharm.py;h=07bf87e180f0f3f2a8c109cf470fa31ccb7f60bc;hb=e93311d0d1e614b2ee73cc88d8a04fdec217cff8;hp=2749ddb28337d6bc18f04c0a2ab409b6ae1e8168;hpb=b26337f4b399b8d2307002aa7ca98c23e2d3a1ed;p=osm%2Fdevops.git diff --git a/installers/charm/osm-pol/src/charm.py b/installers/charm/osm-pol/src/charm.py index 2749ddb2..07bf87e1 100755 --- a/installers/charm/osm-pol/src/charm.py +++ b/installers/charm/osm-pol/src/charm.py @@ -30,6 +30,7 @@ See more: https://charmhub.io/osm import logging from typing import Any, Dict +from charms.data_platform_libs.v0.data_interfaces import DatabaseRequires from charms.kafka_k8s.v0.kafka import KafkaEvents, KafkaRequires from charms.osm_libs.v0.utils import ( CharmError, @@ -43,7 +44,7 @@ from ops.framework import StoredState from ops.main import main from ops.model import ActiveStatus, Container -from legacy_interfaces import MongoClient, MysqlClient +from legacy_interfaces import MysqlClient HOSTPATHS = [ HostPath( @@ -71,7 +72,7 @@ class OsmPolCharm(CharmBase): super().__init__(*args) self.kafka = KafkaRequires(self) - self.mongodb_client = MongoClient(self, "mongodb") + self.mongodb_client = DatabaseRequires(self, "mongodb", database_name="osm") self.mysql_client = MysqlClient(self, "mysql") self._observe_charm_events() self.container: Container = self.unit.get_container(self.container_name) @@ -145,16 +146,23 @@ class OsmPolCharm(CharmBase): # Relation events self.on.kafka_available: self._on_config_changed, self.on["kafka"].relation_broken: self._on_required_relation_broken, + self.on["mysql"].relation_changed: self._on_config_changed, + self.on["mysql"].relation_broken: self._on_config_changed, + self.mongodb_client.on.database_created: self._on_config_changed, + self.on["mongodb"].relation_broken: self._on_required_relation_broken, # Action events self.on.get_debug_mode_information_action: self._on_get_debug_mode_information_action, } - for relation in [self.on[rel_name] for rel_name in ["mongodb", "mysql"]]: - event_handler_mapping[relation.relation_changed] = self._on_config_changed - event_handler_mapping[relation.relation_broken] = self._on_required_relation_broken for event, handler in event_handler_mapping.items(): self.framework.observe(event, handler) + def _is_database_available(self) -> bool: + try: + return self.mongodb_client.is_resource_created() + except KeyError: + return False + def _validate_config(self) -> None: """Validate charm configuration. @@ -174,7 +182,7 @@ class OsmPolCharm(CharmBase): if not self.kafka.host or not self.kafka.port: missing_relations.append("kafka") - if self.mongodb_client.is_missing_data_in_unit(): + if not self._is_database_available(): missing_relations.append("mongodb") if not self.config.get("mysql-uri") and self.mysql_client.is_missing_data_in_unit(): missing_relations.append("mysql") @@ -214,7 +222,7 @@ class OsmPolCharm(CharmBase): "OSMPOL_MESSAGE_DRIVER": "kafka", # Database Mongodb configuration "OSMPOL_DATABASE_DRIVER": "mongo", - "OSMPOL_DATABASE_URI": self.mongodb_client.connection_string, + "OSMPOL_DATABASE_URI": self._get_mongodb_uri(), # Database MySQL configuration "OSMPOL_SQL_DATABASE_URI": self._get_mysql_uri(), }, @@ -225,6 +233,9 @@ class OsmPolCharm(CharmBase): def _get_mysql_uri(self): return self.config.get("mysql-uri") or self.mysql_client.get_root_uri("pol") + def _get_mongodb_uri(self): + return list(self.mongodb_client.fetch_relation_data().values())[0]["uris"] + if __name__ == "__main__": # pragma: no cover main(OsmPolCharm)