X-Git-Url: https://osm.etsi.org/gitweb/?a=blobdiff_plain;f=installers%2Fcharm%2Fosm-nbi%2Fsrc%2Fcharm.py;h=484841acca971355fbdec44f389b711437df8575;hb=refs%2Fchanges%2F86%2F13286%2F3;hp=454b1555f613e46fab47d6292c8f6b6c64380ff1;hpb=c110dca8805110a491ad7415a93c05b01dca0134;p=osm%2Fdevops.git diff --git a/installers/charm/osm-nbi/src/charm.py b/installers/charm/osm-nbi/src/charm.py index 454b1555..484841ac 100755 --- a/installers/charm/osm-nbi/src/charm.py +++ b/installers/charm/osm-nbi/src/charm.py @@ -30,6 +30,7 @@ See more: https://charmhub.io/osm import logging from typing import Any, Dict +from charms.data_platform_libs.v0.data_interfaces import DatabaseRequires from charms.kafka_k8s.v0.kafka import KafkaEvents, KafkaRequires from charms.nginx_ingress_integrator.v0.ingress import IngressRequires from charms.observability_libs.v1.kubernetes_service_patch import KubernetesServicePatch @@ -41,13 +42,14 @@ from charms.osm_libs.v0.utils import ( check_service_active, ) from charms.osm_nbi.v0.nbi import NbiProvides +from charms.osm_temporal.v0.temporal import TemporalRequires from lightkube.models.core_v1 import ServicePort from ops.charm import ActionEvent, CharmBase, RelationJoinedEvent from ops.framework import StoredState from ops.main import main from ops.model import ActiveStatus, Container -from legacy_interfaces import KeystoneClient, MongoClient, PrometheusClient +from legacy_interfaces import KeystoneClient, PrometheusClient HOSTPATHS = [ HostPath( @@ -82,7 +84,10 @@ class OsmNbiCharm(CharmBase): ) self.kafka = KafkaRequires(self) self.nbi = NbiProvides(self) - self.mongodb_client = MongoClient(self, "mongodb") + self.temporal = TemporalRequires(self) + self.mongodb_client = DatabaseRequires( + self, "mongodb", database_name="osm", extra_user_roles="admin" + ) self.prometheus_client = PrometheusClient(self, "prometheus") self.keystone_client = KeystoneClient(self, "keystone") self._observe_charm_events() @@ -113,7 +118,8 @@ class OsmNbiCharm(CharmBase): # Eventually it will become ready after the first pebble-ready event. check_container_ready(self.container) - self._configure_service(self.container) + if not self.debug_mode.started: + self._configure_service(self.container) self._update_ingress_config() self._update_nbi_relation() # Update charm status @@ -178,17 +184,27 @@ class OsmNbiCharm(CharmBase): # Relation events self.on.kafka_available: self._on_config_changed, self.on["kafka"].relation_broken: self._on_required_relation_broken, + self.mongodb_client.on.database_created: self._on_config_changed, + self.on["mongodb"].relation_broken: self._on_required_relation_broken, # Action events self.on.get_debug_mode_information_action: self._on_get_debug_mode_information_action, self.on.nbi_relation_joined: self._update_nbi_relation, + self.on["temporal"].relation_changed: self._on_config_changed, + self.on["temporal"].relation_broken: self._on_required_relation_broken, } - for relation in [self.on[rel_name] for rel_name in ["mongodb", "prometheus", "keystone"]]: + for relation in [self.on[rel_name] for rel_name in ["prometheus", "keystone"]]: event_handler_mapping[relation.relation_changed] = self._on_config_changed event_handler_mapping[relation.relation_broken] = self._on_required_relation_broken for event, handler in event_handler_mapping.items(): self.framework.observe(event, handler) + def _is_database_available(self) -> bool: + try: + return self.mongodb_client.is_resource_created() + except KeyError: + return False + def _validate_config(self) -> None: """Validate charm configuration. @@ -208,12 +224,14 @@ class OsmNbiCharm(CharmBase): if not self.kafka.host or not self.kafka.port: missing_relations.append("kafka") - if self.mongodb_client.is_missing_data_in_unit(): + if not self._is_database_available(): missing_relations.append("mongodb") if self.prometheus_client.is_missing_data_in_app(): missing_relations.append("prometheus") if self.keystone_client.is_missing_data_in_app(): missing_relations.append("keystone") + if not self.temporal.host or not self.temporal.port: + missing_relations.append("temporal") if missing_relations: relations_str = ", ".join(missing_relations) @@ -262,13 +280,13 @@ class OsmNbiCharm(CharmBase): "OSMNBI_MESSAGE_DRIVER": "kafka", # Database configuration "OSMNBI_DATABASE_DRIVER": "mongo", - "OSMNBI_DATABASE_URI": self.mongodb_client.connection_string, + "OSMNBI_DATABASE_URI": self._get_mongodb_uri(), "OSMNBI_DATABASE_COMMONKEY": self.config["database-commonkey"], # Storage configuration "OSMNBI_STORAGE_DRIVER": "mongo", "OSMNBI_STORAGE_PATH": "/app/storage", "OSMNBI_STORAGE_COLLECTION": "files", - "OSMNBI_STORAGE_URI": self.mongodb_client.connection_string, + "OSMNBI_STORAGE_URI": self._get_mongodb_uri(), # Prometheus configuration "OSMNBI_PROMETHEUS_HOST": self.prometheus_client.hostname, "OSMNBI_PROMETHEUS_PORT": self.prometheus_client.port, @@ -288,11 +306,17 @@ class OsmNbiCharm(CharmBase): "OSMNBI_SERVER_SSL_CERTIFICATE": "", "OSMNBI_SERVER_SSL_PRIVATE_KEY": "", "OSMNBI_SERVER_SSL_PASS_PHRASE": "", + # Temporal configuration + "OSMNBI_TEMPORAL_HOST": self.temporal.host, + "OSMNBI_TEMPORAL_PORT": self.temporal.port, }, } }, } + def _get_mongodb_uri(self): + return list(self.mongodb_client.fetch_relation_data().values())[0]["uris"] + if __name__ == "__main__": # pragma: no cover main(OsmNbiCharm)