X-Git-Url: https://osm.etsi.org/gitweb/?a=blobdiff_plain;f=installers%2Fcharm%2Fosm-lcm%2Fsrc%2Fcharm.py;h=2ea908608b5293793e225eec04c5799522cfd115;hb=35cfd81f73e286a1ba4edca17a2b516ea44b5adb;hp=c7e1126f96221a4b0bde0bdbecec9489dbb149b0;hpb=fe67909cdef35dbf4357abad97f7710c8e83f584;p=osm%2Fdevops.git diff --git a/installers/charm/osm-lcm/src/charm.py b/installers/charm/osm-lcm/src/charm.py index c7e1126f..2ea90860 100755 --- a/installers/charm/osm-lcm/src/charm.py +++ b/installers/charm/osm-lcm/src/charm.py @@ -30,6 +30,7 @@ See more: https://charmhub.io/osm import logging from typing import Any, Dict +from charms.data_platform_libs.v0.data_interfaces import DatabaseRequires from charms.kafka_k8s.v0.kafka import KafkaRequires, _KafkaAvailableEvent from charms.osm_libs.v0.utils import ( CharmError, @@ -38,7 +39,6 @@ from charms.osm_libs.v0.utils import ( check_container_ready, check_service_active, ) -from charms.osm_temporal.v0.temporal import TemporalRequires from charms.osm_ro.v0.ro import RoRequires from charms.osm_vca_integrator.v0.vca import VcaDataChangedEvent, VcaRequires from ops.charm import ActionEvent, CharmBase, CharmEvents @@ -46,8 +46,6 @@ from ops.framework import EventSource, StoredState from ops.main import main from ops.model import ActiveStatus, Container -from legacy_interfaces import MongoClient - HOSTPATHS = [ HostPath( config="lcm-hostpath", @@ -85,8 +83,9 @@ class OsmLcmCharm(CharmBase): super().__init__(*args) self.vca = VcaRequires(self) self.kafka = KafkaRequires(self) - self.temporal = TemporalRequires(self) - self.mongodb_client = MongoClient(self, "mongodb") + self.mongodb_client = DatabaseRequires( + self, "mongodb", database_name="osm", extra_user_roles="admin" + ) self._observe_charm_events() self.ro = RoRequires(self) self.container: Container = self.unit.get_container(self.container_name) @@ -178,12 +177,10 @@ class OsmLcmCharm(CharmBase): # Relation events self.on.kafka_available: self._on_config_changed, self.on["kafka"].relation_broken: self._on_required_relation_broken, - self.on["mongodb"].relation_changed: self._on_config_changed, + self.mongodb_client.on.database_created: self._on_config_changed, self.on["mongodb"].relation_broken: self._on_required_relation_broken, self.on["ro"].relation_changed: self._on_config_changed, self.on["ro"].relation_broken: self._on_required_relation_broken, - self.on["temporal"].relation_changed: self._on_config_changed, - self.on["temporal"].relation_broken: self._on_required_relation_broken, self.on.vca_data_changed: self._on_config_changed, self.on["vca"].relation_broken: self._on_config_changed, # Action events @@ -203,12 +200,10 @@ class OsmLcmCharm(CharmBase): if not self.kafka.host or not self.kafka.port: missing_relations.append("kafka") - if self.mongodb_client.is_missing_data_in_unit(): + if not self._is_database_available(): missing_relations.append("mongodb") if not self.ro.host or not self.ro.port: missing_relations.append("ro") - if not self.temporal.host or not self.temporal.port: - missing_relations.append("temporal") if missing_relations: relations_str = ", ".join(missing_relations) @@ -217,6 +212,12 @@ class OsmLcmCharm(CharmBase): logger.warning(error_msg) raise CharmError(error_msg) + def _is_database_available(self) -> bool: + try: + return self.mongodb_client.is_resource_created() + except KeyError: + return False + def _configure_service(self, container: Container) -> None: """Add Pebble layer with the lcm service.""" logger.debug(f"configuring {self.app.name} service") @@ -238,18 +239,15 @@ class OsmLcmCharm(CharmBase): "OSMLCM_RO_TENANT": "osm", # Database configuration "OSMLCM_DATABASE_DRIVER": "mongo", - "OSMLCM_DATABASE_URI": self.mongodb_client.connection_string, + "OSMLCM_DATABASE_URI": self._get_mongodb_uri(), "OSMLCM_DATABASE_COMMONKEY": self.config["database-commonkey"], # Storage configuration "OSMLCM_STORAGE_DRIVER": "mongo", "OSMLCM_STORAGE_PATH": "/app/storage", "OSMLCM_STORAGE_COLLECTION": "files", - "OSMLCM_STORAGE_URI": self.mongodb_client.connection_string, + "OSMLCM_STORAGE_URI": self._get_mongodb_uri(), "OSMLCM_VCA_HELM_CA_CERTS": self.config["helm-ca-certs"], "OSMLCM_VCA_STABLEREPOURL": self.config["helm-stable-repo-url"], - # Temporal configuration - "OSMNBI_TEMPORAL_HOST": self.temporal.host, - "OSMNBI_TEMPORAL_PORT": self.temporal.port, } # Vca configuration if self.vca.data: @@ -284,6 +282,9 @@ class OsmLcmCharm(CharmBase): } return layer_config + def _get_mongodb_uri(self): + return list(self.mongodb_client.fetch_relation_data().values())[0]["uris"] + if __name__ == "__main__": # pragma: no cover main(OsmLcmCharm)