X-Git-Url: https://osm.etsi.org/gitweb/?a=blobdiff_plain;f=installers%2Fcharm%2Fnbi%2Fsrc%2Fcharm.py;h=cb47d1ce89d99afc839dbe132aed25e8d3fb34bc;hb=bb2f914425f0e7f64014d3edd6e55a83fe108975;hp=faba78ab2993089d33af9a6f16fbe4212ff7a3f8;hpb=cafe31e388357499765ddc3360b865800b612d7a;p=osm%2Fdevops.git diff --git a/installers/charm/nbi/src/charm.py b/installers/charm/nbi/src/charm.py index faba78ab..cb47d1ce 100755 --- a/installers/charm/nbi/src/charm.py +++ b/installers/charm/nbi/src/charm.py @@ -29,10 +29,10 @@ from typing import NoReturn, Optional from urllib.parse import urlparse +from charms.kafka_k8s.v0.kafka import KafkaEvents, KafkaRequires from ops.main import main from opslib.osm.charm import CharmedOsmBase, RelationsMissing from opslib.osm.interfaces.http import HttpServer -from opslib.osm.interfaces.kafka import KafkaClient from opslib.osm.interfaces.keystone import KeystoneClient from opslib.osm.interfaces.mongo import MongoClient from opslib.osm.interfaces.prometheus import PrometheusClient @@ -118,6 +118,8 @@ class ConfigModel(ModelValidator): class NbiCharm(CharmedOsmBase): + on = KafkaEvents() + def __init__(self, *args) -> NoReturn: super().__init__( *args, @@ -139,9 +141,9 @@ class NbiCharm(CharmedOsmBase): }, ) - self.kafka_client = KafkaClient(self, "kafka") - self.framework.observe(self.on["kafka"].relation_changed, self.configure_pod) - self.framework.observe(self.on["kafka"].relation_broken, self.configure_pod) + self.kafka = KafkaRequires(self) + self.framework.observe(self.on.kafka_available, self.configure_pod) + self.framework.observe(self.on.kafka_broken, self.configure_pod) self.mongodb_client = MongoClient(self, "mongodb") self.framework.observe(self.on["mongodb"].relation_changed, self.configure_pod) @@ -174,10 +176,7 @@ class NbiCharm(CharmedOsmBase): def _check_missing_dependencies(self, config: ConfigModel): missing_relations = [] - if ( - self.kafka_client.is_missing_data_in_unit() - and self.kafka_client.is_missing_data_in_app() - ): + if not self.kafka.host or not self.kafka.port: missing_relations.append("kafka") if not config.mongodb_uri and self.mongodb_client.is_missing_data_in_unit(): missing_relations.append("mongodb") @@ -227,7 +226,7 @@ class NbiCharm(CharmedOsmBase): "command": [ "sh", "-c", - f"until (nc -zvw1 {self.kafka_client.host} {self.kafka_client.port} ); do sleep 3; done; exit 0", + f"until (nc -zvw1 {self.kafka.host} {self.kafka.port} ); do sleep 3; done; exit 0", ], } ) @@ -257,9 +256,9 @@ class NbiCharm(CharmedOsmBase): "OSMNBI_SERVER_ENABLE_TEST": config.enable_test, "OSMNBI_STATIC_DIR": "/app/osm_nbi/html_public", # Kafka configuration - "OSMNBI_MESSAGE_HOST": self.kafka_client.host, + "OSMNBI_MESSAGE_HOST": self.kafka.host, "OSMNBI_MESSAGE_DRIVER": "kafka", - "OSMNBI_MESSAGE_PORT": self.kafka_client.port, + "OSMNBI_MESSAGE_PORT": self.kafka.port, # Database configuration "OSMNBI_DATABASE_DRIVER": "mongo", # Storage configuration