X-Git-Url: https://osm.etsi.org/gitweb/?a=blobdiff_plain;f=installers%2Fcharm%2Flcm%2Fsrc%2Fcharm.py;h=52b6964a80ac72ba0a02c0194fcf81a209f633c0;hb=13722ca955cf2dfc9fd7b11a4c11ea5dc63f1e46;hp=d65bdcfa35c8be6c5ebb4383de6c59bb06597ef8;hpb=426d4938f27b200f359078258f41109b399d5e06;p=osm%2Fdevops.git diff --git a/installers/charm/lcm/src/charm.py b/installers/charm/lcm/src/charm.py index d65bdcfa..52b6964a 100755 --- a/installers/charm/lcm/src/charm.py +++ b/installers/charm/lcm/src/charm.py @@ -21,7 +21,6 @@ ## import logging -from pydantic import ValidationError from typing import Any, Dict, NoReturn from ops.charm import CharmBase, CharmEvents @@ -112,10 +111,8 @@ class LcmCharm(CharmBase): Args: event (EventBase): Kafka relation event. """ - data_loc = event.unit if event.unit else event.app - - message_host = event.relation.data[data_loc].get("host") - message_port = event.relation.data[data_loc].get("port") + message_host = event.relation.data[event.unit].get("host") + message_port = event.relation.data[event.unit].get("port") if ( message_host @@ -145,9 +142,7 @@ class LcmCharm(CharmBase): Args: event (EventBase): DB relation event. """ - data_loc = event.unit if event.unit else event.app - - database_uri = event.relation.data[data_loc].get("connection_string") + database_uri = event.relation.data[event.unit].get("connection_string") if database_uri and self.state.database_uri != database_uri: self.state.database_uri = database_uri @@ -168,10 +163,8 @@ class LcmCharm(CharmBase): Args: event (EventBase): Keystone relation event. """ - data_loc = event.unit if event.unit else event.app - - ro_host = event.relation.data[data_loc].get("host") - ro_port = event.relation.data[data_loc].get("port") + ro_host = event.relation.data[event.unit].get("host") + ro_port = event.relation.data[event.unit].get("port") if ( ro_host @@ -262,7 +255,7 @@ class LcmCharm(CharmBase): self.model.app.name, self.port, ) - except ValidationError as exc: + except ValueError as exc: logger.exception("Config/Relation data validation error") self.unit.status = BlockedStatus(str(exc)) return