X-Git-Url: https://osm.etsi.org/gitweb/?a=blobdiff_plain;ds=sidebyside;f=osm_nbi%2Fhtml_out.py;h=f591a707a1c045dee7d4f5d1170072e05372bdc5;hb=dcf0b7744577eaaef0b2a9ac4006589e6d39cbd2;hp=5fd12ce45b947e4eac3e51f8dd4504b30815723d;hpb=7fd248705f1eba06d0998339af9e48e6b8ffe5c1;p=osm%2FNBI.git diff --git a/osm_nbi/html_out.py b/osm_nbi/html_out.py index 5fd12ce..f591a70 100644 --- a/osm_nbi/html_out.py +++ b/osm_nbi/html_out.py @@ -26,7 +26,8 @@ html_start = """
-" + yaml.safe_dump(data, explicit_start=False, indent=4, default_flow_style=False) + "" - body = html_body.format(item=request.path_info) + return ( + "
" + + yaml.safe_dump( + data, explicit_start=False, indent=4, default_flow_style=False + ) + + "" + ) + body = html_body.format(item=html_escape(request.path_info)) if response.status and response.status > 202: - body += html_body_error.format(yaml.safe_dump(data, explicit_start=True, indent=4, default_flow_style=False)) + # input request.path_info (URL) can contain XSS that are translated into output error detail + body += html_body_error.format( + html_escape( + yaml.safe_dump( + data, explicit_start=True, indent=4, default_flow_style=False + ) + ) + ) elif isinstance(data, (list, tuple)): if request.path_info == "/vnfpkgm/v1/vnf_packages": body += html_upload_body.format(request.path_info + "_content", "VNFD") @@ -162,24 +189,43 @@ def format(data, request, response, toke_info): data_id = k.pop("_id", None) elif isinstance(k, str): data_id = k - body += '
{id}: {t}
'.format(url=request.path_info, id=data_id, - t=html_escape(str(k))) + body += '{id}: {t}
'.format( + url=request.path_info, id=data_id, t=html_escape(str(k)) + ) elif isinstance(data, dict): if "Location" in response.headers: body += ' show '.format(response.headers["Location"]) else: - body += '" + html_escape(yaml.safe_dump(data, explicit_start=True, indent=4, default_flow_style=False)) + \ - "" + elif request.path_info.startswith( + "/vnfpkgm/v1/vnf_packages/" + ) or request.path_info.startswith("/vnfpkgm/v1/vnf_packages_content/"): + body += html_vnfpackage_body.format(id=_id) + elif request.path_info.startswith( + "/nsd/v1/ns_descriptors/" + ) or request.path_info.startswith("/nsd/v1/ns_descriptors_content/"): + body += html_nspackage_body.format(id=_id) + body += ( + "
" + + html_escape( + yaml.safe_dump( + data, explicit_start=True, indent=4, default_flow_style=False + ) + ) + + "" + ) elif data is None: if request.method == "DELETE" or "METHOD=DELETE" in request.query_string: body += "
deleted"