Bug 407 : Deleting Package on Descriptor Validation Failure

[osm/SO.git] / rwlaunchpad / plugins / rwlaunchpadtasklet / rift / tasklets / rwlaunchpad / uploader.py

diff --git a/rwlaunchpad/plugins/rwlaunchpadtasklet/rift/tasklets/rwlaunchpad/uploader.py b/rwlaunchpad/plugins/rwlaunchpadtasklet/rift/tasklets/rwlaunchpad/uploader.py
index 38e2ae9..800c7ef 100644 (file)
--- a/rwlaunchpad/plugins/rwlaunchpadtasklet/rift/tasklets/rwlaunchpad/uploader.py
+++ b/rwlaunchpad/plugins/rwlaunchpadtasklet/rift/tasklets/rwlaunchpad/uploader.py
@@ -461,6 +461,7 @@ class OnboardPackage(downloader.DownloaderProtocol):
                     self.validate_descriptor_fields(temp_package)
                 except Exception as e:
                     self.log.exception("Descriptor validation Failed")
+                    self.delete_stored_package(stored_package)
                     raise
                 try:
                     self.extract_icons(temp_package)
@@ -489,6 +490,7 @@ class OnboardPackage(downloader.DownloaderProtocol):
             if str(e):
                 self.log.message(OnboardError(str(e)))
             self.log.message(OnboardFailure())
+            raise OnboardException(OnboardFailure())
 
     def on_download_succeeded(self, job):
         self.log.message(DownloadSuccess("Package downloaded."))