Provide ip address at N2VC deploy for vdu
[osm/LCM.git] / osm_lcm / lcm.py
index d257b45..3266914 100644 (file)
@@ -3,13 +3,14 @@
 
 import asyncio
 import yaml
-import ROclient
 import logging
 import logging.handlers
 import getopt
 import functools
 import sys
 import traceback
+import ROclient
+# from osm_lcm import version as lcm_version, version_date as lcm_version_date, ROclient
 from osm_common import dbmemory
 from osm_common import dbmongo
 from osm_common import fslocal
@@ -29,7 +30,7 @@ from time import time
 
 
 __author__ = "Alfonso Tierno"
-min_RO_version = [0, 5, 69]
+min_RO_version = [0, 5, 72]
 
 
 class LcmException(Exception):
@@ -189,7 +190,7 @@ class Lcm:
                 logger_module.addHandler(file_handler)
             if "loglevel" in config[k1]:
                 logger_module.setLevel(config[k1]["loglevel"])
-
+        # self.logger.critical("starting osm/lcm version {} {}".format(lcm_version, lcm_version_date))
         self.n2vc = N2VC(
             log=self.logger,
             server=config['VCA']['host'],
@@ -657,8 +658,7 @@ class Lcm:
             if ci_file:
                 ci_file.close()
 
-    def n2vc_callback(self, model_name, application_name, status, message, db_nsr, db_nslcmop, member_vnf_index,
-                      task=None):
+    def n2vc_callback(self, model_name, application_name, status, message, db_nsr, db_nslcmop, task=None):
         """
         Callback both for charm status change and task completion
         :param model_name: Charm model name
@@ -675,7 +675,6 @@ class Lcm:
         :param message: detailed message error
         :param db_nsr: nsr database content
         :param db_nslcmop: nslcmop database content
-        :param member_vnf_index: NSD member-vnf-index
         :param task: None for charm status change, or task for completion task callback
         :return:
         """
@@ -685,11 +684,15 @@ class Lcm:
         db_nslcmop_update = {}
         try:
             nsr_id = db_nsr["_id"]
-            nslcmop_id = db_nslcmop["_id"]
             nsr_lcm = db_nsr["_admin"]["deployed"]
+            nslcmop_id = db_nslcmop["_id"]
             ns_operation = db_nslcmop["lcmOperationType"]
-            logging_text = "Task ns={} {}={} [n2vc_callback] vnf_index={}".format(nsr_id, ns_operation, nslcmop_id,
-                                                                                  member_vnf_index)
+            logging_text = "Task ns={} {}={} [n2vc_callback] application={}".format(nsr_id, ns_operation, nslcmop_id,
+                                                                                    application_name)
+            vca_deployed = nsr_lcm["VCA"].get(application_name)
+            if not vca_deployed:
+                self.logger.error(logging_text + " Not present at nsr._admin.deployed.VCA")
+                return
 
             if task:
                 if task.cancelled():
@@ -702,12 +705,12 @@ class Lcm:
                     if exc:
                         self.logger.error(logging_text + " task Exception={}".format(exc))
                         if ns_operation in ("instantiate", "terminate"):
-                            nsr_lcm["VCA"][member_vnf_index]['operational-status'] = "error"
-                            db_nsr_update["_admin.deployed.VCA.{}.operational-status".format(member_vnf_index)] = \
+                            vca_deployed['operational-status'] = "error"
+                            db_nsr_update["_admin.deployed.VCA.{}.operational-status".format(application_name)] = \
                                 "error"
-                            nsr_lcm["VCA"][member_vnf_index]['detailed-status'] = str(exc)
+                            vca_deployed['detailed-status'] = str(exc)
                             db_nsr_update[
-                                "_admin.deployed.VCA.{}.detailed-status".format(member_vnf_index)] = str(exc)
+                                "_admin.deployed.VCA.{}.detailed-status".format(application_name)] = str(exc)
                         elif ns_operation == "action":
                             db_nslcmop_update["operationState"] = "FAILED"
                             db_nslcmop_update["detailed-status"] = str(exc)
@@ -725,12 +728,12 @@ class Lcm:
                         return
             elif status:
                 self.logger.debug(logging_text + " Enter status={}".format(status))
-                if nsr_lcm["VCA"][member_vnf_index]['operational-status'] == status:
+                if vca_deployed['operational-status'] == status:
                     return  # same status, ignore
-                nsr_lcm["VCA"][member_vnf_index]['operational-status'] = status
-                db_nsr_update["_admin.deployed.VCA.{}.operational-status".format(member_vnf_index)] = status
-                nsr_lcm["VCA"][member_vnf_index]['detailed-status'] = str(message)
-                db_nsr_update["_admin.deployed.VCA.{}.detailed-status".format(member_vnf_index)] = str(message)
+                vca_deployed['operational-status'] = status
+                db_nsr_update["_admin.deployed.VCA.{}.operational-status".format(application_name)] = status
+                vca_deployed['detailed-status'] = str(message)
+                db_nsr_update["_admin.deployed.VCA.{}.detailed-status".format(application_name)] = str(message)
             else:
                 self.logger.critical(logging_text + " Enter with bad parameters", exc_info=True)
                 return
@@ -738,7 +741,7 @@ class Lcm:
             all_active = True
             status_map = {}
             n2vc_error_text = []   # contain text error list. If empty no one is in error status
-            for vnf_index, vca_info in nsr_lcm["VCA"].items():
+            for _, vca_info in nsr_lcm["VCA"].items():
                 vca_status = vca_info["operational-status"]
                 if vca_status not in status_map:
                     # Initialize it
@@ -748,12 +751,12 @@ class Lcm:
                 if vca_status != "active":
                     all_active = False
                 if vca_status in ("error", "blocked"):
-                    n2vc_error_text.append("member_vnf_index={} {}: {}".format(member_vnf_index, vca_status,
-                                                                               vca_info["detailed-status"]))
+                    n2vc_error_text.append("member_vnf_index={} vdu_id={} {}: {}".format(vca_info["member-vnf-index"],
+                                                                                         vca_info["vdu_id"], vca_status,
+                                                                                         vca_info["detailed-status"]))
 
             if all_active:
-                self.logger.debug("[n2vc_callback] ns_instantiate={} vnf_index={} All active".format(nsr_id,
-                                                                                                     member_vnf_index))
+                self.logger.debug(logging_text + " All active")
                 db_nsr_update["config-status"] = "configured"
                 db_nsr_update["detailed-status"] = "done"
                 db_nslcmop_update["operationState"] = "COMPLETED"
@@ -777,7 +780,7 @@ class Lcm:
                 db_nslcmop_update["detailed-status"] = cs
 
         except Exception as e:
-            self.logger.critical("[n2vc_callback] vnf_index={} Exception {}".format(member_vnf_index, e), exc_info=True)
+            self.logger.critical(logging_text + " Exception {}".format(e), exc_info=True)
         finally:
             try:
                 if db_nslcmop_update:
@@ -785,10 +788,9 @@ class Lcm:
                 if db_nsr_update:
                     self.update_db_2("nsrs", nsr_id, db_nsr_update)
             except Exception as e:
-                self.logger.critical("[n2vc_callback] vnf_index={} Update database Exception {}".format(
-                    member_vnf_index, e), exc_info=True)
+                self.logger.critical(logging_text + " Update database Exception {}".format(e), exc_info=True)
 
-    def ns_params_2_RO(self, ns_params):
+    def ns_params_2_RO(self, ns_params, nsd, vnfd_dict):
         """
         Creates a RO ns descriptor from OSM ns_instantite params
         :param ns_params: OSM instantiate params
@@ -808,6 +810,18 @@ class Lcm:
             vim_2_RO[vim_account] = RO_vim_id
             return RO_vim_id
 
+        def ip_profile_2_RO(ip_profile):
+            RO_ip_profile = deepcopy((ip_profile))
+            if "dns-server" in RO_ip_profile:
+                RO_ip_profile["dns-address"] = RO_ip_profile.pop("dns-server")
+            if RO_ip_profile.get("ip-version") == "ipv4":
+                RO_ip_profile["ip-version"] = "IPv4"
+            if RO_ip_profile.get("ip-version") == "ipv6":
+                RO_ip_profile["ip-version"] = "IPv6"
+            if "dhcp-params" in RO_ip_profile:
+                RO_ip_profile["dhcp"] = RO_ip_profile.pop("dhcp-params")
+            return RO_ip_profile
+
         if not ns_params:
             return None
         RO_ns_params = {
@@ -821,67 +835,99 @@ class Lcm:
         if ns_params.get("ssh-authorized-key"):
             RO_ns_params["cloud-config"] = {"key-pairs": ns_params["ssh-authorized-key"]}
         if ns_params.get("vnf"):
-            for vnf in ns_params["vnf"]:
-                RO_vnf = {}
-                if "vimAccountId" in vnf:
-                    RO_vnf["datacenter"] = vim_account_2_RO(vnf["vimAccountId"])
+            for vnf_params in ns_params["vnf"]:
+                for constituent_vnfd in nsd["constituent-vnfd"]:
+                    if constituent_vnfd["member-vnf-index"] == vnf_params["member-vnf-index"]:
+                        vnf_descriptor = vnfd_dict[constituent_vnfd["vnfd-id-ref"]]
+                        break
+                else:
+                    raise LcmException("Invalid instantiate parameter vnf:member-vnf-index={} is not present at nsd:"
+                                       "constituent-vnfd".format(vnf_params["member-vnf-index"]))
+                RO_vnf = {"vdus": {}, "networks": {}}
+                if vnf_params.get("vimAccountId"):
+                    RO_vnf["datacenter"] = vim_account_2_RO(vnf_params["vimAccountId"])
+                if vnf_params.get("vdu"):
+                    for vdu_params in vnf_params["vdu"]:
+                        RO_vnf["vdus"][vdu_params["id"]] = {}
+                        if vdu_params.get("volume"):
+                            RO_vnf["vdus"][vdu_params["id"]]["devices"] = {}
+                            for volume_params in vdu_params["volume"]:
+                                RO_vnf["vdus"][vdu_params["id"]]["devices"][volume_params["name"]] = {}
+                                if volume_params.get("vim-volume-id"):
+                                    RO_vnf["vdus"][vdu_params["id"]]["devices"][volume_params["name"]]["vim_id"] = \
+                                        volume_params["vim-volume-id"]
+                        if vdu_params.get("interface"):
+                            RO_vnf["vdus"][vdu_params["id"]]["interfaces"] = {}
+                            for interface_params in vdu_params["interface"]:
+                                RO_interface = {}
+                                RO_vnf["vdus"][vdu_params["id"]]["interfaces"][interface_params["name"]] = RO_interface
+                                if interface_params.get("ip-address"):
+                                    RO_interface["ip_address"] = interface_params["ip-address"]
+                                if interface_params.get("mac-address"):
+                                    RO_interface["mac_address"] = interface_params["mac-address"]
+                                if interface_params.get("floating-ip-required"):
+                                    RO_interface["floating-ip"] = interface_params["floating-ip-required"]
+                if vnf_params.get("internal-vld"):
+                    for internal_vld_params in vnf_params["internal-vld"]:
+                        RO_vnf["networks"][internal_vld_params["name"]] = {}
+                        if internal_vld_params.get("vim-network-name"):
+                            RO_vnf["networks"][internal_vld_params["name"]]["vim-network-name"] = \
+                                internal_vld_params["vim-network-name"]
+                        if internal_vld_params.get("ip-profile"):
+                            RO_vnf["networks"][internal_vld_params["name"]]["ip-profile"] = \
+                                ip_profile_2_RO(internal_vld_params["ip-profile"])
+                        if internal_vld_params.get("internal-connection-point"):
+                            for icp_params in internal_vld_params["internal-connection-point"]:
+                                # look for interface
+                                iface_found = False
+                                for vdu_descriptor in vnf_descriptor["vdu"]:
+                                    for vdu_interface in vdu_descriptor["interface"]:
+                                        if vdu_interface.get("internal-connection-point-ref") == icp_params["id-ref"]:
+                                            if vdu_descriptor["id"] not in RO_vnf["vdus"]:
+                                                RO_vnf["vdus"][vdu_descriptor["id"]] = {}
+                                            if "interfaces" not in RO_vnf["vdus"][vdu_descriptor["id"]]:
+                                                RO_vnf["vdus"][vdu_descriptor["id"]]["interfaces"] = {}
+                                            RO_ifaces = RO_vnf["vdus"][vdu_descriptor["id"]]["interfaces"]
+                                            if vdu_interface["name"] not in RO_ifaces:
+                                                RO_ifaces[vdu_interface["name"]] = {}
+
+                                            RO_ifaces[vdu_interface["name"]]["ip_address"] = icp_params["ip-address"]
+                                            iface_found = True
+                                            break
+                                    if iface_found:
+                                        break
+                                else:
+                                    raise LcmException("Invalid instantiate parameter vnf:member-vnf-index[{}]:"
+                                                       "internal-vld:id-ref={} is not present at vnfd:internal-"
+                                                       "connection-point".format(vnf_params["member-vnf-index"],
+                                                                                 icp_params["id-ref"]))
+
+                if not RO_vnf["vdus"]:
+                    del RO_vnf["vdus"]
+                if not RO_vnf["networks"]:
+                    del RO_vnf["networks"]
                 if RO_vnf:
-                    RO_ns_params["vnfs"][vnf["member-vnf-index"]] = RO_vnf
+                    RO_ns_params["vnfs"][vnf_params["member-vnf-index"]] = RO_vnf
         if ns_params.get("vld"):
-            for vld in ns_params["vld"]:
+            for vld_params in ns_params["vld"]:
                 RO_vld = {}
-                if "ip-profile" in vld:
-                    RO_vld["ip-profile"] = vld["ip-profile"]
-                if "vim-network-name" in vld:
+                if "ip-profile" in vld_params:
+                    RO_vld["ip-profile"] = ip_profile_2_RO(vld_params["ip-profile"])
+                if "vim-network-name" in vld_params:
                     RO_vld["sites"] = []
-                    if isinstance(vld["vim-network-name"], dict):
-                        for vim_account, vim_net in vld["vim-network-name"].items():
+                    if isinstance(vld_params["vim-network-name"], dict):
+                        for vim_account, vim_net in vld_params["vim-network-name"].items():
                             RO_vld["sites"].append({
                                 "netmap-use": vim_net,
                                 "datacenter": vim_account_2_RO(vim_account)
                             })
                     else:  # isinstance str
-                        RO_vld["sites"].append({"netmap-use": vld["vim-network-name"]})
+                        RO_vld["sites"].append({"netmap-use": vld_params["vim-network-name"]})
                 if RO_vld:
-                    RO_ns_params["networks"][vld["name"]] = RO_vld
+                    RO_ns_params["networks"][vld_params["name"]] = RO_vld
         return RO_ns_params
 
-    def ns_update_vnfr(self, db_vnfrs, ns_RO_info):
-        """
-        Updates database vnfr with the RO info, e.g. ip_address, vim_id... Descriptor db_vnfrs is also updated
-        :param db_vnfrs:
-        :param ns_RO_info:
-        :return:
-        """
-        for vnf_index, db_vnfr in db_vnfrs.items():
-            vnfr_deployed = ns_RO_info.get(vnf_index)
-            if not vnfr_deployed:
-                continue
-            vnfr_update = {}
-            db_vnfr["ip-address"] = vnfr_update["ip-address"] = vnfr_deployed.get("ip_address")
-            for index, vdur in enumerate(db_vnfr["vdur"]):
-                vdu_deployed = vnfr_deployed["vdur"].get(vdur["vdu-id-ref"])
-                if not vdu_deployed:
-                    continue
-                vnfr_update["vdur.{}.vim-id".format(index)] = vdu_deployed.get("vim_id")
-                db_vnfr["vdur"][index]["vim-id"] = vnfr_update["vdur.{}.vim-id".format(index)]
-                vnfr_update["vdur.{}.ip-address".format(index)] = vdu_deployed.get("ip_address")
-                db_vnfr["vdur"][index]["ip-address"] = vnfr_update["vdur.{}.ip-address".format(index)]
-                for index2, interface in enumerate(vdur["interfaces"]):
-                    iface_deployed = vdu_deployed["interfaces"].get(interface["name"])
-                    if not iface_deployed:
-                        continue
-                    db_vnfr["vdur"][index]["interfaces"][index2]["vim-id"] =\
-                        vnfr_update["vdur.{}.interfaces.{}.vim-id".format(index, index2)] = iface_deployed.get("vim_id")
-                    db_vnfr["vdur"][index]["interfaces"][index2]["ip-address"] =\
-                        vnfr_update["vdur.{}.interfaces.{}.ip-address".format(index, index2)] = iface_deployed.get(
-                        "ip_address")
-                    db_vnfr["vdur"][index]["interfaces"][index2]["mac-address"] =\
-                        vnfr_update["vdur.{}.interfaces.{}.mac-address".format(index, index2)] = iface_deployed.get(
-                        "mac_address")
-            self.update_db_2("vnfrs", db_vnfr["_id"], vnfr_update)
-
-    def ns_update_vnfr_2(self, db_vnfrs, nsr_desc_RO):
+    def ns_update_vnfr(self, db_vnfrs, nsr_desc_RO):
         """
         Updates database vnfr with the RO info, e.g. ip_address, vim_id... Descriptor db_vnfrs is also updated
         :param db_vnfrs:
@@ -917,7 +963,7 @@ class Lcm:
                     break
 
             else:
-                raise LcmException("ns_update_vnfr_2: Not found member_vnf_index={} at RO info".format(vnf_index))
+                raise LcmException("ns_update_vnfr: Not found member_vnf_index={} at RO info".format(vnf_index))
 
     async def create_monitoring(self, nsr_id, vnf_member_index, vnfd_desc):
         if not vnfd_desc.get("scaling-group-descriptor"):
@@ -980,6 +1026,7 @@ class Lcm:
             db_nslcmop = self.db.get_one("nslcmops", {"_id": nslcmop_id})
             step = "Getting nsr={} from db".format(nsr_id)
             db_nsr = self.db.get_one("nsrs", {"_id": nsr_id})
+            ns_params = db_nsr.get("instantiate_params")
             nsd = db_nsr["nsd"]
             nsr_name = db_nsr["name"]   # TODO short-name??
             needed_vnfd = {}
@@ -1081,7 +1128,6 @@ class Lcm:
                 # self.logger.debug(logging_text + step)
 
                 # check if VIM is creating and wait  look if previous tasks in process
-                ns_params = db_nsr.get("instantiate_params")
                 task_name, task_dependency = self.lcm_tasks.lookfor_related("vim_account", ns_params["vimAccountId"])
                 if task_dependency:
                     step = "Waiting for related tasks to be completed: {}".format(task_name)
@@ -1097,7 +1143,7 @@ class Lcm:
                             self.logger.debug(logging_text + step)
                             await asyncio.wait(task_dependency, timeout=3600)
 
-                RO_ns_params = self.ns_params_2_RO(ns_params)
+                RO_ns_params = self.ns_params_2_RO(ns_params, nsd, needed_vnfd)
                 desc = await RO.create("ns", descriptor=RO_ns_params,
                                        name=db_nsr["name"],
                                        scenario=RO_nsd_uuid)
@@ -1154,8 +1200,7 @@ class Lcm:
                 raise ROclient.ROClientException("Timeout waiting ns to be ready")
 
             step = "Updating VNFRs"
-            # self.ns_update_vnfr(db_vnfrs, ns_RO_info)
-            self.ns_update_vnfr_2(db_vnfrs, desc)
+            self.ns_update_vnfr(db_vnfrs, desc)
 
             db_nsr["detailed-status"] = "Configuring vnfr"
             self.update_db_2("nsrs", nsr_id, db_nsr_update)
@@ -1163,10 +1208,12 @@ class Lcm:
             # The parameters we'll need to deploy a charm
             number_to_configure = 0
 
-            def deploy():
+            def deploy(vnf_index, vdu_id, mgmt_ip_address, config_primitive=None):
                 """An inner function to deploy the charm from either vnf or vdu
+                vnf_index is mandatory. vdu_id can be None for a vnf configuration or the id for vdu configuration
                 """
-
+                if not mgmt_ip_address:
+                    raise LcmException("vnfd/vdu has not management ip address to configure it")
                 # Login to the VCA.
                 # if number_to_configure == 0:
                 #     self.logger.debug("Logging into N2VC...")
@@ -1188,19 +1235,26 @@ class Lcm:
                 )
 
                 # Setup the runtime parameters for this VNF
-                params['rw_mgmt_ip'] = db_vnfrs[vnf_index]["ip-address"]
+                params = {'rw_mgmt_ip': mgmt_ip_address}
+                if config_primitive:
+                    params["initial-config-primitive"] = config_primitive
 
                 # ns_name will be ignored in the current version of N2VC
                 # but will be implemented for the next point release.
                 model_name = 'default'
+                vdu_id_text = "vnfd"
+                if vdu_id:
+                    vdu_id_text = vdu_id
                 application_name = self.n2vc.FormatApplicationName(
                     nsr_name,
                     vnf_index,
-                    vnfd['name'],
+                    vdu_id_text
                 )
                 if not nsr_lcm.get("VCA"):
                     nsr_lcm["VCA"] = {}
-                nsr_lcm["VCA"][vnf_index] = db_nsr_update["_admin.deployed.VCA.{}".format(vnf_index)] = {
+                nsr_lcm["VCA"][application_name] = db_nsr_update["_admin.deployed.VCA.{}".format(application_name)] = {
+                    "member-vnf-index": vnf_index,
+                    "vdu_id": vdu_id,
                     "model": model_name,
                     "application": application_name,
                     "operational-status": "init",
@@ -1222,13 +1276,12 @@ class Lcm:
                         self.n2vc_callback,  # Callback for status changes
                         db_nsr,              # Callback parameter
                         db_nslcmop,
-                        vnf_index,           # Callback parameter
                         None,                # Callback parameter (task)
                     )
                 )
                 task.add_done_callback(functools.partial(self.n2vc_callback, model_name, application_name, None, None,
-                                                         db_nsr, db_nslcmop, vnf_index))
-                self.lcm_tasks.register("ns", nsr_id, nslcmop_id, "create_charm:" + vnf_index, task)
+                                                         db_nsr, db_nslcmop))
+                self.lcm_tasks.register("ns", nsr_id, nslcmop_id, "create_charm:" + application_name, task)
 
             step = "Looking for needed vnfd to configure"
             self.logger.debug(logging_text + step)
@@ -1243,36 +1296,39 @@ class Lcm:
 
                 if vnf_config and vnf_config.get("juju"):
                     proxy_charm = vnf_config["juju"]["charm"]
-                    params = {}
+                    config_primitive = None
 
                     if proxy_charm:
                         if 'initial-config-primitive' in vnf_config:
-                            params['initial-config-primitive'] = vnf_config['initial-config-primitive']
+                            config_primitive = vnf_config['initial-config-primitive']
 
                         # Login to the VCA. If there are multiple calls to login(),
                         # subsequent calls will be a nop and return immediately.
                         step = "connecting to N2VC to configure vnf {}".format(vnf_index)
                         await self.n2vc.login()
-                        deploy()
+                        deploy(vnf_index, None, db_vnfrs[vnf_index]["ip-address"], config_primitive)
                         number_to_configure += 1
 
                 # Deploy charms for each VDU that supports one.
+                vdu_index = 0
                 for vdu in vnfd['vdu']:
                     vdu_config = vdu.get('vdu-configuration')
                     proxy_charm = None
-                    params = {}
+                    config_primitive = None
 
                     if vdu_config and vdu_config.get("juju"):
                         proxy_charm = vdu_config["juju"]["charm"]
 
                         if 'initial-config-primitive' in vdu_config:
-                            params['initial-config-primitive'] = vdu_config['initial-config-primitive']
+                            config_primitive = vdu_config['initial-config-primitive']
 
                         if proxy_charm:
                             step = "connecting to N2VC to configure vdu {} from vnf {}".format(vdu["id"], vnf_index)
                             await self.n2vc.login()
-                            deploy()
+                            deploy(vnf_index, vdu["id"], db_vnfrs[vnf_index]["vdur"][vdu_index]["ip-address"],
+                                   config_primitive)
                             number_to_configure += 1
+                    vdu_index += 1
 
             if number_to_configure:
                 db_nsr_update["config-status"] = "configuring"
@@ -1356,24 +1412,23 @@ class Lcm:
                     db_nsr_update["detailed-status"] = "Deleting charms"
                     self.logger.debug(logging_text + step)
                     self.update_db_2("nsrs", nsr_id, db_nsr_update)
-                    for vnf_index, deploy_info in nsr_lcm["VCA"].items():
-                        if deploy_info and deploy_info.get("application"):
+                    for application_name, deploy_info in nsr_lcm["VCA"].items():
+                        if deploy_info:  # TODO it would be desirable having a and deploy_info.get("deployed"):
                             task = asyncio.ensure_future(
                                 self.n2vc.RemoveCharms(
                                     deploy_info['model'],
-                                    deploy_info['application'],
+                                    application_name,
                                     # self.n2vc_callback,
                                     # db_nsr,
                                     # db_nslcmop,
-                                    # vnf_index,
                                 )
                             )
                             vca_task_list.append(task)
-                            vca_task_dict[vnf_index] = task
+                            vca_task_dict[application_name] = task
                             # task.add_done_callback(functools.partial(self.n2vc_callback, deploy_info['model'],
                             #                                          deploy_info['application'], None, db_nsr,
                             #                                          db_nslcmop, vnf_index))
-                            self.lcm_ns_tasks[nsr_id][nslcmop_id]["delete_charm:" + vnf_index] = task
+                            self.lcm_ns_tasks[nsr_id][nslcmop_id]["delete_charm:" + application_name] = task
                 except Exception as e:
                     self.logger.debug(logging_text + "Failed while deleting charms: {}".format(e))
 
@@ -1452,19 +1507,19 @@ class Lcm:
                 self.update_db_2("nslcmops", nslcmop_id, db_nslcmop_update)
                 self.update_db_2("nsrs", nsr_id, db_nsr_update)
                 await asyncio.wait(vca_task_list, timeout=300)
-            for vnf_index, task in vca_task_dict.items():
+            for application_name, task in vca_task_dict.items():
                 if task.cancelled():
-                    failed_detail.append("VCA[{}] Deletion has been cancelled".format(vnf_index))
+                    failed_detail.append("VCA[{}] Deletion has been cancelled".format(application_name))
                 elif task.done():
                     exc = task.exception()
                     if exc:
-                        failed_detail.append("VCA[{}] Deletion exception: {}".format(vnf_index, exc))
+                        failed_detail.append("VCA[{}] Deletion exception: {}".format(application_name, exc))
                     else:
-                        db_nsr_update["_admin.deployed.VCA.{}".format(vnf_index)] = None
+                        db_nsr_update["_admin.deployed.VCA.{}".format(application_name)] = None
                 else:  # timeout
                     # TODO Should it be cancelled?!!
                     task.cancel()
-                    failed_detail.append("VCA[{}] Deletion timeout".format(vnf_index))
+                    failed_detail.append("VCA[{}] Deletion timeout".format(application_name))
 
             if failed_detail:
                 self.logger.error(logging_text + " ;".join(failed_detail))
@@ -1515,10 +1570,20 @@ class Lcm:
                 self.update_db_2("nsrs", nsr_id, db_nsr_update)
             self.lcm_tasks.remove("ns", nsr_id, nslcmop_id, "ns_terminate")
 
-    async def _ns_execute_primitive(self, db_deployed, member_vnf_index, primitive, primitive_params):
-        vca_deployed = db_deployed["VCA"].get(member_vnf_index)
+    async def _ns_execute_primitive(self, db_deployed, nsr_name, member_vnf_index, vdu_id, primitive, primitive_params):
+
+        vdu_id_text = "vnfd"
+        if vdu_id:
+            vdu_id_text = vdu_id
+        application_name = self.n2vc.FormatApplicationName(
+            nsr_name,
+            member_vnf_index,
+            vdu_id_text
+        )
+        vca_deployed = db_deployed["VCA"].get(application_name)
         if not vca_deployed:
-            raise LcmException("charm for member_vnf_index={} is not deployed".format(member_vnf_index))
+            raise LcmException("charm for member_vnf_index={} vdu_id={} is not deployed".format(member_vnf_index,
+                                                                                                vdu_id))
         model_name = vca_deployed.get("model")
         application_name = vca_deployed.get("application")
         if not model_name or not application_name:
@@ -1575,12 +1640,15 @@ class Lcm:
             db_nslcmop = self.db.get_one("nslcmops", {"_id": nslcmop_id})
             db_nsr = self.db.get_one("nsrs", {"_id": nsr_id})
             nsr_lcm = db_nsr["_admin"].get("deployed")
+            nsr_name = db_nsr["name"]
             vnf_index = db_nslcmop["operationParams"]["member_vnf_index"]
+            vdu_id = db_nslcmop["operationParams"].get("vdu_id")
 
             # TODO check if ns is in a proper status
             primitive = db_nslcmop["operationParams"]["primitive"]
             primitive_params = db_nslcmop["operationParams"]["primitive_params"]
-            result, result_detail = await self._ns_execute_primitive(nsr_lcm, vnf_index, primitive, primitive_params)
+            result, result_detail = await self._ns_execute_primitive(nsr_lcm, nsr_name, vnf_index, vdu_id, primitive,
+                                                                     primitive_params)
             db_nslcmop_update = {
                 "detailed-status": result_detail,
                 "operationState": result,
@@ -1801,8 +1869,7 @@ class Lcm:
                     raise ROclient.ROClientException("Timeout waiting ns to be ready")
 
                 step = "Updating VNFRs"
-                # self.ns_update_vnfr({db_vnfr["member-vnf-index-ref"]: db_vnfr}, ns_RO_info)
-                self.ns_update_vnfr_2({db_vnfr["member-vnf-index-ref"]: db_vnfr}, desc)
+                self.ns_update_vnfr({db_vnfr["member-vnf-index-ref"]: db_vnfr}, desc)
 
                 # update VDU_SCALING_INFO with the obtained ip_addresses
                 if vdu_scaling_info["scaling_direction"] == "OUT":