adding flake 8 test

[osm/common.git] / osm_common / tests / test_dbmemory.py

diff --git a/osm_common/tests/test_dbmemory.py b/osm_common/tests/test_dbmemory.py
index a11dc1a..c4d2874 100644 (file)
--- a/osm_common/tests/test_dbmemory.py
+++ b/osm_common/tests/test_dbmemory.py
@@ -8,11 +8,13 @@ from osm_common.dbmemory import DbMemory
 
 __author__ = 'Eduardo Sousa <eduardosousa@av.it.pt>'
 
+
 @pytest.fixture
 def db_memory():
     db = DbMemory()
     return db
 
+
 @pytest.fixture
 def db_memory_with_data():
     db = DbMemory()
@@ -23,48 +25,53 @@ def db_memory_with_data():
 
     return db
 
+
 def empty_exception_message():
     return 'database exception '
 
+
 def get_one_exception_message(filter):
     return "database exception Not found entry with filter='{}'".format(filter)
 
+
 def get_one_multiple_exception_message(filter):
     return "database exception Found more than one entry with filter='{}'".format(filter)
 
+
 def del_one_exception_message(filter):
     return "database exception Not found entry with filter='{}'".format(filter)
 
+
 def replace_exception_message(filter):
     return "database exception Not found entry with filter='{}'".format(filter)
 
+
 def test_constructor():
     db = DbMemory()
-
     assert db.logger == logging.getLogger('db')
     assert len(db.db) == 0
 
+
 def test_constructor_with_logger():
     logger_name = 'db_local'
-
     db = DbMemory(logger_name=logger_name)
-
     assert db.logger == logging.getLogger(logger_name)
     assert len(db.db) == 0
 
+
 def test_db_connect():
     logger_name = 'db_local'
     config = {'logger_name': logger_name}
-
     db = DbMemory()
     db.db_connect(config)
-
     assert db.logger == logging.getLogger(logger_name)
     assert len(db.db) == 0
 
+
 def test_db_disconnect(db_memory):
     db_memory.db_disconnect()
 
+
 @pytest.mark.parametrize("table, filter", [
     ("test", {}),
     ("test", {"_id": 1}),
@@ -72,9 +79,9 @@ def test_db_disconnect(db_memory):
     ("test", {"_id": 1, "data": 1})])
 def test_get_list_with_empty_db(db_memory, table, filter):
     result = db_memory.get_list(table, filter)
-
     assert len(result) == 0
 
+
 @pytest.mark.parametrize("table, filter, expected_data", [
     ("test", {}, [{"_id": 1, "data": 1}, {"_id": 2, "data": 2}, {"_id": 3, "data": 3}]),
     ("test", {"_id": 1}, [{"_id": 1, "data": 1}]),
@@ -92,22 +99,21 @@ def test_get_list_with_empty_db(db_memory, table, filter):
     ("test_table", {"_id": 1, "data": 1}, [])])
 def test_get_list_with_non_empty_db(db_memory_with_data, table, filter, expected_data):
     result = db_memory_with_data.get_list(table, filter)
-
     assert len(result) == len(expected_data)
     for data in expected_data:
         assert data in result
 
+
 def test_get_list_exception(db_memory_with_data):
     table = 'test'
     filter = {}
-
     db_memory_with_data._find = MagicMock(side_effect=Exception())
-
     with pytest.raises(DbException) as excinfo:
         db_memory_with_data.get_list(table, filter)
     assert str(excinfo.value) == empty_exception_message()
     assert excinfo.value.http_code == http.HTTPStatus.NOT_FOUND
 
+
 @pytest.mark.parametrize("table, filter, expected_data", [
     ("test", {"_id": 1}, {"_id": 1, "data": 1}),
     ("test", {"_id": 2}, {"_id": 2, "data": 2}),
@@ -120,33 +126,32 @@ def test_get_list_exception(db_memory_with_data):
     ("test", {"_id": 3, "data": 3}, {"_id": 3, "data": 3})])
 def test_get_one(db_memory_with_data, table, filter, expected_data):
     result = db_memory_with_data.get_one(table, filter)
-
     assert result == expected_data
     assert len(db_memory_with_data.db) == 1
     assert table in db_memory_with_data.db
     assert len(db_memory_with_data.db[table]) == 3
     assert result in db_memory_with_data.db[table]
 
+
 @pytest.mark.parametrize("table, filter, expected_data", [
     ("test", {}, {"_id": 1, "data": 1})])
 def test_get_one_with_multiple_results(db_memory_with_data, table, filter, expected_data):
     result = db_memory_with_data.get_one(table, filter, fail_on_more=False)
-
     assert result == expected_data
     assert len(db_memory_with_data.db) == 1
     assert table in db_memory_with_data.db
     assert len(db_memory_with_data.db[table]) == 3
     assert result in db_memory_with_data.db[table]
 
+
 def test_get_one_with_multiple_results_exception(db_memory_with_data):
     table = "test"
     filter = {}
-
     with pytest.raises(DbException) as excinfo:
         db_memory_with_data.get_one(table, filter)
-
     assert str(excinfo.value) == (empty_exception_message() + get_one_multiple_exception_message(filter))
-#    assert excinfo.value.http_code == http.HTTPStatus.CONFLICT
+    # assert excinfo.value.http_code == http.HTTPStatus.CONFLICT
+
 
 @pytest.mark.parametrize("table, filter", [
     ("test", {"_id": 4}),
@@ -161,6 +166,7 @@ def test_get_one_with_non_empty_db_exception(db_memory_with_data, table, filter)
     assert str(excinfo.value) == (empty_exception_message() + get_one_exception_message(filter))
     assert excinfo.value.http_code == http.HTTPStatus.NOT_FOUND
 
+
 @pytest.mark.parametrize("table, filter", [
     ("test", {"_id": 4}),
     ("test", {"data": 4}),
@@ -170,8 +176,8 @@ def test_get_one_with_non_empty_db_exception(db_memory_with_data, table, filter)
     ("test_table", {"_id": 4, "data": 4})])
 def test_get_one_with_non_empty_db_none(db_memory_with_data, table, filter):
     result = db_memory_with_data.get_one(table, filter, fail_on_empty=False)
-    
-    assert result == None
+    assert result is None
+
 
 @pytest.mark.parametrize("table, filter", [
     ("test", {"_id": 4}),
@@ -186,6 +192,7 @@ def test_get_one_with_empty_db_exception(db_memory, table, filter):
     assert str(excinfo.value) == (empty_exception_message() + get_one_exception_message(filter))
     assert excinfo.value.http_code == http.HTTPStatus.NOT_FOUND
 
+
 @pytest.mark.parametrize("table, filter", [
     ("test", {"_id": 4}),
     ("test", {"data": 4}),
@@ -195,20 +202,19 @@ def test_get_one_with_empty_db_exception(db_memory, table, filter):
     ("test_table", {"_id": 4, "data": 4})])
 def test_get_one_with_empty_db_none(db_memory, table, filter):
     result = db_memory.get_one(table, filter, fail_on_empty=False)
-    
-    assert result == None
+    assert result is None
+
 
 def test_get_one_generic_exception(db_memory_with_data):
     table = 'test'
     filter = {}
-
     db_memory_with_data._find = MagicMock(side_effect=Exception())
-
     with pytest.raises(DbException) as excinfo:
         db_memory_with_data.get_one(table, filter)
     assert str(excinfo.value) == empty_exception_message()
     assert excinfo.value.http_code == http.HTTPStatus.NOT_FOUND
 
+
 @pytest.mark.parametrize("table, filter, expected_data", [
     ("test", {}, []),
     ("test", {"_id": 1}, [{"_id": 2, "data": 2}, {"_id": 3, "data": 3}]), 
@@ -217,7 +223,6 @@ def test_get_one_generic_exception(db_memory_with_data):
     ("test", {"_id": 2, "data": 2}, [{"_id": 1, "data": 1}, {"_id": 3, "data": 3}])])
 def test_del_list_with_non_empty_db(db_memory_with_data, table, filter, expected_data):
     result = db_memory_with_data.del_list(table, filter)
-
     assert result["deleted"] == (3 - len(expected_data))
     assert len(db_memory_with_data.db) == 1
     assert table in db_memory_with_data.db
@@ -225,6 +230,7 @@ def test_del_list_with_non_empty_db(db_memory_with_data, table, filter, expected
     for data in expected_data:
         assert data in db_memory_with_data.db[table]
 
+
 @pytest.mark.parametrize("table, filter", [
     ("test", {}),
     ("test", {"_id": 1}),
@@ -237,17 +243,17 @@ def test_del_list_with_empty_db(db_memory, table, filter):
     result = db_memory.del_list(table, filter)
     assert result['deleted'] == 0
 
+
 def test_del_list_generic_exception(db_memory_with_data):
     table = 'test'
     filter = {}
-
     db_memory_with_data._find = MagicMock(side_effect=Exception())
-
     with pytest.raises(DbException) as excinfo:
         db_memory_with_data.del_list(table, filter)
     assert str(excinfo.value) == empty_exception_message()
     assert excinfo.value.http_code == http.HTTPStatus.NOT_FOUND
 
+
 @pytest.mark.parametrize("table, filter, data", [
     ("test", {}, {"_id": 1, "data": 1}),
     ("test", {"_id": 1}, {"_id": 1, "data": 1}),
@@ -258,13 +264,13 @@ def test_del_list_generic_exception(db_memory_with_data):
     ("test", {"_id": 2, "data": 2}, {"_id": 2, "data": 2})])
 def test_del_one(db_memory_with_data, table, filter, data):
     result = db_memory_with_data.del_one(table, filter)
-
     assert result == {"deleted": 1}
     assert len(db_memory_with_data.db) == 1
     assert table in db_memory_with_data.db
     assert len(db_memory_with_data.db[table]) == 2
     assert data not in db_memory_with_data.db[table]
 
+
 @pytest.mark.parametrize("table, filter", [
     ("test", {}),
     ("test", {"_id": 1}),
@@ -286,6 +292,7 @@ def test_del_one_with_empty_db_exception(db_memory, table, filter):
     assert str(excinfo.value) == (empty_exception_message() + del_one_exception_message(filter))
     assert excinfo.value.http_code == http.HTTPStatus.NOT_FOUND
 
+
 @pytest.mark.parametrize("table, filter", [
     ("test", {}),
     ("test", {"_id": 1}),
@@ -303,8 +310,8 @@ def test_del_one_with_empty_db_exception(db_memory, table, filter):
     ("test_table", {"_id": 2, "data": 2})])
 def test_del_one_with_empty_db_none(db_memory, table, filter):
     result = db_memory.del_one(table, filter, fail_on_empty=False)
+    assert result is None
 
-    assert result == None
 
 @pytest.mark.parametrize("table, filter", [
     ("test", {"_id": 4}),
@@ -326,6 +333,7 @@ def test_del_one_with_non_empty_db_exception(db_memory_with_data, table, filter)
     assert str(excinfo.value) == (empty_exception_message() + del_one_exception_message(filter))
     assert excinfo.value.http_code == http.HTTPStatus.NOT_FOUND
 
+
 @pytest.mark.parametrize("table, filter", [
     ("test", {"_id": 4}),
     ("test", {"_id": 5}),
@@ -342,8 +350,8 @@ def test_del_one_with_non_empty_db_exception(db_memory_with_data, table, filter)
     ("test_table", {"_id": 2, "data": 2})])
 def test_del_one_with_non_empty_db_none(db_memory_with_data, table, filter):
     result = db_memory_with_data.del_one(table, filter, fail_on_empty=False)
+    assert result is None
 
-    assert result == None
 
 @pytest.mark.parametrize("fail_on_empty", [
     (True),
@@ -351,14 +359,13 @@ def test_del_one_with_non_empty_db_none(db_memory_with_data, table, filter):
 def test_del_one_generic_exception(db_memory_with_data, fail_on_empty):
     table = 'test'
     filter = {}
-
     db_memory_with_data._find = MagicMock(side_effect=Exception())
-
     with pytest.raises(DbException) as excinfo:
         db_memory_with_data.del_one(table, filter, fail_on_empty=fail_on_empty)
     assert str(excinfo.value) == empty_exception_message()
     assert excinfo.value.http_code == http.HTTPStatus.NOT_FOUND
 
+
 @pytest.mark.parametrize("table, filter, indata", [
     ("test", {}, {"_id": 1, "data": 42}),
     ("test", {}, {"_id": 3, "data": 42}),
@@ -370,13 +377,13 @@ def test_del_one_generic_exception(db_memory_with_data, fail_on_empty):
     ("test", {"_id": 3, "data": 3}, {"_id": 3, "data": 42})])
 def test_replace(db_memory_with_data, table, filter, indata):
     result = db_memory_with_data.replace(table, filter, indata)
-
     assert result == {"updated": 1}
     assert len(db_memory_with_data.db) == 1
     assert table in db_memory_with_data.db
     assert len(db_memory_with_data.db[table]) == 3
     assert indata in db_memory_with_data.db[table]
 
+
 @pytest.mark.parametrize("table, filter, indata", [
     ("test", {}, {'_id': 1, 'data': 1}),
     ("test", {}, {'_id': 2, 'data': 1}),
@@ -394,6 +401,7 @@ def test_replace_without_data_exception(db_memory, table, filter, indata):
     assert str(excinfo.value) == (empty_exception_message() + replace_exception_message(filter))
     assert excinfo.value.http_code == http.HTTPStatus.NOT_FOUND
 
+
 @pytest.mark.parametrize("table, filter, indata", [
     ("test", {}, {'_id': 1, 'data': 1}),
     ("test", {}, {'_id': 2, 'data': 1}),
@@ -407,7 +415,8 @@ def test_replace_without_data_exception(db_memory, table, filter, indata):
     ("test_table", {'_id': 1, 'data': 1}, {'_id': 1, 'data': 1})])
 def test_replace_without_data_none(db_memory, table, filter, indata):
     result = db_memory.replace(table, filter, indata, fail_on_empty=False)
-    assert result == None
+    assert result is None
+
 
 @pytest.mark.parametrize("table, filter, indata", [
     ("test_table", {}, {'_id': 1, 'data': 1}),
@@ -421,6 +430,7 @@ def test_replace_with_data_exception(db_memory_with_data, table, filter, indata)
     assert str(excinfo.value) == (empty_exception_message() + replace_exception_message(filter))
     assert excinfo.value.http_code == http.HTTPStatus.NOT_FOUND
 
+
 @pytest.mark.parametrize("table, filter, indata", [
     ("test_table", {}, {'_id': 1, 'data': 1}),
     ("test_table", {}, {'_id': 2, 'data': 1}),
@@ -429,23 +439,23 @@ def test_replace_with_data_exception(db_memory_with_data, table, filter, indata)
     ("test_table", {'_id': 1, 'data': 1}, {'_id': 1, 'data': 1})])
 def test_replace_with_data_none(db_memory_with_data, table, filter, indata):
     result = db_memory_with_data.replace(table, filter, indata, fail_on_empty=False)
-    assert result == None
+    assert result is None
+
 
 @pytest.mark.parametrize("fail_on_empty", [
-    (True),
-    (False)])
+    True,
+    False])
 def test_replace_generic_exception(db_memory_with_data, fail_on_empty):
     table = 'test'
     filter = {}
     indata = {'_id': 1, 'data': 1}
-
     db_memory_with_data._find = MagicMock(side_effect=Exception())
-
     with pytest.raises(DbException) as excinfo:
         db_memory_with_data.replace(table, filter, indata, fail_on_empty=fail_on_empty)
     assert str(excinfo.value) == empty_exception_message()
     assert excinfo.value.http_code == http.HTTPStatus.NOT_FOUND
 
+
 @pytest.mark.parametrize("table, id, data", [
     ("test", "1", {"data": 1}),
     ("test", "1", {"data": 2}),
@@ -466,15 +476,14 @@ def test_replace_generic_exception(db_memory_with_data, fail_on_empty):
 def test_create_with_empty_db_with_id(db_memory, table, id, data):
     data_to_insert = data
     data_to_insert['_id'] = id
-
     returned_id = db_memory.create(table, data_to_insert)
-
     assert returned_id == id
     assert len(db_memory.db) == 1
     assert table in db_memory.db
     assert len(db_memory.db[table]) == 1
     assert data_to_insert in db_memory.db[table]
 
+
 @pytest.mark.parametrize("table, id, data", [
     ("test", "4", {"data": 1}),
     ("test", "5", {"data": 2}),
@@ -495,15 +504,14 @@ def test_create_with_empty_db_with_id(db_memory, table, id, data):
 def test_create_with_non_empty_db_with_id(db_memory_with_data, table, id, data):
     data_to_insert = data
     data_to_insert['_id'] = id
-
     returned_id = db_memory_with_data.create(table, data_to_insert)
-
     assert returned_id == id
     assert len(db_memory_with_data.db) == (1 if table == 'test' else 2)
     assert table in db_memory_with_data.db
     assert len(db_memory_with_data.db[table]) == (4 if table == 'test' else 1)
     assert data_to_insert in db_memory_with_data.db[table]
 
+
 @pytest.mark.parametrize("table, data", [
     ("test", {"data": 1}),
     ("test", {"data": 2}),
@@ -523,16 +531,14 @@ def test_create_with_non_empty_db_with_id(db_memory_with_data, table, id, data):
     ("test_table", {"data_1": 2, "data_2": 1})])
 def test_create_with_empty_db_without_id(db_memory, table, data):
     returned_id = db_memory.create(table, data)
-
     assert len(db_memory.db) == 1
     assert table in db_memory.db
     assert len(db_memory.db[table]) == 1
-
     data_inserted = data
     data_inserted['_id'] = returned_id
-
     assert data_inserted in db_memory.db[table]
 
+
 @pytest.mark.parametrize("table, data", [
     ("test", {"data": 1}),
     ("test", {"data": 2}),
@@ -552,23 +558,19 @@ def test_create_with_empty_db_without_id(db_memory, table, data):
     ("test_table", {"data_1": 2, "data_2": 1})])
 def test_create_with_non_empty_db_without_id(db_memory_with_data, table, data):
     returned_id = db_memory_with_data.create(table, data)
-
     assert len(db_memory_with_data.db) == (1 if table == 'test' else 2)
     assert table in db_memory_with_data.db
     assert len(db_memory_with_data.db[table]) == (4 if table == 'test' else 1)
-    
     data_inserted = data
     data_inserted['_id'] = returned_id
-
     assert data_inserted in db_memory_with_data.db[table]
 
+
 def test_create_with_exception(db_memory):
     table = "test"
     data = {"_id": 1, "data": 1}
-
     db_memory.db = MagicMock()
     db_memory.db.__contains__.side_effect = Exception()
-
     with pytest.raises(DbException) as excinfo:
         db_memory.create(table, data)
     assert str(excinfo.value) == empty_exception_message()