+ self.assertIn(
+ p_id, db_s1_args[0][1]["_admin.projects_write.cont"], "Wrong DB filter"
+ )
+ self.assertIsNone(
+ db_s1_args[1]["update_dict"], "Wrong DB update dictionary"
+ )
+ self.assertEqual(
+ db_s1_args[1]["pull_list"],
+ {"_admin.projects_read": (p_id,), "_admin.projects_write": (p_id,)},
+ "Wrong DB pull_list dictionary",
+ )
+ self.fs.file_delete.assert_not_called()
+ return
+
+ @patch("osm_nbi.descriptor_topics.yaml")
+ def test_validate_descriptor_changes(self, mock_yaml):
+ descriptor_name = "test_descriptor"
+ self.fs.file_open.side_effect = lambda path, mode: open(
+ "/tmp/" + str(uuid4()), "a+b"
+ )
+ with self.subTest(i=1, t="VNFD has changes in day1-2 config primitive"):
+ old_vnfd, new_vnfd = self.create_desc_temp(db_vnfd_content)
+ new_vnfd["df"][0]["lcm-operations-configuration"]["operate-vnf-op-config"][
+ "day1-2"
+ ][0]["config-primitive"][0]["name"] = "new_action"
+ mock_yaml.load.side_effect = [old_vnfd, new_vnfd]
+ with self.assertNotRaises(EngineException):
+ self.topic._validate_descriptor_changes(
+ descriptor_name, "/tmp/", "/tmp:1/"
+ )
+ with self.subTest(i=2, t="VNFD sw version changed"):
+ # old vnfd uses the default software version: 1.0
+ new_vnfd["software-version"] = "1.3"
+ new_vnfd["sw-image-desc"][0]["name"] = "new-image"
+ mock_yaml.load.side_effect = [old_vnfd, new_vnfd]
+ with self.assertNotRaises(EngineException):
+ self.topic._validate_descriptor_changes(
+ descriptor_name, "/tmp/", "/tmp:1/"
+ )
+ with self.subTest(
+ i=3, t="VNFD sw version is not changed and mgmt-cp has changed"
+ ):
+ old_vnfd, new_vnfd = self.create_desc_temp(db_vnfd_content)
+ new_vnfd["mgmt-cp"] = "new-mgmt-cp"
+ mock_yaml.load.side_effect = [old_vnfd, new_vnfd]
+ with self.assertRaises(EngineException) as e:
+ self.topic._validate_descriptor_changes(
+ descriptor_name, "/tmp/", "/tmp:1/"
+ )
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm("there are disallowed changes in the vnf descriptor"),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+
+ def test_validate_mgmt_interface_connection_point_on_valid_descriptor(self):
+ indata = deepcopy(db_vnfd_content)
+ self.topic.validate_mgmt_interface_connection_point(indata)
+
+ def test_validate_mgmt_interface_connection_point_when_missing_connection_point(
+ self,
+ ):
+ indata = deepcopy(db_vnfd_content)
+ indata["ext-cpd"] = []
+ with self.assertRaises(EngineException) as e:
+ self.topic.validate_mgmt_interface_connection_point(indata)
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "mgmt-cp='{}' must match an existing ext-cpd".format(indata["mgmt-cp"])
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+
+ def test_validate_mgmt_interface_connection_point_when_missing_mgmt_cp(self):
+ indata = deepcopy(db_vnfd_content)
+ indata.pop("mgmt-cp")
+ with self.assertRaises(EngineException) as e:
+ self.topic.validate_mgmt_interface_connection_point(indata)
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm("'mgmt-cp' is a mandatory field and it is not defined"),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+
+ def test_validate_vdu_internal_connection_points_on_valid_descriptor(self):
+ indata = db_vnfd_content
+ vdu = indata["vdu"][0]
+ self.topic.validate_vdu_internal_connection_points(vdu)
+
+ def test_validate_external_connection_points_on_valid_descriptor(self):
+ indata = db_vnfd_content
+ self.topic.validate_external_connection_points(indata)
+
+ def test_validate_external_connection_points_when_missing_internal_connection_point(
+ self,
+ ):
+ indata = deepcopy(db_vnfd_content)
+ vdu = indata["vdu"][0]
+ vdu.pop("int-cpd")
+ affected_ext_cpd = indata["ext-cpd"][0]
+ with self.assertRaises(EngineException) as e:
+ self.topic.validate_external_connection_points(indata)
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "ext-cpd[id='{}']:int-cpd must match an existing vdu int-cpd".format(
+ affected_ext_cpd["id"]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+
+ def test_validate_vdu_internal_connection_points_on_duplicated_internal_connection_point(
+ self,
+ ):
+ indata = deepcopy(db_vnfd_content)
+ vdu = indata["vdu"][0]
+ duplicated_cpd = {
+ "id": "vnf-mgmt",
+ "order": 3,
+ "virtual-network-interface-requirement": [{"name": "duplicated"}],
+ }
+ vdu["int-cpd"].insert(0, duplicated_cpd)
+ with self.assertRaises(EngineException) as e:
+ self.topic.validate_vdu_internal_connection_points(vdu)
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "vdu[id='{}']:int-cpd[id='{}'] is already used by other int-cpd".format(
+ vdu["id"], duplicated_cpd["id"]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+
+ def test_validate_external_connection_points_on_duplicated_external_connection_point(
+ self,
+ ):
+ indata = deepcopy(db_vnfd_content)
+ duplicated_cpd = {
+ "id": "vnf-mgmt-ext",
+ "int-cpd": {"vdu-id": "dataVM", "cpd": "vnf-data"},
+ }
+ indata["ext-cpd"].insert(0, duplicated_cpd)
+ with self.assertRaises(EngineException) as e:
+ self.topic.validate_external_connection_points(indata)
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "ext-cpd[id='{}'] is already used by other ext-cpd".format(
+ duplicated_cpd["id"]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+
+ def test_validate_internal_virtual_links_on_valid_descriptor(self):
+ indata = db_vnfd_content
+ self.topic.validate_internal_virtual_links(indata)
+
+ def test_validate_internal_virtual_links_on_duplicated_ivld(self):
+ indata = deepcopy(db_vnfd_content)
+ duplicated_vld = {"id": "internal"}
+ indata["int-virtual-link-desc"].insert(0, duplicated_vld)
+ with self.assertRaises(EngineException) as e:
+ self.topic.validate_internal_virtual_links(indata)
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "Duplicated VLD id in int-virtual-link-desc[id={}]".format(
+ duplicated_vld["id"]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+
+ def test_validate_internal_virtual_links_when_missing_ivld_on_connection_point(
+ self,
+ ):
+ indata = deepcopy(db_vnfd_content)
+ vdu = indata["vdu"][0]
+ affected_int_cpd = vdu["int-cpd"][0]
+ affected_int_cpd["int-virtual-link-desc"] = "non-existing-int-virtual-link-desc"
+ with self.assertRaises(EngineException) as e:
+ self.topic.validate_internal_virtual_links(indata)
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "vdu[id='{}']:int-cpd[id='{}']:int-virtual-link-desc='{}' must match an existing "
+ "int-virtual-link-desc".format(
+ vdu["id"],
+ affected_int_cpd["id"],
+ affected_int_cpd["int-virtual-link-desc"],
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+
+ def test_validate_internal_virtual_links_when_missing_ivld_on_profile(self):
+ indata = deepcopy(db_vnfd_content)
+ affected_ivld_profile = {"id": "non-existing-int-virtual-link-desc"}
+ df = indata["df"][0]
+ df["virtual-link-profile"] = [affected_ivld_profile]
+ with self.assertRaises(EngineException) as e:
+ self.topic.validate_internal_virtual_links(indata)
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "df[id='{}']:virtual-link-profile='{}' must match an existing "
+ "int-virtual-link-desc".format(df["id"], affected_ivld_profile["id"])
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+
+ def test_validate_monitoring_params_on_valid_descriptor(self):
+ indata = db_vnfd_content
+ self.topic.validate_monitoring_params(indata)
+
+ def test_validate_monitoring_params_on_duplicated_ivld_monitoring_param(self):
+ indata = deepcopy(db_vnfd_content)
+ duplicated_mp = {"id": "cpu", "name": "cpu", "performance_metric": "cpu"}
+ affected_ivld = indata["int-virtual-link-desc"][0]
+ affected_ivld["monitoring-parameters"] = [duplicated_mp, duplicated_mp]
+ with self.assertRaises(EngineException) as e:
+ self.topic.validate_monitoring_params(indata)
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "Duplicated monitoring-parameter id in "
+ "int-virtual-link-desc[id='{}']:monitoring-parameters[id='{}']".format(
+ affected_ivld["id"], duplicated_mp["id"]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+
+ def test_validate_monitoring_params_on_duplicated_vdu_monitoring_param(self):
+ indata = deepcopy(db_vnfd_content)
+ duplicated_mp = {
+ "id": "dataVM_cpu_util",
+ "name": "dataVM_cpu_util",
+ "performance_metric": "cpu",
+ }
+ affected_vdu = indata["vdu"][1]
+ affected_vdu["monitoring-parameter"].insert(0, duplicated_mp)
+ with self.assertRaises(EngineException) as e:
+ self.topic.validate_monitoring_params(indata)
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "Duplicated monitoring-parameter id in "
+ "vdu[id='{}']:monitoring-parameter[id='{}']".format(
+ affected_vdu["id"], duplicated_mp["id"]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+
+ def test_validate_monitoring_params_on_duplicated_df_monitoring_param(self):
+ indata = deepcopy(db_vnfd_content)
+ duplicated_mp = {
+ "id": "memory",
+ "name": "memory",
+ "performance_metric": "memory",
+ }
+ affected_df = indata["df"][0]
+ affected_df["monitoring-parameter"] = [duplicated_mp, duplicated_mp]
+ with self.assertRaises(EngineException) as e:
+ self.topic.validate_monitoring_params(indata)
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "Duplicated monitoring-parameter id in "
+ "df[id='{}']:monitoring-parameter[id='{}']".format(
+ affected_df["id"], duplicated_mp["id"]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+
+ def test_validate_scaling_group_descriptor_on_valid_descriptor(self):
+ indata = db_vnfd_content
+ self.topic.validate_scaling_group_descriptor(indata)
+
+ def test_validate_scaling_group_descriptor_when_missing_monitoring_param(self):
+ indata = deepcopy(db_vnfd_content)
+ vdu = indata["vdu"][1]
+ affected_df = indata["df"][0]
+ affected_sa = affected_df["scaling-aspect"][0]
+ affected_sp = affected_sa["scaling-policy"][0]
+ affected_sc = affected_sp["scaling-criteria"][0]
+ vdu.pop("monitoring-parameter")
+ with self.assertRaises(EngineException) as e:
+ self.topic.validate_scaling_group_descriptor(indata)
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "df[id='{}']:scaling-aspect[id='{}']:scaling-policy"
+ "[name='{}']:scaling-criteria[name='{}']: "
+ "vnf-monitoring-param-ref='{}' not defined in any monitoring-param".format(
+ affected_df["id"],
+ affected_sa["id"],
+ affected_sp["name"],
+ affected_sc["name"],
+ affected_sc["vnf-monitoring-param-ref"],
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+
+ def test_validate_scaling_group_descriptor_when_missing_vnf_configuration(self):
+ indata = deepcopy(db_vnfd_content)
+ df = indata["df"][0]
+ affected_sa = df["scaling-aspect"][0]
+ indata["df"][0]["lcm-operations-configuration"]["operate-vnf-op-config"][
+ "day1-2"
+ ].pop()
+ with self.assertRaises(EngineException) as e:
+ self.topic.validate_scaling_group_descriptor(indata)
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "'day1-2 configuration' not defined in the descriptor but it is referenced "
+ "by df[id='{}']:scaling-aspect[id='{}']:scaling-config-action".format(
+ df["id"], affected_sa["id"]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+
+ def test_validate_scaling_group_descriptor_when_missing_scaling_config_action_primitive(
+ self,
+ ):
+ indata = deepcopy(db_vnfd_content)
+ df = indata["df"][0]
+ affected_sa = df["scaling-aspect"][0]
+ affected_sca_primitive = affected_sa["scaling-config-action"][0][
+ "vnf-config-primitive-name-ref"
+ ]
+ df["lcm-operations-configuration"]["operate-vnf-op-config"]["day1-2"][0][
+ "config-primitive"
+ ] = []
+ with self.assertRaises(EngineException) as e:
+ self.topic.validate_scaling_group_descriptor(indata)
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "df[id='{}']:scaling-aspect[id='{}']:scaling-config-action:vnf-"
+ "config-primitive-name-ref='{}' does not match any "
+ "day1-2 configuration:config-primitive:name".format(
+ df["id"], affected_sa["id"], affected_sca_primitive
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+
+ def test_new_vnfd_revision(self):
+ did = db_vnfd_content["_id"]
+ self.fs.get_params.return_value = {}
+ self.fs.file_exists.return_value = False
+ self.fs.file_open.side_effect = lambda path, mode: open(
+ "/tmp/" + str(uuid4()), "a+b"
+ )
+ test_vnfd = deepcopy(db_vnfd_content)
+ del test_vnfd["_id"]
+ del test_vnfd["_admin"]
+ self.db.create.return_value = did
+ rollback = []
+ did2, oid = self.topic.new(rollback, fake_session, {})
+ db_args = self.db.create.call_args[0]
+ self.assertEqual(db_args[1]['_admin']['revision'], 0,
+ "New package should be at revision 0")
+
+ @patch("osm_nbi.descriptor_topics.shutil")
+ @patch("osm_nbi.descriptor_topics.os.rename")
+ def test_update_vnfd(self, mock_rename, mock_shutil):
+ old_revision = 5
+ did = db_vnfd_content["_id"]
+ self.fs.path = ""
+ self.fs.get_params.return_value = {}
+ self.fs.file_exists.return_value = False
+ self.fs.file_open.side_effect = lambda path, mode: open(
+ "/tmp/" + str(uuid4()), "a+b"
+ )
+ new_vnfd = deepcopy(db_vnfd_content)
+ del new_vnfd["_id"]
+ self.db.create.return_value = did
+ rollback = []
+ did2, oid = self.topic.new(rollback, fake_session, {})
+ del new_vnfd["vdu"][0]["cloud-init-file"]
+ del new_vnfd["df"][0]["lcm-operations-configuration"]["operate-vnf-op-config"][
+ "day1-2"][0]["execution-environment-list"][0]["juju"]
+
+
+ old_vnfd = {
+ "_id": did,
+ "_admin": deepcopy(db_vnfd_content["_admin"])
+ }
+ old_vnfd["_admin"]["revision"] = old_revision
+ self.db.get_one.side_effect = [
+ old_vnfd,
+ None,
+ ]
+ self.topic.upload_content(
+ fake_session, did, new_vnfd, {}, {"Content-Type": []}
+ )
+
+ db_args = self.db.replace.call_args[0]
+ self.assertEqual(db_args[2]['_admin']['revision'], old_revision + 1,
+ "Revision should increment")
+
+
+class Test_NsdTopic(TestCase):
+ @classmethod
+ def setUpClass(cls):
+ cls.test_name = "test-nsd-topic"
+
+ @classmethod
+ def tearDownClass(cls):
+ pass
+
+ def setUp(self):
+ self.db = Mock(dbbase.DbBase())
+ self.fs = Mock(fsbase.FsBase())
+ self.msg = Mock(msgbase.MsgBase())
+ self.auth = Mock(authconn.Authconn(None, None, None))
+ self.topic = NsdTopic(self.db, self.fs, self.msg, self.auth)
+ self.topic.check_quota = Mock(return_value=None) # skip quota
+
+ @contextmanager
+ def assertNotRaises(self, exception_type):
+ try:
+ yield None
+ except exception_type:
+ raise self.failureException("{} raised".format(exception_type.__name__))
+
+ def create_desc_temp(self, template):
+ old_desc = deepcopy(template)
+ new_desc = deepcopy(template)
+ return old_desc, new_desc
+
+ @patch("osm_nbi.descriptor_topics.shutil")
+ @patch("osm_nbi.descriptor_topics.os.rename")
+ def test_new_nsd(self, mock_rename, mock_shutil):
+ did = db_nsd_content["_id"]
+ self.fs.get_params.return_value = {}
+ self.fs.file_exists.return_value = False
+ self.fs.file_open.side_effect = lambda path, mode: open(
+ "/tmp/" + str(uuid4()), "a+b"
+ )
+ test_nsd = deepcopy(db_nsd_content)
+ del test_nsd["_id"]
+ del test_nsd["_admin"]
+ with self.subTest(i=1, t="Normal Creation"):
+ self.db.create.return_value = did
+ rollback = []
+ did2, oid = self.topic.new(rollback, fake_session, {})
+ db_args = self.db.create.call_args[0]
+ msg_args = self.msg.write.call_args[0]
+ self.assertEqual(len(rollback), 1, "Wrong rollback length")
+ self.assertEqual(msg_args[0], self.topic.topic_msg, "Wrong message topic")
+ self.assertEqual(msg_args[1], "created", "Wrong message action")
+ self.assertEqual(msg_args[2], {"_id": did}, "Wrong message content")
+ self.assertEqual(db_args[0], self.topic.topic, "Wrong DB topic")
+ self.assertEqual(did2, did, "Wrong DB NSD id")
+ self.assertIsNotNone(db_args[1]["_admin"]["created"], "Wrong creation time")
+ self.assertEqual(
+ db_args[1]["_admin"]["modified"],
+ db_args[1]["_admin"]["created"],
+ "Wrong modification time",
+ )
+ self.assertEqual(
+ db_args[1]["_admin"]["projects_read"],
+ [test_pid],
+ "Wrong read-only project list",
+ )
+ self.assertEqual(
+ db_args[1]["_admin"]["projects_write"],
+ [test_pid],
+ "Wrong read-write project list",
+ )
+ try:
+ self.fs.path = ""
+ self.db.get_one.side_effect = [
+ {"_id": did, "_admin": db_nsd_content["_admin"]},
+ None,
+ ]
+ self.db.get_list.return_value = [db_vnfd_content]
+ self.topic.upload_content(
+ fake_session, did, test_nsd, {}, {"Content-Type": []}
+ )
+ msg_args = self.msg.write.call_args[0]
+ test_nsd["_id"] = did
+ self.assertEqual(
+ msg_args[0], self.topic.topic_msg, "Wrong message topic"
+ )
+ self.assertEqual(msg_args[1], "edited", "Wrong message action")
+ self.assertEqual(msg_args[2], test_nsd, "Wrong message content")
+ db_args = self.db.get_one.mock_calls[0][1]
+ self.assertEqual(db_args[0], self.topic.topic, "Wrong DB topic")
+ self.assertEqual(db_args[1]["_id"], did, "Wrong DB NSD id")
+ db_args = self.db.replace.call_args[0]
+ self.assertEqual(db_args[0], self.topic.topic, "Wrong DB topic")
+ self.assertEqual(db_args[1], did, "Wrong DB NSD id")
+ admin = db_args[2]["_admin"]
+ db_admin = db_nsd_content["_admin"]
+ self.assertEqual(
+ admin["created"], db_admin["created"], "Wrong creation time"
+ )
+ self.assertGreater(
+ admin["modified"], db_admin["created"], "Wrong modification time"
+ )
+ self.assertEqual(
+ admin["projects_read"],
+ db_admin["projects_read"],
+ "Wrong read-only project list",
+ )
+ self.assertEqual(
+ admin["projects_write"],
+ db_admin["projects_write"],
+ "Wrong read-write project list",
+ )
+ self.assertEqual(
+ admin["onboardingState"], "ONBOARDED", "Wrong onboarding state"
+ )
+ self.assertEqual(
+ admin["operationalState"], "ENABLED", "Wrong operational state"
+ )
+ self.assertEqual(admin["usageState"], "NOT_IN_USE", "Wrong usage state")
+ storage = admin["storage"]
+ self.assertEqual(storage["folder"], did, "Wrong storage folder")
+ self.assertEqual(
+ storage["descriptor"], "package", "Wrong storage descriptor"
+ )
+ compare_desc(self, test_nsd, db_args[2], "NSD")
+ revision_args = self.db.create.call_args[0]
+ self.assertEqual(
+ revision_args[0], self.topic.topic + "_revisions", "Wrong topic"
+ )
+ self.assertEqual(
+ revision_args[1]["id"], db_args[2]["id"], "Wrong revision id"
+ )
+ self.assertEqual(
+ revision_args[1]["_id"],
+ db_args[2]["_id"] + ":1",
+ "Wrong revision _id"
+ )
+
+ finally:
+ pass
+ self.db.get_one.side_effect = (
+ lambda table, filter, fail_on_empty=None, fail_on_more=None: {
+ "_id": did,
+ "_admin": db_nsd_content["_admin"],
+ }
+ )
+ with self.subTest(i=2, t="Check Pyangbind Validation: required properties"):
+ tmp = test_nsd["id"]
+ del test_nsd["id"]
+ try:
+ with self.assertRaises(
+ EngineException, msg="Accepted NSD with a missing required property"
+ ) as e:
+ self.topic.upload_content(
+ fake_session, did, test_nsd, {}, {"Content-Type": []}
+ )
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm("Error in pyangbind validation: '{}'".format("id")),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+ finally:
+ test_nsd["id"] = tmp
+ with self.subTest(i=3, t="Check Pyangbind Validation: additional properties"):
+ test_nsd["extra-property"] = 0
+ try:
+ with self.assertRaises(
+ EngineException, msg="Accepted NSD with an additional property"
+ ) as e:
+ self.topic.upload_content(
+ fake_session, did, test_nsd, {}, {"Content-Type": []}
+ )
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "Error in pyangbind validation: {} ({})".format(
+ "json object contained a key that did not exist",
+ "extra-property",
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+ finally:
+ del test_nsd["extra-property"]
+ with self.subTest(i=4, t="Check Pyangbind Validation: property types"):
+ tmp = test_nsd["designer"]
+ test_nsd["designer"] = {"key": 0}
+ try:
+ with self.assertRaises(
+ EngineException, msg="Accepted NSD with a wrongly typed property"
+ ) as e:
+ self.topic.upload_content(
+ fake_session, did, test_nsd, {}, {"Content-Type": []}
+ )
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "Error in pyangbind validation: {} ({})".format(
+ "json object contained a key that did not exist", "key"
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+ finally:
+ test_nsd["designer"] = tmp
+ with self.subTest(
+ i=5, t="Check Input Validation: mgmt-network+virtual-link-protocol-data"
+ ):
+ df = test_nsd["df"][0]
+ mgmt_profile = {
+ "id": "id",
+ "virtual-link-desc-id": "mgmt",
+ "virtual-link-protocol-data": {"associated-layer-protocol": "ipv4"},
+ }
+ df["virtual-link-profile"] = [mgmt_profile]
+ try:
+ with self.assertRaises(
+ EngineException, msg="Accepted VLD with mgmt-network+ip-profile"
+ ) as e:
+ self.topic.upload_content(
+ fake_session, did, test_nsd, {}, {"Content-Type": []}
+ )
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "Error at df[id='{}']:virtual-link-profile[id='{}']:virtual-link-protocol-data"
+ " You cannot set a virtual-link-protocol-data when mgmt-network is True".format(
+ df["id"], mgmt_profile["id"]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+ finally:
+ del df["virtual-link-profile"]
+ with self.subTest(i=6, t="Check Descriptor Dependencies: vnfd-id[]"):
+ self.db.get_one.side_effect = [
+ {"_id": did, "_admin": db_nsd_content["_admin"]},
+ None,
+ ]
+ self.db.get_list.return_value = []
+ try:
+ with self.assertRaises(
+ EngineException, msg="Accepted wrong VNFD ID reference"
+ ) as e:
+ self.topic.upload_content(
+ fake_session, did, test_nsd, {}, {"Content-Type": []}
+ )
+ self.assertEqual(
+ e.exception.http_code, HTTPStatus.CONFLICT, "Wrong HTTP status code"
+ )
+ self.assertIn(
+ norm(
+ "'vnfd-id'='{}' references a non existing vnfd".format(
+ test_nsd["vnfd-id"][0]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+ finally:
+ pass
+ with self.subTest(
+ i=7,
+ t="Check Descriptor Dependencies: "
+ "vld[vnfd-connection-point-ref][vnfd-connection-point-ref]",
+ ):
+ vnfd_descriptor = deepcopy(db_vnfd_content)
+ df = test_nsd["df"][0]
+ affected_vnf_profile = df["vnf-profile"][0]
+ affected_virtual_link = affected_vnf_profile["virtual-link-connectivity"][1]
+ affected_cpd = vnfd_descriptor["ext-cpd"].pop()
+ self.db.get_one.side_effect = [
+ {"_id": did, "_admin": db_nsd_content["_admin"]},
+ None,
+ ]
+ self.db.get_list.return_value = [vnfd_descriptor]
+ try:
+ with self.assertRaises(
+ EngineException, msg="Accepted wrong VLD CP reference"
+ ) as e:
+ self.topic.upload_content(
+ fake_session, did, test_nsd, {}, {"Content-Type": []}
+ )
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm(
+ "Error at df[id='{}']:vnf-profile[id='{}']:virtual-link-connectivity"
+ "[virtual-link-profile-id='{}']:constituent-cpd-id='{}' references a "
+ "non existing ext-cpd:id inside vnfd '{}'".format(
+ df["id"],
+ affected_vnf_profile["id"],
+ affected_virtual_link["virtual-link-profile-id"],
+ affected_cpd["id"],
+ vnfd_descriptor["id"],
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+ finally:
+ pass
+ return
+
+ def test_edit_nsd(self):
+ nsd_content = deepcopy(db_nsd_content)
+ did = nsd_content["_id"]
+ self.fs.file_exists.return_value = True
+ self.fs.dir_ls.return_value = True
+ with self.subTest(i=1, t="Normal Edition"):
+ now = time()
+ self.db.get_one.side_effect = [deepcopy(nsd_content), None]
+ self.db.get_list.return_value = [db_vnfd_content]
+ data = {"id": "new-nsd-id", "name": "new-nsd-name"}
+ self.topic.edit(fake_session, did, data)
+ db_args = self.db.replace.call_args[0]
+ msg_args = self.msg.write.call_args[0]
+ data["_id"] = did
+ self.assertEqual(msg_args[0], self.topic.topic_msg, "Wrong message topic")
+ self.assertEqual(msg_args[1], "edited", "Wrong message action")
+ self.assertEqual(msg_args[2], data, "Wrong message content")
+ self.assertEqual(db_args[0], self.topic.topic, "Wrong DB topic")
+ self.assertEqual(db_args[1], did, "Wrong DB ID")
+ self.assertEqual(
+ db_args[2]["_admin"]["created"],
+ nsd_content["_admin"]["created"],
+ "Wrong creation time",
+ )
+ self.assertGreater(
+ db_args[2]["_admin"]["modified"], now, "Wrong modification time"
+ )
+ self.assertEqual(
+ db_args[2]["_admin"]["projects_read"],
+ nsd_content["_admin"]["projects_read"],
+ "Wrong read-only project list",
+ )
+ self.assertEqual(
+ db_args[2]["_admin"]["projects_write"],
+ nsd_content["_admin"]["projects_write"],
+ "Wrong read-write project list",
+ )
+ self.assertEqual(db_args[2]["id"], data["id"], "Wrong NSD ID")
+ self.assertEqual(db_args[2]["name"], data["name"], "Wrong NSD Name")
+ with self.subTest(i=2, t="Conflict on Edit"):
+ data = {"id": "fake-nsd-id", "name": "new-nsd-name"}
+ self.db.get_one.side_effect = [
+ nsd_content,
+ {"_id": str(uuid4()), "id": data["id"]},
+ ]
+ with self.assertRaises(
+ EngineException, msg="Accepted existing NSD ID"
+ ) as e:
+ self.topic.edit(fake_session, did, data)
+ self.assertEqual(
+ e.exception.http_code, HTTPStatus.CONFLICT, "Wrong HTTP status code"
+ )
+ self.assertIn(
+ norm(
+ "{} with id '{}' already exists for this project".format(
+ "nsd", data["id"]
+ )
+ ),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+ with self.subTest(i=3, t="Check Envelope"):
+ data = {"nsd": {"nsd": {"id": "new-nsd-id", "name": "new-nsd-name"}}}
+ self.db.get_one.side_effect = [nsd_content, None]
+ with self.assertRaises(
+ EngineException, msg="Accepted NSD with wrong envelope"
+ ) as e:
+ self.topic.edit(fake_session, did, data, content=nsd_content)
+ self.assertEqual(
+ e.exception.http_code, HTTPStatus.BAD_REQUEST, "Wrong HTTP status code"
+ )
+ self.assertIn(
+ "'nsd' must be a list of only one element",
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+ return
+
+ def test_delete_nsd(self):
+ did = db_nsd_content["_id"]
+ self.db.get_one.return_value = db_nsd_content
+ p_id = db_nsd_content["_admin"]["projects_read"][0]
+ with self.subTest(i=1, t="Normal Deletion"):
+ self.db.get_list.return_value = []
+ self.db.del_one.return_value = {"deleted": 1}
+ self.topic.delete(fake_session, did)
+ db_args = self.db.del_one.call_args[0]
+ msg_args = self.msg.write.call_args[0]
+ self.assertEqual(msg_args[0], self.topic.topic_msg, "Wrong message topic")
+ self.assertEqual(msg_args[1], "deleted", "Wrong message action")
+ self.assertEqual(msg_args[2], {"_id": did}, "Wrong message content")
+ self.assertEqual(db_args[0], self.topic.topic, "Wrong DB topic")
+ self.assertEqual(db_args[1]["_id"], did, "Wrong DB ID")
+ self.assertEqual(
+ db_args[1]["_admin.projects_write.cont"],
+ [p_id, "ANY"],
+ "Wrong DB filter",
+ )
+ db_g1_args = self.db.get_one.call_args[0]
+ self.assertEqual(db_g1_args[0], self.topic.topic, "Wrong DB topic")
+ self.assertEqual(db_g1_args[1]["_id"], did, "Wrong DB NSD ID")
+ db_gl_calls = self.db.get_list.call_args_list
+ self.assertEqual(db_gl_calls[0][0][0], "nsrs", "Wrong DB topic")
+ # self.assertEqual(db_gl_calls[0][0][1]["nsd-id"], did, "Wrong DB NSD ID") # Filter changed after call
+ self.assertEqual(db_gl_calls[1][0][0], "nsts", "Wrong DB topic")
+ self.assertEqual(
+ db_gl_calls[1][0][1]["netslice-subnet.ANYINDEX.nsd-ref"],
+ db_nsd_content["id"],
+ "Wrong DB NSD netslice-subnet nsd-ref",
+ )
+ self.db.set_one.assert_not_called()