+ self.assertEqual(
+ db_s1_args[1]["pull_list"],
+ {"_admin.projects_read": (p_id,), "_admin.projects_write": (p_id,)},
+ "Wrong DB pull_list dictionary",
+ )
+ self.fs.file_delete.assert_not_called()
+ return
+
+ def prepare_vnfd_validation(self):
+ descriptor_name = "test_descriptor"
+ self.fs.file_open.side_effect = lambda path, mode: open(
+ "/tmp/" + str(uuid4()), "a+b"
+ )
+ old_vnfd, new_vnfd = self.create_desc_temp(db_vnfd_content)
+ return descriptor_name, old_vnfd, new_vnfd
+
+ @patch("osm_nbi.descriptor_topics.detect_descriptor_usage")
+ @patch("osm_nbi.descriptor_topics.yaml.safe_load")
+ def test_validate_vnfd_changes_day12_config_primitive_changed(
+ self, mock_safe_load, mock_detect_usage
+ ):
+ """Validating VNFD for VNFD updates, day1-2 config primitive has changed"""
+ descriptor_name, old_vnfd, new_vnfd = self.prepare_vnfd_validation()
+ did = old_vnfd["_id"]
+ new_vnfd["df"][0]["lcm-operations-configuration"]["operate-vnf-op-config"][
+ "day1-2"
+ ][0]["config-primitive"][0]["name"] = "new_action"
+ mock_safe_load.side_effect = [old_vnfd, new_vnfd]
+ mock_detect_usage.return_value = True
+ self.db.get_one.return_value = old_vnfd
+
+ with self.assertNotRaises(EngineException):
+ self.topic._validate_descriptor_changes(
+ did, descriptor_name, "/tmp/", "/tmp:1/"
+ )
+ self.db.get_one.assert_called_once()
+ mock_detect_usage.assert_called_once()
+ self.assertEqual(mock_safe_load.call_count, 2)
+
+ @patch("osm_nbi.descriptor_topics.detect_descriptor_usage")
+ @patch("osm_nbi.descriptor_topics.yaml.safe_load")
+ def test_validate_vnfd_changes_sw_version_changed(
+ self, mock_safe_load, mock_detect_usage
+ ):
+ """Validating VNFD for updates, software version has changed"""
+ # old vnfd uses the default software version: 1.0
+ descriptor_name, old_vnfd, new_vnfd = self.prepare_vnfd_validation()
+ did = old_vnfd["_id"]
+ new_vnfd["software-version"] = "1.3"
+ new_vnfd["sw-image-desc"][0]["name"] = "new-image"
+ mock_safe_load.side_effect = [old_vnfd, new_vnfd]
+ mock_detect_usage.return_value = True
+ self.db.get_one.return_value = old_vnfd
+
+ with self.assertNotRaises(EngineException):
+ self.topic._validate_descriptor_changes(
+ did, descriptor_name, "/tmp/", "/tmp:1/"
+ )
+ self.db.get_one.assert_called_once()
+ mock_detect_usage.assert_called_once()
+ self.assertEqual(mock_safe_load.call_count, 2)
+
+ @patch("osm_nbi.descriptor_topics.detect_descriptor_usage")
+ @patch("osm_nbi.descriptor_topics.yaml.safe_load")
+ def test_validate_vnfd_changes_sw_version_not_changed_mgm_cp_changed(
+ self, mock_safe_load, mock_detect_usage
+ ):
+ """Validating VNFD for updates, software version has not
+ changed, mgmt-cp has changed."""
+ descriptor_name, old_vnfd, new_vnfd = self.prepare_vnfd_validation()
+ new_vnfd["mgmt-cp"] = "new-mgmt-cp"
+ mock_safe_load.side_effect = [old_vnfd, new_vnfd]
+ did = old_vnfd["_id"]
+ mock_detect_usage.return_value = True
+ self.db.get_one.return_value = old_vnfd
+
+ with self.assertRaises(
+ EngineException, msg="there are disallowed changes in the vnf descriptor"
+ ) as e:
+ self.topic._validate_descriptor_changes(
+ did, descriptor_name, "/tmp/", "/tmp:1/"
+ )
+
+ self.assertEqual(
+ e.exception.http_code,
+ HTTPStatus.UNPROCESSABLE_ENTITY,
+ "Wrong HTTP status code",
+ )
+ self.assertIn(
+ norm("there are disallowed changes in the vnf descriptor"),
+ norm(str(e.exception)),
+ "Wrong exception text",
+ )
+ self.db.get_one.assert_called_once()
+ mock_detect_usage.assert_called_once()
+ self.assertEqual(mock_safe_load.call_count, 2)
+
+ @patch("osm_nbi.descriptor_topics.detect_descriptor_usage")
+ @patch("osm_nbi.descriptor_topics.yaml.safe_load")
+ def test_validate_vnfd_changes_sw_version_not_changed_mgm_cp_changed_vnfd_not_in_use(
+ self, mock_safe_load, mock_detect_usage
+ ):
+ """Validating VNFD for updates, software version has not
+ changed, mgmt-cp has changed, vnfd is not in use."""
+ descriptor_name, old_vnfd, new_vnfd = self.prepare_vnfd_validation()
+ new_vnfd["mgmt-cp"] = "new-mgmt-cp"
+ mock_safe_load.side_effect = [old_vnfd, new_vnfd]
+ did = old_vnfd["_id"]
+ mock_detect_usage.return_value = None
+ self.db.get_one.return_value = old_vnfd
+
+ with self.assertNotRaises(EngineException):
+ self.topic._validate_descriptor_changes(
+ did, descriptor_name, "/tmp/", "/tmp:1/"