From 397917c239d0856e231b8c3fea0084dd64368572 Mon Sep 17 00:00:00 2001
From: aguilard <e.dah.tid@telefonica.com>
Date: Tue, 24 Oct 2023 12:09:44 +0000
Subject: [PATCH] Fix bug 2268: Authentication error when instantiating NS on
GCP.
There was a bug in _reload_connection method of GCP connector which is called
when trying to reconnect after a previous error: the credentials parameter was
missing in googleapiclient.discovery.build call.
Change-Id: I38bcd1508cb3c45314f2fc76109c85c3279b9709
Signed-off-by: aguilard <e.dah.tid@telefonica.com>
(cherry picked from commit 6c7318f4ee720e17a8a6e95dc4ac0c551ee5da32)
---
RO-VIM-gcp/osm_rovim_gcp/vimconn_gcp.py | 4 +++-
.../notes/fix_bug_2268-94c0189c7dd607f0.yaml | 23 +++++++++++++++++++
2 files changed, 26 insertions(+), 1 deletion(-)
create mode 100644 releasenotes/notes/fix_bug_2268-94c0189c7dd607f0.yaml
diff --git a/RO-VIM-gcp/osm_rovim_gcp/vimconn_gcp.py b/RO-VIM-gcp/osm_rovim_gcp/vimconn_gcp.py
index 6532be3b..5b58c1a5 100644
--- a/RO-VIM-gcp/osm_rovim_gcp/vimconn_gcp.py
+++ b/RO-VIM-gcp/osm_rovim_gcp/vimconn_gcp.py
@@ -183,7 +183,9 @@ class vimconnector(vimconn.VimConnector):
try:
# Set to client created
- self.conn_compute = googleapiclient.discovery.build("compute", "v1")
+ self.conn_compute = googleapiclient.discovery.build(
+ "compute", "v1", credentials=self.credentials
+ )
except Exception as e:
self._format_vimconn_exception(e)
diff --git a/releasenotes/notes/fix_bug_2268-94c0189c7dd607f0.yaml b/releasenotes/notes/fix_bug_2268-94c0189c7dd607f0.yaml
new file mode 100644
index 00000000..386f1e4e
--- /dev/null
+++ b/releasenotes/notes/fix_bug_2268-94c0189c7dd607f0.yaml
@@ -0,0 +1,23 @@
+#######################################################################################
+# Copyright ETSI Contributors and Others.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+# implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#######################################################################################
+---
+fixes:
+ - |
+ Fix bug 2268: Authentication error when instantiating NS on GCP.
+ There was a bug in _reload_connection method of GCP connector which is
+ called when trying to reconnect after a previous error: the credentials
+ parameter was missing in googleapiclient.discovery.build() call.
--
GitLab