commit c0d0234449b80a56febe1f5a933196643a13e463
author garciadeblas <gerardo.garciadeblas@telefonica.com> Thu Nov 25 11:57:18 2021 +0100
committer garciadeblas <gerardo.garciadeblas@telefonica.com> Fri Nov 26 15:49:11 2021 +0100
tree b18df8c5f7c48033b7bab659fcbd283eed399ad3
parent c5f10c39b0081d27a1ac1a06bab967da0d633c25

Fix propagation of failures in installer scripts

Change-Id: Ie83a4c9284ea63b40c37975da261634f930b6317
Signed-off-by: garciadeblas <gerardo.garciadeblas@telefonica.com>

common/logging

diff --git a/common/logging b/common/logging
index a48e01d..080eb63 100644
--- a/common/logging
+++ b/common/logging
@@ -34,6 +34,13 @@
 }
 
 
+FATAL_TRACK() {
+	echo -e "\n### $(date) ${FUNCNAME[1]}: FATAL error: $*" >&2
+	track end fatal $1 "'${@:2}'" none
+	print_stack
+	exit 1
+}
+
 FATAL() { 
 	echo -e "\n### $(date) ${FUNCNAME[1]}: FATAL error: $*" >&2
 	print_stack

common/track

diff --git a/common/track b/common/track
index 627c680..e5a5ef7 100644
--- a/common/track
+++ b/common/track
@@ -60,13 +60,14 @@
             operation="${1:-${osm_track_event_name}}"
             shift 1
             value="${1:-}"
+            value="${value// /_}"
             shift 1
             comment="${1:-}"
-            shift 1
             comment="${comment// /_}"
-            tags="${1:-}"
             shift 1
+            tags="${1:-}"
             tags="${tags//,/\~}"
+            shift 1
             [ "$value" == "none" ] && value=""
             [ "$comment" == "none" ] && comment=""
             [ "$tags" == "none" ] && tags=""