Fixing common security vulnerabilities
Correcting try-except-pass usage, removing assert improper usage.
Change-Id: Ic24c7e8a8f579c6dfd4a9740eff11ab1561af5e1
Signed-off-by: aticig <gulsum.atici@canonical.com>
(cherry picked from commit d3b582a7268d90c072bb7fbe10a25c80851f3c1e)
diff --git a/osm_common/dbmemory.py b/osm_common/dbmemory.py
index 9f8c571..ad52135 100644
--- a/osm_common/dbmemory.py
+++ b/osm_common/dbmemory.py
@@ -398,16 +398,18 @@
)
del dict_to_update[key_to_update]
updated = True
- except Exception:
- pass
+ except Exception as unset_error:
+ self.logger.error(f"{unset_error} occured while updating DB.")
if pull:
for dot_k, v in pull.items():
try:
dict_to_update, key_to_update, _ = _iterate_keys(
dot_k, db_item, populate=False
)
- except Exception:
+ except Exception as pull_error:
+ self.logger.error(f"{pull_error} occured while updating DB.")
continue
+
if key_to_update not in dict_to_update:
continue
if not isinstance(dict_to_update[key_to_update], list):
@@ -430,8 +432,12 @@
dict_to_update, key_to_update, _ = _iterate_keys(
dot_k, db_item, populate=False
)
- except Exception:
+ except Exception as iterate_error:
+ self.logger.error(
+ f"{iterate_error} occured while iterating keys in db update."
+ )
continue
+
if key_to_update not in dict_to_update:
continue
if not isinstance(dict_to_update[key_to_update], list):