commit fed47b0903b8e5ee93591ef53540432d3ecce796
author Anderson Bravalheri <a.bravalheri@bristol.ac.uk> Sun Dec 16 20:44:08 2018 +0000
committer Anderson Bravalheri <a.bravalheri@bristol.ac.uk> Fri Jan 18 12:24:01 2019 +0000
tree ca8abc044e154e6cdcf72df97edfff4641d0cec3
parent 0fb702806f0ae0e3157fffcd541537293edb84b8

Inject "wim_port_mappings" from "wim.config"

Automatically create/update port mappings during WIM creation/update,
as discussed in the WIM implementation meeting (12/Dec/2018).

Additionally fix small related errors and ensure wan_port_mappings
are returned by the HTTP server using the same keys forming the schema.

Change-Id: Icc27ad85c1de826ed96cb42b377055ea1b0c2cab
Signed-off-by: Anderson Bravalheri <a.bravalheri@bristol.ac.uk>

osm_ro/wim/persistence.py

diff --git a/osm_ro/wim/persistence.py b/osm_ro/wim/persistence.py
index 8f95d56..b956965 100644
--- a/osm_ro/wim/persistence.py
+++ b/osm_ro/wim/persistence.py
@@ -326,12 +326,11 @@
         where = {'uuid': wim['uuid']}
 
         # unserialize config, edit and serialize it again
-        if wim_descriptor.get('config'):
-            new_config_dict = wim_descriptor["config"]
-            config_dict = remove_none_items(merge_dicts(
-                wim.get('config') or {}, new_config_dict))
-            wim_descriptor['config'] = (
-                _serialize(config_dict) if config_dict else None)
+        new_config_dict = wim_descriptor.get('config', {}) or {}
+        config_dict = remove_none_items(merge_dicts(
+            wim.get('config', {}) or {}, new_config_dict))
+        wim_descriptor['config'] = (
+            _serialize(config_dict) if config_dict else None)
 
         with self.lock:
             self.db.update_rows('wims', wim_descriptor, where)
@@ -508,8 +507,12 @@
 
         See :obj:`~.query` for additional keyword arguments.
         """
-        kwargs.update(datacenter=datacenter, tenant=tenant)
-        return self.query(_DATACENTER_JOIN, **kwargs)
+        if tenant:
+            kwargs.update(datacenter=datacenter, tenant=tenant)
+            return self.query(_DATACENTER_JOIN, **kwargs)
+        else:
+            return [self.get_by_name_or_uuid('datacenters',
+                                             datacenter, **kwargs)]
 
     def get_datacenter_by(self, datacenter=None, tenant=None, **kwargs):
         """Similar to ``get_datacenters_by``, but ensuring just one result"""
@@ -622,7 +625,7 @@
         return [
             {'wim_id': key[0],
              'datacenter_id': key[1],
-             'wan_pop_port_mappings': [
+             'pop_wan_mappings': [
                  filter_out_dict_keys(mapping, (
                      'id', 'wim_id', 'datacenter_id',
                      'created_at', 'modified_at'))