Coverity-CWE 922: Insecure Storage of Sensitive Information(localStorage write)
- Coverity fix for localStorage write issue: For storing datas
in browser localStorage so changed it to sessionStorage
Change-Id: I3fdce439b923e006b44a50a42fab19b7ffbcdec6
Signed-off-by: SANDHYA.JS <sandhya.j@tataelxsi.co.in>
diff --git a/src/app/users/add-user/AddEditUserComponent.ts b/src/app/users/add-user/AddEditUserComponent.ts
index e7592e4..2931d79 100644
--- a/src/app/users/add-user/AddEditUserComponent.ts
+++ b/src/app/users/add-user/AddEditUserComponent.ts
@@ -79,7 +79,7 @@
public isPassword: boolean;
/** Variable holds value for first login user @public */
- public isFirstLogin: boolean = Boolean(localStorage.getItem('firstLogin') === 'true');
+ public isFirstLogin: boolean = Boolean(sessionStorage.getItem('firstLogin') === 'true');
/** Instance of the rest service @private */
private restService: RestService;
@@ -273,10 +273,10 @@
/** Method to check loggedin username and update @private */
private checkUsername(payLoad: LOGINPARAMS): void {
- const logUsername: string = localStorage.getItem('username');
+ const logUsername: string = sessionStorage.getItem('username');
if (this.userType === 'editUserName' && logUsername === this.userName) {
this.authService.userName.next(payLoad.username);
- localStorage.setItem('username', payLoad.username);
+ sessionStorage.setItem('username', payLoad.username);
}
}
}
diff --git a/src/app/users/user-details/UserDetailsComponent.ts b/src/app/users/user-details/UserDetailsComponent.ts
index 51047ba..12c37fe 100644
--- a/src/app/users/user-details/UserDetailsComponent.ts
+++ b/src/app/users/user-details/UserDetailsComponent.ts
@@ -125,7 +125,7 @@
this.projectService.getAllProjects().subscribe((projects: {}[]) => {
this.projectList = projects;
});
- this.isAdminShow = localStorage.getItem('admin_show') === 'true' ? true : false;
+ this.isAdminShow = sessionStorage.getItem('admin_show') === 'true' ? true : false;
this.generateColumns();
this.generateSettings();
this.generateData();