Fix Bug 2121: NG-UI uses unmaintained Chokidar version
- Upgraded Angular from 11 to 14 version to remove chokidar
unmaintained version.
- Changed linting tool tslint to eslint for angular 14 as tslint
is depreacted after angular 12
- Resolved linting issues from code
Change-Id: I00e908ab651db0f080e0d18a9d1c9711f4e36b91
Signed-off-by: SANDHYA.JS <sandhya.j@tataelxsi.co.in>
diff --git a/src/app/users/UsersComponent.ts b/src/app/users/UsersComponent.ts
index 178b979..b14c2e7 100644
--- a/src/app/users/UsersComponent.ts
+++ b/src/app/users/UsersComponent.ts
@@ -49,7 +49,9 @@
/** Return to list NS Package List */
public redirectToList(getURL: string): void {
if (getURL === '/users') {
- this.router.navigate(['/users/details']).catch();
+ this.router.navigate(['/users/details']).catch((): void => {
+ // Catch Navigation Error
+ });
}
}
}
diff --git a/src/app/users/UsersModule.ts b/src/app/users/UsersModule.ts
index 8b5f316..2294886 100644
--- a/src/app/users/UsersModule.ts
+++ b/src/app/users/UsersModule.ts
@@ -63,15 +63,14 @@
FlexLayoutModule, NgSelectModule, NgbModule, RouterModule.forChild(routes), PagePerRowModule, LoaderModule,
PageReloadModule, ChangePasswordModule],
declarations: [UsersComponent, UserDetailsComponent, ProjectRoleComponent],
- providers: [DataService],
- entryComponents: [ProjectRoleComponent]
+ providers: [DataService]
})
/** Exporting a class @exports UsersModule */
export class UsersModule {
/**
* Lifecyle Hooks the trigger before component is instantiate
*/
- public ngOnInit(): void {
- // Empty Block
- }
+ constructor() {
+ //Empty
+ }
}
diff --git a/src/app/users/add-user/AddEditUserComponent.ts b/src/app/users/add-user/AddEditUserComponent.ts
index 0e9456a..076cfba 100644
--- a/src/app/users/add-user/AddEditUserComponent.ts
+++ b/src/app/users/add-user/AddEditUserComponent.ts
@@ -18,6 +18,7 @@
/**
* @file Add Edit Component.
*/
+import { isNullOrUndefined } from 'util';
import { HttpHeaders } from '@angular/common/http';
import { Component, Injector, Input, OnInit } from '@angular/core';
import { AbstractControl, FormBuilder, FormGroup, Validators } from '@angular/forms';
@@ -29,7 +30,6 @@
import { environment } from 'environment';
import { RestService } from 'RestService';
import { SharedService } from 'SharedService';
-import { isNullOrUndefined } from 'util';
/**
* Creating component
@@ -265,6 +265,7 @@
/** Used to get the AbstractControl of controlName passed @private */
private getFormControl(controlName: string): AbstractControl {
+ // eslint-disable-next-line security/detect-object-injection
return this.userForm.controls[controlName];
}
diff --git a/src/app/users/project-role/ProjectRoleComponent.ts b/src/app/users/project-role/ProjectRoleComponent.ts
index 600cecd..3a7e612 100644
--- a/src/app/users/project-role/ProjectRoleComponent.ts
+++ b/src/app/users/project-role/ProjectRoleComponent.ts
@@ -141,7 +141,6 @@
/** Handle FormArray Controls @public */
public getControls(): AbstractControl[] {
- // tslint:disable-next-line:no-backbone-get-set-outside-model
return (this.projectRoleForm.get('project_role_mappings') as FormArray).controls;
}
@@ -185,7 +184,6 @@
/** Set all roles and project values to the form @public */
public loadMapping(): void {
this.userDetails.project_role_mappings.forEach((data: ProjectRoleMappings): void => {
- // tslint:disable-next-line:no-backbone-get-set-outside-model
this.projectRoleFormArray = this.projectRoleForm.get('project_role_mappings') as FormArray;
this.projectRoleFormArray.push(this.projectRoleParamsBuilder);
});
@@ -229,7 +227,6 @@
/** Add extra mapping and set empty project and roles @public */
public addMapping(): void {
- // tslint:disable-next-line:no-backbone-get-set-outside-model
this.projectRoleFormArray = this.projectRoleForm.get('project_role_mappings') as FormArray;
this.projectRoleFormArray.push(this.projectRoleParamsBuilder);
}
diff --git a/src/app/users/user-details/UserDetailsComponent.ts b/src/app/users/user-details/UserDetailsComponent.ts
index aede6e2..ba24454 100644
--- a/src/app/users/user-details/UserDetailsComponent.ts
+++ b/src/app/users/user-details/UserDetailsComponent.ts
@@ -18,6 +18,7 @@
/**
* @file users details Component.
*/
+import { isNullOrUndefined } from 'util';
import { Component, Injector, OnDestroy, OnInit } from '@angular/core';
import { NgbModal, NgbModalRef } from '@ng-bootstrap/ng-bootstrap';
import { TranslateService } from '@ngx-translate/core';
@@ -32,7 +33,6 @@
import { SharedService } from 'SharedService';
import { UserData, UserDetail } from 'UserModel';
import { UsersActionComponent } from 'UsersActionComponent';
-import { isNullOrUndefined } from 'util';
/**
* Creating component
@@ -146,6 +146,7 @@
/** on Navigate to Composer Page @public */
public composeUser(): void {
+ // eslint-disable-next-line security/detect-non-literal-fs-filename
const modalRef: NgbModalRef = this.modalService.open(AddEditUserComponent, { backdrop: 'static' });
modalRef.componentInstance.userTitle = this.translateService.instant('PAGE.USERS.NEWUSER');
modalRef.componentInstance.userType = 'add';
@@ -153,7 +154,9 @@
if (result) {
this.sharedService.callData();
}
- }).catch();
+ }).catch((): void => {
+ // Catch Navigation Error
+ });
}
/** smart table listing manipulation @private */
@@ -206,7 +209,9 @@
}
this.dataSource.load(this.userData).then((data: {}) => {
this.isLoadingResults = false;
- }).catch();
+ }).catch((): void => {
+ // Catch Navigation Error
+ });
}, (error: ERRORDATA) => {
this.restService.handleError(error, 'get');
this.isLoadingResults = false;