commit 59f520da90fb12b9d9871889dfbc5d57aa14c591
author David Garcia <david.garcia@canonical.com> Thu Oct 15 13:16:45 2020 +0200
committer David Garcia <david.garcia@canonical.com> Wed Oct 21 13:28:23 2020 +0200
tree 56c43333879f27690ea51ccf0d5aa4ef824c8c43
parent 7077e2601a209a87f7fe397b35586e7701ca759a

Fix bug 1236: Retry if leader unit is not obtained

There a racing condition when N2VC tries to get the leader unit, but there
leader-elected hook has not been triggered. In that case, day-1 action might fail.

This commit solved this issue by retrying a couple of times.

Change-Id: If79cd243aa9ebdf8ed0e6235481eeb9fd2640612
Signed-off-by: David Garcia <david.garcia@canonical.com>

n2vc/tests/unit/test_libjuju.py

diff --git a/n2vc/tests/unit/test_libjuju.py b/n2vc/tests/unit/test_libjuju.py
index 8c16c9d..123da4a 100644
--- a/n2vc/tests/unit/test_libjuju.py
+++ b/n2vc/tests/unit/test_libjuju.py
@@ -30,6 +30,7 @@
     JujuActionNotFound,
     JujuApplicationExists,
     JujuInvalidK8sConfiguration,
+    JujuLeaderUnitNotFound,
 )
 
 
@@ -579,7 +580,35 @@
         mock_disconnect_controller.assert_called()
         mock_disconnect_model.assert_called()
 
-    # TODO no leader unit found exception
+    @asynctest.mock.patch("asyncio.sleep")
+    @asynctest.mock.patch("n2vc.tests.unit.utils.FakeUnit.is_leader_from_status")
+    def test_no_leader(
+        self,
+        mock_is_leader_from_status,
+        mock_sleep,
+        mock_get_action_status,
+        mock_get_action_output,
+        mock_wait_for,
+        mock__get_application,
+        mock_disconnect_controller,
+        mock_disconnect_model,
+        mock_get_model,
+        mock_get_controller,
+    ):
+        mock_get_model.return_value = juju.model.Model()
+        mock__get_application.return_value = FakeApplication()
+        mock_is_leader_from_status.return_value = False
+        output = None
+        status = None
+        with self.assertRaises(JujuLeaderUnitNotFound):
+            output, status = self.loop.run_until_complete(
+                self.libjuju.execute_action("app", "model", "action",)
+            )
+        self.assertIsNone(output)
+        self.assertIsNone(status)
+
+        mock_disconnect_controller.assert_called()
+        mock_disconnect_model.assert_called()
 
     def test_succesful_exec(
         self,