commit 4b68cb610f768a4d59e9dd67b974eb1a4f61038b
author Patricia Reinoso <patricia.reinoso@canonical.com> Tue Aug 30 16:08:48 2022 +0000
committer calvinosanc1 <guillermo.calvino@canonical.com> Thu Sep 01 15:53:34 2022 +0200
tree b11394de2377f036333982a6c6406c3440a7657b
parent 6343d434fa3cec28d8b9b470054d3a13ada8865a

Fix bug 2149

Set appropriate delete method for
cluster role bindings in case of exception

Change-Id: I187ec50dbec37ed9ff51e18234ab51e02c42ce40
Signed-off-by: Patricia Reinoso <patricia.reinoso@canonical.com>

n2vc/k8s_juju_conn.py

diff --git a/n2vc/k8s_juju_conn.py b/n2vc/k8s_juju_conn.py
index 396d79b..6708748 100644
--- a/n2vc/k8s_juju_conn.py
+++ b/n2vc/k8s_juju_conn.py
@@ -156,7 +156,7 @@
             self.log.debug("Role binding created")
             cleanup_data.append(
                 {
-                    "delete": kubectl.delete_service_account,
+                    "delete": kubectl.delete_cluster_role_binding,
                     "args": (metadata_name,),
                 }
             )

n2vc/tests/unit/test_k8s_juju_conn.py

diff --git a/n2vc/tests/unit/test_k8s_juju_conn.py b/n2vc/tests/unit/test_k8s_juju_conn.py
index 3e35494..6119d50 100644
--- a/n2vc/tests/unit/test_k8s_juju_conn.py
+++ b/n2vc/tests/unit/test_k8s_juju_conn.py
@@ -134,9 +134,15 @@
             uuid, created = self.loop.run_until_complete(
                 self.k8s_juju_conn.init_env(k8s_creds=kubeconfig)
             )
-
         self.assertIsNone(created)
         self.assertIsNone(uuid)
+        self.kubectl.create_cluster_role.assert_called_once()
+        self.kubectl.create_service_account.assert_called_once()
+        self.kubectl.create_cluster_role_binding.assert_called_once()
+        self.kubectl.get_default_storage_class.assert_called_once()
+        self.kubectl.delete_cluster_role.assert_called_once()
+        self.kubectl.delete_service_account.assert_called_once()
+        self.kubectl.delete_cluster_role_binding.assert_called_once()
         self.k8s_juju_conn.libjuju.add_k8s.assert_called_once()