commit cae650341754311d90bc7c7a0321787b6c0e315a
author Benjamin Diaz <bdiaz@whitestack.com> Fri Jul 06 16:04:19 2018 -0300
committer Benjamin Diaz <bdiaz@whitestack.com> Fri Jul 06 16:05:03 2018 -0300
tree 4900c30eed0cf7dd00ab7fe22e187139facd260f
parent 97d7df670c46be95e707d276b05c70ad61fc4ab5

[MON] Fixes notifier bug during alarm triggering

Signed-off-by: Benjamin Diaz <bdiaz@whitestack.com>

osm_mon/plugins/OpenStack/Aodh/notifier.py

diff --git a/osm_mon/plugins/OpenStack/Aodh/notifier.py b/osm_mon/plugins/OpenStack/Aodh/notifier.py
index 377404a..8f3f0fe 100644
--- a/osm_mon/plugins/OpenStack/Aodh/notifier.py
+++ b/osm_mon/plugins/OpenStack/Aodh/notifier.py
@@ -72,11 +72,11 @@
             post_data = post_data.decode()
         except AttributeError:
             pass
-        log.info("This alarm was triggered: %s", json.dumps(post_data))
+        log.info("This alarm was triggered: %s", post_data)
 
         # Send alarm notification to message bus
         try:
-            self.notify_alarm(json.dumps(post_data))
+            self.notify_alarm(json.loads(post_data))
         except Exception:
             log.exception("Error notifying alarm")
 

osm_mon/test/OpenStack/unit/test_notifier.py

diff --git a/osm_mon/test/OpenStack/unit/test_notifier.py b/osm_mon/test/OpenStack/unit/test_notifier.py
index 951bf10..a135cec 100644
--- a/osm_mon/test/OpenStack/unit/test_notifier.py
+++ b/osm_mon/test/OpenStack/unit/test_notifier.py
@@ -52,7 +52,7 @@
 
 class RFile():
     def read(self, content_length):
-        return post_data
+        return json.dumps(post_data, sort_keys=True)
 
 
 class MockNotifierHandler(NotifierHandler):
@@ -98,7 +98,7 @@
         self.handler.do_POST()
 
         set_head.assert_called_once()
-        notify.assert_called_with(json.dumps(post_data))
+        notify.assert_called_with(post_data)
 
     @mock.patch.object(KafkaProducer, "notify_alarm")
     @mock.patch.object(DatabaseManager, "get_alarm")