commit 869131ae0c5e033162ccd2cd20998a6b1ba19473
author garciadeblas <gerardo.garciadeblas@telefonica.com> Fri Nov 08 01:11:46 2024 +0100
committer garciadeblas <gerardo.garciadeblas@telefonica.com> Fri Mar 21 10:13:20 2025 +0100
tree 35027e754959955b691d85c4fc4d9bbcadfb0cc4
parent 635b35ab067df1301c78d3953065bacf6c57250c

Manage situations where ODU workflows fail before it is launched (empty workflow_name)

Change-Id: I63a2113eee3626b6bc018519ca324b95ada1dc73
Signed-off-by: garciadeblas <gerardo.garciadeblas@telefonica.com>

osm_lcm/odu_libs/cluster_mgmt.py

diff --git a/osm_lcm/odu_libs/cluster_mgmt.py b/osm_lcm/odu_libs/cluster_mgmt.py
index 81d85ec..4c24b96 100644
--- a/osm_lcm/odu_libs/cluster_mgmt.py
+++ b/osm_lcm/odu_libs/cluster_mgmt.py
@@ -62,12 +62,16 @@
     secret_namespace = "osm-workflows"
     secret_key = "agekey"
     secret_value = private_key_new_cluster
-    await self.create_secret(
-        secret_name,
-        secret_namespace,
-        secret_key,
-        secret_value,
-    )
+    try:
+        await self.create_secret(
+            secret_name,
+            secret_namespace,
+            secret_key,
+            secret_value,
+        )
+    except Exception as e:
+        self.logger.info(f"Cannot create secret {secret_name}: {e}")
+        return False, ""
 
     # Additional params for the workflow
     cluster_kustomization_name = cluster_name
@@ -131,7 +135,7 @@
         api_plural="workflows",
         api_version="v1alpha1",
     )
-    return workflow_name
+    return True, workflow_name
 
 
 async def update_cluster(self, op_id, op_params, content):
@@ -156,12 +160,16 @@
     secret_namespace = "osm-workflows"
     secret_key = "agekey"
     secret_value = private_key_cluster
-    await self.create_secret(
-        secret_name,
-        secret_namespace,
-        secret_key,
-        secret_value,
-    )
+    try:
+        await self.create_secret(
+            secret_name,
+            secret_namespace,
+            secret_key,
+            secret_value,
+        )
+    except Exception as e:
+        self.logger.info(f"Cannot create secret {secret_name}: {e}")
+        return False, ""
 
     # Additional params for the workflow
     cluster_kustomization_name = cluster_name
@@ -213,7 +221,7 @@
         api_plural="workflows",
         api_version="v1alpha1",
     )
-    return workflow_name
+    return True, workflow_name
 
 
 async def delete_cluster(self, op_id, op_params, content):
@@ -254,7 +262,7 @@
         api_plural="workflows",
         api_version="v1alpha1",
     )
-    return workflow_name
+    return True, workflow_name
 
 
 async def register_cluster(self, op_id, op_params, content):
@@ -277,12 +285,18 @@
     secret_namespace = "osm-workflows"
     secret_key = "agekey"
     secret_value = private_key_new_cluster
-    await self.create_secret(
-        secret_name,
-        secret_namespace,
-        secret_key,
-        secret_value,
-    )
+    try:
+        await self.create_secret(
+            secret_name,
+            secret_namespace,
+            secret_key,
+            secret_value,
+        )
+    except Exception as e:
+        self.logger.info(
+            f"Cannot create secret {secret_name} in namespace {secret_namespace}: {e}"
+        )
+        return False, ""
 
     # Create secret with kubeconfig
     secret_name2 = f"kubeconfig-{cluster_name}"
@@ -327,7 +341,7 @@
         api_plural="workflows",
         api_version="v1alpha1",
     )
-    return workflow_name
+    return True, workflow_name
 
 
 async def deregister_cluster(self, op_id, op_params, content):
@@ -367,7 +381,7 @@
         api_plural="workflows",
         api_version="v1alpha1",
     )
-    return workflow_name
+    return True, workflow_name
 
 
 async def get_cluster_credentials(self, db_cluster):