commit 4c0e6805c44f9ed1d0bb35161bf69645f5b84151
author Gabriel Cuba <gcuba@whitestack.com> Mon Oct 09 13:22:38 2023 -0500
committer cubag <gcuba@whitestack.com> Fri Oct 13 08:23:26 2023 +0200
tree d5f154cae70707b9746a6dc7a6f2f5bbc31c243e
parent 9e9a923448e6673fc0396265732115b55f1df9da

Fix multiple minor security vulnerabilities

Change-Id: I7c2a42c8bd025767de12ebca2573ab01d200c100
Signed-off-by: Gabriel Cuba <gcuba@whitestack.com>

osm_lcm/ROclient.py

diff --git a/osm_lcm/ROclient.py b/osm_lcm/ROclient.py
index cdbde9c..e731ec1 100644
--- a/osm_lcm/ROclient.py
+++ b/osm_lcm/ROclient.py
@@ -99,7 +99,7 @@
         if len(indata) == 1 and "instance" in indata:
             clean_indata = indata["instance"]
     else:
-        assert False, "remove_envelop with unknown item {}".format(item)
+        raise ROClientException("remove_envelop with unknown item {}".format(item))
 
     return clean_indata
 
@@ -272,7 +272,7 @@
         elif item == "sdn":
             return {"sdn_controller": indata}
         else:
-            assert False, "_create_envelop with unknown item {}".format(item)
+            raise ROClientException("remove_envelop with unknown item {}".format(item))
 
     @staticmethod
     def update_descriptor(desc, kwargs):
@@ -359,9 +359,10 @@
         if item_id:
             return item_id
         desc = content[item]
-        assert isinstance(
-            desc, list
-        ), "_get_item_uuid get a non dict with a list inside {}".format(type(desc))
+        if not isinstance(desc, list):
+            raise ROClientException(
+                "_get_item_uuid get a non dict with a list inside {}".format(type(desc))
+            )
         uuid = None
         for i in desc:
             if item_id_name and i["name"] != item_id_name: